import { resolveNativeSkillsEnabled } from "openclaw/plugin-sdk/config-runtime"; import type { OpenClawConfig } from "openclaw/plugin-sdk/config-runtime"; import { readChannelAllowFromStore } from "openclaw/plugin-sdk/conversation-runtime"; import type { ResolvedTelegramAccount } from "./accounts.js"; import { isNumericTelegramUserId, normalizeTelegramAllowFromEntry } from "./allow-from.js"; function collectInvalidTelegramAllowFromEntries(params: { entries: unknown; target: Set }) { if (!Array.isArray(params.entries)) { return; } for (const entry of params.entries) { const normalized = normalizeTelegramAllowFromEntry(entry); if (!normalized || normalized === "*") { continue; } if (!isNumericTelegramUserId(normalized)) { params.target.add(normalized); } } } export async function collectTelegramSecurityAuditFindings(params: { cfg: OpenClawConfig; accountId?: string | null; account: ResolvedTelegramAccount; }) { const findings: Array<{ checkId: string; severity: "info" | "warn" | "critical"; title: string; detail: string; remediation?: string; }> = []; if (params.cfg.commands?.text === false) { return findings; } const telegramCfg = params.account.config ?? {}; const accountId = params.accountId?.trim() || params.account.accountId || "default"; const defaultGroupPolicy = params.cfg.channels?.defaults?.groupPolicy; const groupPolicy = (telegramCfg.groupPolicy as string | undefined) ?? defaultGroupPolicy ?? "allowlist"; const groups = telegramCfg.groups as Record | undefined; const groupsConfigured = Boolean(groups) && Object.keys(groups ?? {}).length > 0; const groupAccessPossible = groupPolicy === "open" || (groupPolicy === "allowlist" && groupsConfigured); if (!groupAccessPossible) { return findings; } const storeAllowFrom = await readChannelAllowFromStore("telegram", process.env, accountId).catch( () => [], ); const storeHasWildcard = storeAllowFrom.some((value) => String(value).trim() === "*"); const invalidTelegramAllowFromEntries = new Set(); collectInvalidTelegramAllowFromEntries({ entries: storeAllowFrom, target: invalidTelegramAllowFromEntries, }); const groupAllowFrom = Array.isArray(telegramCfg.groupAllowFrom) ? telegramCfg.groupAllowFrom : []; const groupAllowFromHasWildcard = groupAllowFrom.some((value) => String(value).trim() === "*"); collectInvalidTelegramAllowFromEntries({ entries: groupAllowFrom, target: invalidTelegramAllowFromEntries, }); collectInvalidTelegramAllowFromEntries({ entries: Array.isArray(telegramCfg.allowFrom) ? telegramCfg.allowFrom : [], target: invalidTelegramAllowFromEntries, }); let anyGroupOverride = false; if (groups) { for (const value of Object.values(groups)) { if (!value || typeof value !== "object") { continue; } const group = value as Record; const allowFrom = Array.isArray(group.allowFrom) ? group.allowFrom : []; if (allowFrom.length > 0) { anyGroupOverride = true; collectInvalidTelegramAllowFromEntries({ entries: allowFrom, target: invalidTelegramAllowFromEntries, }); } const topics = group.topics; if (!topics || typeof topics !== "object") { continue; } for (const topicValue of Object.values(topics as Record)) { if (!topicValue || typeof topicValue !== "object") { continue; } const topic = topicValue as Record; const topicAllow = Array.isArray(topic.allowFrom) ? topic.allowFrom : []; if (topicAllow.length > 0) { anyGroupOverride = true; } collectInvalidTelegramAllowFromEntries({ entries: topicAllow, target: invalidTelegramAllowFromEntries, }); } } } const hasAnySenderAllowlist = storeAllowFrom.length > 0 || groupAllowFrom.length > 0 || anyGroupOverride; if (invalidTelegramAllowFromEntries.size > 0) { const examples = Array.from(invalidTelegramAllowFromEntries).slice(0, 5); const more = invalidTelegramAllowFromEntries.size > examples.length ? ` (+${invalidTelegramAllowFromEntries.size - examples.length} more)` : ""; findings.push({ checkId: "channels.telegram.allowFrom.invalid_entries", severity: "warn", title: "Telegram allowlist contains non-numeric entries", detail: "Telegram sender authorization requires numeric Telegram user IDs. " + `Found non-numeric allowFrom entries: ${examples.join(", ")}${more}.`, remediation: "Replace @username entries with numeric Telegram user IDs (use setup to resolve), then re-run the audit.", }); } if (storeHasWildcard || groupAllowFromHasWildcard) { findings.push({ checkId: "channels.telegram.groups.allowFrom.wildcard", severity: "critical", title: "Telegram group allowlist contains wildcard", detail: 'Telegram group sender allowlist contains "*", which allows any group member to run /… commands and control directives.', remediation: 'Remove "*" from channels.telegram.groupAllowFrom and pairing store; prefer explicit numeric Telegram user IDs.', }); return findings; } if (!hasAnySenderAllowlist) { const skillsEnabled = resolveNativeSkillsEnabled({ providerId: "telegram", providerSetting: (telegramCfg.commands as { nativeSkills?: unknown } | undefined) ?.nativeSkills as boolean | "auto" | undefined, globalSetting: params.cfg.commands?.nativeSkills, }); findings.push({ checkId: "channels.telegram.groups.allowFrom.missing", severity: "critical", title: "Telegram group commands have no sender allowlist", detail: `Telegram group access is enabled but no sender allowlist is configured; this allows any group member to invoke /… commands` + (skillsEnabled ? " (including skill commands)." : "."), remediation: "Approve yourself via pairing (recommended), or set channels.telegram.groupAllowFrom (or per-group groups..allowFrom).", }); } return findings; }