Files
openclaw/extensions/openai/openai-chatgpt-device-code.test.ts
Vincent Koc 18e107f494 fix(plugins): report request timeouts for stalled response bodies (#116166)
* fix(openai): preserve device-code request timeouts

* fix(msteams): preserve SharePoint upload timeouts

* fix(qqbot): preserve channel API request timeouts
2026-07-30 10:03:39 +08:00

675 lines
22 KiB
TypeScript

// Openai tests cover openai chatgpt device code plugin behavior.
import { afterEach, describe, expect, it, vi } from "vitest";
import { resolveCodexAccessTokenExpiry } from "./openai-chatgpt-auth-identity.js";
import { loginOpenAICodexDeviceCode } from "./openai-chatgpt-device-code.js";
function createJwt(payload: Record<string, unknown>): string {
const header = Buffer.from(JSON.stringify({ alg: "none", typ: "JWT" })).toString("base64url");
const body = Buffer.from(JSON.stringify(payload)).toString("base64url");
return `${header}.${body}.signature`;
}
function createJsonResponse(body: unknown, init?: { status?: number }) {
return new Response(JSON.stringify(body), {
status: init?.status ?? 200,
headers: {
"Content-Type": "application/json",
},
});
}
function cancelTrackedResponse(
text: string,
init: ResponseInit,
): {
response: Response;
wasCanceled: () => boolean;
} {
let canceled = false;
const stream = new ReadableStream<Uint8Array>({
start(controller) {
controller.enqueue(new TextEncoder().encode(text));
},
cancel() {
canceled = true;
},
});
return {
response: new Response(stream, init),
wasCanceled: () => canceled,
};
}
function fetchCall(fetchMock: ReturnType<typeof vi.fn<typeof fetch>>, index: number) {
const call = fetchMock.mock.calls[index];
if (!call) {
throw new Error(`expected fetch call ${index}`);
}
return call;
}
function waitForFetchAbort(init?: RequestInit): Promise<Response> {
const signal = init?.signal;
if (!signal) {
return Promise.reject(new Error("expected fetch signal"));
}
return new Promise((_resolve, reject) => {
const rejectWithReason = () =>
reject(signal.reason instanceof Error ? signal.reason : new Error("request aborted"));
if (signal.aborted) {
rejectWithReason();
return;
}
signal.addEventListener("abort", rejectWithReason, { once: true });
});
}
function createBodyThatStallsUntilAbort(init?: RequestInit): Response {
const signal = init?.signal;
if (!signal) {
throw new Error("expected fetch signal");
}
return new Response(
new ReadableStream<Uint8Array>({
start(controller) {
const fail = () => controller.error(signal.reason);
if (signal.aborted) {
fail();
return;
}
signal.addEventListener("abort", fail, { once: true });
},
}),
{ status: 200, headers: { "Content-Type": "application/json" } },
);
}
describe("loginOpenAICodexDeviceCode", () => {
afterEach(() => {
vi.restoreAllMocks();
vi.useRealTimers();
vi.unstubAllEnvs();
});
it("times out while waiting for device-code response headers", async () => {
vi.useFakeTimers();
const fetchMock = vi.fn<typeof fetch>((_input, init) => waitForFetchAbort(init));
const login = loginOpenAICodexDeviceCode({
fetchFn: fetchMock,
onVerification: async () => {},
});
await vi.advanceTimersByTimeAsync(0);
expect(fetchMock).toHaveBeenCalledOnce();
expect(fetchCall(fetchMock, 0)[1]?.signal).toBeInstanceOf(AbortSignal);
const rejected = expect(login).rejects.toThrow(
"OpenAI device code user code request timed out after 30000ms",
);
await vi.advanceTimersByTimeAsync(30_000);
await rejected;
});
it("keeps the request timeout active while reading the response body", async () => {
vi.useFakeTimers();
const fetchMock = vi.fn<typeof fetch>(async (_input, init) =>
createBodyThatStallsUntilAbort(init),
);
const login = loginOpenAICodexDeviceCode({
fetchFn: fetchMock,
onVerification: async () => {},
});
await vi.advanceTimersByTimeAsync(0);
expect(fetchMock).toHaveBeenCalledOnce();
await Promise.all([
expect(login).rejects.toThrow("OpenAI device code user code request timed out after 30000ms"),
vi.advanceTimersByTimeAsync(30_000),
]);
});
it("still honors caller cancellation during an active device-code request", async () => {
const callerController = new AbortController();
const fetchMock = vi.fn<typeof fetch>((_input, init) => waitForFetchAbort(init));
const login = loginOpenAICodexDeviceCode({
fetchFn: fetchMock,
onVerification: async () => {},
signal: callerController.signal,
});
await vi.waitFor(() => expect(fetchMock).toHaveBeenCalledOnce());
callerController.abort(new Error("cancelled by caller"));
await expect(login).rejects.toThrow("cancelled by caller");
});
it("routes device-code auth through a configured HTTPS proxy", async () => {
vi.stubEnv("https_proxy", "http://127.0.0.1:7897");
vi.stubEnv("no_proxy", "");
const fetchMock = vi.fn<typeof fetch>().mockResolvedValue(new Response(null, { status: 503 }));
await expect(
loginOpenAICodexDeviceCode({
fetchFn: fetchMock,
onVerification: async () => {},
}),
).rejects.toThrow("OpenAI device code request failed: HTTP 503");
const requestInit = fetchCall(fetchMock, 0)[1] as
| (RequestInit & { dispatcher?: { constructor?: { name?: string } } })
| undefined;
expect(requestInit?.dispatcher?.constructor?.name).toContain("EnvHttpProxyAgent");
});
it("keeps strict guarded fetch when NO_PROXY bypasses OpenAI auth", async () => {
vi.stubEnv("https_proxy", "http://127.0.0.1:7897");
vi.stubEnv("no_proxy", "auth.openai.com");
const fetchMock = vi.fn<typeof fetch>().mockResolvedValue(new Response(null, { status: 503 }));
await expect(
loginOpenAICodexDeviceCode({
fetchFn: fetchMock,
onVerification: async () => {},
}),
).rejects.toThrow("OpenAI device code request failed: HTTP 503");
const requestInit = fetchCall(fetchMock, 0)[1] as
| (RequestInit & { dispatcher?: unknown })
| undefined;
expect(requestInit?.dispatcher).toBeUndefined();
});
it("requests a device code, polls for authorization, and exchanges OAuth tokens", async () => {
vi.useFakeTimers();
vi.stubEnv("OPENCLAW_VERSION", "2026.3.22");
try {
const fetchMock = vi
.fn<typeof fetch>()
.mockResolvedValueOnce(
createJsonResponse({
device_auth_id: "device-auth-123",
user_code: "CODE-12345",
interval: "0",
}),
)
.mockResolvedValueOnce(new Response(null, { status: 404 }))
.mockResolvedValueOnce(
createJsonResponse({
authorization_code: "authorization-code-123",
code_challenge: "ignored",
code_verifier: "code-verifier-123",
}),
)
.mockResolvedValueOnce(
createJsonResponse({
access_token: createJwt({
exp: Math.floor(Date.now() / 1000) + 600,
"https://api.openai.com/auth": {
chatgpt_account_id: "acct_123",
},
"https://api.openai.com/profile": {
email: "codex@example.com",
},
}),
refresh_token: "refresh-token-123",
id_token: createJwt({
"https://api.openai.com/auth": {
chatgpt_account_id: "acct_123",
},
}),
expires_in: 600,
}),
);
const onVerification = vi.fn(async () => {});
const onProgress = vi.fn();
const credentialsPromise = loginOpenAICodexDeviceCode({
fetchFn: fetchMock as typeof fetch,
onVerification,
onProgress,
});
await vi.advanceTimersByTimeAsync(0);
expect(fetchMock).toHaveBeenCalledTimes(2);
await vi.advanceTimersByTimeAsync(4_999);
expect(fetchMock).toHaveBeenCalledTimes(2);
await vi.advanceTimersByTimeAsync(1);
const credentials = await credentialsPromise;
const userCodeRequest = fetchCall(fetchMock, 0);
expect(userCodeRequest[0]).toBe("https://auth.openai.com/api/accounts/deviceauth/usercode");
expect(userCodeRequest[1]?.method).toBe("POST");
expect(userCodeRequest[1]?.signal).toBeInstanceOf(AbortSignal);
expect(userCodeRequest[1]?.headers).toEqual({
"Content-Type": "application/json",
originator: "openclaw",
version: "2026.3.22",
"User-Agent": "openclaw/2026.3.22",
});
const deviceTokenRequest = fetchCall(fetchMock, 1);
expect(deviceTokenRequest[0]).toBe("https://auth.openai.com/api/accounts/deviceauth/token");
expect(deviceTokenRequest[1]?.method).toBe("POST");
expect(deviceTokenRequest[1]?.signal).toBeInstanceOf(AbortSignal);
expect(deviceTokenRequest[1]?.headers).toEqual({
"Content-Type": "application/json",
originator: "openclaw",
version: "2026.3.22",
"User-Agent": "openclaw/2026.3.22",
});
const oauthTokenRequest = fetchCall(fetchMock, 3);
expect(oauthTokenRequest[0]).toBe("https://auth.openai.com/oauth/token");
expect(oauthTokenRequest[1]?.method).toBe("POST");
expect(oauthTokenRequest[1]?.signal).toBeInstanceOf(AbortSignal);
expect(oauthTokenRequest[1]?.headers).toEqual({
"Content-Type": "application/x-www-form-urlencoded",
originator: "openclaw",
version: "2026.3.22",
"User-Agent": "openclaw/2026.3.22",
});
expect(onVerification).toHaveBeenCalledWith({
verificationUrl: "https://auth.openai.com/codex/device",
userCode: "CODE-12345",
expiresInMs: 900_000,
});
expect(onProgress).toHaveBeenNthCalledWith(1, "Requesting device code…");
expect(onProgress).toHaveBeenNthCalledWith(2, "Waiting for device authorization…");
expect(onProgress).toHaveBeenNthCalledWith(3, "Exchanging device code…");
expect(typeof credentials.access).toBe("string");
expect(credentials.access.length).toBeGreaterThan(0);
expect(credentials.refresh).toBe("refresh-token-123");
expect(credentials).not.toHaveProperty("accountId");
expect(credentials.expires).toBeGreaterThan(Date.now());
} finally {
vi.useRealTimers();
vi.unstubAllEnvs();
}
});
it("retries a timed-out authorization poll within the overall device deadline", async () => {
vi.useFakeTimers();
const accessToken = createJwt({
exp: Math.floor(Date.now() / 1000) + 600,
});
let pollAttempts = 0;
const fetchMock = vi.fn<typeof fetch>(async (input, init) => {
const url = typeof input === "string" ? input : input instanceof URL ? input.href : input.url;
if (url.endsWith("/api/accounts/deviceauth/usercode")) {
return createJsonResponse({
device_auth_id: "device-auth-123",
user_code: "CODE-12345",
interval: "0",
});
}
if (url.endsWith("/api/accounts/deviceauth/token")) {
pollAttempts += 1;
if (pollAttempts === 1) {
return await waitForFetchAbort(init);
}
return createJsonResponse({
authorization_code: "authorization-code-123",
code_verifier: "code-verifier-123",
});
}
if (url.endsWith("/oauth/token")) {
return createJsonResponse({
access_token: accessToken,
refresh_token: "refresh-token-123",
expires_in: 600,
});
}
throw new Error(`unexpected OpenAI device-code URL: ${url}`);
});
const login = loginOpenAICodexDeviceCode({
fetchFn: fetchMock,
onVerification: async () => {},
});
await vi.advanceTimersByTimeAsync(0);
expect(pollAttempts).toBe(1);
const resolved = expect(login).resolves.toMatchObject({ refresh: "refresh-token-123" });
await vi.advanceTimersByTimeAsync(30_000);
await resolved;
expect(pollAttempts).toBe(2);
expect(fetchMock).toHaveBeenCalledTimes(4);
});
it("retries a transient authorization poll network failure after the poll delay", async () => {
vi.useFakeTimers();
try {
const accessToken = createJwt({
exp: Math.floor(Date.now() / 1000) + 600,
});
const fetchMock = vi
.fn<typeof fetch>()
.mockResolvedValueOnce(
createJsonResponse({
device_auth_id: "device-auth-123",
user_code: "CODE-12345",
interval: "2",
}),
)
.mockRejectedValueOnce(
new TypeError("fetch failed", {
cause: Object.assign(new Error("getaddrinfo ENOTFOUND auth.openai.com"), {
code: "ENOTFOUND",
}),
}),
)
.mockResolvedValueOnce(
createJsonResponse({
authorization_code: "authorization-code-123",
code_verifier: "code-verifier-123",
}),
)
.mockResolvedValueOnce(
createJsonResponse({
access_token: accessToken,
refresh_token: "refresh-token-123",
expires_in: 600,
}),
);
const login = loginOpenAICodexDeviceCode({
fetchFn: fetchMock,
onVerification: async () => {},
});
await vi.advanceTimersByTimeAsync(0);
expect(fetchMock).toHaveBeenCalledTimes(2);
const resolved = expect(login).resolves.toMatchObject({ refresh: "refresh-token-123" });
await vi.advanceTimersByTimeAsync(1_999);
expect(fetchMock).toHaveBeenCalledTimes(2);
await vi.advanceTimersByTimeAsync(1);
await resolved;
expect(fetchMock).toHaveBeenCalledTimes(4);
} finally {
vi.useRealTimers();
}
});
it("still surfaces local authorization poll errors that are not transport failures", async () => {
const fetchMock = vi
.fn<typeof fetch>()
.mockResolvedValueOnce(
createJsonResponse({
device_auth_id: "device-auth-123",
user_code: "CODE-12345",
interval: "0",
}),
)
.mockRejectedValueOnce(new TypeError("undefined is not a function"));
await expect(
loginOpenAICodexDeviceCode({
fetchFn: fetchMock,
onVerification: async () => {},
}),
).rejects.toThrow("undefined is not a function");
});
it("aborts device-code polling without another request", async () => {
vi.useFakeTimers();
const controller = new AbortController();
try {
const fetchMock = vi
.fn<typeof fetch>()
.mockResolvedValueOnce(
createJsonResponse({
device_auth_id: "device-auth-123",
user_code: "CODE-12345",
interval: "5",
}),
)
.mockResolvedValueOnce(new Response(null, { status: 404 }));
const login = loginOpenAICodexDeviceCode({
fetchFn: fetchMock,
onVerification: async () => {},
signal: controller.signal,
});
await vi.advanceTimersByTimeAsync(0);
expect(fetchMock).toHaveBeenCalledTimes(2);
controller.abort(new Error("cancelled"));
await expect(login).rejects.toThrow("cancelled");
await vi.advanceTimersByTimeAsync(5_000);
expect(fetchMock).toHaveBeenCalledTimes(2);
} finally {
vi.useRealTimers();
}
});
it("treats JWT-derived expiry fallback as an absolute timestamp", async () => {
const accessToken = createJwt({
exp: Math.floor(Date.now() / 1000) + 600,
"https://api.openai.com/auth": {
chatgpt_account_id: "acct_123",
},
});
const expectedExpiry = resolveCodexAccessTokenExpiry(accessToken);
const fetchMock = vi
.fn()
.mockResolvedValueOnce(
createJsonResponse({
device_auth_id: "device-auth-123",
user_code: "CODE-12345",
interval: "0",
}),
)
.mockResolvedValueOnce(
createJsonResponse({
authorization_code: "authorization-code-123",
code_verifier: "code-verifier-123",
}),
)
.mockResolvedValueOnce(
createJsonResponse({
access_token: accessToken,
refresh_token: "refresh-token-123",
}),
);
const credentials = await loginOpenAICodexDeviceCode({
fetchFn: fetchMock as typeof fetch,
onVerification: async () => {},
});
if (expectedExpiry === undefined) {
throw new Error("expected device-code expiry to be calculated");
}
expect(credentials.expires).toBe(expectedExpiry);
});
it("accepts token exchange JSON above the diagnostic preview limit", async () => {
const accessToken = createJwt({
exp: Math.floor(Date.now() / 1000) + 600,
"https://api.openai.com/auth": {
chatgpt_account_id: "acct_123",
},
});
const fetchMock = vi
.fn()
.mockResolvedValueOnce(
createJsonResponse({
device_auth_id: "device-auth-123",
user_code: "CODE-12345",
interval: "0",
}),
)
.mockResolvedValueOnce(
createJsonResponse({
authorization_code: "authorization-code-123",
code_verifier: "code-verifier-123",
}),
)
.mockResolvedValueOnce(
createJsonResponse({
access_token: accessToken,
refresh_token: "refresh-token-123",
id_token: "x".repeat(10_000),
}),
);
const credentials = await loginOpenAICodexDeviceCode({
fetchFn: fetchMock as typeof fetch,
onVerification: async () => {},
});
expect(credentials.refresh).toBe("refresh-token-123");
});
it("falls back when device-code intervals and token lifetimes overflow safe milliseconds", async () => {
vi.useFakeTimers();
try {
const accessToken = createJwt({
exp: Math.floor(Date.now() / 1000) + 600,
"https://api.openai.com/auth": {
chatgpt_account_id: "acct_123",
},
});
const expectedExpiry = resolveCodexAccessTokenExpiry(accessToken);
const fetchMock = vi
.fn<typeof fetch>()
.mockResolvedValueOnce(
createJsonResponse({
device_auth_id: "device-auth-123",
user_code: "CODE-12345",
interval: Number.MAX_SAFE_INTEGER,
}),
)
.mockResolvedValueOnce(new Response(null, { status: 404 }))
.mockResolvedValueOnce(
createJsonResponse({
authorization_code: "authorization-code-123",
code_verifier: "code-verifier-123",
}),
)
.mockResolvedValueOnce(
createJsonResponse({
access_token: accessToken,
refresh_token: "refresh-token-123",
expires_in: Number.MAX_SAFE_INTEGER,
}),
);
const credentialsPromise = loginOpenAICodexDeviceCode({
fetchFn: fetchMock as typeof fetch,
onVerification: async () => {},
});
await vi.advanceTimersByTimeAsync(0);
expect(fetchMock).toHaveBeenCalledTimes(2);
await vi.advanceTimersByTimeAsync(4_999);
expect(fetchMock).toHaveBeenCalledTimes(2);
await vi.advanceTimersByTimeAsync(1);
const credentials = await credentialsPromise;
if (expectedExpiry === undefined) {
throw new Error("expected device-code expiry to be calculated");
}
expect(credentials.expires).toBe(expectedExpiry);
} finally {
vi.useRealTimers();
}
});
it("surfaces user-code request failures", async () => {
const fetchMock = vi.fn().mockResolvedValueOnce(
new Response(`down\r\n\u001B[31mnow\u001B[0m`, {
status: 503,
}),
);
await expect(
loginOpenAICodexDeviceCode({
fetchFn: fetchMock as typeof fetch,
onVerification: async () => {},
}),
).rejects.toThrow("OpenAI device code request failed: HTTP 503 down now");
});
it("bounds user-code error bodies without using response.text()", async () => {
const tracked = cancelTrackedResponse(`${"device code unavailable ".repeat(1024)}tail`, {
status: 503,
headers: { "Content-Type": "text/plain" },
});
const textSpy = vi.spyOn(tracked.response, "text").mockRejectedValue(new Error("unbounded"));
const fetchMock = vi.fn().mockResolvedValueOnce(tracked.response);
const error = await loginOpenAICodexDeviceCode({
fetchFn: fetchMock as typeof fetch,
onVerification: async () => {},
}).catch((cause: unknown) => cause);
expect(error).toBeInstanceOf(Error);
expect((error as Error).message).toMatch(
/OpenAI device code request failed: HTTP 503 device code unavailable/,
);
expect((error as Error).message).not.toContain("tail");
expect(tracked.wasCanceled()).toBe(true);
expect(textSpy).not.toHaveBeenCalled();
});
it("surfaces device authorization failures with sanitized payload details", async () => {
const fetchMock = vi
.fn()
.mockResolvedValueOnce(
createJsonResponse({
device_auth_id: "device-auth-123",
user_code: "CODE-12345",
interval: "0",
}),
)
.mockResolvedValueOnce(
createJsonResponse(
{
error: "authorization_declined\r\n\u001B[31mspoofed\u001B[0m",
error_description: "Denied\r\nnext line",
},
{ status: 401 },
),
);
await expect(
loginOpenAICodexDeviceCode({
fetchFn: fetchMock as typeof fetch,
onVerification: async () => {},
}),
).rejects.toThrow(
"OpenAI device authorization failed: authorization_declined spoofed (Denied next line)",
);
});
it("strips C1 terminal controls from reflected device-code errors", async () => {
const fetchMock = vi
.fn()
.mockResolvedValueOnce(
createJsonResponse({
device_auth_id: "device-auth-123",
user_code: "CODE-12345",
interval: "0",
}),
)
.mockResolvedValueOnce(
createJsonResponse(
{
error: `authorization_declined${String.fromCharCode(0x9b)}spoofed`,
error_description: `Denied${String.fromCharCode(0x9d)}next line`,
},
{ status: 401 },
),
);
await expect(
loginOpenAICodexDeviceCode({
fetchFn: fetchMock as typeof fetch,
onVerification: async () => {},
}),
).rejects.toThrow(
"OpenAI device authorization failed: authorization_declined spoofed (Denied next line)",
);
});
});