mirror of
https://github.com/openclaw/openclaw.git
synced 2026-05-06 08:00:42 +00:00
* fix: forward launcher respawn signals * docs: explain respawn signal exit timer * fix: centralize launcher respawn supervision * fix: include respawn helper in duplicate scan * fix: keep launcher respawn bridge local
376 lines
13 KiB
TypeScript
376 lines
13 KiB
TypeScript
import { spawn, spawnSync } from "node:child_process";
|
|
import fs from "node:fs/promises";
|
|
import path from "node:path";
|
|
import { afterEach, describe, expect, it } from "vitest";
|
|
import { cleanupTempDirs, makeTempDir } from "./helpers/temp-dir.js";
|
|
|
|
async function makeLauncherFixture(fixtureRoots: string[]): Promise<string> {
|
|
const fixtureRoot = makeTempDir(fixtureRoots, "openclaw-launcher-");
|
|
await fs.copyFile(
|
|
path.resolve(process.cwd(), "openclaw.mjs"),
|
|
path.join(fixtureRoot, "openclaw.mjs"),
|
|
);
|
|
await fs.mkdir(path.join(fixtureRoot, "dist"), { recursive: true });
|
|
return fixtureRoot;
|
|
}
|
|
|
|
async function addSourceTreeMarker(fixtureRoot: string): Promise<void> {
|
|
await fs.mkdir(path.join(fixtureRoot, "src"), { recursive: true });
|
|
await fs.writeFile(path.join(fixtureRoot, "src", "entry.ts"), "export {};\n", "utf8");
|
|
}
|
|
|
|
async function addGitMarker(fixtureRoot: string): Promise<void> {
|
|
await fs.writeFile(path.join(fixtureRoot, ".git"), "gitdir: .git/worktrees/openclaw\n", "utf8");
|
|
}
|
|
|
|
async function addCompileCacheProbe(fixtureRoot: string): Promise<void> {
|
|
await fs.writeFile(
|
|
path.join(fixtureRoot, "dist", "entry.js"),
|
|
[
|
|
'import module from "node:module";',
|
|
"process.stdout.write(",
|
|
' `${module.getCompileCacheDir?.() ? "cache:enabled" : "cache:disabled"};respawn:${process.env.OPENCLAW_SOURCE_COMPILE_CACHE_RESPAWNED ?? "0"}`',
|
|
");",
|
|
].join("\n"),
|
|
"utf8",
|
|
);
|
|
}
|
|
|
|
async function waitForFile(filePath: string, timeoutMs: number): Promise<string> {
|
|
const start = Date.now();
|
|
while (Date.now() - start < timeoutMs) {
|
|
try {
|
|
return await fs.readFile(filePath, "utf8");
|
|
} catch {
|
|
await new Promise((resolve) => setTimeout(resolve, 50));
|
|
}
|
|
}
|
|
throw new Error(`timed out waiting for ${filePath}`);
|
|
}
|
|
|
|
async function waitUntil(check: () => boolean, timeoutMs: number): Promise<boolean> {
|
|
const start = Date.now();
|
|
while (Date.now() - start < timeoutMs) {
|
|
if (check()) {
|
|
return true;
|
|
}
|
|
await new Promise((resolve) => setTimeout(resolve, 50));
|
|
}
|
|
return check();
|
|
}
|
|
|
|
function isProcessAlive(pid: number | undefined): boolean {
|
|
if (!pid) {
|
|
return false;
|
|
}
|
|
try {
|
|
process.kill(pid, 0);
|
|
return true;
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
function launcherEnv(extra: NodeJS.ProcessEnv = {}): NodeJS.ProcessEnv {
|
|
const env = { ...process.env, ...extra };
|
|
delete env.NODE_COMPILE_CACHE;
|
|
delete env.NODE_DISABLE_COMPILE_CACHE;
|
|
for (const [key, value] of Object.entries(extra)) {
|
|
if (value === undefined) {
|
|
delete env[key];
|
|
} else {
|
|
env[key] = value;
|
|
}
|
|
}
|
|
return env;
|
|
}
|
|
|
|
describe("openclaw launcher", () => {
|
|
const fixtureRoots: string[] = [];
|
|
|
|
afterEach(async () => {
|
|
cleanupTempDirs(fixtureRoots);
|
|
});
|
|
|
|
it("surfaces transitive entry import failures instead of masking them as missing dist", async () => {
|
|
const fixtureRoot = await makeLauncherFixture(fixtureRoots);
|
|
await fs.writeFile(
|
|
path.join(fixtureRoot, "dist", "entry.js"),
|
|
'import "missing-openclaw-launcher-dep";\nexport {};\n',
|
|
"utf8",
|
|
);
|
|
|
|
const result = spawnSync(process.execPath, [path.join(fixtureRoot, "openclaw.mjs"), "--help"], {
|
|
cwd: fixtureRoot,
|
|
env: launcherEnv(),
|
|
encoding: "utf8",
|
|
});
|
|
|
|
expect(result.status).not.toBe(0);
|
|
expect(result.stderr).toContain("missing-openclaw-launcher-dep");
|
|
expect(result.stderr).not.toContain("missing dist/entry.(m)js");
|
|
});
|
|
|
|
it("keeps the friendly launcher error for a truly missing entry build output", async () => {
|
|
const fixtureRoot = await makeLauncherFixture(fixtureRoots);
|
|
|
|
const result = spawnSync(process.execPath, [path.join(fixtureRoot, "openclaw.mjs"), "--help"], {
|
|
cwd: fixtureRoot,
|
|
env: launcherEnv(),
|
|
encoding: "utf8",
|
|
});
|
|
|
|
expect(result.status).not.toBe(0);
|
|
expect(result.stderr).toContain("missing dist/entry.(m)js");
|
|
});
|
|
|
|
it("explains how to recover from an unbuilt source install", async () => {
|
|
const fixtureRoot = await makeLauncherFixture(fixtureRoots);
|
|
await addSourceTreeMarker(fixtureRoot);
|
|
|
|
const result = spawnSync(process.execPath, [path.join(fixtureRoot, "openclaw.mjs"), "--help"], {
|
|
cwd: fixtureRoot,
|
|
env: launcherEnv(),
|
|
encoding: "utf8",
|
|
});
|
|
|
|
expect(result.status).not.toBe(0);
|
|
expect(result.stderr).toContain("missing dist/entry.(m)js");
|
|
expect(result.stderr).toContain("unbuilt source tree or GitHub source archive");
|
|
expect(result.stderr).toContain("pnpm install && pnpm build");
|
|
expect(result.stderr).toContain("github:openclaw/openclaw#<ref>");
|
|
});
|
|
|
|
it("keeps compile cache off for source-checkout launchers", async () => {
|
|
const fixtureRoot = await makeLauncherFixture(fixtureRoots);
|
|
await addSourceTreeMarker(fixtureRoot);
|
|
await addCompileCacheProbe(fixtureRoot);
|
|
|
|
const result = spawnSync(process.execPath, [path.join(fixtureRoot, "openclaw.mjs")], {
|
|
cwd: fixtureRoot,
|
|
env: launcherEnv(),
|
|
encoding: "utf8",
|
|
});
|
|
|
|
expect(result.status).toBe(0);
|
|
expect(result.stdout).toBe("cache:disabled;respawn:0");
|
|
});
|
|
|
|
it("respawns source-checkout launchers without inherited NODE_COMPILE_CACHE", async () => {
|
|
const fixtureRoot = await makeLauncherFixture(fixtureRoots);
|
|
await addGitMarker(fixtureRoot);
|
|
await addCompileCacheProbe(fixtureRoot);
|
|
|
|
const result = spawnSync(process.execPath, [path.join(fixtureRoot, "openclaw.mjs")], {
|
|
cwd: fixtureRoot,
|
|
env: launcherEnv({
|
|
NODE_COMPILE_CACHE: path.join(fixtureRoot, ".node-compile-cache"),
|
|
}),
|
|
encoding: "utf8",
|
|
});
|
|
|
|
expect(result.status).toBe(0);
|
|
expect(result.stdout).toBe("cache:disabled;respawn:1");
|
|
});
|
|
|
|
it.runIf(process.platform !== "win32")(
|
|
"forwards SIGTERM to source-checkout compile-cache respawn children",
|
|
async () => {
|
|
const fixtureRoot = await makeLauncherFixture(fixtureRoots);
|
|
await addGitMarker(fixtureRoot);
|
|
const childInfoPath = path.join(fixtureRoot, "child-info.json");
|
|
await fs.writeFile(
|
|
path.join(fixtureRoot, "dist", "entry.js"),
|
|
[
|
|
'import { writeFileSync } from "node:fs";',
|
|
`writeFileSync(${JSON.stringify(childInfoPath)}, JSON.stringify({ pid: process.pid }) + "\\n");`,
|
|
'process.title = "openclaw-launcher-sigterm-test-child";',
|
|
"setInterval(() => {}, 1000);",
|
|
"",
|
|
].join("\n"),
|
|
"utf8",
|
|
);
|
|
|
|
const launcher = spawn(process.execPath, [path.join(fixtureRoot, "openclaw.mjs")], {
|
|
cwd: fixtureRoot,
|
|
env: launcherEnv({
|
|
NODE_COMPILE_CACHE: path.join(fixtureRoot, ".node-compile-cache"),
|
|
}),
|
|
stdio: "ignore",
|
|
});
|
|
let respawnChildPid: number | undefined;
|
|
|
|
try {
|
|
const childInfo = JSON.parse(await waitForFile(childInfoPath, 5000)) as { pid: number };
|
|
respawnChildPid = childInfo.pid;
|
|
|
|
launcher.kill("SIGTERM");
|
|
|
|
await waitUntil(() => !isProcessAlive(respawnChildPid), 5000);
|
|
expect(isProcessAlive(respawnChildPid)).toBe(false);
|
|
} finally {
|
|
if (isProcessAlive(respawnChildPid)) {
|
|
process.kill(respawnChildPid!, "SIGKILL");
|
|
}
|
|
if (isProcessAlive(launcher.pid)) {
|
|
process.kill(launcher.pid!, "SIGKILL");
|
|
}
|
|
}
|
|
},
|
|
);
|
|
|
|
it.runIf(process.platform !== "win32")(
|
|
"exits after SIGTERM when the respawn child ignores the forwarded signal",
|
|
async () => {
|
|
const fixtureRoot = await makeLauncherFixture(fixtureRoots);
|
|
await addGitMarker(fixtureRoot);
|
|
const childInfoPath = path.join(fixtureRoot, "child-info.json");
|
|
await fs.writeFile(
|
|
path.join(fixtureRoot, "dist", "entry.js"),
|
|
[
|
|
'import { writeFileSync } from "node:fs";',
|
|
`writeFileSync(${JSON.stringify(childInfoPath)}, JSON.stringify({ pid: process.pid }) + "\\n");`,
|
|
'process.title = "openclaw-launcher-sigterm-ignore-test-child";',
|
|
'process.on("SIGTERM", () => {});',
|
|
"setInterval(() => {}, 1000);",
|
|
"",
|
|
].join("\n"),
|
|
"utf8",
|
|
);
|
|
|
|
const launcher = spawn(process.execPath, [path.join(fixtureRoot, "openclaw.mjs")], {
|
|
cwd: fixtureRoot,
|
|
env: launcherEnv({
|
|
NODE_COMPILE_CACHE: path.join(fixtureRoot, ".node-compile-cache"),
|
|
}),
|
|
stdio: "ignore",
|
|
});
|
|
let respawnChildPid: number | undefined;
|
|
|
|
try {
|
|
const childInfo = JSON.parse(await waitForFile(childInfoPath, 5000)) as { pid: number };
|
|
respawnChildPid = childInfo.pid;
|
|
|
|
launcher.kill("SIGTERM");
|
|
|
|
await waitUntil(
|
|
() => !isProcessAlive(launcher.pid) && !isProcessAlive(respawnChildPid),
|
|
5000,
|
|
);
|
|
expect(isProcessAlive(launcher.pid)).toBe(false);
|
|
expect(isProcessAlive(respawnChildPid)).toBe(false);
|
|
} finally {
|
|
if (isProcessAlive(respawnChildPid)) {
|
|
process.kill(respawnChildPid!, "SIGKILL");
|
|
}
|
|
if (isProcessAlive(launcher.pid)) {
|
|
process.kill(launcher.pid!, "SIGKILL");
|
|
}
|
|
}
|
|
},
|
|
);
|
|
|
|
it.runIf(process.platform !== "win32")(
|
|
"respawns symlinked source-checkout launchers without inherited NODE_COMPILE_CACHE",
|
|
async () => {
|
|
const fixtureRoot = await makeLauncherFixture(fixtureRoots);
|
|
await addGitMarker(fixtureRoot);
|
|
await addCompileCacheProbe(fixtureRoot);
|
|
const linkParent = makeTempDir(fixtureRoots, "openclaw-launcher-link-");
|
|
const linkedRoot = path.join(linkParent, "openclaw-linked");
|
|
await fs.symlink(fixtureRoot, linkedRoot, "dir");
|
|
|
|
const result = spawnSync(process.execPath, [path.join(linkedRoot, "openclaw.mjs")], {
|
|
cwd: linkParent,
|
|
env: launcherEnv({
|
|
NODE_COMPILE_CACHE: path.join(linkParent, ".node-compile-cache"),
|
|
}),
|
|
encoding: "utf8",
|
|
});
|
|
|
|
expect(result.status).toBe(0);
|
|
expect(result.stdout).toBe("cache:disabled;respawn:1");
|
|
},
|
|
);
|
|
|
|
it("keeps compile cache enabled for packaged launchers when NODE_COMPILE_CACHE is configured", async () => {
|
|
const fixtureRoot = await makeLauncherFixture(fixtureRoots);
|
|
await addCompileCacheProbe(fixtureRoot);
|
|
|
|
const result = spawnSync(process.execPath, [path.join(fixtureRoot, "openclaw.mjs")], {
|
|
cwd: fixtureRoot,
|
|
env: launcherEnv({
|
|
NODE_COMPILE_CACHE: path.join(fixtureRoot, ".node-compile-cache"),
|
|
}),
|
|
encoding: "utf8",
|
|
});
|
|
|
|
expect(result.status).toBe(0);
|
|
expect(result.stdout).toBe("cache:enabled;respawn:0");
|
|
});
|
|
|
|
it("scopes packaged launcher compile cache inside configured cache roots", async () => {
|
|
const fixtureRoot = await makeLauncherFixture(fixtureRoots);
|
|
await fs.writeFile(path.join(fixtureRoot, "package.json"), '{"version":"2026.4.29"}\n');
|
|
await fs.writeFile(
|
|
path.join(fixtureRoot, "dist", "entry.js"),
|
|
[
|
|
'import module from "node:module";',
|
|
'process.stdout.write(module.getCompileCacheDir?.() ?? "cache:disabled");',
|
|
].join("\n"),
|
|
"utf8",
|
|
);
|
|
|
|
const result = spawnSync(process.execPath, [path.join(fixtureRoot, "openclaw.mjs")], {
|
|
cwd: fixtureRoot,
|
|
env: launcherEnv({
|
|
NODE_COMPILE_CACHE: path.join(fixtureRoot, ".node-compile-cache"),
|
|
}),
|
|
encoding: "utf8",
|
|
});
|
|
|
|
expect(result.status).toBe(0);
|
|
expect(result.stdout).toContain(path.join(".node-compile-cache", "openclaw", "2026.4.29"));
|
|
});
|
|
|
|
it("falls back to the default packaged launcher compile cache when NODE_COMPILE_CACHE is empty", async () => {
|
|
const fixtureRoot = await makeLauncherFixture(fixtureRoots);
|
|
const runCwd = makeTempDir(fixtureRoots, "openclaw-launcher-cwd-");
|
|
await fs.writeFile(path.join(fixtureRoot, "package.json"), '{"version":"2026.4.29"}\n');
|
|
await fs.writeFile(
|
|
path.join(fixtureRoot, "dist", "entry.js"),
|
|
[
|
|
'import module from "node:module";',
|
|
'process.stdout.write(module.getCompileCacheDir?.() ?? "cache:disabled");',
|
|
].join("\n"),
|
|
"utf8",
|
|
);
|
|
|
|
const result = spawnSync(process.execPath, [path.join(fixtureRoot, "openclaw.mjs")], {
|
|
cwd: runCwd,
|
|
env: launcherEnv({
|
|
NODE_COMPILE_CACHE: "",
|
|
}),
|
|
encoding: "utf8",
|
|
});
|
|
|
|
expect(result.status).toBe(0);
|
|
expect(result.stdout).toContain(path.join("node-compile-cache", "openclaw", "2026.4.29"));
|
|
expect(result.stdout).not.toContain(path.join(runCwd, "openclaw"));
|
|
});
|
|
|
|
it("enables compile cache for packaged launchers", async () => {
|
|
const fixtureRoot = await makeLauncherFixture(fixtureRoots);
|
|
await addCompileCacheProbe(fixtureRoot);
|
|
|
|
const result = spawnSync(process.execPath, [path.join(fixtureRoot, "openclaw.mjs")], {
|
|
cwd: fixtureRoot,
|
|
env: launcherEnv(),
|
|
encoding: "utf8",
|
|
});
|
|
|
|
expect(result.status).toBe(0);
|
|
expect(result.stdout).toBe("cache:enabled;respawn:0");
|
|
});
|
|
});
|