Files
openclaw/test/vitest-projects-config.test.ts
clawsweeper[bot] cb31616d88 fix(ui): clean up delete confirm popover listener (#76318)
Summary:
- The PR centralizes Control UI chat delete-confirm popover dismissal, adds listener-cleanup regression coverage and unit-UI test routing fixes, and records the fix in the changelog.
- Reproducibility: yes. Current-main source shows a high-confidence path: open the delete confirm, let `reques ... ncel, Delete, or same-button toggle; those paths remove the popover without removing the document listener.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(ui): clean up delete confirm popover listener
- PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-7559…
- PR branch already contained follow-up commit before automerge: fix(clawsweeper): reconcile automerge-openclaw-openclaw-75590 with ma…
- PR branch already contained follow-up commit before automerge: fix(ui): repair delete confirm listener cleanup checks

Validation:
- ClawSweeper review passed for head 62240d8153.
- Required merge gates passed before the squash merge.

Prepared head SHA: 62240d8153
Review: https://github.com/openclaw/openclaw/pull/76318#issuecomment-4364990281

Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: Ricardo-M-L <69202550+Ricardo-M-L@users.noreply.github.com>
2026-05-03 02:21:10 +00:00

190 lines
8.1 KiB
TypeScript

import { afterEach, describe, expect, it } from "vitest";
import { createPatternFileHelper } from "./helpers/pattern-file.js";
import { normalizeConfigPath, normalizeConfigPaths } from "./helpers/vitest-config-paths.js";
import { createAgentsCoreVitestConfig } from "./vitest/vitest.agents-core.config.ts";
import { createAgentsPiEmbeddedVitestConfig } from "./vitest/vitest.agents-pi-embedded.config.ts";
import { createAgentsSupportVitestConfig } from "./vitest/vitest.agents-support.config.ts";
import { createAgentsToolsVitestConfig } from "./vitest/vitest.agents-tools.config.ts";
import { createAgentsVitestConfig } from "./vitest/vitest.agents.config.ts";
import bundledConfig from "./vitest/vitest.bundled.config.ts";
import { createCommandsLightVitestConfig } from "./vitest/vitest.commands-light.config.ts";
import { createCommandsVitestConfig } from "./vitest/vitest.commands.config.ts";
import baseConfig, { rootVitestProjects } from "./vitest/vitest.config.ts";
import contractChannelConfigConfig from "./vitest/vitest.contracts-channel-config.config.ts";
import contractChannelRegistryConfig from "./vitest/vitest.contracts-channel-registry.config.ts";
import contractChannelSessionConfig from "./vitest/vitest.contracts-channel-session.config.ts";
import contractChannelSurfaceConfig from "./vitest/vitest.contracts-channel-surface.config.ts";
import contractPluginConfig from "./vitest/vitest.contracts-plugin.config.ts";
import {
createContractsVitestConfig,
pluginContractPatterns,
} from "./vitest/vitest.contracts-shared.ts";
import { createGatewayVitestConfig } from "./vitest/vitest.gateway.config.ts";
import { createPluginSdkLightVitestConfig } from "./vitest/vitest.plugin-sdk-light.config.ts";
import {
resolveSharedVitestWorkerConfig,
sharedVitestConfig,
} from "./vitest/vitest.shared.config.ts";
import { createUiVitestConfig, unitUiIncludePatterns } from "./vitest/vitest.ui.config.ts";
import { createUnitFastVitestConfig } from "./vitest/vitest.unit-fast.config.ts";
import unitUiConfig from "./vitest/vitest.unit-ui.config.ts";
import { createUnitVitestConfig } from "./vitest/vitest.unit.config.ts";
const patternFiles = createPatternFileHelper("openclaw-vitest-projects-config-");
afterEach(() => {
patternFiles.cleanup();
});
describe("projects vitest config", () => {
it("defines the native root project list for all non-live Vitest lanes", () => {
expect(baseConfig.test?.projects).toEqual([...rootVitestProjects]);
});
it("disables vite env-file loading for vitest lanes", () => {
expect(baseConfig.envFile).toBe(false);
expect(sharedVitestConfig.envFile).toBe(false);
});
it("keeps root projects on their expected pool defaults", () => {
expect(createGatewayVitestConfig().test.pool).toBe("threads");
expect(createAgentsVitestConfig().test.pool).toBe("threads");
expect(createAgentsCoreVitestConfig().test.pool).toBe("threads");
expect(createAgentsPiEmbeddedVitestConfig().test.pool).toBe("threads");
expect(createAgentsSupportVitestConfig().test.pool).toBe("threads");
expect(createAgentsToolsVitestConfig().test.pool).toBe("threads");
expect(createCommandsLightVitestConfig().test.pool).toBe("threads");
expect(createCommandsVitestConfig().test.pool).toBe("forks");
expect(createPluginSdkLightVitestConfig().test.pool).toBe("threads");
expect(createUnitFastVitestConfig().test.pool).toBe("threads");
expect(createContractsVitestConfig(pluginContractPatterns).test.pool).toBe("forks");
});
it("honors explicit worker caps in CI vitest lanes", () => {
expect(
resolveSharedVitestWorkerConfig({
env: { CI: "true", OPENCLAW_VITEST_MAX_WORKERS: "1" },
isCI: true,
isWindows: false,
localScheduling: {
fileParallelism: false,
maxWorkers: 1,
throttledBySystem: false,
},
}),
).toEqual({
fileParallelism: false,
maxWorkers: 1,
});
expect(
resolveSharedVitestWorkerConfig({
env: { CI: "true" },
isCI: true,
isWindows: false,
localScheduling: {
fileParallelism: false,
maxWorkers: 1,
throttledBySystem: false,
},
}),
).toEqual({
fileParallelism: true,
maxWorkers: 3,
});
});
it("keeps contract shards on the non-isolated fork runner by default", () => {
const config = createContractsVitestConfig(pluginContractPatterns);
expect(config.test.pool).toBe("forks");
expect(config.test.isolate).toBe(false);
expect(normalizeConfigPath(config.test.runner)).toBe("test/non-isolated-runner.ts");
});
it("gives contract project configs unique names", () => {
expect([
contractChannelSurfaceConfig.test?.name,
contractChannelConfigConfig.test?.name,
contractChannelRegistryConfig.test?.name,
contractChannelSessionConfig.test?.name,
contractPluginConfig.test?.name,
]).toEqual([
"contracts-channel-surface",
"contracts-channel-config",
"contracts-channel-registry",
"contracts-channel-session",
"contracts-plugin",
]);
});
it("narrows the contracts lane to targeted contract files", () => {
const config = createContractsVitestConfig(pluginContractPatterns, {}, [
"node",
"vitest",
"run",
"src/plugins/contracts/bundled-web-search.google.contract.test.ts",
]);
expect(config.test.include).toEqual([
"src/plugins/contracts/bundled-web-search.google.contract.test.ts",
]);
});
it("intersects contract include-file shards with the config family", () => {
const includeFile = patternFiles.writePatternFile("include.json", [
"src/channels/plugins/contracts/surfaces-only.registry-backed-shard-b.contract.test.ts",
"src/channels/plugins/contracts/surfaces-only.registry-backed-shard-d.contract.test.ts",
"src/channels/plugins/contracts/directory.registry-backed-shard-a.contract.test.ts",
]);
const config = createContractsVitestConfig(
["src/channels/plugins/contracts/*-shard-a.contract.test.ts"],
{
OPENCLAW_VITEST_INCLUDE_FILE: includeFile,
},
);
expect(config.test.include).toEqual([
"src/channels/plugins/contracts/directory.registry-backed-shard-a.contract.test.ts",
]);
});
it("keeps the root ui lane aligned with the shared jsdom setup", () => {
const config = createUiVitestConfig();
expect(config.test.environment).toBe("jsdom");
expect(config.test.isolate).toBe(false);
expect(normalizeConfigPath(config.test.runner)).toBe("test/non-isolated-runner.ts");
const setupFiles = normalizeConfigPaths(config.test.setupFiles);
expect(setupFiles).not.toContain("test/setup-openclaw-runtime.ts");
expect(setupFiles).toContain("ui/src/test-helpers/lit-warnings.setup.ts");
expect(config.test.deps?.optimizer?.web?.enabled).toBe(true);
});
it("keeps the unit-ui shard aligned with the shared jsdom setup", () => {
expect(unitUiConfig.test?.environment).toBe("jsdom");
expect(unitUiConfig.test?.isolate).toBe(false);
expect(normalizeConfigPath(unitUiConfig.test?.runner)).toBe("test/non-isolated-runner.ts");
expect(unitUiIncludePatterns).toContain("ui/src/ui/views/dreaming.test.ts");
const setupFiles = normalizeConfigPaths(unitUiConfig.test?.setupFiles);
expect(setupFiles).not.toContain("test/setup-openclaw-runtime.ts");
expect(setupFiles).toContain("ui/src/test-helpers/lit-warnings.setup.ts");
});
it("keeps the unit lane on the non-isolated runner by default", () => {
const config = createUnitVitestConfig();
expect(config.test.isolate).toBe(false);
expect(normalizeConfigPath(config.test.runner)).toBe("test/non-isolated-runner.ts");
});
it("keeps the unit-fast lane on shared workers without the reset-heavy runner", () => {
const config = createUnitFastVitestConfig();
expect(config.test.isolate).toBe(false);
expect(config.test.runner).toBeUndefined();
});
it("keeps the bundled lane on thread workers with the non-isolated runner", () => {
expect(bundledConfig.test?.pool).toBe("threads");
expect(bundledConfig.test?.isolate).toBe(false);
expect(normalizeConfigPath(bundledConfig.test?.runner)).toBe("test/non-isolated-runner.ts");
});
});