Files
openclaw/extensions/browser/src/server.ts
Coy Geek 8ca66cad68 fix(browser): scope control auth to active gateway mode (#65639)
Browser control now authorizes only the resolved active gateway credential and fails closed when password mode lacks a resolved password.

Also removes the duplicate Slack test-helper middleware stub that kept current CI red after the base rebase.

Fixes #65626.

Co-authored-by: Coy Geek <65363919+coygeek@users.noreply.github.com>
2026-04-25 01:03:39 +01:00

120 lines
3.8 KiB
TypeScript

import type { Server } from "node:http";
import express from "express";
import { deleteBridgeAuthForPort, setBridgeAuthForPort } from "./browser/bridge-auth-registry.js";
import { resolveBrowserConfig } from "./browser/config.js";
import {
ensureBrowserControlAuth,
resolveBrowserControlAuth,
shouldAutoGenerateBrowserAuth,
} from "./browser/control-auth.js";
import { registerBrowserRoutes } from "./browser/routes/index.js";
import type { BrowserRouteRegistrar } from "./browser/routes/types.js";
import { createBrowserRuntimeState, stopBrowserRuntime } from "./browser/runtime-lifecycle.js";
import { type BrowserServerState, createBrowserRouteContext } from "./browser/server-context.js";
import {
installBrowserAuthMiddleware,
installBrowserCommonMiddleware,
} from "./browser/server-middleware.js";
import { loadConfig } from "./config/config.js";
import { createSubsystemLogger } from "./logging/subsystem.js";
import { isDefaultBrowserPluginEnabled } from "./plugin-enabled.js";
let state: BrowserServerState | null = null;
const log = createSubsystemLogger("browser");
const logServer = log.child("server");
export async function startBrowserControlServerFromConfig(): Promise<BrowserServerState | null> {
if (state) {
return state;
}
const cfg = loadConfig();
if (!isDefaultBrowserPluginEnabled(cfg)) {
return null;
}
const resolved = resolveBrowserConfig(cfg.browser, cfg);
if (!resolved.enabled) {
return null;
}
let browserAuth = resolveBrowserControlAuth(cfg);
let browserAuthBootstrapFailed = false;
try {
const ensured = await ensureBrowserControlAuth({ cfg });
browserAuth = ensured.auth;
if (ensured.generatedToken) {
logServer.info(
"No browser auth configured; generated browser control auth credential automatically.",
);
}
} catch (err) {
logServer.warn(`failed to auto-configure browser auth: ${String(err)}`);
browserAuthBootstrapFailed = true;
}
const browserAuthRequired =
browserAuthBootstrapFailed || shouldAutoGenerateBrowserAuth(process.env);
if (browserAuthRequired && !browserAuth.token && !browserAuth.password) {
if (browserAuthBootstrapFailed) {
logServer.error(
"browser control startup aborted: authentication bootstrap failed " +
"and no fallback auth is configured.",
);
} else {
logServer.error("browser control startup aborted: no authentication configured.");
}
return null;
}
const app = express();
installBrowserCommonMiddleware(app);
installBrowserAuthMiddleware(app, browserAuth);
const ctx = createBrowserRouteContext({
getState: () => state,
refreshConfigFromDisk: true,
});
registerBrowserRoutes(app as unknown as BrowserRouteRegistrar, ctx);
const port = resolved.controlPort;
const server = await new Promise<Server>((resolve, reject) => {
const s = app.listen(port, "127.0.0.1", () => resolve(s));
s.once("error", reject);
}).catch((err) => {
logServer.error(`openclaw browser server failed to bind 127.0.0.1:${port}: ${String(err)}`);
return null;
});
if (!server) {
return null;
}
state = await createBrowserRuntimeState({
server,
port,
resolved,
onWarn: (message) => logServer.warn(message),
});
setBridgeAuthForPort(port, browserAuth);
const authMode = browserAuth.token ? "token" : browserAuth.password ? "password" : "off";
logServer.info(`Browser control listening on http://127.0.0.1:${port}/ (auth=${authMode})`);
return state;
}
export async function stopBrowserControlServer(): Promise<void> {
const current = state;
if (current?.port) {
deleteBridgeAuthForPort(current.port);
}
await stopBrowserRuntime({
current,
getState: () => state,
clearState: () => {
state = null;
},
closeServer: true,
onWarn: (message) => logServer.warn(message),
});
}