Files
openclaw/src/cli/config-set-input.ts
cxbAsDev 2295fae731 fix: bound miscellaneous unbounded file reads across 5 modules (#110516)
* fix: bound misc unbounded fs.readFile calls; remove unused fs import

* fix: decode buffer to string before passing to string consumers

readRegularFile and readRegularFileSync return { buffer, stat },
not a string. All 4 new call sites passed the raw object to functions
expecting a string (JSON.parse, RegExp.test, template literals, etc.),
causing TS2345 type errors and runtime failures.

Fix each call by extracting .buffer and calling .toString('utf8')
before passing the result to string consumers.

* style: fix oxfmt formatting in config-set-input.ts

* fix: bound config and trajectory metadata reads

Co-authored-by: 陈宪彪0668000387 <chen.xianbiao@xydigit.com>

* refactor: isolate bounded read ownership

Co-authored-by: 陈宪彪0668000387 <chen.xianbiao@xydigit.com>

---------

Co-authored-by: Peter Steinberger <steipete@gmail.com>
2026-07-18 23:27:26 +01:00

165 lines
5.2 KiB
TypeScript

// Input-mode parsing helpers for `openclaw config set` values, refs, providers, and batches.
import fs from "node:fs";
import {
normalizeOptionalString,
normalizeStringifiedOptionalString,
} from "@openclaw/normalization-core/string-coerce";
import JSON5 from "json5";
import { hasErrnoCode } from "../infra/errors.js";
import { readFileDescriptorBoundedSync } from "../infra/file-descriptor-read.js";
export type ConfigSetOptions = {
strictJson?: boolean;
/** @deprecated Use strictJson. */
json?: boolean;
dryRun?: boolean;
allowExec?: boolean;
merge?: boolean;
replace?: boolean;
refProvider?: string;
refSource?: string;
refId?: string;
providerSource?: string;
providerAllowlist?: string[];
providerPath?: string;
providerMode?: string;
providerTimeoutMs?: string;
providerMaxBytes?: string;
providerCommand?: string;
providerArg?: string[];
providerNoOutputTimeoutMs?: string;
providerMaxOutputBytes?: string;
providerJsonOnly?: boolean;
providerEnv?: string[];
providerPassEnv?: string[];
providerTrustedDir?: string[];
providerAllowInsecurePath?: boolean;
providerAllowSymlinkCommand?: boolean;
batchJson?: string;
batchFile?: string;
};
export type ConfigSetBatchEntry = {
path: string;
value?: unknown;
ref?: unknown;
provider?: unknown;
};
const CONFIG_MUTATION_FILE_MAX_BYTES = 8 * 1024 * 1024;
export function readConfigMutationFileSync(filePath: string): string {
// These explicit CLI file flags have historically followed user-provided
// symlinks. Pin the opened descriptor, then bound the read without changing that contract.
const fd = fs.openSync(filePath, "r");
try {
return readFileDescriptorBoundedSync(fd, CONFIG_MUTATION_FILE_MAX_BYTES).toString("utf8");
} finally {
fs.closeSync(fd);
}
}
export function hasBatchMode(opts: ConfigSetOptions): boolean {
return Boolean(
normalizeOptionalString(opts.batchJson) || normalizeOptionalString(opts.batchFile),
);
}
export function hasRefBuilderOptions(opts: ConfigSetOptions): boolean {
return Boolean(opts.refProvider || opts.refSource || opts.refId);
}
export function hasProviderBuilderOptions(opts: ConfigSetOptions): boolean {
return Boolean(
opts.providerSource ||
opts.providerAllowlist?.length ||
opts.providerPath ||
opts.providerMode ||
opts.providerTimeoutMs ||
opts.providerMaxBytes ||
opts.providerCommand ||
opts.providerArg?.length ||
opts.providerNoOutputTimeoutMs ||
opts.providerMaxOutputBytes ||
opts.providerJsonOnly ||
opts.providerEnv?.length ||
opts.providerPassEnv?.length ||
opts.providerTrustedDir?.length ||
opts.providerAllowInsecurePath ||
opts.providerAllowSymlinkCommand,
);
}
function parseJson5Raw(raw: string, label: string): unknown {
try {
return JSON5.parse(raw);
} catch (err) {
throw new Error(`Failed to parse ${label}: ${String(err)}`, { cause: err });
}
}
function parseBatchEntries(raw: string, sourceLabel: string): ConfigSetBatchEntry[] {
const parsed = parseJson5Raw(raw, sourceLabel);
if (!Array.isArray(parsed)) {
throw new Error(`${sourceLabel} must be a JSON array.`);
}
const out: ConfigSetBatchEntry[] = [];
for (const [index, entry] of parsed.entries()) {
if (!entry || typeof entry !== "object" || Array.isArray(entry)) {
throw new Error(`${sourceLabel}[${index}] must be an object.`);
}
const typed = entry as Record<string, unknown>;
const path = normalizeOptionalString(typed.path) ?? "";
if (!path) {
throw new Error(`${sourceLabel}[${index}].path is required.`);
}
const hasValue = Object.hasOwn(typed, "value");
const hasRef = Object.hasOwn(typed, "ref");
const hasProvider = Object.hasOwn(typed, "provider");
const modeCount = Number(hasValue) + Number(hasRef) + Number(hasProvider);
if (modeCount !== 1) {
throw new Error(
`${sourceLabel}[${index}] must include exactly one of: value, ref, provider.`,
);
}
out.push({
path,
...(hasValue ? { value: typed.value } : {}),
...(hasRef ? { ref: typed.ref } : {}),
...(hasProvider ? { provider: typed.provider } : {}),
});
}
return out;
}
export function parseBatchSource(opts: ConfigSetOptions): ConfigSetBatchEntry[] | null {
// Batch mode is exclusive because each entry carries its own value/ref/provider mode.
const batchJson = normalizeOptionalString(opts.batchJson);
const batchFile = normalizeOptionalString(opts.batchFile);
const hasInline = Boolean(batchJson);
const hasFile = Boolean(batchFile);
if (!hasInline && !hasFile) {
return null;
}
if (hasInline && hasFile) {
throw new Error("Use either --batch-json or --batch-file, not both.");
}
if (hasInline) {
return parseBatchEntries(batchJson as string, "--batch-json");
}
const pathname = normalizeStringifiedOptionalString(opts.batchFile) ?? "";
if (!pathname) {
throw new Error("--batch-file must not be empty.");
}
let raw: string;
try {
raw = readConfigMutationFileSync(pathname);
} catch (err) {
if (hasErrnoCode(err, "ENOENT")) {
throw new Error(`--batch-file not found: ${pathname}`, { cause: err });
}
throw err;
}
return parseBatchEntries(raw, "--batch-file");
}