mirror of
https://github.com/openclaw/openclaw.git
synced 2026-03-12 07:20:45 +00:00
137b7d9aab
* fix(ui): prioritize displayName over label in webchat session picker The session picker dropdown in the webchat UI was showing raw session keys instead of human-readable display names. resolveSessionDisplayName() checked label before displayName and formatted displayName-based entries as key (displayName) instead of displayName (key). Swap the priority so displayName is checked first, and use a consistent humanName (key) format for both displayName and label fallbacks. Fixes #6645 * test: use deterministic updatedAt in session display name tests
80 lines
2.5 KiB
TypeScript
80 lines
2.5 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import type { SessionsListResult } from "./types.ts";
|
|
import { resolveSessionDisplayName } from "./app-render.helpers.ts";
|
|
|
|
type SessionRow = SessionsListResult["sessions"][number];
|
|
|
|
function row(overrides: Partial<SessionRow> & { key: string }): SessionRow {
|
|
return { kind: "direct", updatedAt: 0, ...overrides };
|
|
}
|
|
|
|
describe("resolveSessionDisplayName", () => {
|
|
it("returns key when no row is provided", () => {
|
|
expect(resolveSessionDisplayName("agent:main:main")).toBe("agent:main:main");
|
|
});
|
|
|
|
it("returns key when row has no label or displayName", () => {
|
|
expect(resolveSessionDisplayName("agent:main:main", row({ key: "agent:main:main" }))).toBe(
|
|
"agent:main:main",
|
|
);
|
|
});
|
|
|
|
it("returns key when displayName matches key", () => {
|
|
expect(resolveSessionDisplayName("mykey", row({ key: "mykey", displayName: "mykey" }))).toBe(
|
|
"mykey",
|
|
);
|
|
});
|
|
|
|
it("returns key when label matches key", () => {
|
|
expect(resolveSessionDisplayName("mykey", row({ key: "mykey", label: "mykey" }))).toBe("mykey");
|
|
});
|
|
|
|
it("uses displayName prominently when available", () => {
|
|
expect(
|
|
resolveSessionDisplayName(
|
|
"discord:123:456",
|
|
row({ key: "discord:123:456", displayName: "My Chat" }),
|
|
),
|
|
).toBe("My Chat (discord:123:456)");
|
|
});
|
|
|
|
it("falls back to label when displayName is absent", () => {
|
|
expect(
|
|
resolveSessionDisplayName(
|
|
"discord:123:456",
|
|
row({ key: "discord:123:456", label: "General" }),
|
|
),
|
|
).toBe("General (discord:123:456)");
|
|
});
|
|
|
|
it("prefers displayName over label when both are present", () => {
|
|
expect(
|
|
resolveSessionDisplayName(
|
|
"discord:123:456",
|
|
row({ key: "discord:123:456", displayName: "My Chat", label: "General" }),
|
|
),
|
|
).toBe("My Chat (discord:123:456)");
|
|
});
|
|
|
|
it("ignores whitespace-only displayName", () => {
|
|
expect(
|
|
resolveSessionDisplayName(
|
|
"discord:123:456",
|
|
row({ key: "discord:123:456", displayName: " ", label: "General" }),
|
|
),
|
|
).toBe("General (discord:123:456)");
|
|
});
|
|
|
|
it("ignores whitespace-only label", () => {
|
|
expect(
|
|
resolveSessionDisplayName("discord:123:456", row({ key: "discord:123:456", label: " " })),
|
|
).toBe("discord:123:456");
|
|
});
|
|
|
|
it("trims displayName and label", () => {
|
|
expect(resolveSessionDisplayName("k", row({ key: "k", displayName: " My Chat " }))).toBe(
|
|
"My Chat (k)",
|
|
);
|
|
});
|
|
});
|