mirror of
https://github.com/openclaw/openclaw.git
synced 2026-07-28 04:41:13 +00:00
* fix(reply): deliver final reply when queued follow-up claims session; scope dedupe to routed thread Two core bugs caused composed replies to be silently dropped (no delivery, no error) when a second message arrived in the same thread mid-run: 1. dispatch-from-config: ensureDispatchReplyOperation only kept the dispatch-owned operation authoritative while it had no result. Once runReplyAgent completed the operation to drain queued follow-ups, a second same-thread inbound could claim the session and the first final reply would try to re-acquire the lane instead of finishing delivery, deadlocking behind the queued work. Keep the dispatch-owned operation authoritative through final delivery. 2. reply-payloads-dedupe: messaging-tool reply dedupe compared only the channel target, not the routed thread, so a send in one thread could suppress a later reply in a different thread. Thread the routed thread id through buildReplyPayloads + follow-up delivery and only fall back to channel-only matching for providers without a thread-aware suppression matcher when neither side carries thread evidence. Adds regression tests; existing Telegram topic-suppression behavior is preserved by gating the thread guard to providers lacking a plugin matcher. * fix(reply): preserve threaded message delivery evidence * fix(reply): dedupe final payloads by delivery route * fix(slack): preserve native send thread evidence * fix(reply): preserve explicit reply thread evidence * fix(reply): align explicit reply route dedupe * fix(reply): preserve delivery lane through final dispatch * fix(mattermost): preserve threaded tool send routes * chore(plugin-sdk): refresh API baseline * fix(reply): align final delivery route dedupe * fix(reply): gate followups on final delivery * fix(reply): keep send receipts private * fix(reply): infer implicit message provider * fix(reply): align routed threading policy * fix(reply): preserve queued delivery context * fix(reply): hydrate queued system event routes * fix(reply): hydrate queued execution routes * fix(reply): scope final delivery barriers * fix(slack): preserve DM target aliases * fix(reply): mirror resolved source thread routes * fix(mattermost): retain delayed delivery barrier * fix(codex): separate message routing from tool policy * fix(reply): consume normalized Slack DM targets once * fix(slack): remove stale target alias * style(reply): satisfy changed lint gates * fix(mattermost): preserve explicit reply targets * test: align Slack reply branch checks * fix(reply): persist overflow summaries to admitted session --------- Co-authored-by: Peter Steinberger <steipete@gmail.com>
71 lines
2.3 KiB
TypeScript
71 lines
2.3 KiB
TypeScript
/** Test helpers for queued follow-up reply runs. */
|
|
import { afterAll, beforeAll } from "vitest";
|
|
import type { OpenClawConfig } from "../../config/types.openclaw.js";
|
|
import { defaultRuntime } from "../../runtime.js";
|
|
import type { FollowupRun } from "./queue.js";
|
|
|
|
/** Creates an externally resolved promise for queue-order tests. */
|
|
export function createDeferred<T>() {
|
|
let resolve!: (value: T) => void;
|
|
let reject!: (reason?: unknown) => void;
|
|
const promise = new Promise<T>((res, rej) => {
|
|
resolve = res;
|
|
reject = rej;
|
|
});
|
|
return { promise, resolve, reject };
|
|
}
|
|
|
|
/** Builds a minimal queued follow-up run fixture. */
|
|
export function createQueueTestRun(params: {
|
|
prompt: string;
|
|
messageId?: string;
|
|
originatingChannel?: FollowupRun["originatingChannel"];
|
|
originatingTo?: string;
|
|
originatingAccountId?: string;
|
|
originatingThreadId?: string | number;
|
|
originatingReplyToId?: string;
|
|
originatingReplyToMode?: FollowupRun["originatingReplyToMode"];
|
|
originatingChatType?: string;
|
|
currentInboundEventKind?: FollowupRun["currentInboundEventKind"];
|
|
}): FollowupRun {
|
|
return {
|
|
prompt: params.prompt,
|
|
messageId: params.messageId,
|
|
enqueuedAt: Date.now(),
|
|
originatingChannel: params.originatingChannel,
|
|
originatingTo: params.originatingTo,
|
|
originatingAccountId: params.originatingAccountId,
|
|
originatingThreadId: params.originatingThreadId,
|
|
originatingReplyToId: params.originatingReplyToId,
|
|
originatingReplyToMode: params.originatingReplyToMode,
|
|
originatingChatType: params.originatingChatType,
|
|
currentInboundEventKind: params.currentInboundEventKind,
|
|
run: {
|
|
agentId: "agent",
|
|
agentDir: "/tmp",
|
|
sessionId: "sess",
|
|
sessionFile: "/tmp/session.json",
|
|
workspaceDir: "/tmp",
|
|
config: {} as OpenClawConfig,
|
|
provider: "openai",
|
|
model: "gpt-test",
|
|
timeoutMs: 10_000,
|
|
blockReplyBreak: "text_end",
|
|
},
|
|
};
|
|
}
|
|
|
|
/** Suppresses runtime error logging while queue tests intentionally trigger failures. */
|
|
export function installQueueRuntimeErrorSilencer(): void {
|
|
let previousRuntimeError: typeof defaultRuntime.error;
|
|
|
|
beforeAll(() => {
|
|
previousRuntimeError = defaultRuntime.error;
|
|
defaultRuntime.error = (() => {}) as typeof defaultRuntime.error;
|
|
});
|
|
|
|
afterAll(() => {
|
|
defaultRuntime.error = previousRuntimeError;
|
|
});
|
|
}
|