mirror of
https://github.com/openclaw/openclaw.git
synced 2026-03-19 22:10:51 +00:00
* docs: add ACP thread-bound agents plan doc * docs: expand ACP implementation specification * feat(acp): route ACP sessions through core dispatch and lifecycle cleanup * feat(acp): add /acp commands and Discord spawn gate * ACP: add acpx runtime plugin backend * fix(subagents): defer transient lifecycle errors before announce * Agents: harden ACP sessions_spawn and tighten spawn guidance * Agents: require explicit ACP target for runtime spawns * docs: expand ACP control-plane implementation plan * ACP: harden metadata seeding and spawn guidance * ACP: centralize runtime control-plane manager and fail-closed dispatch * ACP: harden runtime manager and unify spawn helpers * Commands: route ACP sessions through ACP runtime in agent command * ACP: require persisted metadata for runtime spawns * Sessions: preserve ACP metadata when updating entries * Plugins: harden ACP backend registry across loaders * ACPX: make availability probe compatible with adapters * E2E: add manual Discord ACP plain-language smoke script * ACPX: preserve streamed spacing across Discord delivery * Docs: add ACP Discord streaming strategy * ACP: harden Discord stream buffering for thread replies * ACP: reuse shared block reply pipeline for projector * ACP: unify streaming config and adopt coalesceIdleMs * Docs: add temporary ACP production hardening plan * Docs: trim temporary ACP hardening plan goals * Docs: gate ACP thread controls by backend capabilities * ACP: add capability-gated runtime controls and /acp operator commands * Docs: remove temporary ACP hardening plan * ACP: fix spawn target validation and close cache cleanup * ACP: harden runtime dispatch and recovery paths * ACP: split ACP command/runtime internals and centralize policy * ACP: harden runtime lifecycle, validation, and observability * ACP: surface runtime and backend session IDs in thread bindings * docs: add temp plan for binding-service migration * ACP: migrate thread binding flows to SessionBindingService * ACP: address review feedback and preserve prompt wording * ACPX plugin: pin runtime dependency and prefer bundled CLI * Discord: complete binding-service migration cleanup and restore ACP plan * Docs: add standalone ACP agents guide * ACP: route harness intents to thread-bound ACP sessions * ACP: fix spawn thread routing and queue-owner stall * ACP: harden startup reconciliation and command bypass handling * ACP: fix dispatch bypass type narrowing * ACP: align runtime metadata to agentSessionId * ACP: normalize session identifier handling and labels * ACP: mark thread banner session ids provisional until first reply * ACP: stabilize session identity mapping and startup reconciliation * ACP: add resolved session-id notices and cwd in thread intros * Discord: prefix thread meta notices consistently * Discord: unify ACP/thread meta notices with gear prefix * Discord: split thread persona naming from meta formatting * Extensions: bump acpx plugin dependency to 0.1.9 * Agents: gate ACP prompt guidance behind acp.enabled * Docs: remove temp experiment plan docs * Docs: scope streaming plan to holy grail refactor * Docs: refactor ACP agents guide for human-first flow * Docs/Skill: add ACP feature-flag guidance and direct acpx telephone-game flow * Docs/Skill: add OpenCode and Pi to ACP harness lists * Docs/Skill: align ACP harness list with current acpx registry * Dev/Test: move ACP plain-language smoke script and mark as keep * Docs/Skill: reorder ACP harness lists with Pi first * ACP: split control-plane manager into core/types/utils modules * Docs: refresh ACP thread-bound agents plan * ACP: extract dispatch lane and split manager domains * ACP: centralize binding context and remove reverse deps * Infra: unify system message formatting * ACP: centralize error boundaries and session id rendering * ACP: enforce init concurrency cap and strict meta clear * Tests: fix ACP dispatch binding mock typing * Tests: fix Discord thread-binding mock drift and ACP request id * ACP: gate slash bypass and persist cleared overrides * ACPX: await pre-abort cancel before runTurn return * Extension: pin acpx runtime dependency to 0.1.11 * Docs: add pinned acpx install strategy for ACP extension * Extensions/acpx: enforce strict local pinned startup * Extensions/acpx: tighten acp-router install guidance * ACPX: retry runtime test temp-dir cleanup * Extensions/acpx: require proactive ACPX repair for thread spawns * Extensions/acpx: require restart offer after acpx reinstall * extensions/acpx: remove workspace protocol devDependency * extensions/acpx: bump pinned acpx to 0.1.13 * extensions/acpx: sync lockfile after dependency bump * ACPX: make runtime spawn Windows-safe * fix: align doctor-config-flow repair tests with default-account migration (#23580) (thanks @osolmaz)
197 lines
6.5 KiB
TypeScript
197 lines
6.5 KiB
TypeScript
import path from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
import type { OpenClawPluginConfigSchema } from "openclaw/plugin-sdk";
|
|
|
|
export const ACPX_PERMISSION_MODES = ["approve-all", "approve-reads", "deny-all"] as const;
|
|
export type AcpxPermissionMode = (typeof ACPX_PERMISSION_MODES)[number];
|
|
|
|
export const ACPX_NON_INTERACTIVE_POLICIES = ["deny", "fail"] as const;
|
|
export type AcpxNonInteractivePermissionPolicy = (typeof ACPX_NON_INTERACTIVE_POLICIES)[number];
|
|
|
|
export const ACPX_PINNED_VERSION = "0.1.13";
|
|
const ACPX_BIN_NAME = process.platform === "win32" ? "acpx.cmd" : "acpx";
|
|
export const ACPX_PLUGIN_ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
|
|
export const ACPX_BUNDLED_BIN = path.join(ACPX_PLUGIN_ROOT, "node_modules", ".bin", ACPX_BIN_NAME);
|
|
export const ACPX_LOCAL_INSTALL_COMMAND = `npm install --omit=dev --no-save acpx@${ACPX_PINNED_VERSION}`;
|
|
|
|
export type AcpxPluginConfig = {
|
|
cwd?: string;
|
|
permissionMode?: AcpxPermissionMode;
|
|
nonInteractivePermissions?: AcpxNonInteractivePermissionPolicy;
|
|
timeoutSeconds?: number;
|
|
queueOwnerTtlSeconds?: number;
|
|
};
|
|
|
|
export type ResolvedAcpxPluginConfig = {
|
|
command: string;
|
|
cwd: string;
|
|
permissionMode: AcpxPermissionMode;
|
|
nonInteractivePermissions: AcpxNonInteractivePermissionPolicy;
|
|
timeoutSeconds?: number;
|
|
queueOwnerTtlSeconds: number;
|
|
};
|
|
|
|
const DEFAULT_PERMISSION_MODE: AcpxPermissionMode = "approve-reads";
|
|
const DEFAULT_NON_INTERACTIVE_POLICY: AcpxNonInteractivePermissionPolicy = "fail";
|
|
const DEFAULT_QUEUE_OWNER_TTL_SECONDS = 0.1;
|
|
|
|
type ParseResult =
|
|
| { ok: true; value: AcpxPluginConfig | undefined }
|
|
| { ok: false; message: string };
|
|
|
|
function isRecord(value: unknown): value is Record<string, unknown> {
|
|
return typeof value === "object" && value !== null && !Array.isArray(value);
|
|
}
|
|
|
|
function isPermissionMode(value: string): value is AcpxPermissionMode {
|
|
return ACPX_PERMISSION_MODES.includes(value as AcpxPermissionMode);
|
|
}
|
|
|
|
function isNonInteractivePermissionPolicy(
|
|
value: string,
|
|
): value is AcpxNonInteractivePermissionPolicy {
|
|
return ACPX_NON_INTERACTIVE_POLICIES.includes(value as AcpxNonInteractivePermissionPolicy);
|
|
}
|
|
|
|
function parseAcpxPluginConfig(value: unknown): ParseResult {
|
|
if (value === undefined) {
|
|
return { ok: true, value: undefined };
|
|
}
|
|
if (!isRecord(value)) {
|
|
return { ok: false, message: "expected config object" };
|
|
}
|
|
const allowedKeys = new Set([
|
|
"cwd",
|
|
"permissionMode",
|
|
"nonInteractivePermissions",
|
|
"timeoutSeconds",
|
|
"queueOwnerTtlSeconds",
|
|
]);
|
|
for (const key of Object.keys(value)) {
|
|
if (!allowedKeys.has(key)) {
|
|
return { ok: false, message: `unknown config key: ${key}` };
|
|
}
|
|
}
|
|
|
|
const cwd = value.cwd;
|
|
if (cwd !== undefined && (typeof cwd !== "string" || cwd.trim() === "")) {
|
|
return { ok: false, message: "cwd must be a non-empty string" };
|
|
}
|
|
|
|
const permissionMode = value.permissionMode;
|
|
if (
|
|
permissionMode !== undefined &&
|
|
(typeof permissionMode !== "string" || !isPermissionMode(permissionMode))
|
|
) {
|
|
return {
|
|
ok: false,
|
|
message: `permissionMode must be one of: ${ACPX_PERMISSION_MODES.join(", ")}`,
|
|
};
|
|
}
|
|
|
|
const nonInteractivePermissions = value.nonInteractivePermissions;
|
|
if (
|
|
nonInteractivePermissions !== undefined &&
|
|
(typeof nonInteractivePermissions !== "string" ||
|
|
!isNonInteractivePermissionPolicy(nonInteractivePermissions))
|
|
) {
|
|
return {
|
|
ok: false,
|
|
message: `nonInteractivePermissions must be one of: ${ACPX_NON_INTERACTIVE_POLICIES.join(", ")}`,
|
|
};
|
|
}
|
|
|
|
const timeoutSeconds = value.timeoutSeconds;
|
|
if (
|
|
timeoutSeconds !== undefined &&
|
|
(typeof timeoutSeconds !== "number" || !Number.isFinite(timeoutSeconds) || timeoutSeconds <= 0)
|
|
) {
|
|
return { ok: false, message: "timeoutSeconds must be a positive number" };
|
|
}
|
|
|
|
const queueOwnerTtlSeconds = value.queueOwnerTtlSeconds;
|
|
if (
|
|
queueOwnerTtlSeconds !== undefined &&
|
|
(typeof queueOwnerTtlSeconds !== "number" ||
|
|
!Number.isFinite(queueOwnerTtlSeconds) ||
|
|
queueOwnerTtlSeconds < 0)
|
|
) {
|
|
return { ok: false, message: "queueOwnerTtlSeconds must be a non-negative number" };
|
|
}
|
|
|
|
return {
|
|
ok: true,
|
|
value: {
|
|
cwd: typeof cwd === "string" ? cwd.trim() : undefined,
|
|
permissionMode: typeof permissionMode === "string" ? permissionMode : undefined,
|
|
nonInteractivePermissions:
|
|
typeof nonInteractivePermissions === "string" ? nonInteractivePermissions : undefined,
|
|
timeoutSeconds: typeof timeoutSeconds === "number" ? timeoutSeconds : undefined,
|
|
queueOwnerTtlSeconds:
|
|
typeof queueOwnerTtlSeconds === "number" ? queueOwnerTtlSeconds : undefined,
|
|
},
|
|
};
|
|
}
|
|
|
|
export function createAcpxPluginConfigSchema(): OpenClawPluginConfigSchema {
|
|
return {
|
|
safeParse(value: unknown):
|
|
| { success: true; data?: unknown }
|
|
| {
|
|
success: false;
|
|
error: { issues: Array<{ path: Array<string | number>; message: string }> };
|
|
} {
|
|
const parsed = parseAcpxPluginConfig(value);
|
|
if (parsed.ok) {
|
|
return { success: true, data: parsed.value };
|
|
}
|
|
return {
|
|
success: false,
|
|
error: {
|
|
issues: [{ path: [], message: parsed.message }],
|
|
},
|
|
};
|
|
},
|
|
jsonSchema: {
|
|
type: "object",
|
|
additionalProperties: false,
|
|
properties: {
|
|
cwd: { type: "string" },
|
|
permissionMode: {
|
|
type: "string",
|
|
enum: [...ACPX_PERMISSION_MODES],
|
|
},
|
|
nonInteractivePermissions: {
|
|
type: "string",
|
|
enum: [...ACPX_NON_INTERACTIVE_POLICIES],
|
|
},
|
|
timeoutSeconds: { type: "number", minimum: 0.001 },
|
|
queueOwnerTtlSeconds: { type: "number", minimum: 0 },
|
|
},
|
|
},
|
|
};
|
|
}
|
|
|
|
export function resolveAcpxPluginConfig(params: {
|
|
rawConfig: unknown;
|
|
workspaceDir?: string;
|
|
}): ResolvedAcpxPluginConfig {
|
|
const parsed = parseAcpxPluginConfig(params.rawConfig);
|
|
if (!parsed.ok) {
|
|
throw new Error(parsed.message);
|
|
}
|
|
const normalized = parsed.value ?? {};
|
|
const fallbackCwd = params.workspaceDir?.trim() || process.cwd();
|
|
const cwd = path.resolve(normalized.cwd?.trim() || fallbackCwd);
|
|
|
|
return {
|
|
command: ACPX_BUNDLED_BIN,
|
|
cwd,
|
|
permissionMode: normalized.permissionMode ?? DEFAULT_PERMISSION_MODE,
|
|
nonInteractivePermissions:
|
|
normalized.nonInteractivePermissions ?? DEFAULT_NON_INTERACTIVE_POLICY,
|
|
timeoutSeconds: normalized.timeoutSeconds,
|
|
queueOwnerTtlSeconds: normalized.queueOwnerTtlSeconds ?? DEFAULT_QUEUE_OWNER_TTL_SECONDS,
|
|
};
|
|
}
|