mirror of
https://github.com/openclaw/openclaw.git
synced 2026-07-09 21:33:54 +00:00
createNonExitingRuntime.exit() threw a generic Error, making it impossible for upstream try-catch to distinguish a simulated process exit from a real runtime crash. Added an ExitError class (internal-only, not exported from SDK) that callers can check via instanceof. ExitError is kept internal to avoid expanding the public plugin SDK API surface without maintainer approval. Tests import directly from ./runtime.js. Fixes #97796. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
88 lines
2.4 KiB
TypeScript
88 lines
2.4 KiB
TypeScript
// Tests for terminal runtime helpers.
|
|
import { describe, expect, it, vi } from "vitest";
|
|
|
|
// Mock dependencies
|
|
vi.mock("../packages/terminal-core/src/progress-line.js", () => ({
|
|
clearActiveProgressLine: vi.fn(),
|
|
}));
|
|
|
|
vi.mock("../packages/terminal-core/src/restore.js", () => ({
|
|
restoreTerminalState: vi.fn(),
|
|
}));
|
|
|
|
import { createNonExitingRuntime, ExitError, writeRuntimeJson } from "./runtime.js";
|
|
|
|
describe("createNonExitingRuntime", () => {
|
|
it("returns runtime with exit function", () => {
|
|
const runtime = createNonExitingRuntime();
|
|
expect(typeof runtime.exit).toBe("function");
|
|
});
|
|
|
|
it("exit function throws ExitError", () => {
|
|
const runtime = createNonExitingRuntime();
|
|
expect(() => runtime.exit(1)).toThrow(ExitError);
|
|
});
|
|
|
|
it("ExitError includes exit code", () => {
|
|
const runtime = createNonExitingRuntime();
|
|
expect(() => runtime.exit(42)).toThrow("exit 42");
|
|
expect(() => runtime.exit(42)).toThrow(ExitError);
|
|
});
|
|
|
|
it("ExitError is distinguishable from generic Error", () => {
|
|
const runtime = createNonExitingRuntime();
|
|
try {
|
|
runtime.exit(1);
|
|
} catch (err) {
|
|
expect(err instanceof ExitError).toBe(true);
|
|
expect(err instanceof Error).toBe(true);
|
|
}
|
|
});
|
|
});
|
|
|
|
describe("writeRuntimeJson", () => {
|
|
it("writes JSON using writeJson when available", () => {
|
|
const runtime = {
|
|
log: vi.fn(),
|
|
error: vi.fn(),
|
|
exit: vi.fn(),
|
|
writeStdout: vi.fn(),
|
|
writeJson: vi.fn(),
|
|
};
|
|
writeRuntimeJson(runtime, { key: "value" });
|
|
expect(runtime.writeJson).toHaveBeenCalledWith({ key: "value" }, 2);
|
|
});
|
|
|
|
it("writes JSON using log when writeJson not available", () => {
|
|
const runtime = {
|
|
log: vi.fn(),
|
|
error: vi.fn(),
|
|
exit: vi.fn(),
|
|
};
|
|
writeRuntimeJson(runtime, { key: "value" });
|
|
expect(runtime.log).toHaveBeenCalled();
|
|
});
|
|
|
|
it("uses custom space parameter", () => {
|
|
const runtime = {
|
|
log: vi.fn(),
|
|
error: vi.fn(),
|
|
exit: vi.fn(),
|
|
writeStdout: vi.fn(),
|
|
writeJson: vi.fn(),
|
|
};
|
|
writeRuntimeJson(runtime, { key: "value" }, 4);
|
|
expect(runtime.writeJson).toHaveBeenCalledWith({ key: "value" }, 4);
|
|
});
|
|
|
|
it("handles zero space parameter", () => {
|
|
const runtime = {
|
|
log: vi.fn(),
|
|
error: vi.fn(),
|
|
exit: vi.fn(),
|
|
};
|
|
writeRuntimeJson(runtime, { key: "value" }, 0);
|
|
expect(runtime.log).toHaveBeenCalledWith('{"key":"value"}');
|
|
});
|
|
});
|