Files
openclaw/src/plugins/runtime/index.test.ts
Peter Steinberger bb46b79d3c refactor: internalize OpenClaw agent runtime (#85341)
* refactor: extract agent core package

Introduce packages/agent-core as the OpenClaw-owned home for reusable agent loop, harness, session, prompt, and runtime dependency contracts.

* refactor: extract shared llm runtime

Move provider model registries, stream wrappers, OAuth helpers, and LLM utilities into src/llm with plugin-sdk barrels instead of depending on the old embedded runtime layout.

* refactor: remove pi runtime internals

Rename remaining Pi-shaped agent surfaces to OpenClaw agent runtime names, delete obsolete Pi docs and package graph checks, and add the third-party notice for incorporated code.

* refactor: tighten agent session runtime

Make agent-core/runtime dependencies explicit, consolidate compaction and session transcript helpers, and move model/session helpers behind OpenClaw-owned contracts.

* refactor: remove static model and pi auth paths

Drop static model catalogs and Pi auth bridges, move model/provider facts to manifest-owned runtime contracts, and harden internal embedded-agent utilities.

* refactor: remove legacy provider compat paths

* docs: remove agent parity notes

* fix: skip provider wildcard metadata parsing

* refactor: share session extension sdk loading

* refactor: inline acpx proxy error formatter

* refactor: fold edit recovery into edit tool

* fix: accept extension batch separator

* test: align startup provider plugin expectations

* fix: restore provider-scoped release discovery

* test: align static asset packaging expectations

* fix: run static provider catalogs during scoped discovery

* fix: add provider entry catalogs for scoped live discovery

* fix: load lightweight provider catalog entries

* fix: refresh provider-scoped plugin metadata

* fix: keep provider catalog entries on release live path

* fix: keep static manifest models in release live checks

* fix: harden release model discovery

* fix: reduce OpenAI live cache probe reasoning

* fix: disable OpenAI cache probe reasoning

* ci: extend OpenAI gateway live timeout

* fix: extend live gateway model budget

* fix: stabilize release validation regressions

* fix: honor provider aliases in model rows

* fix: stabilize release validation lanes

* fix: stabilize release memory qa

* ci: stabilize release validation lanes

* ci: prefer ipv4 for live docker node calls

* fix: restore shared tool-call stream wrapper

* ci: remove legacy pi test shard alias

* fix: clean up embedded agent test drift

* fix: stabilize runtime alias status

* fix: clean up embedded agent ci drift

* fix: restore release ci invariants

* fix: clean up post-rebase runtime drift

* fix: restore release ci checks

* fix: restore release ci after rebase

* fix: remove stale pi runtime path

* test: align compaction runtime expectations

* test: update plugin prerelease expectations

* fix: handle claude live tool approvals

* fix: stabilize release validation gates

* fix: finish agent runtime import

* test: finish post-rebase agent runtime mocks

* fix: keep codex compaction native

* fix: stabilize codex app-server hook tests

* test: isolate codex diagnostic active run

* test: remove codex diagnostic completion race

# Conflicts:
#	extensions/codex/src/app-server/run-attempt.test.ts

* ci: fix full release manifest performance run id

* refactor: narrow llm plugin sdk boundary

* chore: drop generated google boundary stamps

* fix: repair rebase fallout

* fix: clean up rebased runtime references

* fix: decode codex jwt payloads as base64url

* fix: preserve shipped pi runtime alias

* fix: add scoped sdk virtual modules

* fix: decode llm codex oauth jwt as base64url

* fix: avoid stale vertex adc negative cache

* fix: harden tool arg decoding and codeql path

* fix: keep vertex adc negative checks live

* refactor: consolidate codex jwt and edit helpers

* fix: await codex oauth node runtime imports

* fix: preserve sdk tool and notice contracts

* fix: preserve shipped compat config boundaries

* fix: align codex oauth callback host

* fix: terminate agent-core loop streams on failure

* fix: keep codex oauth callback alive during fallback

* ci: include session tools in critical codeql scans

* fix: keep Cloudflare Anthropic provider auth header

* docs: redirect legacy pi runtime pages

* fix: honor bundled web provider compat discovery

* fix: protect session output spill files

* fix: keep legacy agent dir env blocked

* fix: contain auto-discovered skill symlinks

* fix: harden agent core sdk proxy surfaces

* fix: restore approval reaction sdk compat

* fix: keep live docker runs bounded

* fix: keep codex oauth redirect host aligned

* fix: resolve post-rebase agent runtime drift

* fix: redact anthropic oauth parse failures

* fix: preserve responses strict tool shaping

* fix: repair agent runtime rebase cleanup

* docs: redirect retired parity pages

* fix: bound auto-discovered resources to roots

* fix: repair post-rebase agent test drift

* fix: preserve bundled provider allowlist migration

* fix: preserve manifest-owned provider aliases

* fix: declare photon image dependency

* fix: keep provider headers out of proxy body

* fix: preserve shipped env aliases

* fix: refresh control ui i18n generated state

* fix: quote read fallback paths

* fix: preview edits through configured backend

* test: satisfy core test typecheck

* fix: preserve ZAI usage auth fallback

* test: repair codex diagnostic test

* fix: repair agent runtime rebase drift

* test: finish embedded runner import rename

* fix: repair agent runtime rebase integrations

* test: align compaction oauth fallback expectations

* fix: allow sdk-auth session models

* fix: update doctor tool schema import

* fix: preserve bedrock plugin region

* fix: stream harmony-like prose immediately

* ci: include session runtime in codeql shards

* fix: repair latest rebase integrations

* fix: honor explicit codex websocket transport

* fix: keep openai-compatible credentials provider-scoped

* fix: refresh sdk api baseline after rebase

* fix: route cli runtime aliases through openclaw harness

* test: rename stale harness mock expectation

* test: rename embedded agent overflow calls

* test: clean embedded auth test wording

* test: use openclaw stream types in deepinfra cache test

* fix: refresh sdk api baseline on latest main

* fix: honor bundled discovery compat allowlists

* fix: refresh sdk api baseline after latest rebase

* fix: remove stale rebase imports

* test: rename stale model catalog mock

* test: mock renamed doctor runtime modules

* fix: map canonical kimi env auth

* fix: use internal model registry in bench script

* fix: migrate deepinfra provider catalog entry

* fix: enforce builtin tool suppression

* fix: route compaction auth and proxy payloads safely

* refactor: prune unused llm registry leftovers

* test: update codex hooks session import

* test: fix model picker ci coverage

* test: align model picker auth mock types
2026-05-27 19:24:04 +01:00

447 lines
15 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from "vitest";
import { DEFAULT_MODEL, DEFAULT_PROVIDER } from "../../agents/defaults.js";
import {
resetConfigRuntimeState,
setRuntimeConfigSnapshot,
type OpenClawConfig,
} from "../../config/config.js";
import { onAgentEvent } from "../../infra/agent-events.js";
import {
requestHeartbeat,
resetHeartbeatWakeStateForTests,
setHeartbeatWakeHandler,
} from "../../infra/heartbeat-wake.js";
import * as execModule from "../../process/exec.js";
import { onSessionTranscriptUpdate } from "../../sessions/transcript-events.js";
import { VERSION } from "../../version.js";
const runtimeModelAuthMocks = vi.hoisted(() => ({
getApiKeyForModel: vi.fn(),
getRuntimeAuthForModel: vi.fn(),
resolveApiKeyForProvider: vi.fn(),
}));
vi.mock("./runtime-model-auth.runtime.js", () => runtimeModelAuthMocks);
import {
clearGatewaySubagentRuntime,
createPluginRuntime,
setGatewayNodesRuntime,
setGatewaySubagentRuntime,
} from "./index.js";
function createCommandResult() {
return {
pid: 12345,
stdout: "hello\n",
stderr: "",
code: 0,
signal: null,
killed: false,
noOutputTimedOut: false,
termination: "exit" as const,
};
}
function createGatewaySubagentRuntime() {
return {
run: vi.fn(),
waitForRun: vi.fn(),
getSessionMessages: vi.fn(),
getSession: vi.fn(),
deleteSession: vi.fn(),
};
}
function expectRuntimeShape(
assertRuntime: (runtime: ReturnType<typeof createPluginRuntime>) => void,
) {
const runtime = createPluginRuntime();
assertRuntime(runtime);
}
function expectGatewaySubagentRunFailure(
runtime: ReturnType<typeof createPluginRuntime>,
params: { sessionKey: string; message: string },
) {
expect(() => runtime.subagent.run(params)).toThrow(
"Plugin runtime subagent methods are only available during a gateway request.",
);
}
function expectRuntimeValue<T>(
readValue: (runtime: ReturnType<typeof createPluginRuntime>) => T,
expected: T,
) {
expect(readValue(createPluginRuntime())).toBe(expected);
}
function expectRuntimeSubagentRun(
runtime: ReturnType<typeof createPluginRuntime>,
params: { sessionKey: string; message: string },
) {
return runtime.subagent.run(params);
}
function createGatewaySubagentRunFixture(params?: { allowGatewaySubagentBinding?: boolean }) {
const run = vi.fn().mockResolvedValue({ runId: "run-1" });
const runtime = params?.allowGatewaySubagentBinding
? createPluginRuntime({ allowGatewaySubagentBinding: true })
: createPluginRuntime();
setGatewaySubagentRuntime({
...createGatewaySubagentRuntime(),
run,
});
return { run, runtime };
}
function expectFunctionKeys(value: Record<string, unknown>, keys: readonly string[]) {
for (const key of keys) {
expect(typeof value[key]).toBe("function");
}
}
function expectRunCommandOutcome(params: {
runtime: ReturnType<typeof createPluginRuntime>;
expected: "resolve" | "reject";
commandResult: ReturnType<typeof createCommandResult>;
}) {
const command = params.runtime.system.runCommandWithTimeout(["echo", "hello"], {
timeoutMs: 1000,
});
if (params.expected === "resolve") {
return expect(command).resolves.toEqual(params.commandResult);
}
return expect(command).rejects.toThrow("boom");
}
describe("plugin runtime command execution", () => {
beforeEach(() => {
vi.restoreAllMocks();
runtimeModelAuthMocks.getApiKeyForModel.mockReset();
runtimeModelAuthMocks.getRuntimeAuthForModel.mockReset();
runtimeModelAuthMocks.resolveApiKeyForProvider.mockReset();
resetConfigRuntimeState();
clearGatewaySubagentRuntime();
});
it.each([
{
name: "exposes runtime.system.runCommandWithTimeout by default",
mockKind: "resolve" as const,
expected: "resolve" as const,
},
{
name: "forwards runtime.system.runCommandWithTimeout errors",
mockKind: "reject" as const,
expected: "reject" as const,
},
] as const)("$name", async ({ mockKind, expected }) => {
const commandResult = createCommandResult();
const runCommandWithTimeoutMock = vi.spyOn(execModule, "runCommandWithTimeout");
if (mockKind === "resolve") {
runCommandWithTimeoutMock.mockResolvedValue(commandResult);
} else {
runCommandWithTimeoutMock.mockRejectedValue(new Error("boom"));
}
const runtime = createPluginRuntime();
await expectRunCommandOutcome({ runtime, expected, commandResult });
expect(runCommandWithTimeoutMock).toHaveBeenCalledWith(["echo", "hello"], { timeoutMs: 1000 });
});
it.each([
{
name: "exposes runtime.events.onAgentEvent",
readValue: (runtime: ReturnType<typeof createPluginRuntime>) => runtime.events.onAgentEvent,
expected: onAgentEvent,
},
{
name: "exposes runtime.events.onSessionTranscriptUpdate",
readValue: (runtime: ReturnType<typeof createPluginRuntime>) =>
runtime.events.onSessionTranscriptUpdate,
expected: onSessionTranscriptUpdate,
},
{
name: "exposes runtime.system.requestHeartbeat",
readValue: (runtime: ReturnType<typeof createPluginRuntime>) =>
runtime.system.requestHeartbeat,
expected: requestHeartbeat,
},
{
name: "exposes deprecated runtime.system.requestHeartbeatNow",
readValue: (runtime: ReturnType<typeof createPluginRuntime>) =>
typeof runtime.system.requestHeartbeatNow,
expected: "function",
},
{
name: "exposes runtime.version from the shared VERSION constant",
readValue: (runtime: ReturnType<typeof createPluginRuntime>) => runtime.version,
expected: VERSION,
},
] as const)("$name", ({ readValue, expected }) => {
expectRuntimeValue(readValue, expected);
});
it("maps deprecated runtime.system.requestHeartbeatNow to an immediate compatibility wake", async () => {
vi.useFakeTimers();
resetHeartbeatWakeStateForTests();
const handler = vi.fn(async (_request: Parameters<typeof requestHeartbeat>[0]) => ({
status: "skipped" as const,
reason: "disabled",
}));
setHeartbeatWakeHandler(handler);
try {
createPluginRuntime().system.requestHeartbeatNow({
reason: "legacy-plugin",
coalesceMs: 0,
});
await vi.advanceTimersByTimeAsync(1);
const request = handler.mock.calls[0]?.[0] as
| { source?: string; intent?: string; reason?: string }
| undefined;
expect(request?.source).toBe("other");
expect(request?.intent).toBe("immediate");
expect(request?.reason).toBe("legacy-plugin");
} finally {
resetHeartbeatWakeStateForTests();
vi.useRealTimers();
}
});
it("resolves thinking policy with configured model compat from runtime config", () => {
setRuntimeConfigSnapshot({
models: {
providers: {
gmn: {
baseUrl: "https://gmn.example.com/v1",
models: [
{
id: "gpt-5.4",
name: "GPT 5.4 via GMN",
reasoning: true,
compat: { supportedReasoningEfforts: ["low", "medium", "high", "xhigh"] },
},
],
},
},
},
} as unknown as OpenClawConfig);
const runtime = createPluginRuntime();
const policy = runtime.agent.resolveThinkingPolicy({
provider: "gmn",
model: "gpt-5.4",
});
expect(policy.levels.map((level) => level.id)).toContain("xhigh");
});
it.each([
{
name: "exposes runtime.mediaUnderstanding helpers and keeps stt as an alias",
assert: (runtime: ReturnType<typeof createPluginRuntime>) => {
expectFunctionKeys(runtime.mediaUnderstanding as Record<string, unknown>, [
"runFile",
"describeImageFile",
"describeImageFileWithModel",
"extractStructuredWithModel",
"describeVideoFile",
]);
expect(runtime.mediaUnderstanding.transcribeAudioFile).toBe(
runtime.stt.transcribeAudioFile,
);
},
},
{
name: "exposes runtime.imageGeneration helpers",
assert: (runtime: ReturnType<typeof createPluginRuntime>) => {
expectFunctionKeys(runtime.imageGeneration as Record<string, unknown>, [
"generate",
"listProviders",
]);
},
},
{
name: "exposes runtime.webSearch helpers",
assert: (runtime: ReturnType<typeof createPluginRuntime>) => {
expectFunctionKeys(runtime.webSearch as Record<string, unknown>, [
"listProviders",
"search",
]);
},
},
{
name: "exposes canonical runtime.tasks task runtimes while keeping legacy TaskFlow aliases",
assert: (runtime: ReturnType<typeof createPluginRuntime>) => {
expectFunctionKeys(runtime.tasks.runs as Record<string, unknown>, [
"bindSession",
"fromToolContext",
]);
expectFunctionKeys(runtime.tasks.flows as Record<string, unknown>, [
"bindSession",
"fromToolContext",
]);
expectFunctionKeys(runtime.tasks.managedFlows as Record<string, unknown>, [
"bindSession",
"fromToolContext",
]);
expectFunctionKeys(runtime.tasks.flow as Record<string, unknown>, [
"bindSession",
"fromToolContext",
]);
expect(runtime.tasks.managedFlows).toBe(runtime.tasks.flow);
expect(runtime.taskFlow).toBe(runtime.tasks.managedFlows);
},
},
{
name: "exposes runtime.agent host helpers",
assert: (runtime: ReturnType<typeof createPluginRuntime>) => {
expect(runtime.agent.defaults).toEqual({
model: DEFAULT_MODEL,
provider: DEFAULT_PROVIDER,
});
expectFunctionKeys(runtime.agent as Record<string, unknown>, [
"runEmbeddedAgent",
"runEmbeddedPiAgent",
"normalizeThinkingLevel",
"resolveThinkingPolicy",
"resolveAgentDir",
]);
expect(runtime.agent.runEmbeddedPiAgent).toBe(runtime.agent.runEmbeddedAgent);
expectFunctionKeys(runtime.agent.session as Record<string, unknown>, [
"getSessionEntry",
"listSessionEntries",
"patchSessionEntry",
"upsertSessionEntry",
"updateSessionStore",
"updateSessionStoreEntry",
"resolveSessionFilePath",
]);
},
},
{
name: "exposes runtime.modelAuth with raw and runtime-ready auth helpers",
assert: (runtime: ReturnType<typeof createPluginRuntime>) => {
expectFunctionKeys(runtime.modelAuth, [
"getApiKeyForModel",
"getRuntimeAuthForModel",
"resolveApiKeyForProvider",
]);
},
},
] as const)("$name", ({ assert }) => {
expectRuntimeShape(assert);
});
it("modelAuth wrappers strip agentDir and store to prevent credential steering", async () => {
// The wrappers should not forward agentDir or store from plugin callers.
// We verify this by checking the wrapper functions exist and are not the
// raw implementations (they are wrapped, not direct references).
const { getApiKeyForModel: rawGetApiKey } = await import("../../agents/model-auth.js");
const runtime = createPluginRuntime();
// Wrappers should NOT be the same reference as the raw functions
expect(runtime.modelAuth.getApiKeyForModel).not.toBe(rawGetApiKey);
});
it("modelAuth wrappers preserve workspace scope while stripping credential steering", async () => {
const runtime = createPluginRuntime();
const model = {
id: "workspace-cloud/model",
provider: "workspace-cloud",
api: "openai-responses",
baseUrl: "https://workspace-cloud.example/v1",
};
const cfg = { plugins: { allow: ["workspace-cloud"] } } as OpenClawConfig;
runtimeModelAuthMocks.getApiKeyForModel.mockResolvedValue({
apiKey: "model-key",
source: "workspace cloud credentials",
mode: "api-key",
});
runtimeModelAuthMocks.resolveApiKeyForProvider.mockResolvedValue({
apiKey: "provider-key",
source: "workspace cloud credentials",
mode: "api-key",
});
const modelAuth = await runtime.modelAuth.getApiKeyForModel({
model: model as never,
cfg,
workspaceDir: "/tmp/workspace",
agentDir: "/tmp/agent",
store: { version: 1, profiles: {} },
} as never);
expect(modelAuth.apiKey).toBe("model-key");
const providerAuth = await runtime.modelAuth.resolveApiKeyForProvider({
provider: "workspace-cloud",
cfg,
workspaceDir: "/tmp/workspace",
agentDir: "/tmp/agent",
store: { version: 1, profiles: {} },
} as never);
expect(providerAuth.apiKey).toBe("provider-key");
expect(runtimeModelAuthMocks.getApiKeyForModel).toHaveBeenCalledWith({
model,
cfg,
workspaceDir: "/tmp/workspace",
});
expect(runtimeModelAuthMocks.resolveApiKeyForProvider).toHaveBeenCalledWith({
provider: "workspace-cloud",
cfg,
workspaceDir: "/tmp/workspace",
});
});
it("keeps subagent unavailable by default even after gateway initialization", () => {
const { runtime } = createGatewaySubagentRunFixture();
expectGatewaySubagentRunFailure(runtime, { sessionKey: "s-1", message: "hello" });
});
it("late-binds to the gateway subagent when explicitly enabled", async () => {
const { run, runtime } = createGatewaySubagentRunFixture({
allowGatewaySubagentBinding: true,
});
await expect(
expectRuntimeSubagentRun(runtime, { sessionKey: "s-2", message: "hello" }),
).resolves.toEqual({
runId: "run-1",
});
expect(run).toHaveBeenCalledWith({ sessionKey: "s-2", message: "hello" });
});
it("uses explicit nodes runtime when provided", async () => {
const nodes = {
list: vi.fn().mockResolvedValue({ nodes: [] }),
invoke: vi.fn().mockResolvedValue({ ok: true }),
};
const runtime = createPluginRuntime({ nodes });
await expect(runtime.nodes.list({ connected: true })).resolves.toEqual({ nodes: [] });
await expect(
runtime.nodes.invoke({ nodeId: "node-1", command: "browser.proxy" }),
).resolves.toEqual({ ok: true });
expect(nodes.list).toHaveBeenCalledWith({ connected: true });
expect(nodes.invoke).toHaveBeenCalledWith({ nodeId: "node-1", command: "browser.proxy" });
});
it("late-binds to gateway nodes when explicitly enabled", async () => {
const nodes = {
list: vi.fn().mockResolvedValue({ nodes: [{ nodeId: "node-1" }] }),
invoke: vi.fn().mockResolvedValue({ ok: true }),
};
const runtime = createPluginRuntime({ allowGatewaySubagentBinding: true });
setGatewayNodesRuntime(nodes);
await expect(runtime.nodes.list({ connected: true })).resolves.toEqual({
nodes: [{ nodeId: "node-1" }],
});
expect(nodes.list).toHaveBeenCalledWith({ connected: true });
});
});