Files
openclaw/src/wizard/setup.plugin-config.test.ts
George Zhang 87885b948a fix: handle sensitive, number-clear, and array-clear edge cases in plugin config TUI (#60640) (#60640)
- Skip sensitive fields with a note directing users to openclaw config set
  or the Web UI (WizardPrompter has no masked input)
- Clear number fields to undefined when input is empty instead of storing 0
- Allow clearing array fields to undefined via empty input
2026-04-03 19:27:26 -07:00

162 lines
4.7 KiB
TypeScript

import { describe, expect, it } from "vitest";
import type { OpenClawConfig } from "../config/config.js";
import type { PluginConfigUiHint } from "../plugins/types.js";
import { discoverConfigurablePlugins, discoverUnconfiguredPlugins } from "./setup.plugin-config.js";
function makeManifestPlugin(
id: string,
uiHints?: Record<string, PluginConfigUiHint>,
configSchema?: Record<string, unknown>,
) {
return {
id,
name: id,
configUiHints: uiHints,
configSchema,
enabled: true,
enabledByDefault: true,
};
}
describe("discoverConfigurablePlugins", () => {
it("returns plugins with non-advanced uiHints", () => {
const plugins = [
makeManifestPlugin("openshell", {
mode: { label: "Mode", help: "Sandbox mode" },
gateway: { label: "Gateway", help: "Gateway name" },
gpu: { label: "GPU", advanced: true },
}),
];
const result = discoverConfigurablePlugins({ manifestPlugins: plugins });
expect(result).toHaveLength(1);
expect(result[0]).toBeDefined();
expect(result[0].id).toBe("openshell");
expect(Object.keys(result[0].uiHints)).toEqual(["mode", "gateway"]);
// Advanced field excluded
expect(result[0].uiHints.gpu).toBeUndefined();
});
it("excludes plugins with no uiHints", () => {
const plugins = [makeManifestPlugin("bare-plugin")];
const result = discoverConfigurablePlugins({ manifestPlugins: plugins });
expect(result).toHaveLength(0);
});
it("excludes sensitive fields from promptable hints", () => {
const plugins = [
makeManifestPlugin("secret-plugin", {
endpoint: { label: "Endpoint" },
apiKey: { label: "API Key", sensitive: true },
}),
];
const result = discoverConfigurablePlugins({ manifestPlugins: plugins });
expect(result).toHaveLength(1);
// sensitive fields are still included in uiHints for discovery —
// they are skipped at prompt time, not at discovery time
expect(result[0].uiHints.endpoint).toBeDefined();
expect(result[0].uiHints.apiKey).toBeDefined();
});
it("excludes plugins where all fields are advanced", () => {
const plugins = [
makeManifestPlugin("all-advanced", {
gpu: { label: "GPU", advanced: true },
timeout: { label: "Timeout", advanced: true },
}),
];
const result = discoverConfigurablePlugins({ manifestPlugins: plugins });
expect(result).toHaveLength(0);
});
it("sorts results alphabetically by name", () => {
const plugins = [
makeManifestPlugin("zeta", { a: { label: "A" } }),
makeManifestPlugin("alpha", { b: { label: "B" } }),
];
const result = discoverConfigurablePlugins({ manifestPlugins: plugins });
expect(result.map((p) => p.id)).toEqual(["alpha", "zeta"]);
});
});
describe("discoverUnconfiguredPlugins", () => {
it("returns plugins with at least one unconfigured field", () => {
const plugins = [
makeManifestPlugin("openshell", {
mode: { label: "Mode" },
gateway: { label: "Gateway" },
}),
];
const config: OpenClawConfig = {
plugins: {
entries: {
openshell: {
config: { mode: "mirror" },
},
},
},
};
const result = discoverUnconfiguredPlugins({
manifestPlugins: plugins,
config,
});
// gateway is unconfigured
expect(result).toHaveLength(1);
expect(result[0]).toBeDefined();
expect(result[0].id).toBe("openshell");
});
it("excludes plugins where all fields are configured", () => {
const plugins = [
makeManifestPlugin("openshell", {
mode: { label: "Mode" },
gateway: { label: "Gateway" },
}),
];
const config: OpenClawConfig = {
plugins: {
entries: {
openshell: {
config: { mode: "mirror", gateway: "my-gw" },
},
},
},
};
const result = discoverUnconfiguredPlugins({
manifestPlugins: plugins,
config,
});
expect(result).toHaveLength(0);
});
it("treats empty string as unconfigured", () => {
const plugins = [
makeManifestPlugin("test-plugin", {
endpoint: { label: "Endpoint" },
}),
];
const config: OpenClawConfig = {
plugins: {
entries: {
"test-plugin": {
config: { endpoint: "" },
},
},
},
};
const result = discoverUnconfiguredPlugins({
manifestPlugins: plugins,
config,
});
expect(result).toHaveLength(1);
});
it("returns empty when no plugins have uiHints", () => {
const plugins = [makeManifestPlugin("bare")];
const result = discoverUnconfiguredPlugins({
manifestPlugins: plugins,
config: {},
});
expect(result).toHaveLength(0);
});
});