Files
openclaw/src/gateway/server-methods/sessions.send-followup-status.test.ts
clay-datacurve 7b61ca1b06 Session management improvements and dashboard API (#50101)
* fix: make cleanup "keep" persist subagent sessions indefinitely

* feat: expose subagent session metadata in sessions list

* fix: include status and timing in sessions_list tool

* fix: hide injected timestamp prefixes in chat ui

* feat: push session list updates over websocket

* feat: expose child subagent sessions in subagents list

* feat: add admin http endpoint to kill sessions

* Emit session.message websocket events for transcript updates

* Estimate session costs in sessions list

* Add direct session history HTTP and SSE endpoints

* Harden dashboard session events and history APIs

* Add session lifecycle gateway methods

* Add dashboard session API improvements

* Add dashboard session model and parent linkage support

* fix: tighten dashboard session API metadata

* Fix dashboard session cost metadata

* Persist accumulated session cost

* fix: stop followup queue drain cfg crash

* Fix dashboard session create and model metadata

* fix: stop guessing session model costs

* Gateway: cache OpenRouter pricing for configured models

* Gateway: add timeout session status

* Fix subagent spawn test config loading

* Gateway: preserve operator scopes without device identity

* Emit user message transcript events and deduplicate plugin warnings

* feat: emit sessions.changed lifecycle event on subagent spawn

Adds a session-lifecycle-events module (similar to transcript-events)
that emits create events when subagents are spawned. The gateway
server.impl.ts listens for these events and broadcasts sessions.changed
with reason=create to SSE subscribers, so dashboards can pick up new
subagent sessions without polling.

* Gateway: allow persistent dashboard orchestrator sessions

* fix: preserve operator scopes for token-authenticated backend clients

Backend clients (like agent-dashboard) that authenticate with a valid gateway
token but don't present a device identity were getting their scopes stripped.
The scope-clearing logic ran before checking the device identity decision,
so even when evaluateMissingDeviceIdentity returned 'allow' (because
roleCanSkipDeviceIdentity passed for token-authed operators), scopes were
already cleared.

Fix: also check decision.kind before clearing scopes, so token-authenticated
operators keep their requested scopes.

* Gateway: allow operator-token session kills

* Fix stale active subagent status after follow-up runs

* Fix dashboard image attachments in sessions send

* Fix completed session follow-up status updates

* feat: stream session tool events to operator UIs

* Add sessions.steer gateway coverage

* Persist subagent timing in session store

* Fix subagent session transcript event keys

* Fix active subagent session status in gateway

* bump session label max to 512

* Fix gateway send session reactivation

* fix: publish terminal session lifecycle state

* feat: change default session reset to effectively never

- Change DEFAULT_RESET_MODE from "daily" to "idle"
- Change DEFAULT_IDLE_MINUTES from 60 to 0 (0 = disabled/never)
- Allow idleMinutes=0 through normalization (don't clamp to 1)
- Treat idleMinutes=0 as "no idle expiry" in evaluateSessionFreshness
- Default behavior: mode "idle" + idleMinutes 0 = sessions never auto-reset
- Update test assertion for new default mode

* fix: prep session management followups (#50101) (thanks @clay-datacurve)

---------

Co-authored-by: Tyler Yust <TYTYYUST@YAHOO.COM>
2026-03-19 12:12:30 +09:00

134 lines
4.2 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from "vitest";
import type { GatewayRequestContext, RespondFn } from "./types.js";
const loadSessionEntryMock = vi.fn();
const readSessionMessagesMock = vi.fn();
const loadGatewaySessionRowMock = vi.fn();
const getSubagentRunByChildSessionKeyMock = vi.fn();
const replaceSubagentRunAfterSteerMock = vi.fn();
const chatSendMock = vi.fn();
vi.mock("../session-utils.js", async (importOriginal) => {
const actual = await importOriginal<typeof import("../session-utils.js")>();
return {
...actual,
loadSessionEntry: (...args: unknown[]) => loadSessionEntryMock(...args),
readSessionMessages: (...args: unknown[]) => readSessionMessagesMock(...args),
loadGatewaySessionRow: (...args: unknown[]) => loadGatewaySessionRowMock(...args),
};
});
vi.mock("../../agents/subagent-registry.js", async (importOriginal) => {
const actual = await importOriginal<typeof import("../../agents/subagent-registry.js")>();
return {
...actual,
getSubagentRunByChildSessionKey: (...args: unknown[]) =>
getSubagentRunByChildSessionKeyMock(...args),
replaceSubagentRunAfterSteer: (...args: unknown[]) => replaceSubagentRunAfterSteerMock(...args),
};
});
vi.mock("./chat.js", () => ({
chatHandlers: {
"chat.send": (...args: unknown[]) => chatSendMock(...args),
},
}));
import { sessionsHandlers } from "./sessions.js";
describe("sessions.send completed subagent follow-up status", () => {
beforeEach(() => {
loadSessionEntryMock.mockReset();
readSessionMessagesMock.mockReset();
loadGatewaySessionRowMock.mockReset();
getSubagentRunByChildSessionKeyMock.mockReset();
replaceSubagentRunAfterSteerMock.mockReset();
chatSendMock.mockReset();
});
it("reactivates completed subagent sessions before broadcasting sessions.changed", async () => {
const childSessionKey = "agent:main:subagent:followup";
const completedRun = {
runId: "run-old",
childSessionKey,
controllerSessionKey: "agent:main:main",
requesterSessionKey: "agent:main:main",
requesterDisplayKey: "main",
task: "initial task",
cleanup: "keep" as const,
createdAt: 1,
startedAt: 2,
endedAt: 3,
outcome: { status: "ok" as const },
};
loadSessionEntryMock.mockReturnValue({
canonicalKey: childSessionKey,
storePath: "/tmp/sessions.json",
entry: { sessionId: "sess-followup" },
});
readSessionMessagesMock.mockReturnValue([]);
getSubagentRunByChildSessionKeyMock.mockReturnValue(completedRun);
replaceSubagentRunAfterSteerMock.mockReturnValue(true);
loadGatewaySessionRowMock.mockReturnValue({
status: "running",
startedAt: 123,
endedAt: undefined,
runtimeMs: 10,
});
chatSendMock.mockImplementation(async ({ respond }: { respond: RespondFn }) => {
respond(true, { runId: "run-new", status: "started" }, undefined, undefined);
});
const broadcastToConnIds = vi.fn();
const respond = vi.fn() as unknown as RespondFn;
const context = {
chatAbortControllers: new Map(),
broadcastToConnIds,
getSessionEventSubscriberConnIds: () => new Set(["conn-1"]),
} as unknown as GatewayRequestContext;
await sessionsHandlers["sessions.send"]({
req: { id: "req-1" } as never,
params: {
key: childSessionKey,
message: "follow-up",
idempotencyKey: "run-new",
},
respond,
context,
client: null,
isWebchatConnect: () => false,
});
expect(respond).toHaveBeenCalledWith(
true,
expect.objectContaining({
runId: "run-new",
status: "started",
messageSeq: 1,
}),
undefined,
undefined,
);
expect(replaceSubagentRunAfterSteerMock).toHaveBeenCalledWith({
previousRunId: "run-old",
nextRunId: "run-new",
fallback: completedRun,
runTimeoutSeconds: 0,
});
expect(broadcastToConnIds).toHaveBeenCalledWith(
"sessions.changed",
expect.objectContaining({
sessionKey: childSessionKey,
reason: "send",
status: "running",
startedAt: 123,
endedAt: undefined,
}),
new Set(["conn-1"]),
{ dropIfSlow: true },
);
});
});