mirror of
https://github.com/openclaw/openclaw.git
synced 2026-05-09 18:20:43 +00:00
Use the shared Windows cmd.exe command-line builder for `.cmd` and `.bat` UI runner launches so Node.js v24 no longer sees `spawn(file, args, { shell: true })` and emits DEP0190.
The launcher keeps ordinary `.exe`/`.com` and non-Windows paths on direct argv spawning, while Windows command scripts now run through `cmd.exe /d /s /c` with `shell: false` and `windowsVerbatimArguments: true`.
Local and CI verification passed, including focused UI runner tests, build, check, Real behavior proof, and ClawSweeper gates.
Co-authored-by: Nandana Dileep <nandanadileep@users.noreply.github.com>
Co-authored-by: Brad Groux <3053586+BradGroux@users.noreply.github.com>
205 lines
4.8 KiB
JavaScript
205 lines
4.8 KiB
JavaScript
#!/usr/bin/env node
|
|
import { spawn, spawnSync } from "node:child_process";
|
|
import fs from "node:fs";
|
|
import { createRequire } from "node:module";
|
|
import path from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
import { buildCmdExeCommandLine } from "./windows-cmd-helpers.mjs";
|
|
|
|
const here = path.dirname(fileURLToPath(import.meta.url));
|
|
const repoRoot = path.resolve(here, "..");
|
|
const uiDir = path.join(repoRoot, "ui");
|
|
|
|
const WINDOWS_CMD_EXE_EXTENSIONS = new Set([".cmd", ".bat"]);
|
|
|
|
function usage() {
|
|
// keep this tiny; it's invoked from npm scripts too
|
|
process.stderr.write("Usage: node scripts/ui.js <install|dev|build|test> [...args]\n");
|
|
}
|
|
|
|
function which(cmd) {
|
|
try {
|
|
const key = process.platform === "win32" ? "Path" : "PATH";
|
|
const paths = (process.env[key] ?? process.env.PATH ?? "")
|
|
.split(path.delimiter)
|
|
.filter(Boolean);
|
|
const extensions =
|
|
process.platform === "win32"
|
|
? (process.env.PATHEXT ?? ".EXE;.CMD;.BAT;.COM").split(";").filter(Boolean)
|
|
: [""];
|
|
for (const entry of paths) {
|
|
for (const ext of extensions) {
|
|
const candidate = path.join(entry, process.platform === "win32" ? `${cmd}${ext}` : cmd);
|
|
try {
|
|
if (fs.existsSync(candidate)) {
|
|
return candidate;
|
|
}
|
|
} catch {
|
|
// ignore
|
|
}
|
|
}
|
|
}
|
|
} catch {
|
|
// ignore
|
|
}
|
|
return null;
|
|
}
|
|
|
|
function resolveRunner() {
|
|
const pnpm = which("pnpm");
|
|
if (pnpm) {
|
|
return { cmd: pnpm, kind: "pnpm" };
|
|
}
|
|
return null;
|
|
}
|
|
|
|
export function shouldUseCmdExeForCommand(cmd, platform = process.platform) {
|
|
if (platform !== "win32") {
|
|
return false;
|
|
}
|
|
const extension = path.extname(cmd).toLowerCase();
|
|
return WINDOWS_CMD_EXE_EXTENSIONS.has(extension);
|
|
}
|
|
|
|
export function resolveSpawnCall(cmd, args, envOverride, params = {}) {
|
|
const platform = params.platform ?? process.platform;
|
|
const comSpec = params.comSpec ?? process.env.ComSpec ?? "cmd.exe";
|
|
const options = {
|
|
cwd: params.cwd ?? uiDir,
|
|
stdio: "inherit",
|
|
env: envOverride ?? process.env,
|
|
shell: false,
|
|
};
|
|
|
|
if (shouldUseCmdExeForCommand(cmd, platform)) {
|
|
return {
|
|
command: comSpec,
|
|
args: ["/d", "/s", "/c", buildCmdExeCommandLine(cmd, args)],
|
|
options: {
|
|
...options,
|
|
windowsVerbatimArguments: true,
|
|
},
|
|
};
|
|
}
|
|
|
|
return {
|
|
command: cmd,
|
|
args,
|
|
options,
|
|
};
|
|
}
|
|
|
|
function run(cmd, args) {
|
|
const { command, args: spawnArgs, options } = resolveSpawnCall(cmd, args);
|
|
let child;
|
|
try {
|
|
child = spawn(command, spawnArgs, options);
|
|
} catch (err) {
|
|
console.error(`Failed to launch ${cmd}:`, err);
|
|
process.exit(1);
|
|
return;
|
|
}
|
|
|
|
child.on("error", (err) => {
|
|
console.error(`Failed to launch ${cmd}:`, err);
|
|
process.exit(1);
|
|
});
|
|
child.on("exit", (code) => {
|
|
if (code !== 0) {
|
|
process.exit(code ?? 1);
|
|
}
|
|
});
|
|
}
|
|
|
|
function runSync(cmd, args, envOverride) {
|
|
const { command, args: spawnArgs, options } = resolveSpawnCall(cmd, args, envOverride);
|
|
let result;
|
|
try {
|
|
result = spawnSync(command, spawnArgs, options);
|
|
} catch (err) {
|
|
console.error(`Failed to launch ${cmd}:`, err);
|
|
process.exit(1);
|
|
return;
|
|
}
|
|
if (result.signal) {
|
|
process.exit(1);
|
|
}
|
|
if ((result.status ?? 1) !== 0) {
|
|
process.exit(result.status ?? 1);
|
|
}
|
|
}
|
|
|
|
function depsInstalled(kind) {
|
|
try {
|
|
const require = createRequire(path.join(uiDir, "package.json"));
|
|
require.resolve("vite");
|
|
require.resolve("dompurify");
|
|
if (kind === "test") {
|
|
require.resolve("vitest");
|
|
require.resolve("@vitest/browser-playwright");
|
|
require.resolve("playwright");
|
|
}
|
|
return true;
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
function resolveScriptAction(action) {
|
|
if (action === "install") {
|
|
return null;
|
|
}
|
|
if (action === "dev") {
|
|
return "dev";
|
|
}
|
|
if (action === "build") {
|
|
return "build";
|
|
}
|
|
if (action === "test") {
|
|
return "test";
|
|
}
|
|
return null;
|
|
}
|
|
|
|
export function main(argv = process.argv.slice(2)) {
|
|
const [action, ...rest] = argv;
|
|
if (!action) {
|
|
usage();
|
|
process.exit(2);
|
|
}
|
|
|
|
const runner = resolveRunner();
|
|
if (!runner) {
|
|
process.stderr.write("Missing UI runner: install pnpm, then retry.\n");
|
|
process.exit(1);
|
|
}
|
|
|
|
const script = resolveScriptAction(action);
|
|
if (action !== "install" && !script) {
|
|
usage();
|
|
process.exit(2);
|
|
}
|
|
|
|
if (action === "install") {
|
|
run(runner.cmd, ["install", ...rest]);
|
|
return;
|
|
}
|
|
|
|
if (!depsInstalled(action === "test" ? "test" : "build")) {
|
|
const installEnv = process.env;
|
|
const installArgs = ["install"];
|
|
runSync(runner.cmd, installArgs, installEnv);
|
|
}
|
|
|
|
run(runner.cmd, ["run", script, ...rest]);
|
|
}
|
|
|
|
const isDirectExecution = (() => {
|
|
const entry = process.argv[1];
|
|
return Boolean(entry && path.resolve(entry) === fileURLToPath(import.meta.url));
|
|
})();
|
|
|
|
if (isDirectExecution) {
|
|
main();
|
|
}
|