mirror of
https://github.com/openclaw/openclaw.git
synced 2026-07-16 15:01:44 +00:00
6b95f98fe7
* fix(core): make indexed access explicit in auto-reply, infra, and config Part 1/3 of the src NUIA phase-3b burn-down (#104600): iteration and destructuring over index reads, boundary guards on parsed input, and named invariants. Config path walkers bind the path head once; SQLite migration key handling is hoisted without query-shape changes. * fix(core): make indexed access explicit in cli, gateway, commands, security, shared Part 2/3: argv/token selection restructured, gateway event/attachment invariants named, security parsers stay fail-closed (invariant violations throw), edit-distance matrices access checked entries. * fix(core): make indexed access explicit across remaining src surfaces Part 3/3: channels, plugins, process, cron, plugin-sdk, media, logging, tui, hooks, daemon, and small directories. Latent bug fixed: a tailnet resolver could leak undefined through a string|null contract and now fails with a descriptive local error. * fix(core): keep optional boundaries optional after per-commit review Review findings: expectDefined misused where absence is a legitimate state. CLI --profile/route-args missing next tokens take their existing miss paths; help normalization compares --help against the last positional again; first-time plugin install spreads absent cfg.plugins; denylist scan iterates manifest dependency entries instead of throwing on omitted sections; tailnet resolver returns a guaranteed string at the source instead of a caller-side undefined throw. * refactor(core): closed-key provider labels and honest optional passthroughs PROVIDER_LABELS becomes a satisfies-typed closed record (static reads provably defined; dynamic lookups go through providerUsageLabel with honest string|undefined). Status-scan overview passes its optional params through unchanged instead of asserting them. * fix(channels): make getChatChannelMeta honestly optional The original signature claimed ChatChannelMeta while leaking undefined on bundled channel id metadata drift; three of four callers already handled absence. The return type now says so, and the one assuming caller falls back to the raw channel label. * fix(core): index-safety for post-rebase main drift Covers the sqlite-sessions flip and auth-source-plan code that landed mid-phase, plus the channel-validation test consuming the now honestly optional getChatChannelMeta. * refactor(channels): split chat-meta accessors along the SDK contract getChatChannelMeta keeps its shipped plugin-SDK signature (defined for bundled ids, fail-loud on impossible misses); new findChatChannelMeta carries the drift-tolerant optional contract for core auto-enable and formatting paths. * fix(qa-channel): own channel metadata instead of a guaranteed-undefined catalog lookup qa-channel spread getChatChannelMeta over an id that is never in the bundled catalog, shipping an empty setup meta by accident; the fail-loud SDK accessor exposed it. The channel now declares its metadata once. * fix(gateway): heartbeat projection lookahead is optional at the transcript tail expectDefined wrapped messages[i + 1] whose absence on the final message is the normal case; the adjacent ternary already handled it. Restores the plain optional read with an explicit guard in the pair condition. * fix(plugin-sdk): channel plugin factory tolerates non-bundled channel ids again createChannelPluginBase spreads bundled catalog meta for ANY channel id, where absence is the normal case for external plugins; the resolver is honestly optional again while the exported bundled-id accessor keeps the fail-loud contract. * fix(core): spreads of optional config sections stay optional Fresh-setup and first-install paths (crestodian setup inference, hook installs, agent config base, target agent models) legitimately lack the section being rebuilt; spreading undefined is the shipped {} semantics. Removes the remaining gratuitous assertion wraps found by tree audit.
69 lines
2.0 KiB
TypeScript
69 lines
2.0 KiB
TypeScript
/** Shared argument splitter for service command lines rendered by platform adapters. */
|
|
type ArgSplitEscapeMode = "none" | "backslash" | "backslash-quote-only";
|
|
type ArgSplitQuoteChar = '"' | "'";
|
|
type ArgSplitQuoteStart = "anywhere" | "item-start";
|
|
|
|
/** Splits service command strings while preserving quoted arguments across platform parsers. */
|
|
export function splitArgsPreservingQuotes(
|
|
value: string,
|
|
options?: {
|
|
escapeMode?: ArgSplitEscapeMode;
|
|
quoteChars?: readonly ArgSplitQuoteChar[];
|
|
quoteStart?: ArgSplitQuoteStart;
|
|
},
|
|
): string[] {
|
|
const args: string[] = [];
|
|
let current = "";
|
|
let quoteChar: ArgSplitQuoteChar | null = null;
|
|
const escapeMode = options?.escapeMode ?? "none";
|
|
const quoteChars = new Set<ArgSplitQuoteChar>(options?.quoteChars ?? ['"']);
|
|
const quoteStart = options?.quoteStart ?? "anywhere";
|
|
|
|
for (let i = 0; i < value.length; i++) {
|
|
const char = value.charAt(i);
|
|
if (escapeMode === "backslash" && char === "\\") {
|
|
// POSIX-style service parsers consume any escaped next byte.
|
|
if (i + 1 < value.length) {
|
|
current += value[i + 1];
|
|
i++;
|
|
}
|
|
continue;
|
|
}
|
|
if (
|
|
escapeMode === "backslash-quote-only" &&
|
|
char === "\\" &&
|
|
i + 1 < value.length &&
|
|
value[i + 1] === '"'
|
|
) {
|
|
// Windows cmd scripts escape only renderer-inserted quotes here; paths keep
|
|
// their backslashes literal.
|
|
current += '"';
|
|
i++;
|
|
continue;
|
|
}
|
|
if (quoteChars.has(char as ArgSplitQuoteChar)) {
|
|
if (quoteChar === char) {
|
|
quoteChar = null;
|
|
continue;
|
|
}
|
|
const canOpenQuote = quoteStart === "anywhere" || current.length === 0;
|
|
if (!quoteChar && canOpenQuote) {
|
|
quoteChar = char as ArgSplitQuoteChar;
|
|
continue;
|
|
}
|
|
}
|
|
if (!quoteChar && /\s/.test(char)) {
|
|
if (current) {
|
|
args.push(current);
|
|
current = "";
|
|
}
|
|
continue;
|
|
}
|
|
current += char;
|
|
}
|
|
if (current) {
|
|
args.push(current);
|
|
}
|
|
return args;
|
|
}
|