Files
openclaw/src/media/ffmpeg-exec.ts
openclaw-clownfish[bot] 0f11dcd15f fix(media): handle ffprobe stdin EPIPE
Handle broken-pipe errors from stdin-backed ffprobe without leaking as uncaught exceptions.
2026-04-29 00:49:52 -07:00

103 lines
3.1 KiB
TypeScript

import { execFile, type ExecFileOptions } from "node:child_process";
import { promisify } from "node:util";
import { resolveSystemBin } from "../infra/resolve-system-bin.js";
import { normalizeLowercaseStringOrEmpty } from "../shared/string-coerce.js";
import {
MEDIA_FFMPEG_MAX_BUFFER_BYTES,
MEDIA_FFMPEG_TIMEOUT_MS,
MEDIA_FFPROBE_TIMEOUT_MS,
} from "./ffmpeg-limits.js";
const execFileAsync = promisify(execFile);
export type MediaExecOptions = {
timeoutMs?: number;
maxBufferBytes?: number;
input?: Buffer | string;
};
function resolveExecOptions(
defaultTimeoutMs: number,
options: MediaExecOptions | undefined,
): ExecFileOptions {
return {
timeout: options?.timeoutMs ?? defaultTimeoutMs,
maxBuffer: options?.maxBufferBytes ?? MEDIA_FFMPEG_MAX_BUFFER_BYTES,
};
}
function requireSystemBin(name: string): string {
const resolved = resolveSystemBin(name, { trust: "standard" });
if (!resolved) {
const hint =
process.platform === "darwin"
? "e.g. brew install ffmpeg"
: "e.g. apt install ffmpeg / dnf install ffmpeg";
throw new Error(
`${name} not found in trusted system directories. ` +
`Install it via your system package manager (${hint}).`,
);
}
return resolved;
}
function isBrokenPipeError(error: Error): boolean {
return (error as NodeJS.ErrnoException).code === "EPIPE";
}
export async function runFfprobe(args: string[], options?: MediaExecOptions): Promise<string> {
const execOptions = resolveExecOptions(MEDIA_FFPROBE_TIMEOUT_MS, options);
if (options?.input == null) {
const { stdout } = await execFileAsync(requireSystemBin("ffprobe"), args, execOptions);
return stdout.toString();
}
return await new Promise<string>((resolve, reject) => {
let stdinWriteError: Error | undefined;
const proc = execFile(requireSystemBin("ffprobe"), args, execOptions, (err, stdout) => {
if (err) {
reject(err);
return;
}
if (stdinWriteError && !isBrokenPipeError(stdinWriteError)) {
reject(stdinWriteError);
return;
}
resolve(stdout.toString());
});
proc.stdin?.once("error", (err: Error) => {
stdinWriteError = err;
});
proc.stdin?.end(options.input);
});
}
export async function runFfmpeg(args: string[], options?: MediaExecOptions): Promise<string> {
const { stdout } = await execFileAsync(
requireSystemBin("ffmpeg"),
args,
resolveExecOptions(MEDIA_FFMPEG_TIMEOUT_MS, options),
);
return stdout.toString();
}
export function parseFfprobeCsvFields(stdout: string, maxFields: number): string[] {
return stdout
.trim()
.split(/[,\r\n]+/, maxFields)
.map((field) => normalizeLowercaseStringOrEmpty(field));
}
export function parseFfprobeCodecAndSampleRate(stdout: string): {
codec: string | null;
sampleRateHz: number | null;
} {
const [codecRaw, sampleRateRaw] = parseFfprobeCsvFields(stdout, 2);
const codec = codecRaw ? codecRaw : null;
const sampleRate = sampleRateRaw ? Number.parseInt(sampleRateRaw, 10) : Number.NaN;
return {
codec,
sampleRateHz: Number.isFinite(sampleRate) ? sampleRate : null,
};
}