Files
openclaw/extensions/slack/src/threading.test.ts
Yossi Eliaz 443255461c fix(slack): preserve assistant DM root thread context (#63840)
Preserve Slack Agents & Assistants DM root thread context for tool and subagent replies even when Slack omits or misreports `channel_type`, while leaving non-DM self-thread roots top-level.

Fixes #63659.

Thanks @zozo123.
2026-05-30 22:28:49 +01:00

173 lines
5.1 KiB
TypeScript

import { describe, expect, it } from "vitest";
import { resolveSlackThreadContext, resolveSlackThreadTargets } from "./threading.js";
describe("resolveSlackThreadTargets", () => {
function expectAutoCreatedTopLevelThreadTsBehavior(replyToMode: "off" | "first" | "batched") {
const { replyThreadTs, statusThreadTs, isThreadReply } = resolveSlackThreadTargets({
replyToMode,
message: {
type: "message",
channel: "C1",
ts: "123",
thread_ts: "123",
},
});
expect(isThreadReply).toBe(false);
expect(replyThreadTs).toBeUndefined();
expect(statusThreadTs).toBeUndefined();
}
it("threads replies when message is already threaded", () => {
const { replyThreadTs, statusThreadTs } = resolveSlackThreadTargets({
replyToMode: "off",
message: {
type: "message",
channel: "C1",
ts: "123",
thread_ts: "456",
},
});
expect(replyThreadTs).toBe("456");
expect(statusThreadTs).toBe("456");
});
it("threads top-level replies when mode is all", () => {
const { replyThreadTs, statusThreadTs } = resolveSlackThreadTargets({
replyToMode: "all",
message: {
type: "message",
channel: "C1",
ts: "123",
},
});
expect(replyThreadTs).toBe("123");
expect(statusThreadTs).toBe("123");
});
it("does not thread status indicator when reply threading is off", () => {
const { replyThreadTs, statusThreadTs } = resolveSlackThreadTargets({
replyToMode: "off",
message: {
type: "message",
channel: "C1",
ts: "123",
},
});
expect(replyThreadTs).toBeUndefined();
expect(statusThreadTs).toBeUndefined();
});
it("does not treat auto-created top-level thread_ts as a real thread when mode is off", () => {
expectAutoCreatedTopLevelThreadTsBehavior("off");
});
it("keeps first-mode behavior for auto-created top-level thread_ts", () => {
expectAutoCreatedTopLevelThreadTsBehavior("first");
});
it("keeps batched-mode behavior for auto-created top-level thread_ts", () => {
expectAutoCreatedTopLevelThreadTsBehavior("batched");
});
it("sets messageThreadId for top-level messages when replyToMode is all", () => {
const context = resolveSlackThreadContext({
replyToMode: "all",
message: {
type: "message",
channel: "C1",
ts: "123",
},
});
expect(context.isThreadReply).toBe(false);
expect(context.messageThreadId).toBe("123");
expect(context.replyToId).toBe("123");
});
it("sets messageThreadId for DM assistant thread-root messages regardless of replyToMode", () => {
for (const replyToMode of ["off", "first", "batched"] as const) {
const context = resolveSlackThreadContext({
replyToMode,
isDirectMessage: true,
message: {
type: "message",
channel: "D1",
channel_type: "im",
ts: "123",
thread_ts: "123",
},
});
expect(context.isThreadReply).toBe(false);
// thread_ts == ts in a DM: Agents & Assistants root — preserve thread
// context so tool calls (subagent results) thread correctly.
expect(context.messageThreadId).toBe("123");
expect(context.replyToId).toBe("123");
}
});
it("uses normalized direct-message state for DM assistant thread-root messages", () => {
for (const channelType of ["channel", undefined] as const) {
const message = {
type: "message",
channel: "D1",
ts: "123",
thread_ts: "123",
...(channelType ? { channel_type: channelType } : {}),
} as const;
const context = resolveSlackThreadContext({
replyToMode: "off",
isDirectMessage: true,
message,
});
expect(context.isThreadReply).toBe(false);
expect(context.messageThreadId).toBe("123");
expect(context.replyToId).toBe("123");
}
});
it("does not set messageThreadId for channel thread-root messages with non-all replyToMode", () => {
for (const replyToMode of ["off", "first", "batched"] as const) {
const context = resolveSlackThreadContext({
replyToMode,
isDirectMessage: false,
message: {
type: "message",
channel: "C1",
channel_type: "channel",
ts: "123",
thread_ts: "123",
},
});
expect(context.isThreadReply).toBe(false);
// thread_ts == ts in a channel: auto-created top-level thread_ts should
// NOT force threaded mode — only DM assistant threads get the override.
expect(context.messageThreadId).toBeUndefined();
expect(context.replyToId).toBe("123");
}
});
it("prefers thread_ts as messageThreadId for replies", () => {
const context = resolveSlackThreadContext({
replyToMode: "off",
message: {
type: "message",
channel: "C1",
ts: "123",
thread_ts: "456",
},
});
expect(context.isThreadReply).toBe(true);
expect(context.messageThreadId).toBe("456");
expect(context.replyToId).toBe("456");
});
});