mirror of
https://github.com/openclaw/openclaw.git
synced 2026-08-02 22:41:33 +00:00
* fix(e2e): bound Docker stats sample lines * fix(e2e): format Docker stats line cap proof * fix docker stats CRLF line cap --------- Co-authored-by: Peter Steinberger <steipete@gmail.com>
191 lines
6.6 KiB
TypeScript
191 lines
6.6 KiB
TypeScript
// Docker Stats Resource Ceiling tests cover docker stats resource ceiling script behavior.
|
|
import { spawnSync } from "node:child_process";
|
|
import { mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import { afterEach, describe, expect, it } from "vitest";
|
|
|
|
const SCRIPT_PATH = "scripts/e2e/lib/docker-stats/assert-resource-ceiling.mjs";
|
|
const MAX_STATS_SAMPLE_LINE_BYTES = 1024 * 1024;
|
|
const tempRoots: string[] = [];
|
|
|
|
function writeStats(contents: string): string {
|
|
const root = mkdtempSync(join(tmpdir(), "openclaw-docker-stats-"));
|
|
tempRoots.push(root);
|
|
const file = join(root, "stats.jsonl");
|
|
writeFileSync(file, contents);
|
|
return file;
|
|
}
|
|
|
|
function runAssert(statsFile: string, maxMemoryMiB = "512", maxCpuPercent = "100") {
|
|
return spawnSync(
|
|
process.execPath,
|
|
[SCRIPT_PATH, statsFile, maxMemoryMiB, maxCpuPercent, "test"],
|
|
{
|
|
encoding: "utf8",
|
|
},
|
|
);
|
|
}
|
|
|
|
function validStatsLineWithBytes(byteLength: number): string {
|
|
const prefix = '{"MemUsage":"128MiB / 2GiB","CPUPerc":"25.0%","padding":"';
|
|
const suffix = '"}';
|
|
const paddingLength = byteLength - Buffer.byteLength(prefix + suffix, "utf8");
|
|
expect(paddingLength).toBeGreaterThan(0);
|
|
return `${prefix}${"x".repeat(paddingLength)}${suffix}`;
|
|
}
|
|
|
|
afterEach(() => {
|
|
for (const root of tempRoots.splice(0)) {
|
|
rmSync(root, { force: true, recursive: true });
|
|
}
|
|
});
|
|
|
|
describe("scripts/e2e/lib/docker-stats/assert-resource-ceiling.mjs", () => {
|
|
it("fails when the stats log contains no parseable samples", () => {
|
|
const result = runAssert(writeStats("not-json\n"));
|
|
|
|
expect(result.status).not.toBe(0);
|
|
expect(result.stderr).toContain("was not valid JSON");
|
|
});
|
|
|
|
it("rejects invalid resource limits instead of disabling the ceiling", () => {
|
|
const result = runAssert(
|
|
writeStats('{"MemUsage":"128MiB / 2GiB","CPUPerc":"25.0%"}\n'),
|
|
"nope",
|
|
);
|
|
|
|
expect(result.status).not.toBe(0);
|
|
expect(result.stderr).toContain("max memory MiB must be a finite non-negative number");
|
|
|
|
const exponent = runAssert(
|
|
writeStats('{"MemUsage":"128MiB / 2GiB","CPUPerc":"25.0%"}\n'),
|
|
"1e3",
|
|
);
|
|
|
|
expect(exponent.status).not.toBe(0);
|
|
expect(exponent.stderr).toContain("max memory MiB must be a finite non-negative number");
|
|
|
|
const cpuExponent = runAssert(
|
|
writeStats('{"MemUsage":"128MiB / 2GiB","CPUPerc":"25.0%"}\n'),
|
|
"512",
|
|
"1e3",
|
|
);
|
|
|
|
expect(cpuExponent.status).not.toBe(0);
|
|
expect(cpuExponent.stderr).toContain("max CPU percent must be a finite non-negative number");
|
|
});
|
|
|
|
it("rejects JSON samples without parseable Docker resource fields", () => {
|
|
const missing = runAssert(writeStats("{}\n"));
|
|
|
|
expect(missing.status).not.toBe(0);
|
|
expect(missing.stderr).toContain("had invalid MemUsage");
|
|
|
|
const malformed = runAssert(writeStats('{"MemUsage":"bad","CPUPerc":"bad"}\n'));
|
|
|
|
expect(malformed.status).not.toBe(0);
|
|
expect(malformed.stderr).toContain("had invalid MemUsage");
|
|
|
|
const looseCpu = runAssert(writeStats('{"MemUsage":"128MiB / 2GiB","CPUPerc":"1e3%"}\n'));
|
|
|
|
expect(looseCpu.status).not.toBe(0);
|
|
expect(looseCpu.stderr).toContain("had invalid CPUPerc");
|
|
});
|
|
|
|
it("reports and enforces parsed Docker resource peaks", () => {
|
|
const result = runAssert(
|
|
writeStats('{"MemUsage":"128MiB / 2GiB","CPUPerc":"25.0%"}\n'),
|
|
"256.5",
|
|
"50.5",
|
|
);
|
|
|
|
expect(result.status).toBe(0);
|
|
expect(result.stdout).toContain("memory=128.0MiB");
|
|
expect(result.stdout).toContain("cpu=25.0%");
|
|
expect(result.stdout).toContain("samples=1");
|
|
});
|
|
|
|
it("streams stats logs instead of slurping them into memory", () => {
|
|
const source = readFileSync(SCRIPT_PATH, "utf8");
|
|
|
|
expect(source).toContain("createReadStream");
|
|
expect(source).toContain("MAX_STATS_SAMPLE_LINE_BYTES");
|
|
expect(source).not.toContain("createInterface");
|
|
expect(source).not.toContain("readFileSync(statsFile");
|
|
expect(source).not.toContain("split(/\\r?\\n/u)");
|
|
});
|
|
|
|
it("rejects oversized stats sample lines before parsing JSON", () => {
|
|
const result = runAssert(writeStats(`{"padding":"${"x".repeat(1024 * 1024)}"}\n`));
|
|
|
|
expect(result.status).not.toBe(0);
|
|
expect(result.stderr).toContain("exceeded 1048576 bytes");
|
|
expect(result.stderr).not.toContain("was not valid JSON");
|
|
});
|
|
|
|
it("accepts large stats sample lines within the line cap", () => {
|
|
const padding = "x".repeat(1024);
|
|
const result = runAssert(
|
|
writeStats(`{"MemUsage":"128MiB / 2GiB","CPUPerc":"25.0%","padding":"${padding}"}\n`),
|
|
);
|
|
|
|
expect(result.status).toBe(0);
|
|
expect(result.stdout).toContain("samples=1");
|
|
});
|
|
|
|
it("accepts CRLF stats sample lines whose content exactly matches the line cap", () => {
|
|
const line = validStatsLineWithBytes(MAX_STATS_SAMPLE_LINE_BYTES);
|
|
const result = runAssert(writeStats(`${line}\r\n`));
|
|
|
|
expect(Buffer.byteLength(line, "utf8")).toBe(MAX_STATS_SAMPLE_LINE_BYTES);
|
|
expect(result.status).toBe(0);
|
|
expect(result.stdout).toContain("samples=1");
|
|
});
|
|
|
|
it("accepts stats sample lines separated by standalone carriage returns", () => {
|
|
const result = runAssert(
|
|
writeStats(
|
|
'{"MemUsage":"128MiB / 2GiB","CPUPerc":"25.0%"}\r{"MemUsage":"64MiB / 2GiB","CPUPerc":"15.0%"}\r',
|
|
),
|
|
);
|
|
|
|
expect(result.status).toBe(0);
|
|
expect(result.stdout).toContain("memory=128.0MiB");
|
|
expect(result.stdout).toContain("samples=2");
|
|
});
|
|
|
|
it("accepts byte-unit Docker memory samples", () => {
|
|
const result = runAssert(writeStats('{"MemUsage":"512B / 2GiB","CPUPerc":"0.5%"}\n'));
|
|
|
|
expect(result.status).toBe(0);
|
|
expect(result.stdout).toContain("samples=1");
|
|
});
|
|
|
|
it("ignores terminal zero-capacity Docker stats samples", () => {
|
|
const result = runAssert(
|
|
writeStats(
|
|
'{"MemUsage":"128MiB / 2GiB","CPUPerc":"25.0%"}\n{"MemUsage":"0B / 0B","CPUPerc":"0.0%"}\n',
|
|
),
|
|
);
|
|
|
|
expect(result.status).toBe(0);
|
|
expect(result.stdout).toContain("memory=128.0MiB");
|
|
expect(result.stdout).toContain("samples=1");
|
|
});
|
|
|
|
it("still fails when only terminal zero-capacity samples were captured", () => {
|
|
const result = runAssert(writeStats('{"MemUsage":"0B / 0B","CPUPerc":"0.0%"}\n'));
|
|
|
|
expect(result.status).not.toBe(0);
|
|
expect(result.stderr).toContain("no docker stats samples captured");
|
|
});
|
|
|
|
it("rejects zero-memory Docker stats samples as invalid proof", () => {
|
|
const result = runAssert(writeStats('{"MemUsage":"0B / 2GiB","CPUPerc":"0.0%"}\n'));
|
|
|
|
expect(result.status).not.toBe(0);
|
|
expect(result.stderr).toContain("had non-positive MemUsage");
|
|
});
|
|
});
|