mirror of
https://github.com/openclaw/openclaw.git
synced 2026-07-15 10:36:09 +00:00
* refactor(sessions): migrate runtime storage to sqlite * test(sessions): fix sqlite CI regressions * test(sessions): align remaining sqlite fixtures * fix(codex): require sqlite trajectory recorder * test(sessions): align orphan recovery sqlite fixture * test(sessions): align sqlite rebase fixtures * fix(sessions): finish current-main integration of the sqlite flip Resolve the whole-store SDK removal across its owner boundary: drop the loadSessionStore re-export and the registry whole-store wrappers, wire hasTrackedActiveSessionRun into gateway chat, complete the preserveLockedHarnessIds cleanup contract, flip the codex thread-history import to storePath targets, and port remaining main-side tests from file-store helpers to session accessor reads. * chore: drop committed pebbles log, revert plugin-inspector bump, refresh generated docs Remove the 1.8k-line .pebbles/events.jsonl work log from the branch, restore the plugin-inspector advisory lane to main's pinned 0.3.10 so the supply-chain bump gets its own review, and regenerate docs_map, the plugin SDK API baseline, and the export-surface ratchet for the merged tree. * feat(sessions): keep archived transcripts by default with zstd cold storage Codex-style retention: deleting or resetting a session archives its transcript as a zstd-compressed JSONL artifact (plain when the runtime lacks node:zlib zstd) and keeps it until the disk budget evicts oldest first. resetArchiveRetention now governs both deleted and reset archives and defaults to keep; maxDiskBytes defaults to 2gb so retention stays bounded, with archives evicted before live sessions. The cron reaper follows the same knob instead of deleting archives on its own timer. * fix(state): converge agent DB migration lineages and bound database growth Merge coherence: run both structure-gated legacy memory-schema repairs (flip-lineage drop, main-lineage identity rebuild) before the flip migration so pre-flip v1/v2 and pre-merge flip v1/v4 databases all converge, and hoist foreign_keys=OFF outside the schema transaction where the pragma was silently ignored and the v1 sessions rebuild cascade-deleted session_entries. Growth guards: fresh agent DBs enable auto_vacuum=INCREMENTAL, WAL maintenance releases freed pages in bounded passes (never a blocking full VACUUM), and doctor reports state/agent DB bloat from freelist stats. * fix(codex): resolve the store path for thread-history import via the SDK The supervision catalog passed the legacy sessionFile locator to the storePath-targeted transcript mirror; resolve the agent store path with the session-store SDK helper instead of a runtime-object seam so test fakes and headless callers need no extra surface. Drop the obsolete missing-session-id preprocessing case: sessions rows are NOT NULL on session_id and upsert repairs id-less patches at write time. * fix(sessions): fail safe on malformed disk-budget config and doctor stat errors A malformed explicit maxDiskBytes disables the budget instead of falling back to the destructive 2gb default the user never chose, and the doctor bloat check skips databases whose paths stat-fail instead of aborting doctor. * fix(sessions): complete sqlite conflict translations * test(sqlite): align hardening checks with maintenance * test(sessions): inspect compressed transcript archives * fix(tests): await session seeds and drop unused helpers flagged by CI lint The five unawaited writeSessionStoreSeed calls raced their SQLite seeds against the assertions, failing compact shards; the bloat probe drops a useless initializer and the merged tests drop now-unused helpers. * test(sessions): type legacy proof events directly * test(sessions): align hardening contracts * perf(sessions): read usage transcript sizes from SQL aggregates Usage/cost scans walked every session and materialized every transcript event just to re-stringify it for a byte estimate — the #86718 stall class reborn on the DB. readTranscriptStatsSync sums stored JSON bytes in SQLite without loading a single row. * fix(sessions): re-root foreign-root transcript paths onto the current sessions dir Restored backups, moved OPENCLAW_STATE_DIR, and rehearsal copies carry absolute sessionFile paths from the old root; the containment fallback kept those foreign paths, so migration read (and would archive) files in the original root and reported local copies missing. Re-root the canonical agents/<id>/sessions suffix onto the current dir when the file exists there; genuine cross-root layouts still fall through unchanged. * test(agents): seed harness admission through sqlite * fix(sqlite): close agent db on pragma setup failure * fix(doctor): compact and retrofit incremental auto-vacuum after session import The migration is the sanctioned offline window: post-import compact reclaims import churn and applies auto_vacuum=INCREMENTAL to databases created before the fresh-DB pragma existed, so runtime maintenance can release pages in bounded passes on every install. --------- Co-authored-by: Peter Steinberger <steipete@gmail.com>
238 lines
7.4 KiB
TypeScript
238 lines
7.4 KiB
TypeScript
// ACPX tests cover index plugin behavior.
|
|
import type { OpenClawPluginApi } from "openclaw/plugin-sdk/plugin-entry";
|
|
import { createTestPluginApi } from "openclaw/plugin-sdk/plugin-test-api";
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
import setupPlugin from "./setup-api.js";
|
|
|
|
const { createAcpxRuntimeServiceMock, tryDispatchAcpReplyHookMock } = vi.hoisted(() => ({
|
|
createAcpxRuntimeServiceMock: vi.fn(),
|
|
tryDispatchAcpReplyHookMock: vi.fn(),
|
|
}));
|
|
|
|
vi.mock("./register.runtime.js", () => ({
|
|
createAcpxRuntimeService: createAcpxRuntimeServiceMock,
|
|
}));
|
|
|
|
vi.mock("openclaw/plugin-sdk/acp-runtime-backend", () => ({
|
|
tryDispatchAcpReplyHook: tryDispatchAcpReplyHookMock,
|
|
}));
|
|
|
|
import plugin from "./index.js";
|
|
|
|
type AcpxAutoEnableProbe = Parameters<OpenClawPluginApi["registerAutoEnableProbe"]>[0];
|
|
|
|
function registerAcpxAutoEnableProbe(): AcpxAutoEnableProbe {
|
|
const probes: AcpxAutoEnableProbe[] = [];
|
|
setupPlugin.register(
|
|
createTestPluginApi({
|
|
registerAutoEnableProbe(probe) {
|
|
probes.push(probe);
|
|
},
|
|
}),
|
|
);
|
|
const probe = probes[0];
|
|
if (!probe) {
|
|
throw new Error("expected ACPX setup plugin to register an auto-enable probe");
|
|
}
|
|
return probe;
|
|
}
|
|
|
|
describe("acpx plugin", () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
it("registers the runtime service and reply_dispatch hook", () => {
|
|
const service = { id: "acpx-service", start: vi.fn() };
|
|
createAcpxRuntimeServiceMock.mockReturnValue(service);
|
|
const openKeyedStore = vi.fn();
|
|
|
|
const api = {
|
|
pluginConfig: { stateDir: "/tmp/acpx" },
|
|
runtime: { state: { openKeyedStore } },
|
|
registerService: vi.fn(),
|
|
on: vi.fn(),
|
|
};
|
|
|
|
plugin.register(api as never);
|
|
|
|
expect(createAcpxRuntimeServiceMock).toHaveBeenCalledWith({
|
|
pluginConfig: api.pluginConfig,
|
|
openKeyedStore: expect.any(Function),
|
|
});
|
|
const params = createAcpxRuntimeServiceMock.mock.calls[0]?.[0] as {
|
|
openKeyedStore: typeof openKeyedStore;
|
|
};
|
|
params.openKeyedStore({ namespace: "test", maxEntries: 1 });
|
|
expect(openKeyedStore).toHaveBeenCalledWith({ namespace: "test", maxEntries: 1 });
|
|
expect(api.registerService).toHaveBeenCalledWith(service);
|
|
expect(api.on).toHaveBeenCalledWith("reply_dispatch", expect.any(Function), {
|
|
timeoutMs: 120_000,
|
|
});
|
|
});
|
|
|
|
it("uses configured ACPX timeout for reply_dispatch hook registration", () => {
|
|
const service = { id: "acpx-service", start: vi.fn() };
|
|
createAcpxRuntimeServiceMock.mockReturnValue(service);
|
|
|
|
const api = {
|
|
pluginConfig: { timeoutSeconds: 180 },
|
|
runtime: { state: { openKeyedStore: vi.fn() } },
|
|
registerService: vi.fn(),
|
|
on: vi.fn(),
|
|
};
|
|
|
|
plugin.register(api as never);
|
|
|
|
expect(api.on).toHaveBeenCalledWith("reply_dispatch", expect.any(Function), {
|
|
timeoutMs: 180_000,
|
|
});
|
|
});
|
|
|
|
it("does not touch runtime state while registering metadata-only plugin APIs", () => {
|
|
const service = { id: "acpx-service", start: vi.fn() };
|
|
createAcpxRuntimeServiceMock.mockReturnValue(service);
|
|
|
|
const api = {
|
|
pluginConfig: {},
|
|
runtime: {},
|
|
registerService: vi.fn(),
|
|
on: vi.fn(),
|
|
};
|
|
|
|
expect(() => plugin.register(api as never)).not.toThrow();
|
|
expect(api.registerService).toHaveBeenCalledWith(service);
|
|
});
|
|
|
|
it("preserves the ACP reply_dispatch runtime path through the registered hook", async () => {
|
|
const service = { id: "acpx-service", start: vi.fn() };
|
|
createAcpxRuntimeServiceMock.mockReturnValue(service);
|
|
tryDispatchAcpReplyHookMock.mockResolvedValue({
|
|
handled: true,
|
|
queuedFinal: true,
|
|
counts: { tool: 1, block: 0, final: 1 },
|
|
});
|
|
|
|
const on = vi.fn();
|
|
const openKeyedStore = vi.fn();
|
|
const api = createTestPluginApi({
|
|
pluginConfig: { stateDir: "/tmp/acpx" },
|
|
runtime: { state: { openKeyedStore } } as never,
|
|
registerService: vi.fn(),
|
|
on,
|
|
});
|
|
|
|
plugin.register(api);
|
|
|
|
const hook = on.mock.calls.find(([hookName]) => hookName === "reply_dispatch")?.[1];
|
|
if (!hook) {
|
|
throw new Error("expected reply_dispatch hook to be registered");
|
|
}
|
|
|
|
const event = {
|
|
ctx: { raw: "reply ctx" },
|
|
runId: "run-1",
|
|
sessionKey: "agent:test:session",
|
|
inboundAudio: false,
|
|
shouldRouteToOriginating: false,
|
|
shouldSendToolSummaries: true,
|
|
sendPolicy: "allow",
|
|
};
|
|
const ctx = {
|
|
cfg: {},
|
|
dispatcher: { dispatch: vi.fn(), getQueuedCounts: vi.fn(), getFailedCounts: vi.fn() },
|
|
recordProcessed: vi.fn(),
|
|
markIdle: vi.fn(),
|
|
};
|
|
|
|
await expect(hook(event, ctx)).resolves.toEqual({
|
|
handled: true,
|
|
queuedFinal: true,
|
|
counts: { tool: 1, block: 0, final: 1 },
|
|
});
|
|
expect(tryDispatchAcpReplyHookMock).toHaveBeenCalledWith(event, {
|
|
...ctx,
|
|
abortSignal: expect.any(AbortSignal),
|
|
});
|
|
});
|
|
|
|
it("aborts the ACP reply_dispatch runtime path at the configured timeout", async () => {
|
|
vi.useFakeTimers();
|
|
try {
|
|
const service = { id: "acpx-service", start: vi.fn() };
|
|
createAcpxRuntimeServiceMock.mockReturnValue(service);
|
|
const observedAbortStates: boolean[] = [];
|
|
tryDispatchAcpReplyHookMock.mockImplementation(async (_event, hookCtx) => {
|
|
const abortSignal = (hookCtx as { abortSignal?: AbortSignal }).abortSignal;
|
|
if (!abortSignal) {
|
|
throw new Error("expected ACPX hook abort signal");
|
|
}
|
|
observedAbortStates.push(abortSignal.aborted);
|
|
await new Promise<void>((resolve) => {
|
|
abortSignal.addEventListener("abort", () => resolve(), { once: true });
|
|
});
|
|
observedAbortStates.push(abortSignal.aborted);
|
|
return {
|
|
handled: true,
|
|
queuedFinal: true,
|
|
counts: { tool: 0, block: 0, final: 1 },
|
|
};
|
|
});
|
|
|
|
const on = vi.fn();
|
|
const api = createTestPluginApi({
|
|
pluginConfig: { timeoutSeconds: 0.001 },
|
|
runtime: { state: { openKeyedStore: vi.fn() } } as never,
|
|
registerService: vi.fn(),
|
|
on,
|
|
});
|
|
|
|
plugin.register(api);
|
|
|
|
const hook = on.mock.calls.find(([hookName]) => hookName === "reply_dispatch")?.[1];
|
|
if (!hook) {
|
|
throw new Error("expected reply_dispatch hook to be registered");
|
|
}
|
|
|
|
const run = hook(
|
|
{
|
|
ctx: { raw: "reply ctx" },
|
|
runId: "run-1",
|
|
sessionKey: "agent:test:session",
|
|
inboundAudio: false,
|
|
shouldRouteToOriginating: false,
|
|
shouldSendToolSummaries: true,
|
|
sendPolicy: "allow",
|
|
},
|
|
{
|
|
cfg: {},
|
|
dispatcher: { dispatch: vi.fn(), getQueuedCounts: vi.fn(), getFailedCounts: vi.fn() },
|
|
recordProcessed: vi.fn(),
|
|
markIdle: vi.fn(),
|
|
},
|
|
);
|
|
|
|
await vi.advanceTimersByTimeAsync(1);
|
|
|
|
await expect(run).resolves.toEqual({
|
|
handled: true,
|
|
queuedFinal: true,
|
|
counts: { tool: 0, block: 0, final: 1 },
|
|
});
|
|
expect(observedAbortStates).toEqual([false, true]);
|
|
} finally {
|
|
vi.useRealTimers();
|
|
}
|
|
});
|
|
|
|
it("declares setup auto-enable reasons for ACPX-owned ACP config", () => {
|
|
const probe = registerAcpxAutoEnableProbe();
|
|
|
|
expect(probe({ config: { acp: { enabled: true } }, env: {} })).toBe("ACP runtime configured");
|
|
expect(probe({ config: { acp: { backend: "acpx" } }, env: {} })).toBe("ACP runtime configured");
|
|
expect(probe({ config: { acp: { enabled: true, backend: "custom-runtime" } }, env: {} })).toBe(
|
|
null,
|
|
);
|
|
});
|
|
});
|