Files
openclaw/src/plugins/cli-gateway-nodes-runtime.test.ts
Jiaming Guo 456c48f368 fix(gateway): require admin scope for browser proxy invoke (#85916)
* fix(gateway): require admin scope for browser proxy invoke

* fix(gateway): document trusted node scopes

* fix(gateway): align browser scope test

* fix(gateway): satisfy node test lint

---------

Co-authored-by: Agustin Rivera <agustin@rivera-web.com>
2026-06-29 16:23:02 -07:00

91 lines
2.8 KiB
TypeScript

/** Tests plugin CLI node Gateway runtime timeout and invocation behavior. */
import { MAX_TIMER_TIMEOUT_MS } from "@openclaw/normalization-core/number-coercion";
import { beforeEach, describe, expect, it, vi } from "vitest";
import {
createPluginCliGatewayNodesRuntime,
resolvePluginCliNodeInvokeGatewayTimeoutMs,
} from "./cli-gateway-nodes-runtime.js";
import { withPluginRuntimePluginScope } from "./runtime/gateway-request-scope.js";
const callGatewayMock = vi.fn();
vi.mock("../gateway/call.js", () => ({
callGateway: (opts: unknown) => callGatewayMock(opts),
}));
describe("createPluginCliGatewayNodesRuntime", () => {
beforeEach(() => {
callGatewayMock.mockReset();
callGatewayMock.mockResolvedValue({});
});
it("caps oversized node invoke gateway timeouts", async () => {
const nodes = createPluginCliGatewayNodesRuntime();
await nodes.invoke({
nodeId: "node-1",
command: "system.run",
timeoutMs: Number.MAX_SAFE_INTEGER,
});
expect(callGatewayMock).toHaveBeenCalledWith(
expect.objectContaining({
method: "node.invoke",
timeoutMs: MAX_TIMER_TIMEOUT_MS,
params: expect.objectContaining({
timeoutMs: Number.MAX_SAFE_INTEGER,
}),
}),
);
});
it("forwards requested node invoke scopes for bundled plugin CLI runtime", async () => {
const nodes = createPluginCliGatewayNodesRuntime();
await withPluginRuntimePluginScope({ pluginId: "google-meet", pluginOrigin: "bundled" }, () =>
nodes.invoke({
nodeId: "node-1",
command: "browser.proxy",
scopes: ["operator.admin"],
}),
);
expect(callGatewayMock).toHaveBeenCalledWith(
expect.objectContaining({
method: "node.invoke",
scopes: ["operator.admin"],
}),
);
});
it("drops requested node invoke scopes for third-party plugin CLI runtime", async () => {
const nodes = createPluginCliGatewayNodesRuntime();
await withPluginRuntimePluginScope({ pluginId: "third-party", pluginOrigin: "global" }, () =>
nodes.invoke({
nodeId: "node-1",
command: "browser.proxy",
scopes: ["operator.admin"],
}),
);
expect(callGatewayMock).toHaveBeenCalledWith(
expect.not.objectContaining({
scopes: expect.anything(),
}),
);
});
});
describe("resolvePluginCliNodeInvokeGatewayTimeoutMs", () => {
it("preserves absent and non-positive timeout behavior", () => {
expect(resolvePluginCliNodeInvokeGatewayTimeoutMs(undefined)).toBeUndefined();
expect(resolvePluginCliNodeInvokeGatewayTimeoutMs(0)).toBeUndefined();
expect(resolvePluginCliNodeInvokeGatewayTimeoutMs(-1)).toBeUndefined();
});
it("adds gateway grace for normal positive timeouts", () => {
expect(resolvePluginCliNodeInvokeGatewayTimeoutMs(10_000)).toBe(15_000);
});
});