mirror of
https://github.com/openclaw/openclaw.git
synced 2026-07-22 22:41:13 +00:00
* perf(ci): scale Vitest workers with runner class and share serial module cache Compact node-test jobs pinned OPENCLAW_VITEST_MAX_WORKERS=2 regardless of runner size, so import-bound suites (30-45s of module-graph import per file) crawled: runner-cli spent 284s on 5s of tests, commands-1 296s on 10s. With serial plans the budget now scales with the class (6 on 8vcpu, 3 on 4vcpu); timing-sensitive groups (tooling, tui-pty, infra-process) stay pinned to 2 via plan-level env. Serial bins share one Vitest fs-module-cache path so later plans reuse the first plan's transforms. The import-bound commands stripes and security suite move to the 8vcpu class, and packing hints refresh from serial-run measurements (run 29481835688). * perf(ci): stripe cli-runner suite and pin media-ui worker budget The agents-core config runs files serially (fileParallelism false guards shared module state), so raising the worker budget cannot help its import-heavy cli-runner suite (~35s module import per file, 213s serial). Stripe it three ways so bins parallelize the imports instead. media-ui hosts browser locator tests that timed out at 6 workers on the first validation run; pin it to the proven 2-worker budget. commands-1's hint drops to its measured 6-worker runtime.
212 lines
7.6 KiB
JavaScript
212 lines
7.6 KiB
JavaScript
// Runs one CI node test shard job: either explicit changed-test targets or a
|
|
// list of packed group plans. Extracted from .github/workflows/ci.yml so the
|
|
// execution policy is unit-testable and plans can run concurrently.
|
|
import { spawn } from "node:child_process";
|
|
import { mkdtempSync, writeFileSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import { StringDecoder } from "node:string_decoder";
|
|
import { isDirectRunUrl } from "./lib/direct-run.mjs";
|
|
import { acquireLocalHeavyCheckLockSync } from "./lib/local-heavy-check-runtime.mjs";
|
|
|
|
// Two concurrent plans halve the serial tail of packed jobs. Children run with
|
|
// inner test-projects parallelism 1 so a job never exceeds two Vitest runs;
|
|
// stacking outer and inner parallelism oversubscribes the 4 vCPU runner class.
|
|
const PLAN_CONCURRENCY = 2;
|
|
const FS_MODULE_CACHE_PATH_ENV_KEY = "OPENCLAW_VITEST_FS_MODULE_CACHE_PATH";
|
|
|
|
function parseJsonEnv(env, name, fallback = null) {
|
|
try {
|
|
return JSON.parse(env[name] ?? "null") ?? fallback;
|
|
} catch {
|
|
return fallback;
|
|
}
|
|
}
|
|
|
|
export function resolveShardPlans(env = process.env) {
|
|
const targets = parseJsonEnv(env, "OPENCLAW_NODE_TEST_TARGETS_JSON");
|
|
if (Array.isArray(targets) && targets.length > 0) {
|
|
// One target per child process preserves the isolation boundaries encoded
|
|
// by full-suite include-pattern shards while keeping one runner job.
|
|
return targets.map((target) => ({ kind: "target", name: target, target }));
|
|
}
|
|
|
|
const groups = parseJsonEnv(env, "OPENCLAW_NODE_TEST_GROUPS_JSON");
|
|
const plans =
|
|
Array.isArray(groups) && groups.length > 0
|
|
? groups
|
|
: [
|
|
{
|
|
configs: parseJsonEnv(env, "OPENCLAW_NODE_TEST_CONFIGS_JSON", []),
|
|
env: parseJsonEnv(env, "OPENCLAW_NODE_TEST_ENV_JSON"),
|
|
includePatterns: parseJsonEnv(env, "OPENCLAW_NODE_TEST_INCLUDE_PATTERNS_JSON"),
|
|
shard_name: env.OPENCLAW_VITEST_SHARD_NAME,
|
|
},
|
|
];
|
|
return plans.map((plan) => ({
|
|
kind: "group",
|
|
name: plan.shard_name ?? plan.configs?.[0] ?? "group",
|
|
plan,
|
|
}));
|
|
}
|
|
|
|
export function buildChildEnv(entry, baseEnv, scratchDir, index, options = {}) {
|
|
const childEnv = {
|
|
...baseEnv,
|
|
// Concurrent children must not share a Vitest module cache directory
|
|
// (shared caches race with ENOTEMPTY when two runs rewrite the same
|
|
// entries), but serial bins reuse one cache so later plans skip the cold
|
|
// module transforms the first plan already paid for.
|
|
[FS_MODULE_CACHE_PATH_ENV_KEY]: join(
|
|
scratchDir,
|
|
options.serial ? "vitest-cache-shared" : `vitest-cache-${index}`,
|
|
),
|
|
OPENCLAW_TEST_PROJECTS_PARALLEL: "1",
|
|
// This wrapper holds the repo heavy-check lock; children skipping it is
|
|
// what lets two plans run concurrently instead of serializing on the lock.
|
|
OPENCLAW_TEST_HEAVY_CHECK_LOCK_HELD: "1",
|
|
};
|
|
if (entry.kind === "target") {
|
|
return childEnv;
|
|
}
|
|
const plan = entry.plan;
|
|
if (plan.shard_name) {
|
|
childEnv.OPENCLAW_VITEST_SHARD_NAME = plan.shard_name;
|
|
}
|
|
if (plan.env && typeof plan.env === "object" && !Array.isArray(plan.env)) {
|
|
for (const [key, value] of Object.entries(plan.env)) {
|
|
if (typeof value === "string") {
|
|
childEnv[key] = value;
|
|
}
|
|
}
|
|
}
|
|
if (Array.isArray(plan.includePatterns) && plan.includePatterns.length > 0) {
|
|
const includeFile = join(scratchDir, `node-test-include-${index}.json`);
|
|
writeFileSync(includeFile, JSON.stringify(plan.includePatterns), "utf8");
|
|
childEnv.OPENCLAW_VITEST_INCLUDE_FILE = includeFile;
|
|
} else {
|
|
delete childEnv.OPENCLAW_VITEST_INCLUDE_FILE;
|
|
}
|
|
return childEnv;
|
|
}
|
|
|
|
const MAX_PENDING_LINE_CHARS = 1_000_000;
|
|
|
|
function relayChildStream(stream, label) {
|
|
const decoder = new StringDecoder("utf8");
|
|
let pending = "";
|
|
const writeLine = (line) => {
|
|
if (!process.stdout.write(`[shard:${label}] ${line}\n`)) {
|
|
stream.pause();
|
|
process.stdout.once("drain", () => stream.resume());
|
|
}
|
|
};
|
|
stream.on("data", (chunk) => {
|
|
pending += decoder.write(chunk);
|
|
const lines = pending.split("\n");
|
|
pending = lines.pop() ?? "";
|
|
for (const line of lines) {
|
|
writeLine(line);
|
|
}
|
|
if (pending.length > MAX_PENDING_LINE_CHARS) {
|
|
writeLine(pending);
|
|
pending = "";
|
|
}
|
|
});
|
|
return () => {
|
|
pending += decoder.end();
|
|
if (pending !== "") {
|
|
writeLine(pending);
|
|
pending = "";
|
|
}
|
|
};
|
|
}
|
|
|
|
export function resolveShardChildCommand(args, nodeExecPath = process.execPath) {
|
|
return {
|
|
command: nodeExecPath,
|
|
args: ["scripts/test-projects.mjs", ...args],
|
|
};
|
|
}
|
|
|
|
function runChild(args, childEnv, label) {
|
|
return new Promise((resolve) => {
|
|
// Use Node directly. `pnpm exec node` may reconcile the workspace before
|
|
// tests, which destroys the sticky dependency fast path.
|
|
const childCommand = resolveShardChildCommand(args);
|
|
const child = spawn(childCommand.command, childCommand.args, {
|
|
env: childEnv,
|
|
stdio: ["ignore", "pipe", "pipe"],
|
|
});
|
|
// Stream with a per-line label instead of buffering: children can run
|
|
// whole suites for hours and verbose output must not accumulate on the
|
|
// wrapper heap. Backpressure pauses the child stream while stdout drains,
|
|
// and an oversized newline-free tail is force-flushed so the pending
|
|
// partial line stays bounded too.
|
|
const flushers = [child.stdout, child.stderr].map((stream) => relayChildStream(stream, label));
|
|
process.stdout.write(`[shard:${label}] begin\n`);
|
|
child.on("close", (code) => {
|
|
for (const flush of flushers) {
|
|
flush();
|
|
}
|
|
process.stdout.write(`[shard:${label}] end (exit ${code ?? 1})\n`);
|
|
resolve(code ?? 1);
|
|
});
|
|
child.on("error", (error) => {
|
|
process.stdout.write(`[shard:${label}] failed to spawn: ${error}\n`);
|
|
resolve(1);
|
|
});
|
|
});
|
|
}
|
|
|
|
export async function runShardPlans(plans, options = {}) {
|
|
const baseEnv = options.env ?? process.env;
|
|
const concurrency = Math.max(1, options.concurrency ?? PLAN_CONCURRENCY);
|
|
const runner = options.runChild ?? runChild;
|
|
const scratchDir = options.scratchDir ?? mkdtempSync(join(tmpdir(), "openclaw-node-shard-"));
|
|
|
|
let nextIndex = 0;
|
|
let exitCode = 0;
|
|
const workers = Array.from({ length: concurrency }, async () => {
|
|
while (nextIndex < plans.length && exitCode === 0) {
|
|
const index = nextIndex;
|
|
nextIndex += 1;
|
|
const entry = plans[index];
|
|
const args = entry.kind === "target" ? [entry.target] : entry.plan.configs;
|
|
if (!Array.isArray(args) || args.length === 0) {
|
|
console.error(`Missing node test shard configs for ${entry.name}`);
|
|
exitCode = exitCode || 1;
|
|
return;
|
|
}
|
|
const childEnv = buildChildEnv(entry, baseEnv, scratchDir, index, {
|
|
serial: concurrency === 1,
|
|
});
|
|
const code = await runner(args, childEnv, entry.name);
|
|
if (code !== 0) {
|
|
// Stop scheduling new plans after a failure; the in-flight sibling
|
|
// finishes so its buffered output still lands in the job log.
|
|
exitCode = exitCode || code;
|
|
}
|
|
}
|
|
});
|
|
await Promise.all(workers);
|
|
return exitCode;
|
|
}
|
|
|
|
if (isDirectRunUrl(process.argv[1], import.meta.url)) {
|
|
const plans = resolveShardPlans();
|
|
// Bins holding spawn/signal-timing suites are marked planConcurrency 1 by
|
|
// the planner; overlapping them with a sibling Vitest run causes flakes.
|
|
const planConcurrency = Number(process.env.OPENCLAW_NODE_TEST_PLAN_CONCURRENCY) || undefined;
|
|
const releaseLock = acquireLocalHeavyCheckLockSync({
|
|
cwd: process.cwd(),
|
|
env: process.env,
|
|
toolName: "test",
|
|
});
|
|
try {
|
|
process.exitCode = await runShardPlans(plans, { concurrency: planConcurrency });
|
|
} finally {
|
|
releaseLock();
|
|
}
|
|
}
|