mirror of
https://github.com/openclaw/openclaw.git
synced 2026-07-15 19:06:05 +00:00
* chore(types): add declaration files for scripts/lib and scripts/e2e modules
* chore(types): add declaration files for top-level script modules (a-m)
* chore(types): add declaration files for top-level script modules (n-z)
* test: use a non-secret-shaped gateway token fixture
* test: type ci workflow guard helpers for the root test lane
* chore(tooling): typecheck root test/** with a dedicated tsgo lane
- test/tsconfig/tsconfig.test.root.json: root-test program (strict unused checks,
fixtures excluded; two Docker E2E clients that import built dist/** stay out,
same rationale as the scripts/e2e exclusion in tsconfig.scripts.json)
- tsgo:test:root wired into tsgo:test, check:test-types, scripts/check.mjs, and
the ci.yml test-types shard, mirroring the tsgo:scripts lane (#104348)
- changed-lane routing: test/**/*.ts (excluding fixtures) and the lane tsconfig
now trigger 'typecheck test root' in check:changed; previously test/ paths ran
lint only, so harness type errors surfaced first in CI (#104287 envDir case)
- burn down all 1071 latent type errors in the program: precise param/local
types across test/scripts, test/vitest, test/e2e, and transitive scripts/e2e
program members; 205 sibling .d.mts declaration files for imported .mjs
modules (committed separately); zero any, zero ts-expect-error
- resolve the pre-existing testing star-export ambiguity in
scripts/e2e/parallels/common.ts with an explicit re-export
Closes #104388
* chore(types): correct declaration fidelity per structured review
- re-derive 51 .d.mts files from implementation data flow instead of
initializers: fix a wrong never return (runTestProjectsDelegation returns
the child), add encoding-sensitive exec/spawn overloads (plain-gh), restore
the full release profile union, make parsed paths string | null, add missing
parseArgs fields via help/non-help unions, add a missing sibling declaration
(budget-number-args), drop 15 unused lint directives
- precise install-record/tuple typing removes the type-aware oxlint
regressions the first declarations caused in scripts/e2e implementations
- route .mts declaration edits under test/ to the testRoot lane and reference
the test-root project from tsconfig.projects.json so tsgo:all covers it
(closes both review findings against the lane wiring)
* chore(scripts): keep telegram runner dist typing structural for the boundary guard
* chore(types): declare runtime pack and gateway readiness exports added on main
* test: pin the importTargetPlan form of the plugin-contract plan import
The guard expectation still referenced the raw await import( form that
7ae5996bb3 (#103975) replaced with the importTargetPlan fallback helper;
the assertion fails on current main.
352 lines
11 KiB
TypeScript
352 lines
11 KiB
TypeScript
// Gateway benchmark child test support simulates child process behavior for script tests.
|
|
import { EventEmitter } from "node:events";
|
|
import { expect, it, vi } from "vitest";
|
|
import { resolveWindowsTaskkillPath } from "../../scripts/lib/windows-taskkill.mjs";
|
|
|
|
function expectedTaskkillPath(): string {
|
|
return resolveWindowsTaskkillPath();
|
|
}
|
|
|
|
type StopChildResult = {
|
|
exitedBeforeTeardown: boolean;
|
|
exitCode: number | null;
|
|
signal: string | null;
|
|
};
|
|
|
|
type StopChild<TChild> = (
|
|
child: TChild,
|
|
options?: {
|
|
killGraceMs?: number;
|
|
platform?: NodeJS.Platform;
|
|
runTaskkill?: typeof spawnSync;
|
|
teardownGraceMs?: number;
|
|
},
|
|
) => Promise<StopChildResult>;
|
|
|
|
export function registerStopChildBehaviorTests<TChild>(params: {
|
|
stopChild: StopChild<TChild>;
|
|
queuedExitCode: number;
|
|
}) {
|
|
it("classifies queued child exits before sending teardown signals", async () => {
|
|
const child = new EventEmitter() as EventEmitter & {
|
|
exitCode: number | null;
|
|
kill: ReturnType<typeof vi.fn>;
|
|
signalCode: NodeJS.Signals | null;
|
|
};
|
|
child.exitCode = null;
|
|
child.signalCode = null;
|
|
child.kill = vi.fn(() => true);
|
|
|
|
const stopped = params.stopChild(child as unknown as TChild);
|
|
queueMicrotask(() => {
|
|
child.exitCode = params.queuedExitCode;
|
|
child.emit("exit", params.queuedExitCode, null);
|
|
});
|
|
|
|
await expect(stopped).resolves.toEqual({
|
|
exitedBeforeTeardown: true,
|
|
exitCode: params.queuedExitCode,
|
|
signal: null,
|
|
});
|
|
expect(child.kill).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("classifies failed teardown signaling as a pre-teardown child exit", async () => {
|
|
const child = new EventEmitter() as EventEmitter & {
|
|
exitCode: number | null;
|
|
kill: ReturnType<typeof vi.fn>;
|
|
signalCode: NodeJS.Signals | null;
|
|
};
|
|
child.exitCode = null;
|
|
child.signalCode = null;
|
|
child.kill = vi.fn(() => {
|
|
setImmediate(() => {
|
|
child.exitCode = 8;
|
|
child.emit("exit", 8, null);
|
|
});
|
|
return false;
|
|
});
|
|
|
|
await expect(params.stopChild(child as unknown as TChild)).resolves.toEqual({
|
|
exitedBeforeTeardown: true,
|
|
exitCode: 8,
|
|
signal: null,
|
|
});
|
|
expect(child.kill).toHaveBeenCalledWith("SIGTERM");
|
|
});
|
|
|
|
it("bounds teardown when the child ignores termination signals", async () => {
|
|
const child = new EventEmitter() as EventEmitter & {
|
|
exitCode: number | null;
|
|
kill: ReturnType<typeof vi.fn>;
|
|
signalCode: NodeJS.Signals | null;
|
|
stderr: { destroy: ReturnType<typeof vi.fn> };
|
|
stdin: { destroy: ReturnType<typeof vi.fn> };
|
|
stdout: { destroy: ReturnType<typeof vi.fn> };
|
|
unref: ReturnType<typeof vi.fn>;
|
|
};
|
|
child.exitCode = null;
|
|
child.signalCode = null;
|
|
child.kill = vi.fn(() => true);
|
|
child.stderr = { destroy: vi.fn() };
|
|
child.stdin = { destroy: vi.fn() };
|
|
child.stdout = { destroy: vi.fn() };
|
|
child.unref = vi.fn();
|
|
|
|
await expect(
|
|
params.stopChild(child as unknown as TChild, {
|
|
killGraceMs: 1,
|
|
teardownGraceMs: 1,
|
|
}),
|
|
).resolves.toEqual({
|
|
exitedBeforeTeardown: false,
|
|
exitCode: null,
|
|
signal: "SIGKILL",
|
|
});
|
|
expect(child.kill).toHaveBeenNthCalledWith(1, "SIGTERM");
|
|
expect(child.kill).toHaveBeenNthCalledWith(2, "SIGKILL");
|
|
expect(child.stdin.destroy).toHaveBeenCalledOnce();
|
|
expect(child.stdout.destroy).toHaveBeenCalledOnce();
|
|
expect(child.stderr.destroy).toHaveBeenCalledOnce();
|
|
expect(child.unref).toHaveBeenCalledOnce();
|
|
});
|
|
|
|
it("signals Windows child process trees with taskkill", async () => {
|
|
const child = new EventEmitter() as EventEmitter & {
|
|
exitCode: number | null;
|
|
kill: ReturnType<typeof vi.fn>;
|
|
pid: number;
|
|
signalCode: NodeJS.Signals | null;
|
|
stderr: { destroy: ReturnType<typeof vi.fn> };
|
|
stdin: { destroy: ReturnType<typeof vi.fn> };
|
|
stdout: { destroy: ReturnType<typeof vi.fn> };
|
|
unref: ReturnType<typeof vi.fn>;
|
|
};
|
|
child.exitCode = null;
|
|
child.kill = vi.fn(() => true);
|
|
child.pid = 4450;
|
|
child.signalCode = null;
|
|
child.stderr = { destroy: vi.fn() };
|
|
child.stdin = { destroy: vi.fn() };
|
|
child.stdout = { destroy: vi.fn() };
|
|
child.unref = vi.fn();
|
|
const runTaskkill = vi.fn(() => ({ error: undefined, status: 0 }));
|
|
|
|
await expect(
|
|
params.stopChild(child as unknown as TChild, {
|
|
killGraceMs: 1,
|
|
platform: "win32",
|
|
runTaskkill: runTaskkill as unknown as typeof spawnSync,
|
|
teardownGraceMs: 1,
|
|
}),
|
|
).resolves.toEqual({
|
|
exitedBeforeTeardown: false,
|
|
exitCode: null,
|
|
signal: "SIGKILL",
|
|
});
|
|
expect(runTaskkill).toHaveBeenNthCalledWith(1, expectedTaskkillPath(), ["/PID", "4450", "/T"], {
|
|
stdio: "ignore",
|
|
});
|
|
expect(runTaskkill).toHaveBeenNthCalledWith(
|
|
2,
|
|
expectedTaskkillPath(),
|
|
["/PID", "4450", "/T", "/F"],
|
|
{
|
|
stdio: "ignore",
|
|
},
|
|
);
|
|
expect(child.kill).not.toHaveBeenCalled();
|
|
expect(child.stdin.destroy).toHaveBeenCalledOnce();
|
|
expect(child.stdout.destroy).toHaveBeenCalledOnce();
|
|
expect(child.stderr.destroy).toHaveBeenCalledOnce();
|
|
expect(child.unref).toHaveBeenCalledOnce();
|
|
});
|
|
|
|
it("force-kills Windows child process trees when graceful taskkill fails", async () => {
|
|
const child = new EventEmitter() as EventEmitter & {
|
|
exitCode: number | null;
|
|
kill: ReturnType<typeof vi.fn>;
|
|
pid: number;
|
|
signalCode: NodeJS.Signals | null;
|
|
stderr: { destroy: ReturnType<typeof vi.fn> };
|
|
stdin: { destroy: ReturnType<typeof vi.fn> };
|
|
stdout: { destroy: ReturnType<typeof vi.fn> };
|
|
unref: ReturnType<typeof vi.fn>;
|
|
};
|
|
child.exitCode = null;
|
|
child.kill = vi.fn(() => true);
|
|
child.pid = 4450;
|
|
child.signalCode = null;
|
|
child.stderr = { destroy: vi.fn() };
|
|
child.stdin = { destroy: vi.fn() };
|
|
child.stdout = { destroy: vi.fn() };
|
|
child.unref = vi.fn();
|
|
const runTaskkill = vi
|
|
.fn()
|
|
.mockReturnValueOnce({ error: undefined, status: 1 })
|
|
.mockReturnValueOnce({ error: undefined, status: 0 })
|
|
.mockReturnValueOnce({ error: undefined, status: 0 });
|
|
|
|
await expect(
|
|
params.stopChild(child as unknown as TChild, {
|
|
killGraceMs: 1,
|
|
platform: "win32",
|
|
runTaskkill,
|
|
teardownGraceMs: 1,
|
|
}),
|
|
).resolves.toEqual({
|
|
exitedBeforeTeardown: false,
|
|
exitCode: null,
|
|
signal: "SIGKILL",
|
|
});
|
|
expect(runTaskkill).toHaveBeenNthCalledWith(1, expectedTaskkillPath(), ["/PID", "4450", "/T"], {
|
|
stdio: "ignore",
|
|
});
|
|
expect(runTaskkill).toHaveBeenNthCalledWith(
|
|
2,
|
|
expectedTaskkillPath(),
|
|
["/PID", "4450", "/T", "/F"],
|
|
{
|
|
stdio: "ignore",
|
|
},
|
|
);
|
|
expect(runTaskkill).toHaveBeenNthCalledWith(
|
|
3,
|
|
expectedTaskkillPath(),
|
|
["/PID", "4450", "/T", "/F"],
|
|
{
|
|
stdio: "ignore",
|
|
},
|
|
);
|
|
expect(child.kill).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it.skipIf(process.platform === "win32")(
|
|
"preserves pre-teardown wrapper exits while cleaning the process group",
|
|
async () => {
|
|
const child = new EventEmitter() as EventEmitter & {
|
|
exitCode: number | null;
|
|
kill: ReturnType<typeof vi.fn>;
|
|
pid: number;
|
|
signalCode: NodeJS.Signals | null;
|
|
stderr: { destroy: ReturnType<typeof vi.fn> };
|
|
stdin: { destroy: ReturnType<typeof vi.fn> };
|
|
stdout: { destroy: ReturnType<typeof vi.fn> };
|
|
unref: ReturnType<typeof vi.fn>;
|
|
};
|
|
child.exitCode = null;
|
|
child.kill = vi.fn(() => true);
|
|
child.pid = 4444;
|
|
child.signalCode = null;
|
|
child.stderr = { destroy: vi.fn() };
|
|
child.stdin = { destroy: vi.fn() };
|
|
child.stdout = { destroy: vi.fn() };
|
|
child.unref = vi.fn();
|
|
|
|
let processGroupAlive = true;
|
|
const processKill = vi.spyOn(process, "kill").mockImplementation((pid, signal) => {
|
|
expect(pid).toBe(-child.pid);
|
|
if (signal === "SIGKILL") {
|
|
processGroupAlive = false;
|
|
return true;
|
|
}
|
|
if (signal === 0 && !processGroupAlive) {
|
|
throw Object.assign(new Error("gone"), { code: "ESRCH" });
|
|
}
|
|
return true;
|
|
});
|
|
try {
|
|
const stopped = params.stopChild(child as unknown as TChild, {
|
|
killGraceMs: 50,
|
|
teardownGraceMs: 1,
|
|
});
|
|
queueMicrotask(() => {
|
|
child.exitCode = 0;
|
|
child.emit("exit", 0, null);
|
|
});
|
|
await expect(stopped).resolves.toEqual({
|
|
exitedBeforeTeardown: true,
|
|
exitCode: 0,
|
|
signal: null,
|
|
});
|
|
expect(processKill).toHaveBeenCalledWith(-child.pid, "SIGTERM");
|
|
expect(processKill).toHaveBeenCalledWith(-child.pid, "SIGKILL");
|
|
expect(child.kill).not.toHaveBeenCalled();
|
|
expect(child.stdin.destroy).not.toHaveBeenCalled();
|
|
expect(child.stdout.destroy).not.toHaveBeenCalled();
|
|
expect(child.stderr.destroy).not.toHaveBeenCalled();
|
|
expect(child.unref).not.toHaveBeenCalled();
|
|
} finally {
|
|
processKill.mockRestore();
|
|
}
|
|
},
|
|
);
|
|
|
|
it.skipIf(process.platform === "win32")(
|
|
"waits for the process group after a teardown-triggered wrapper exit",
|
|
async () => {
|
|
const child = new EventEmitter() as EventEmitter & {
|
|
exitCode: number | null;
|
|
kill: ReturnType<typeof vi.fn>;
|
|
pid: number;
|
|
signalCode: NodeJS.Signals | null;
|
|
stderr: { destroy: ReturnType<typeof vi.fn> };
|
|
stdin: { destroy: ReturnType<typeof vi.fn> };
|
|
stdout: { destroy: ReturnType<typeof vi.fn> };
|
|
unref: ReturnType<typeof vi.fn>;
|
|
};
|
|
child.exitCode = null;
|
|
child.kill = vi.fn(() => true);
|
|
child.pid = 4445;
|
|
child.signalCode = null;
|
|
child.stderr = { destroy: vi.fn() };
|
|
child.stdin = { destroy: vi.fn() };
|
|
child.stdout = { destroy: vi.fn() };
|
|
child.unref = vi.fn();
|
|
|
|
let emittedExit = false;
|
|
let processGroupAlive = true;
|
|
const processKill = vi.spyOn(process, "kill").mockImplementation((pid, signal) => {
|
|
expect(pid).toBe(-child.pid);
|
|
if (signal === "SIGTERM" && !emittedExit) {
|
|
emittedExit = true;
|
|
queueMicrotask(() => {
|
|
child.exitCode = 0;
|
|
child.emit("exit", 0, null);
|
|
});
|
|
}
|
|
if (signal === "SIGKILL") {
|
|
processGroupAlive = false;
|
|
return true;
|
|
}
|
|
if (signal === 0 && !processGroupAlive) {
|
|
throw Object.assign(new Error("gone"), { code: "ESRCH" });
|
|
}
|
|
return true;
|
|
});
|
|
try {
|
|
await expect(
|
|
params.stopChild(child as unknown as TChild, {
|
|
killGraceMs: 50,
|
|
teardownGraceMs: 1,
|
|
}),
|
|
).resolves.toEqual({
|
|
exitedBeforeTeardown: false,
|
|
exitCode: 0,
|
|
signal: null,
|
|
});
|
|
expect(processKill).toHaveBeenCalledWith(-child.pid, "SIGTERM");
|
|
expect(processKill).toHaveBeenCalledWith(-child.pid, "SIGKILL");
|
|
expect(child.kill).not.toHaveBeenCalled();
|
|
expect(child.stdin.destroy).not.toHaveBeenCalled();
|
|
expect(child.stdout.destroy).not.toHaveBeenCalled();
|
|
expect(child.stderr.destroy).not.toHaveBeenCalled();
|
|
expect(child.unref).not.toHaveBeenCalled();
|
|
} finally {
|
|
processKill.mockRestore();
|
|
}
|
|
},
|
|
);
|
|
}
|
|
import type { spawnSync } from "node:child_process";
|