mirror of
https://github.com/openclaw/openclaw.git
synced 2026-07-01 06:13:36 +00:00
* fix(reply): deliver final reply when queued follow-up claims session; scope dedupe to routed thread Two core bugs caused composed replies to be silently dropped (no delivery, no error) when a second message arrived in the same thread mid-run: 1. dispatch-from-config: ensureDispatchReplyOperation only kept the dispatch-owned operation authoritative while it had no result. Once runReplyAgent completed the operation to drain queued follow-ups, a second same-thread inbound could claim the session and the first final reply would try to re-acquire the lane instead of finishing delivery, deadlocking behind the queued work. Keep the dispatch-owned operation authoritative through final delivery. 2. reply-payloads-dedupe: messaging-tool reply dedupe compared only the channel target, not the routed thread, so a send in one thread could suppress a later reply in a different thread. Thread the routed thread id through buildReplyPayloads + follow-up delivery and only fall back to channel-only matching for providers without a thread-aware suppression matcher when neither side carries thread evidence. Adds regression tests; existing Telegram topic-suppression behavior is preserved by gating the thread guard to providers lacking a plugin matcher. * fix(reply): preserve threaded message delivery evidence * fix(reply): dedupe final payloads by delivery route * fix(slack): preserve native send thread evidence * fix(reply): preserve explicit reply thread evidence * fix(reply): align explicit reply route dedupe * fix(reply): preserve delivery lane through final dispatch * fix(mattermost): preserve threaded tool send routes * chore(plugin-sdk): refresh API baseline * fix(reply): align final delivery route dedupe * fix(reply): gate followups on final delivery * fix(reply): keep send receipts private * fix(reply): infer implicit message provider * fix(reply): align routed threading policy * fix(reply): preserve queued delivery context * fix(reply): hydrate queued system event routes * fix(reply): hydrate queued execution routes * fix(reply): scope final delivery barriers * fix(slack): preserve DM target aliases * fix(reply): mirror resolved source thread routes * fix(mattermost): retain delayed delivery barrier * fix(codex): separate message routing from tool policy * fix(reply): consume normalized Slack DM targets once * fix(slack): remove stale target alias * style(reply): satisfy changed lint gates * fix(mattermost): preserve explicit reply targets * test: align Slack reply branch checks * fix(reply): persist overflow summaries to admitted session --------- Co-authored-by: Peter Steinberger <steipete@gmail.com>
276 lines
7.7 KiB
TypeScript
276 lines
7.7 KiB
TypeScript
// Slack tests cover threading tool context plugin behavior.
|
|
import type { OpenClawConfig } from "openclaw/plugin-sdk/config-contracts";
|
|
import { describe, expect, it } from "vitest";
|
|
import { buildSlackThreadingToolContext } from "./threading-tool-context.js";
|
|
|
|
const emptyCfg = {} as OpenClawConfig;
|
|
|
|
function resolveReplyToModeWithConfig(params: {
|
|
slackConfig: Record<string, unknown>;
|
|
context: Record<string, unknown>;
|
|
}) {
|
|
const cfg = {
|
|
channels: {
|
|
slack: params.slackConfig,
|
|
},
|
|
} as OpenClawConfig;
|
|
const result = buildSlackThreadingToolContext({
|
|
cfg,
|
|
accountId: null,
|
|
context: params.context as never,
|
|
});
|
|
return result.replyToMode;
|
|
}
|
|
|
|
describe("buildSlackThreadingToolContext", () => {
|
|
it("uses top-level replyToMode by default", () => {
|
|
const cfg = {
|
|
channels: {
|
|
slack: { replyToMode: "first" },
|
|
},
|
|
} as OpenClawConfig;
|
|
const result = buildSlackThreadingToolContext({
|
|
cfg,
|
|
accountId: null,
|
|
context: { ChatType: "channel" },
|
|
});
|
|
expect(result.replyToMode).toBe("first");
|
|
});
|
|
|
|
it("uses chat-type replyToMode overrides for direct messages when configured", () => {
|
|
expect(
|
|
resolveReplyToModeWithConfig({
|
|
slackConfig: {
|
|
replyToMode: "off",
|
|
replyToModeByChatType: { direct: "all" },
|
|
},
|
|
context: { ChatType: "direct" },
|
|
}),
|
|
).toBe("all");
|
|
});
|
|
|
|
it("uses top-level replyToMode for channels when no channel override is set", () => {
|
|
expect(
|
|
resolveReplyToModeWithConfig({
|
|
slackConfig: {
|
|
replyToMode: "off",
|
|
replyToModeByChatType: { direct: "all" },
|
|
},
|
|
context: { ChatType: "channel" },
|
|
}),
|
|
).toBe("off");
|
|
});
|
|
|
|
it("falls back to top-level when no chat-type override is set", () => {
|
|
const cfg = {
|
|
channels: {
|
|
slack: {
|
|
replyToMode: "first",
|
|
},
|
|
},
|
|
} as OpenClawConfig;
|
|
const result = buildSlackThreadingToolContext({
|
|
cfg,
|
|
accountId: null,
|
|
context: { ChatType: "direct" },
|
|
});
|
|
expect(result.replyToMode).toBe("first");
|
|
});
|
|
|
|
it("uses legacy dm.replyToMode for direct messages when no chat-type override exists", () => {
|
|
expect(
|
|
resolveReplyToModeWithConfig({
|
|
slackConfig: {
|
|
replyToMode: "off",
|
|
dm: { replyToMode: "all" },
|
|
},
|
|
context: { ChatType: "direct" },
|
|
}),
|
|
).toBe("all");
|
|
});
|
|
|
|
it("uses all mode when MessageThreadId is present", () => {
|
|
expect(
|
|
resolveReplyToModeWithConfig({
|
|
slackConfig: {
|
|
replyToMode: "all",
|
|
replyToModeByChatType: { direct: "off" },
|
|
},
|
|
context: {
|
|
ChatType: "direct",
|
|
ThreadLabel: "thread-label",
|
|
MessageThreadId: "1771999998.834199",
|
|
},
|
|
}),
|
|
).toBe("all");
|
|
});
|
|
|
|
it("does not force all mode from ThreadLabel alone", () => {
|
|
expect(
|
|
resolveReplyToModeWithConfig({
|
|
slackConfig: {
|
|
replyToMode: "all",
|
|
replyToModeByChatType: { direct: "off" },
|
|
},
|
|
context: {
|
|
ChatType: "direct",
|
|
ThreadLabel: "label-without-real-thread",
|
|
},
|
|
}),
|
|
).toBe("off");
|
|
});
|
|
|
|
it("uses ReplyToId as the current thread when MessageThreadId is omitted", () => {
|
|
const result = buildSlackThreadingToolContext({
|
|
cfg: {
|
|
channels: {
|
|
slack: {
|
|
replyToMode: "all",
|
|
replyToModeByChatType: { direct: "off" },
|
|
},
|
|
},
|
|
} as OpenClawConfig,
|
|
accountId: null,
|
|
context: {
|
|
ChatType: "direct",
|
|
To: "user:U8SUVSVGS",
|
|
NativeChannelId: "D8SRXRDNF",
|
|
CurrentMessageId: "1772000000.111111",
|
|
ReplyToId: "1771999998.834199",
|
|
},
|
|
});
|
|
|
|
expect(result.currentThreadTs).toBe("1771999998.834199");
|
|
expect(result.replyToMode).toBe("all");
|
|
expect(result.sameChannelThreadRequired).toBe(true);
|
|
});
|
|
|
|
it("uses TransportThreadId when ReplyToId matches the current message", () => {
|
|
const result = buildSlackThreadingToolContext({
|
|
cfg: {
|
|
channels: {
|
|
slack: {
|
|
replyToMode: "all",
|
|
replyToModeByChatType: { direct: "off" },
|
|
},
|
|
},
|
|
} as OpenClawConfig,
|
|
accountId: null,
|
|
context: {
|
|
ChatType: "direct",
|
|
CurrentMessageId: "1771999998.834199",
|
|
ReplyToId: "1771999998.834199",
|
|
TransportThreadId: "1771999998.834199",
|
|
},
|
|
});
|
|
|
|
expect(result.currentThreadTs).toBe("1771999998.834199");
|
|
expect(result.replyToMode).toBe("all");
|
|
expect(result.sameChannelThreadRequired).toBe(true);
|
|
});
|
|
|
|
it("keeps top-level ReplyToId as an anchor without forcing configured off mode", () => {
|
|
const result = buildSlackThreadingToolContext({
|
|
cfg: {
|
|
channels: {
|
|
slack: {
|
|
replyToMode: "all",
|
|
replyToModeByChatType: { direct: "off" },
|
|
},
|
|
},
|
|
} as OpenClawConfig,
|
|
accountId: null,
|
|
context: {
|
|
ChatType: "direct",
|
|
CurrentMessageId: "1771999998.834199",
|
|
ReplyToId: "1771999998.834199",
|
|
},
|
|
});
|
|
|
|
expect(result.currentThreadTs).toBe("1771999998.834199");
|
|
expect(result.replyToMode).toBe("off");
|
|
expect(result.sameChannelThreadRequired).toBe(false);
|
|
});
|
|
|
|
it("keeps top-level ReplyToId as the first-reply anchor for single-use modes", () => {
|
|
const result = buildSlackThreadingToolContext({
|
|
cfg: {
|
|
channels: {
|
|
slack: {
|
|
replyToMode: "first",
|
|
},
|
|
},
|
|
} as OpenClawConfig,
|
|
accountId: null,
|
|
context: {
|
|
ChatType: "direct",
|
|
CurrentMessageId: "1771999998.834199",
|
|
ReplyToId: "1771999998.834199",
|
|
},
|
|
});
|
|
|
|
expect(result.currentThreadTs).toBe("1771999998.834199");
|
|
expect(result.replyToMode).toBe("first");
|
|
});
|
|
|
|
it("keeps configured channel behavior when not in a thread", () => {
|
|
const cfg = {
|
|
channels: {
|
|
slack: {
|
|
replyToMode: "off",
|
|
replyToModeByChatType: { channel: "first" },
|
|
},
|
|
},
|
|
} as OpenClawConfig;
|
|
const result = buildSlackThreadingToolContext({
|
|
cfg,
|
|
accountId: null,
|
|
context: { ChatType: "channel", ThreadLabel: "label-only" },
|
|
});
|
|
expect(result.replyToMode).toBe("first");
|
|
});
|
|
|
|
it("defaults to off when no replyToMode is configured", () => {
|
|
const result = buildSlackThreadingToolContext({
|
|
cfg: emptyCfg,
|
|
accountId: null,
|
|
context: { ChatType: "direct" },
|
|
});
|
|
expect(result.replyToMode).toBe("off");
|
|
});
|
|
|
|
it("extracts currentChannelId from channel: prefixed To", () => {
|
|
const result = buildSlackThreadingToolContext({
|
|
cfg: emptyCfg,
|
|
accountId: null,
|
|
context: { ChatType: "channel", To: "channel:C1234ABC" },
|
|
});
|
|
expect(result.currentChannelId).toBe("C1234ABC");
|
|
expect(result.currentMessagingTarget).toBe("channel:C1234ABC");
|
|
});
|
|
|
|
it("preserves native and routable DM targets", () => {
|
|
const result = buildSlackThreadingToolContext({
|
|
cfg: emptyCfg,
|
|
accountId: null,
|
|
context: {
|
|
ChatType: "direct",
|
|
To: "user:U8SUVSVGS",
|
|
NativeChannelId: "D8SRXRDNF",
|
|
},
|
|
});
|
|
expect(result.currentChannelId).toBe("D8SRXRDNF");
|
|
expect(result.currentMessagingTarget).toBe("user:U8SUVSVGS");
|
|
});
|
|
|
|
it("uses the user target for implicit DM sends when NativeChannelId is missing", () => {
|
|
const result = buildSlackThreadingToolContext({
|
|
cfg: emptyCfg,
|
|
accountId: null,
|
|
context: { ChatType: "direct", To: "user:U8SUVSVGS" },
|
|
});
|
|
expect(result.currentChannelId).toBe("user:U8SUVSVGS");
|
|
expect(result.currentMessagingTarget).toBe("user:U8SUVSVGS");
|
|
});
|
|
});
|