Files
openclaw/src/agents/tool-display-exec-shell.ts
lin-hongkuan 3f16718b0c fix: keep heredoc bodies out of shell stage splits (#102889)
* fix: keep heredoc bodies out of shell stage splits

* chore: refresh PR #102889 checks

* fix: handle multiple same-line heredocs

* fix: keep heredoc bodies with declaring stages

* test: cover escaped heredoc delimiters

* style: format escaped heredoc regression

* fix: distinguish here-strings from heredocs

* fix: ignore non-heredoc shell syntax

---------

Co-authored-by: lin-hongkuan <lin-hongkuan@users.noreply.github.com>
Co-authored-by: Peter Steinberger <steipete@gmail.com>
2026-07-10 00:35:58 +01:00

574 lines
14 KiB
TypeScript

/**
* Lightweight shell parsing helpers for exec display summaries.
*
* Handles common quoting, wrapper, and preamble shapes for UI labels without validating shell syntax.
*/
import { normalizeLowercaseStringOrEmpty } from "@openclaw/normalization-core/string-coerce";
type PreambleResult = {
command: string;
chdirPath?: string;
};
/** Removes matching outer single or double quotes from a display token. */
export function stripOuterQuotes(value: string | undefined): string | undefined {
if (!value) {
return value;
}
const trimmed = value.trim();
if (
trimmed.length >= 2 &&
((trimmed.startsWith('"') && trimmed.endsWith('"')) ||
(trimmed.startsWith("'") && trimmed.endsWith("'")))
) {
return trimmed.slice(1, -1).trim();
}
return trimmed;
}
/** Splits a command string into shell-ish words while respecting simple quotes and escapes. */
export function splitShellWords(input: string | undefined, maxWords = 48): string[] {
if (!input) {
return [];
}
const words: string[] = [];
let current = "";
let quote: '"' | "'" | undefined;
let escaped = false;
for (const char of input) {
if (escaped) {
current += char;
escaped = false;
continue;
}
if (char === "\\") {
escaped = true;
continue;
}
if (quote) {
if (char === quote) {
quote = undefined;
} else {
current += char;
}
continue;
}
if (char === '"' || char === "'") {
quote = char;
continue;
}
if (/\s/.test(char)) {
if (!current) {
continue;
}
words.push(current);
if (words.length >= maxWords) {
return words;
}
current = "";
continue;
}
current += char;
}
if (current) {
words.push(current);
}
return words;
}
/** Returns a normalized basename for a command token. */
export function binaryName(token: string | undefined): string | undefined {
if (!token) {
return undefined;
}
const cleaned = stripOuterQuotes(token) ?? token;
const segment = cleaned.split(/[/]/).at(-1) ?? cleaned;
return normalizeLowercaseStringOrEmpty(segment);
}
/** Reads the value for any matching short or long option name. */
export function optionValue(words: string[], names: string[]): string | undefined {
const lookup = new Set(names);
for (let i = 0; i < words.length; i += 1) {
const token = words[i];
if (!token) {
continue;
}
if (lookup.has(token)) {
const value = words[i + 1];
if (value && !value.startsWith("-")) {
return value;
}
continue;
}
for (const name of names) {
if (name.startsWith("--") && token.startsWith(`${name}=`)) {
return token.slice(name.length + 1);
}
}
}
return undefined;
}
/** Returns positional args after skipping options and configured option values. */
export function positionalArgs(
words: string[],
from = 1,
optionsWithValue: string[] = [],
): string[] {
const args: string[] = [];
const takesValue = new Set(optionsWithValue);
for (let i = from; i < words.length; i += 1) {
const token = words[i];
if (!token) {
continue;
}
if (token === "--") {
for (let j = i + 1; j < words.length; j += 1) {
const candidate = words[j];
if (candidate) {
args.push(candidate);
}
}
break;
}
if (token.startsWith("--")) {
if (token.includes("=")) {
continue;
}
if (takesValue.has(token)) {
i += 1;
}
continue;
}
if (token.startsWith("-")) {
if (takesValue.has(token)) {
i += 1;
}
continue;
}
args.push(token);
}
return args;
}
/** Returns the first positional arg after skipping options and configured option values. */
export function firstPositional(
words: string[],
from = 1,
optionsWithValue: string[] = [],
): string | undefined {
return positionalArgs(words, from, optionsWithValue)[0];
}
/** Removes leading `env` wrappers and VAR=value assignments from parsed words. */
export function trimLeadingEnv(words: string[]): string[] {
if (words.length === 0) {
return words;
}
let index = 0;
if (binaryName(words[0]) === "env") {
index = 1;
while (index < words.length) {
const token = words[index];
if (!token) {
break;
}
if (token.startsWith("-")) {
index += 1;
continue;
}
if (/^[A-Za-z_][A-Za-z0-9_]*=/.test(token)) {
index += 1;
continue;
}
break;
}
return words.slice(index);
}
while (index < words.length && /^[A-Za-z_][A-Za-z0-9_]*=/.test(words[index])) {
index += 1;
}
return words.slice(index);
}
/** Unwraps common `sh -c`/`bash -lc` command wrappers for display parsing. */
export function unwrapShellWrapper(command: string): string {
const words = splitShellWords(command, 10);
if (words.length < 3) {
return command;
}
const bin = binaryName(words[0]);
if (!(bin === "bash" || bin === "sh" || bin === "zsh" || bin === "fish")) {
return command;
}
const flagIndex = words.findIndex(
(token, index) => index > 0 && (token === "-c" || token === "-lc" || token === "-ic"),
);
if (flagIndex === -1) {
return command;
}
const inner = words
.slice(flagIndex + 1)
.join(" ")
.trim();
return inner ? (stripOuterQuotes(inner) ?? command) : command;
}
type HeredocMarker = {
value: string;
stripLeadingTabs: boolean;
operatorIndex: number;
};
function parseHeredocMarker(command: string, operatorIndex: number): HeredocMarker | undefined {
if (
command[operatorIndex] !== "<" ||
command[operatorIndex - 1] === "<" ||
command[operatorIndex + 1] !== "<" ||
command[operatorIndex + 2] === "<"
) {
return undefined;
}
const stripLeadingTabs = command[operatorIndex + 2] === "-";
let index = operatorIndex + (stripLeadingTabs ? 3 : 2);
while (/[ \t]/u.test(command[index] ?? "")) {
index += 1;
}
let value = "";
let quote: '"' | "'" | undefined;
for (; index < command.length; index += 1) {
const char = command[index] ?? "";
if (quote) {
if (char === quote) {
quote = undefined;
continue;
}
if (quote === '"' && char === "\\" && index + 1 < command.length) {
index += 1;
value += command[index] ?? "";
continue;
}
value += char;
continue;
}
if (/[\r\n;&|<>]/u.test(char) || /[ \t]/u.test(char)) {
break;
}
if (char === "'" || char === '"') {
quote = char;
continue;
}
if (char === "\\" && index + 1 < command.length) {
index += 1;
value += command[index] ?? "";
continue;
}
value += char;
}
return value ? { value, stripLeadingTabs, operatorIndex } : undefined;
}
function findHeredocBodyEnd(
command: string,
marker: HeredocMarker,
bodyStart: number,
): number | undefined {
let lineStart = bodyStart;
while (lineStart <= command.length) {
const lineEnd = command.indexOf("\n", lineStart);
const end = lineEnd === -1 ? command.length : lineEnd;
const rawLine = command.slice(lineStart, end).replace(/\r$/u, "");
const candidate = marker.stripLeadingTabs ? rawLine.replace(/^\t+/u, "") : rawLine;
if (candidate === marker.value) {
return end;
}
if (lineEnd === -1) {
return undefined;
}
lineStart = lineEnd + 1;
}
return undefined;
}
export function scanTopLevelChars(
command: string,
visit: (char: string, index: number) => boolean | void,
visitHeredocBody?: (operatorIndex: number, start: number, end: number) => void,
): void {
let quote: '"' | "'" | undefined;
let escaped = false;
let atWordStart = true;
let arithmeticDepth = 0;
let plainSubshellDepth = 0;
let pendingHeredocs: HeredocMarker[] = [];
for (let i = 0; i < command.length; i += 1) {
const char = command[i];
if (escaped) {
escaped = false;
if (char !== "\n") {
atWordStart = false;
}
continue;
}
if (char === "\\") {
escaped = true;
continue;
}
if (quote) {
if (char === quote) {
quote = undefined;
}
continue;
}
if (char === '"' || char === "'") {
quote = char;
atWordStart = false;
continue;
}
if (char === "#" && atWordStart && arithmeticDepth === 0) {
const newline = command.indexOf("\n", i + 1);
if (newline === -1) {
return;
}
i = newline - 1;
continue;
}
const startsArithmetic =
arithmeticDepth === 0 &&
char === "(" &&
command[i + 1] === "(" &&
(command[i - 1] === "$" || atWordStart);
const inArithmetic = arithmeticDepth > 0 || startsArithmetic;
if (!inArithmetic) {
const heredoc = parseHeredocMarker(command, i);
if (heredoc) {
pendingHeredocs.push(heredoc);
}
}
if (char === "\n" && pendingHeredocs.length > 0) {
let bodyStart = i + 1;
let bodyEnd: number | undefined;
const bodies: Array<{ marker: HeredocMarker; start: number; end: number }> = [];
for (const marker of pendingHeredocs) {
bodyEnd = findHeredocBodyEnd(command, marker, bodyStart);
if (bodyEnd === undefined) {
break;
}
bodies.push({ marker, start: bodyStart, end: bodyEnd });
bodyStart = bodyEnd + 1;
}
pendingHeredocs = [];
if (bodyEnd !== undefined) {
for (const body of bodies) {
visitHeredocBody?.(body.marker.operatorIndex, body.start, body.end);
}
i = bodyEnd - 1;
continue;
}
}
if (!inArithmetic && visit(char, i) === false) {
return;
}
if (char === "(" && (arithmeticDepth > 0 || startsArithmetic)) {
arithmeticDepth += 1;
continue;
}
if (char === ")" && arithmeticDepth > 0) {
arithmeticDepth -= 1;
continue;
}
if (inArithmetic) {
continue;
}
if (/\s/u.test(char)) {
atWordStart = true;
} else if (char === "(") {
const previous = command[i - 1];
const isWordExpansion = previous === "$" || previous === "<" || previous === ">";
if (isWordExpansion) {
// The expansion is part of the surrounding word, but its body starts a fresh command.
atWordStart = true;
} else if (atWordStart) {
plainSubshellDepth += 1;
atWordStart = true;
}
} else if (char === ")") {
if (plainSubshellDepth > 0) {
plainSubshellDepth -= 1;
atWordStart = true;
} else {
// Command and process substitutions remain part of the word that opened them.
atWordStart = false;
}
} else if (/[;&|<>]/u.test(char)) {
atWordStart = true;
} else {
atWordStart = false;
}
}
}
function splitTopLevel(
command: string,
separatorLength: (char: string, index: number) => number,
): string[] {
const parts: string[] = [];
let segmentStart = 0;
let sliceStart = 0;
let chunks: string[] = [];
scanTopLevelChars(
command,
(char, index) => {
const length = separatorLength(char, index);
if (length === 0) {
return true;
}
parts.push(chunks.join("") + command.slice(sliceStart, index));
segmentStart = index + length;
sliceStart = segmentStart;
chunks = [];
return true;
},
(operatorIndex, bodyStart, bodyEnd) => {
if (operatorIndex < segmentStart) {
chunks.push(command.slice(sliceStart, bodyStart));
sliceStart = bodyEnd;
}
},
);
parts.push(chunks.join("") + command.slice(sliceStart));
return parts.map((part) => part.trim()).filter((part) => part.length > 0);
}
/** Splits a command on top-level stage separators such as `;`, `&&`, and `||`. */
export function splitTopLevelStages(command: string): string[] {
return splitTopLevel(command, (char, index) => {
if (char === ";") {
return 1;
}
if ((char === "&" || char === "|") && command[index + 1] === char) {
return 2;
}
return 0;
});
}
/** Splits a command on top-level single pipes without splitting `||`. */
export function splitTopLevelPipes(command: string): string[] {
return splitTopLevel(command, (char, index) => {
if (char === "|" && command[index - 1] !== "|" && command[index + 1] !== "|") {
return 1;
}
return 0;
});
}
function parseChdirTarget(head: string): string | undefined {
const words = splitShellWords(head, 3);
const bin = binaryName(words[0]);
if (bin === "cd" || bin === "pushd") {
return words[1] || undefined;
}
return undefined;
}
function isChdirCommand(head: string): boolean {
const bin = binaryName(splitShellWords(head, 2)[0]);
return bin === "cd" || bin === "pushd" || bin === "popd";
}
function isPopdCommand(head: string): boolean {
return binaryName(splitShellWords(head, 2)[0]) === "popd";
}
/** Removes leading setup commands such as exports and cwd changes from display summaries. */
export function stripShellPreamble(command: string): PreambleResult {
let rest = command.trim();
let chdirPath: string | undefined;
for (let i = 0; i < 4; i += 1) {
let first: { index: number; length: number; isOr?: boolean } | undefined;
// Only scan top-level separators so quoted strings and nested shell fragments stay intact in
// the command fragment that display code will summarize.
scanTopLevelChars(rest, (char, idx) => {
if (char === "&" && rest[idx + 1] === "&") {
first = { index: idx, length: 2 };
return false;
}
if (char === "|" && rest[idx + 1] === "|") {
first = { index: idx, length: 2, isOr: true };
return false;
}
if (char === ";" || char === "\n") {
first = { index: idx, length: 1 };
return false;
}
return undefined;
});
const head = (first ? rest.slice(0, first.index) : rest).trim();
const isChdir = (first ? !first.isOr : i > 0) && isChdirCommand(head);
const isPreamble =
head.startsWith("set ") || head.startsWith("export ") || head.startsWith("unset ") || isChdir;
if (!isPreamble) {
break;
}
if (isChdir) {
if (isPopdCommand(head)) {
chdirPath = undefined;
} else {
chdirPath = parseChdirTarget(head) ?? chdirPath;
}
}
rest = first ? rest.slice(first.index + first.length).trimStart() : "";
if (!rest) {
break;
}
}
return { command: rest.trim(), chdirPath };
}