mirror of
https://github.com/openclaw/openclaw.git
synced 2026-05-09 12:30:43 +00:00
* fix(googlechat): localize google auth gaxios compat * fix(googlechat): declare undici for staged runtime deps * fix(googlechat): harden google auth transport * fix(googlechat): narrow credential file reads * fix(googlechat): preserve auth proxy transport * fix(googlechat): allow symlinked auth files * fix(googlechat): atomically load auth files * fix(googlechat): eagerly buffer auth responses * fix(googlechat): cap auth response buffering * fix(googlechat): pin staged auth runtime deps * fix(googlechat): buffer auth responses as array buffers * Update CHANGELOG.md * fix(googlechat): reject unstreamed auth responses * fix(googlechat): use ambient fetch for auth transport * fix(googlechat): keep guarded auth fetch on runtime path * fix(googlechat): align staged zod range * chore(lockfile): sync googlechat zod spec
422 lines
13 KiB
TypeScript
422 lines
13 KiB
TypeScript
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import type { ResolvedGoogleChatAccount } from "./accounts.js";
|
|
import { downloadGoogleChatMedia, sendGoogleChatMessage } from "./api.js";
|
|
import { resolveGoogleChatGroupRequireMention } from "./group-policy.js";
|
|
import { isSenderAllowed } from "./sender-allow.js";
|
|
import {
|
|
isGoogleChatSpaceTarget,
|
|
isGoogleChatUserTarget,
|
|
normalizeGoogleChatTarget,
|
|
} from "./targets.js";
|
|
|
|
const mocks = vi.hoisted(() => ({
|
|
buildHostnameAllowlistPolicyFromSuffixAllowlist: vi.fn((hosts: string[]) => ({
|
|
hostnameAllowlist: hosts,
|
|
})),
|
|
fetchWithSsrFGuard: vi.fn(async (params: { url: string; init?: RequestInit }) => ({
|
|
response: await fetch(params.url, params.init),
|
|
release: async () => {},
|
|
})),
|
|
googleAuthCtor: vi.fn(),
|
|
gaxiosCtor: vi.fn(),
|
|
getAccessToken: vi.fn().mockResolvedValue({ token: "access-token" }),
|
|
oauthCtor: vi.fn(),
|
|
verifySignedJwtWithCertsAsync: vi.fn(),
|
|
verifyIdToken: vi.fn(),
|
|
getGoogleChatAccessToken: vi.fn().mockResolvedValue("token"),
|
|
}));
|
|
|
|
vi.mock("openclaw/plugin-sdk/ssrf-runtime", () => {
|
|
return {
|
|
buildHostnameAllowlistPolicyFromSuffixAllowlist:
|
|
mocks.buildHostnameAllowlistPolicyFromSuffixAllowlist,
|
|
fetchWithSsrFGuard: mocks.fetchWithSsrFGuard,
|
|
};
|
|
});
|
|
|
|
vi.mock("gaxios", () => ({
|
|
Gaxios: class {
|
|
defaults: unknown;
|
|
|
|
constructor(defaults?: unknown) {
|
|
this.defaults = defaults;
|
|
mocks.gaxiosCtor(defaults);
|
|
}
|
|
},
|
|
}));
|
|
|
|
vi.mock("google-auth-library", () => ({
|
|
GoogleAuth: class {
|
|
constructor(options?: unknown) {
|
|
mocks.googleAuthCtor(options);
|
|
}
|
|
|
|
getClient = vi.fn().mockResolvedValue({
|
|
getAccessToken: mocks.getAccessToken,
|
|
});
|
|
},
|
|
OAuth2Client: class {
|
|
constructor(options?: unknown) {
|
|
mocks.oauthCtor(options);
|
|
}
|
|
|
|
verifyIdToken = mocks.verifyIdToken;
|
|
verifySignedJwtWithCertsAsync = mocks.verifySignedJwtWithCertsAsync;
|
|
},
|
|
}));
|
|
|
|
vi.mock("./auth.js", async () => {
|
|
const actual = await vi.importActual<typeof import("./auth.js")>("./auth.js");
|
|
return {
|
|
...actual,
|
|
getGoogleChatAccessToken: mocks.getGoogleChatAccessToken,
|
|
};
|
|
});
|
|
|
|
const authActual = await vi.importActual<typeof import("./auth.js")>("./auth.js");
|
|
const { __testing: authTesting, getGoogleChatAccessToken, verifyGoogleChatRequest } = authActual;
|
|
|
|
const account = {
|
|
accountId: "default",
|
|
enabled: true,
|
|
credentialSource: "inline",
|
|
config: {},
|
|
} as ResolvedGoogleChatAccount;
|
|
|
|
function stubSuccessfulSend(name: string) {
|
|
const fetchMock = vi
|
|
.fn()
|
|
.mockResolvedValue(new Response(JSON.stringify({ name }), { status: 200 }));
|
|
vi.stubGlobal("fetch", fetchMock);
|
|
return fetchMock;
|
|
}
|
|
|
|
async function expectDownloadToRejectForResponse(response: Response) {
|
|
vi.stubGlobal("fetch", vi.fn().mockResolvedValue(response));
|
|
await expect(
|
|
downloadGoogleChatMedia({ account, resourceName: "media/123", maxBytes: 10 }),
|
|
).rejects.toThrow(/max bytes/i);
|
|
}
|
|
|
|
describe("normalizeGoogleChatTarget", () => {
|
|
it("normalizes provider prefixes", () => {
|
|
expect(normalizeGoogleChatTarget("googlechat:users/123")).toBe("users/123");
|
|
expect(normalizeGoogleChatTarget("google-chat:spaces/AAA")).toBe("spaces/AAA");
|
|
expect(normalizeGoogleChatTarget("gchat:user:User@Example.com")).toBe("users/user@example.com");
|
|
});
|
|
|
|
it("normalizes email targets to users/<email>", () => {
|
|
expect(normalizeGoogleChatTarget("User@Example.com")).toBe("users/user@example.com");
|
|
expect(normalizeGoogleChatTarget("users/User@Example.com")).toBe("users/user@example.com");
|
|
});
|
|
|
|
it("preserves space targets", () => {
|
|
expect(normalizeGoogleChatTarget("space:spaces/BBB")).toBe("spaces/BBB");
|
|
expect(normalizeGoogleChatTarget("spaces/CCC")).toBe("spaces/CCC");
|
|
});
|
|
});
|
|
|
|
describe("target helpers", () => {
|
|
it("detects user and space targets", () => {
|
|
expect(isGoogleChatUserTarget("users/abc")).toBe(true);
|
|
expect(isGoogleChatSpaceTarget("spaces/abc")).toBe(true);
|
|
expect(isGoogleChatUserTarget("spaces/abc")).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("googlechat group policy", () => {
|
|
it("uses generic channel group policy helpers", () => {
|
|
const cfg = {
|
|
channels: {
|
|
googlechat: {
|
|
groups: {
|
|
"spaces/AAA": {
|
|
requireMention: false,
|
|
},
|
|
"*": {
|
|
requireMention: true,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
} as any;
|
|
|
|
expect(resolveGoogleChatGroupRequireMention({ cfg, groupId: "spaces/AAA" })).toBe(false);
|
|
expect(resolveGoogleChatGroupRequireMention({ cfg, groupId: "spaces/BBB" })).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe("isSenderAllowed", () => {
|
|
it("matches raw email entries only when dangerous name matching is enabled", () => {
|
|
expect(isSenderAllowed("users/123", "Jane@Example.com", ["jane@example.com"])).toBe(false);
|
|
expect(isSenderAllowed("users/123", "Jane@Example.com", ["jane@example.com"], true)).toBe(true);
|
|
});
|
|
|
|
it("does not treat users/<email> entries as email allowlist (deprecated form)", () => {
|
|
expect(isSenderAllowed("users/123", "Jane@Example.com", ["users/jane@example.com"])).toBe(
|
|
false,
|
|
);
|
|
});
|
|
|
|
it("still matches user id entries", () => {
|
|
expect(isSenderAllowed("users/abc", "jane@example.com", ["users/abc"])).toBe(true);
|
|
});
|
|
|
|
it("rejects non-matching raw email entries", () => {
|
|
expect(isSenderAllowed("users/123", "jane@example.com", ["other@example.com"], true)).toBe(
|
|
false,
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("downloadGoogleChatMedia", () => {
|
|
afterEach(() => {
|
|
authTesting.resetGoogleChatAuthForTests();
|
|
mocks.fetchWithSsrFGuard.mockClear();
|
|
vi.unstubAllGlobals();
|
|
});
|
|
|
|
it("rejects when content-length exceeds max bytes", async () => {
|
|
const body = new ReadableStream({
|
|
start(controller) {
|
|
controller.enqueue(new Uint8Array([1, 2, 3]));
|
|
controller.close();
|
|
},
|
|
});
|
|
const response = new Response(body, {
|
|
status: 200,
|
|
headers: { "content-length": "50", "content-type": "application/octet-stream" },
|
|
});
|
|
await expectDownloadToRejectForResponse(response);
|
|
});
|
|
|
|
it("rejects when streamed payload exceeds max bytes", async () => {
|
|
const chunks = [new Uint8Array(6), new Uint8Array(6)];
|
|
let index = 0;
|
|
const body = new ReadableStream({
|
|
pull(controller) {
|
|
if (index < chunks.length) {
|
|
controller.enqueue(chunks[index++]);
|
|
} else {
|
|
controller.close();
|
|
}
|
|
},
|
|
});
|
|
const response = new Response(body, {
|
|
status: 200,
|
|
headers: { "content-type": "application/octet-stream" },
|
|
});
|
|
await expectDownloadToRejectForResponse(response);
|
|
});
|
|
});
|
|
|
|
describe("sendGoogleChatMessage", () => {
|
|
afterEach(() => {
|
|
authTesting.resetGoogleChatAuthForTests();
|
|
mocks.fetchWithSsrFGuard.mockClear();
|
|
vi.unstubAllGlobals();
|
|
});
|
|
|
|
it("adds messageReplyOption when sending to an existing thread", async () => {
|
|
const fetchMock = stubSuccessfulSend("spaces/AAA/messages/123");
|
|
|
|
await sendGoogleChatMessage({
|
|
account,
|
|
space: "spaces/AAA",
|
|
text: "hello",
|
|
thread: "spaces/AAA/threads/xyz",
|
|
});
|
|
|
|
const [url, init] = fetchMock.mock.calls[0] ?? [];
|
|
expect(String(url)).toContain("messageReplyOption=REPLY_MESSAGE_FALLBACK_TO_NEW_THREAD");
|
|
expect(JSON.parse(String(init?.body))).toMatchObject({
|
|
text: "hello",
|
|
thread: { name: "spaces/AAA/threads/xyz" },
|
|
});
|
|
});
|
|
|
|
it("does not set messageReplyOption for non-thread sends", async () => {
|
|
const fetchMock = stubSuccessfulSend("spaces/AAA/messages/124");
|
|
|
|
await sendGoogleChatMessage({
|
|
account,
|
|
space: "spaces/AAA",
|
|
text: "hello",
|
|
});
|
|
|
|
const [url] = fetchMock.mock.calls[0] ?? [];
|
|
expect(String(url)).not.toContain("messageReplyOption=");
|
|
});
|
|
});
|
|
|
|
function mockTicket(payload: Record<string, unknown>) {
|
|
mocks.verifyIdToken.mockResolvedValue({
|
|
getPayload: () => payload,
|
|
});
|
|
}
|
|
|
|
describe("verifyGoogleChatRequest", () => {
|
|
afterEach(() => {
|
|
authTesting.resetGoogleChatAuthForTests();
|
|
mocks.getAccessToken.mockClear();
|
|
mocks.gaxiosCtor.mockClear();
|
|
mocks.googleAuthCtor.mockClear();
|
|
mocks.oauthCtor.mockClear();
|
|
});
|
|
|
|
it("injects a scoped transporter into GoogleAuth access-token clients", async () => {
|
|
await expect(
|
|
getGoogleChatAccessToken({
|
|
...account,
|
|
credentials: {
|
|
auth_provider_x509_cert_url: "https://www.googleapis.com/oauth2/v1/certs",
|
|
auth_uri: "https://accounts.google.com/o/oauth2/auth",
|
|
client_email: "bot@example.iam.gserviceaccount.com",
|
|
private_key: "key",
|
|
token_uri: "https://oauth2.googleapis.com/token",
|
|
type: "service_account",
|
|
universe_domain: "googleapis.com",
|
|
},
|
|
}),
|
|
).resolves.toBe("access-token");
|
|
|
|
const googleAuthOptions = mocks.googleAuthCtor.mock.calls[0]?.[0] as {
|
|
clientOptions?: { transporter?: { defaults?: { fetchImplementation?: unknown } } };
|
|
credentials?: { client_email?: string; token_uri?: string };
|
|
};
|
|
|
|
expect(mocks.gaxiosCtor).toHaveBeenCalledOnce();
|
|
expect(googleAuthOptions).toMatchObject({
|
|
clientOptions: {
|
|
transporter: {
|
|
defaults: {
|
|
fetchImplementation: expect.any(Function),
|
|
},
|
|
},
|
|
},
|
|
credentials: {
|
|
client_email: "bot@example.iam.gserviceaccount.com",
|
|
token_uri: "https://oauth2.googleapis.com/token",
|
|
},
|
|
});
|
|
expect(mocks.getAccessToken).toHaveBeenCalledOnce();
|
|
expect("window" in globalThis).toBe(false);
|
|
});
|
|
|
|
it("accepts Google Chat app-url tokens from the Chat issuer", async () => {
|
|
mocks.verifyIdToken.mockReset();
|
|
mockTicket({
|
|
email: "chat@system.gserviceaccount.com",
|
|
email_verified: true,
|
|
});
|
|
|
|
await expect(
|
|
verifyGoogleChatRequest({
|
|
bearer: "token",
|
|
audienceType: "app-url",
|
|
audience: "https://example.com/googlechat",
|
|
}),
|
|
).resolves.toEqual({ ok: true });
|
|
|
|
const oauthOptions = mocks.oauthCtor.mock.calls[0]?.[0] as {
|
|
transporter?: { defaults?: { fetchImplementation?: unknown } };
|
|
};
|
|
expect(oauthOptions).toMatchObject({
|
|
transporter: {
|
|
defaults: {
|
|
fetchImplementation: expect.any(Function),
|
|
},
|
|
},
|
|
});
|
|
});
|
|
|
|
it("rejects add-on tokens when no principal binding is configured", async () => {
|
|
mocks.verifyIdToken.mockReset();
|
|
mockTicket({
|
|
email: "service-123@gcp-sa-gsuiteaddons.iam.gserviceaccount.com",
|
|
email_verified: true,
|
|
sub: "principal-1",
|
|
});
|
|
|
|
await expect(
|
|
verifyGoogleChatRequest({
|
|
bearer: "token",
|
|
audienceType: "app-url",
|
|
audience: "https://example.com/googlechat",
|
|
}),
|
|
).resolves.toEqual({
|
|
ok: false,
|
|
reason: "missing add-on principal binding",
|
|
});
|
|
});
|
|
|
|
it("accepts add-on tokens only when the bound principal matches", async () => {
|
|
mocks.verifyIdToken.mockReset();
|
|
mockTicket({
|
|
email: "service-123@gcp-sa-gsuiteaddons.iam.gserviceaccount.com",
|
|
email_verified: true,
|
|
sub: "principal-1",
|
|
});
|
|
|
|
await expect(
|
|
verifyGoogleChatRequest({
|
|
bearer: "token",
|
|
audienceType: "app-url",
|
|
audience: "https://example.com/googlechat",
|
|
expectedAddOnPrincipal: "principal-1",
|
|
}),
|
|
).resolves.toEqual({ ok: true });
|
|
});
|
|
|
|
it("rejects add-on tokens when the bound principal does not match", async () => {
|
|
mocks.verifyIdToken.mockReset();
|
|
mockTicket({
|
|
email: "service-123@gcp-sa-gsuiteaddons.iam.gserviceaccount.com",
|
|
email_verified: true,
|
|
sub: "principal-2",
|
|
});
|
|
|
|
await expect(
|
|
verifyGoogleChatRequest({
|
|
bearer: "token",
|
|
audienceType: "app-url",
|
|
audience: "https://example.com/googlechat",
|
|
expectedAddOnPrincipal: "principal-1",
|
|
}),
|
|
).resolves.toEqual({
|
|
ok: false,
|
|
reason: "unexpected add-on principal: principal-2",
|
|
});
|
|
});
|
|
|
|
it("fetches Chat certs through the guarded fetch for project-number tokens", async () => {
|
|
const release = vi.fn();
|
|
mocks.fetchWithSsrFGuard.mockClear();
|
|
mocks.fetchWithSsrFGuard.mockResolvedValueOnce({
|
|
response: new Response(JSON.stringify({ "kid-1": "cert-body" }), { status: 200 }),
|
|
release,
|
|
});
|
|
mocks.verifySignedJwtWithCertsAsync.mockReset().mockResolvedValue(undefined);
|
|
|
|
await expect(
|
|
verifyGoogleChatRequest({
|
|
bearer: "token",
|
|
audienceType: "project-number",
|
|
audience: "123456789",
|
|
}),
|
|
).resolves.toEqual({ ok: true });
|
|
|
|
expect(mocks.fetchWithSsrFGuard).toHaveBeenCalledWith({
|
|
url: "https://www.googleapis.com/service_accounts/v1/metadata/x509/chat@system.gserviceaccount.com",
|
|
auditContext: "googlechat.auth.certs",
|
|
});
|
|
expect(mocks.verifySignedJwtWithCertsAsync).toHaveBeenCalledWith(
|
|
"token",
|
|
{ "kid-1": "cert-body" },
|
|
"123456789",
|
|
["chat@system.gserviceaccount.com"],
|
|
);
|
|
expect(release).toHaveBeenCalledOnce();
|
|
});
|
|
});
|