Files
openclaw/extensions/qa-lab/src/codex-plugin-lifecycle.test.ts
Peter Steinberger bb46b79d3c refactor: internalize OpenClaw agent runtime (#85341)
* refactor: extract agent core package

Introduce packages/agent-core as the OpenClaw-owned home for reusable agent loop, harness, session, prompt, and runtime dependency contracts.

* refactor: extract shared llm runtime

Move provider model registries, stream wrappers, OAuth helpers, and LLM utilities into src/llm with plugin-sdk barrels instead of depending on the old embedded runtime layout.

* refactor: remove pi runtime internals

Rename remaining Pi-shaped agent surfaces to OpenClaw agent runtime names, delete obsolete Pi docs and package graph checks, and add the third-party notice for incorporated code.

* refactor: tighten agent session runtime

Make agent-core/runtime dependencies explicit, consolidate compaction and session transcript helpers, and move model/session helpers behind OpenClaw-owned contracts.

* refactor: remove static model and pi auth paths

Drop static model catalogs and Pi auth bridges, move model/provider facts to manifest-owned runtime contracts, and harden internal embedded-agent utilities.

* refactor: remove legacy provider compat paths

* docs: remove agent parity notes

* fix: skip provider wildcard metadata parsing

* refactor: share session extension sdk loading

* refactor: inline acpx proxy error formatter

* refactor: fold edit recovery into edit tool

* fix: accept extension batch separator

* test: align startup provider plugin expectations

* fix: restore provider-scoped release discovery

* test: align static asset packaging expectations

* fix: run static provider catalogs during scoped discovery

* fix: add provider entry catalogs for scoped live discovery

* fix: load lightweight provider catalog entries

* fix: refresh provider-scoped plugin metadata

* fix: keep provider catalog entries on release live path

* fix: keep static manifest models in release live checks

* fix: harden release model discovery

* fix: reduce OpenAI live cache probe reasoning

* fix: disable OpenAI cache probe reasoning

* ci: extend OpenAI gateway live timeout

* fix: extend live gateway model budget

* fix: stabilize release validation regressions

* fix: honor provider aliases in model rows

* fix: stabilize release validation lanes

* fix: stabilize release memory qa

* ci: stabilize release validation lanes

* ci: prefer ipv4 for live docker node calls

* fix: restore shared tool-call stream wrapper

* ci: remove legacy pi test shard alias

* fix: clean up embedded agent test drift

* fix: stabilize runtime alias status

* fix: clean up embedded agent ci drift

* fix: restore release ci invariants

* fix: clean up post-rebase runtime drift

* fix: restore release ci checks

* fix: restore release ci after rebase

* fix: remove stale pi runtime path

* test: align compaction runtime expectations

* test: update plugin prerelease expectations

* fix: handle claude live tool approvals

* fix: stabilize release validation gates

* fix: finish agent runtime import

* test: finish post-rebase agent runtime mocks

* fix: keep codex compaction native

* fix: stabilize codex app-server hook tests

* test: isolate codex diagnostic active run

* test: remove codex diagnostic completion race

# Conflicts:
#	extensions/codex/src/app-server/run-attempt.test.ts

* ci: fix full release manifest performance run id

* refactor: narrow llm plugin sdk boundary

* chore: drop generated google boundary stamps

* fix: repair rebase fallout

* fix: clean up rebased runtime references

* fix: decode codex jwt payloads as base64url

* fix: preserve shipped pi runtime alias

* fix: add scoped sdk virtual modules

* fix: decode llm codex oauth jwt as base64url

* fix: avoid stale vertex adc negative cache

* fix: harden tool arg decoding and codeql path

* fix: keep vertex adc negative checks live

* refactor: consolidate codex jwt and edit helpers

* fix: await codex oauth node runtime imports

* fix: preserve sdk tool and notice contracts

* fix: preserve shipped compat config boundaries

* fix: align codex oauth callback host

* fix: terminate agent-core loop streams on failure

* fix: keep codex oauth callback alive during fallback

* ci: include session tools in critical codeql scans

* fix: keep Cloudflare Anthropic provider auth header

* docs: redirect legacy pi runtime pages

* fix: honor bundled web provider compat discovery

* fix: protect session output spill files

* fix: keep legacy agent dir env blocked

* fix: contain auto-discovered skill symlinks

* fix: harden agent core sdk proxy surfaces

* fix: restore approval reaction sdk compat

* fix: keep live docker runs bounded

* fix: keep codex oauth redirect host aligned

* fix: resolve post-rebase agent runtime drift

* fix: redact anthropic oauth parse failures

* fix: preserve responses strict tool shaping

* fix: repair agent runtime rebase cleanup

* docs: redirect retired parity pages

* fix: bound auto-discovered resources to roots

* fix: repair post-rebase agent test drift

* fix: preserve bundled provider allowlist migration

* fix: preserve manifest-owned provider aliases

* fix: declare photon image dependency

* fix: keep provider headers out of proxy body

* fix: preserve shipped env aliases

* fix: refresh control ui i18n generated state

* fix: quote read fallback paths

* fix: preview edits through configured backend

* test: satisfy core test typecheck

* fix: preserve ZAI usage auth fallback

* test: repair codex diagnostic test

* fix: repair agent runtime rebase drift

* test: finish embedded runner import rename

* fix: repair agent runtime rebase integrations

* test: align compaction oauth fallback expectations

* fix: allow sdk-auth session models

* fix: update doctor tool schema import

* fix: preserve bedrock plugin region

* fix: stream harmony-like prose immediately

* ci: include session runtime in codeql shards

* fix: repair latest rebase integrations

* fix: honor explicit codex websocket transport

* fix: keep openai-compatible credentials provider-scoped

* fix: refresh sdk api baseline after rebase

* fix: route cli runtime aliases through openclaw harness

* test: rename stale harness mock expectation

* test: rename embedded agent overflow calls

* test: clean embedded auth test wording

* test: use openclaw stream types in deepinfra cache test

* fix: refresh sdk api baseline on latest main

* fix: honor bundled discovery compat allowlists

* fix: refresh sdk api baseline after latest rebase

* fix: remove stale rebase imports

* test: rename stale model catalog mock

* test: mock renamed doctor runtime modules

* fix: map canonical kimi env auth

* fix: use internal model registry in bench script

* fix: migrate deepinfra provider catalog entry

* fix: enforce builtin tool suppression

* fix: route compaction auth and proxy payloads safely

* refactor: prune unused llm registry leftovers

* test: update codex hooks session import

* test: fix model picker ci coverage

* test: align model picker auth mock types
2026-05-27 19:24:04 +01:00

191 lines
6.9 KiB
TypeScript

import fs from "node:fs/promises";
import path from "node:path";
import { afterEach, describe, expect, it } from "vitest";
import {
QA_CODEX_OAUTH_PROFILE_ID,
QA_OPENAI_API_KEY_PROFILE_ID,
resolveCodexAuthProfile,
seedAuthProfiles,
snapshotAuthProfiles,
} from "./auth-profile.fixture.js";
import {
CODEX_PLUGIN_CURRENT_VERSION,
CODEX_PLUGIN_LIFECYCLE_MESSAGES,
createCodexPluginInstallGate,
evaluateCodexPluginLifecycle,
seedCodexPluginAt,
snapshotCodexPluginState,
} from "./codex-plugin.fixture.js";
import { createTempDirHarness } from "./temp-dir.test-helper.js";
const tempDirs = createTempDirHarness();
async function createAgentDir(prefix: string) {
const root = await tempDirs.makeTempDir(prefix);
const agentDir = path.join(root, "agents", "qa", "agent");
await fs.mkdir(agentDir, { recursive: true });
return agentDir;
}
afterEach(async () => {
await tempDirs.cleanup();
});
describe("codex plugin lifecycle: cold install", () => {
it("repairs a missing codex plugin before the retry succeeds without leaking to the API-key path", async () => {
const agentDir = await createAgentDir("qa-codex-plugin-cold-");
await seedCodexPluginAt("missing", agentDir);
await seedAuthProfiles("mixed", agentDir);
const missing = evaluateCodexPluginLifecycle({
plugin: await snapshotCodexPluginState(agentDir),
auth: await snapshotAuthProfiles(agentDir),
hostVersion: CODEX_PLUGIN_CURRENT_VERSION,
});
expect(missing.status).toBe("repair-required");
expect(missing.remediation).toBe(CODEX_PLUGIN_LIFECYCLE_MESSAGES.missingPlugin);
expect(missing.selectedAuthProfileId).toBe(QA_CODEX_OAUTH_PROFILE_ID);
expect(missing.selectedAuthProfileId).not.toBe(QA_OPENAI_API_KEY_PROFILE_ID);
await seedCodexPluginAt("current", agentDir);
const repaired = evaluateCodexPluginLifecycle({
plugin: await snapshotCodexPluginState(agentDir),
auth: await snapshotAuthProfiles(agentDir),
hostVersion: CODEX_PLUGIN_CURRENT_VERSION,
});
expect(repaired.status).toBe("ready");
expect(repaired.remediation).toBeUndefined();
expect(repaired.tokenRoute).toBe("codex-oauth");
});
});
describe("codex plugin lifecycle: OAuth-only with mixed profiles", () => {
it("selects openai-codex OAuth when openai API-key profiles are present", async () => {
const agentDir = await createAgentDir("qa-codex-auth-mixed-");
await seedAuthProfiles("mixed", agentDir);
const selection = resolveCodexAuthProfile(await snapshotAuthProfiles(agentDir));
expect(selection.status).toBe("ready");
if (selection.status !== "ready") {
throw new Error(selection.remediation);
}
expect(selection.profileId).toBe(QA_CODEX_OAUTH_PROFILE_ID);
expect(selection.profileId).not.toBe(QA_OPENAI_API_KEY_PROFILE_ID);
expect(selection.provider).toBe("openai-codex");
expect(selection.mode).toBe("oauth");
});
});
describe("codex plugin lifecycle: pinned-old codex plugin with new OpenClaw", () => {
it("blocks with a precise update remediation when the plugin is older than the host", async () => {
const agentDir = await createAgentDir("qa-codex-plugin-old-");
await seedCodexPluginAt("2026.5.19", agentDir);
await seedAuthProfiles("oauth-only", agentDir);
const result = evaluateCodexPluginLifecycle({
plugin: await snapshotCodexPluginState(agentDir),
auth: await snapshotAuthProfiles(agentDir),
hostVersion: "2026.5.21",
});
expect(result.status).toBe("blocked");
expect(result.remediation).toBe(
'Codex plugin version 2026.5.19 is older than OpenClaw 2026.5.21. Run "openclaw plugins update codex" or unpin codex, then rerun "openclaw doctor --fix".',
);
});
});
describe("codex plugin lifecycle: pinned-new codex plugin with old OpenClaw", () => {
it("blocks with a precise host-upgrade remediation when the plugin is newer than the host", async () => {
const agentDir = await createAgentDir("qa-codex-plugin-new-");
await seedCodexPluginAt("2026.5.22", agentDir);
await seedAuthProfiles("oauth-only", agentDir);
const result = evaluateCodexPluginLifecycle({
plugin: await snapshotCodexPluginState(agentDir),
auth: await snapshotAuthProfiles(agentDir),
hostVersion: "2026.5.21",
});
expect(result.status).toBe("blocked");
expect(result.remediation).toBe(
"Codex plugin version 2026.5.22 requires a newer OpenClaw host than 2026.5.21. Upgrade OpenClaw or install a codex plugin version pinned to 2026.5.21.",
);
});
});
describe("codex plugin lifecycle: install racing first agent turn", () => {
it("gates the first turn on install completion without sleeps, lost tokens, or duplicate responses", async () => {
const gate = createCodexPluginInstallGate();
const turn = gate.runFirstTurnAfterInstall({
inputTokens: 17,
run: () => "QA_CODEX_PLUGIN_TURN_OK",
});
expect(gate.events).toEqual(["agent-turn:waiting-for-codex-plugin"]);
gate.markInstalled();
await expect(turn).resolves.toEqual({
text: "QA_CODEX_PLUGIN_TURN_OK",
inputTokens: 17,
responseCount: 1,
});
expect(gate.events).toEqual([
"agent-turn:waiting-for-codex-plugin",
"codex-plugin:installed",
"agent-turn:started",
"agent-turn:completed",
]);
});
});
describe("codex plugin lifecycle: doctor migration safety matrix", () => {
it.each([
{
name: "oauth-only host",
profileShape: "oauth-only" as const,
config: {},
},
{
name: "mixed profile with no pin",
profileShape: "mixed" as const,
config: {},
},
{
name: "mixed profile with defaults OpenClaw pin",
profileShape: "mixed" as const,
config: { agents: { defaults: { agentRuntime: { id: "openclaw" } } } },
expectedRemovedRuntimePins: ["agentRuntime.id=openclaw"],
},
{
name: "mixed profile with main-agent OpenClaw pin",
profileShape: "mixed" as const,
config: { agents: { list: { main: { agentRuntime: { id: "openclaw" } } } } },
expectedRemovedRuntimePins: ["agentRuntime.id=openclaw"],
},
])(
"keeps codex auth and strips stale OpenClaw runtime pins for $name",
async ({ profileShape, config, expectedRemovedRuntimePins = [] }) => {
const agentDir = await createAgentDir("qa-codex-doctor-matrix-");
await seedCodexPluginAt("current", agentDir);
await seedAuthProfiles(profileShape, agentDir);
const result = evaluateCodexPluginLifecycle({
plugin: await snapshotCodexPluginState(agentDir),
auth: await snapshotAuthProfiles(agentDir),
hostVersion: CODEX_PLUGIN_CURRENT_VERSION,
config,
doctorFix: true,
});
expect(result.status).toBe("ready");
expect(result.selectedAuthProfileId).toBe(QA_CODEX_OAUTH_PROFILE_ID);
expect(result.tokenRoute).toBe("codex-oauth");
expect(result.removedRuntimePins).toEqual(expectedRemovedRuntimePins);
},
);
});