mirror of
https://github.com/openclaw/openclaw.git
synced 2026-06-07 00:02:53 +00:00
Fix Codex app-server native thread overflow recovery and CLI compaction fallback.
- rotate Codex native startup bindings when rollout token pressure leaves too little headroom
- keep byte-size rollout fuses ahead of rollout content reads
- clear stale resumed context-engine bindings only when the stored thread id still matches
- fall back to context-engine compaction when Codex owns/skips native compaction
Verification:
- node scripts/run-vitest.mjs run --config test/vitest/vitest.extension-codex.config.ts extensions/codex/src/app-server/startup-binding.test.ts extensions/codex/src/app-server/run-attempt.context-engine.test.ts extensions/codex/src/app-server/session-binding.test.ts --reporter=verbose
- node scripts/run-vitest.mjs run --config test/vitest/vitest.agents.config.ts src/agents/command/cli-compaction.test.ts --reporter=verbose
- git diff --check origin/main...HEAD
- autoreview --mode branch --base origin/main: clean
- GitHub CI for 466bfbe78c: green
Co-authored-by: fuller-stack-dev <263060202+fuller-stack-dev@users.noreply.github.com>
538 lines
18 KiB
TypeScript
538 lines
18 KiB
TypeScript
import fs from "node:fs/promises";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { readCodexAppServerBinding, writeCodexAppServerBinding } from "./session-binding.js";
|
|
import { rotateOversizedCodexAppServerStartupBinding } from "./startup-binding.js";
|
|
|
|
describe("Codex app-server startup binding", () => {
|
|
let tempDir: string;
|
|
|
|
beforeEach(async () => {
|
|
tempDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-codex-startup-binding-"));
|
|
});
|
|
|
|
afterEach(async () => {
|
|
vi.restoreAllMocks();
|
|
await fs.rm(tempDir, { recursive: true, force: true });
|
|
});
|
|
|
|
async function writeExistingBinding(
|
|
sessionFile: string,
|
|
workspaceDir: string,
|
|
overrides: Partial<Parameters<typeof writeCodexAppServerBinding>[1]> = {},
|
|
) {
|
|
await writeCodexAppServerBinding(sessionFile, {
|
|
threadId: "thread-existing",
|
|
cwd: workspaceDir,
|
|
model: "gpt-5.4-codex",
|
|
modelProvider: "openai",
|
|
...overrides,
|
|
});
|
|
}
|
|
|
|
async function writeSessionRecord(sessionFile: string, record: Record<string, unknown>) {
|
|
await fs.mkdir(path.dirname(sessionFile), { recursive: true });
|
|
await fs.writeFile(
|
|
path.join(path.dirname(sessionFile), "sessions.json"),
|
|
JSON.stringify({
|
|
"agent:main:session-1": {
|
|
sessionFile,
|
|
...record,
|
|
},
|
|
}),
|
|
);
|
|
}
|
|
|
|
it("does not use a default byte limit when maxActiveTranscriptBytes is unset", async () => {
|
|
const sessionFile = path.join(tempDir, "session.jsonl");
|
|
const workspaceDir = path.join(tempDir, "workspace");
|
|
const agentDir = path.join(tempDir, "agent");
|
|
await writeExistingBinding(sessionFile, workspaceDir, { dynamicToolsFingerprint: "[]" });
|
|
await writeSessionRecord(sessionFile, { totalTokens: 12_000 });
|
|
const rolloutDir = path.join(agentDir, "codex-home", "sessions");
|
|
await fs.mkdir(rolloutDir, { recursive: true });
|
|
await fs.writeFile(
|
|
path.join(rolloutDir, "rollout-thread-existing.jsonl"),
|
|
"x".repeat(2_000_000),
|
|
);
|
|
|
|
const binding = await rotateOversizedCodexAppServerStartupBinding({
|
|
binding: await readCodexAppServerBinding(sessionFile),
|
|
sessionFile,
|
|
agentDir,
|
|
config: {
|
|
agents: {
|
|
defaults: {
|
|
compaction: {
|
|
truncateAfterCompaction: true,
|
|
},
|
|
},
|
|
},
|
|
} as never,
|
|
});
|
|
|
|
expect(binding?.threadId).toBe("thread-existing");
|
|
const savedBinding = await readCodexAppServerBinding(sessionFile);
|
|
expect(savedBinding?.threadId).toBe("thread-existing");
|
|
});
|
|
|
|
it("checks native rollout token pressure under default compaction config", async () => {
|
|
const sessionFile = path.join(tempDir, "session.jsonl");
|
|
const workspaceDir = path.join(tempDir, "workspace");
|
|
const agentDir = path.join(tempDir, "agent");
|
|
await writeExistingBinding(sessionFile, workspaceDir, { dynamicToolsFingerprint: "[]" });
|
|
await writeSessionRecord(sessionFile, { totalTokens: 12_000 });
|
|
const rolloutDir = path.join(agentDir, "codex-home", "sessions");
|
|
await fs.mkdir(rolloutDir, { recursive: true });
|
|
await fs.writeFile(
|
|
path.join(rolloutDir, "rollout-thread-existing.jsonl"),
|
|
`${JSON.stringify({
|
|
payload: {
|
|
type: "token_count",
|
|
info: {
|
|
last_token_usage: {
|
|
total_tokens: 241_198,
|
|
},
|
|
model_context_window: 258_400,
|
|
},
|
|
},
|
|
})}\n`,
|
|
);
|
|
|
|
const binding = await rotateOversizedCodexAppServerStartupBinding({
|
|
binding: await readCodexAppServerBinding(sessionFile),
|
|
sessionFile,
|
|
agentDir,
|
|
config: undefined,
|
|
});
|
|
|
|
expect(binding).toBeUndefined();
|
|
const savedBinding = await readCodexAppServerBinding(sessionFile);
|
|
expect(savedBinding).toBeUndefined();
|
|
});
|
|
|
|
it("caps the default native reserve so small context windows keep prompt budget", async () => {
|
|
const sessionFile = path.join(tempDir, "session.jsonl");
|
|
const workspaceDir = path.join(tempDir, "workspace");
|
|
const agentDir = path.join(tempDir, "agent");
|
|
await writeExistingBinding(sessionFile, workspaceDir, { dynamicToolsFingerprint: "[]" });
|
|
await writeSessionRecord(sessionFile, { totalTokens: 100 });
|
|
const rolloutDir = path.join(agentDir, "codex-home", "sessions");
|
|
await fs.mkdir(rolloutDir, { recursive: true });
|
|
await fs.writeFile(
|
|
path.join(rolloutDir, "rollout-thread-existing.jsonl"),
|
|
`${JSON.stringify({
|
|
payload: {
|
|
type: "token_count",
|
|
info: {
|
|
last_token_usage: {
|
|
total_tokens: 100,
|
|
},
|
|
model_context_window: 16_000,
|
|
},
|
|
},
|
|
})}\n`,
|
|
);
|
|
|
|
const binding = await rotateOversizedCodexAppServerStartupBinding({
|
|
binding: await readCodexAppServerBinding(sessionFile),
|
|
sessionFile,
|
|
agentDir,
|
|
config: undefined,
|
|
});
|
|
|
|
expect(binding?.threadId).toBe("thread-existing");
|
|
const savedBinding = await readCodexAppServerBinding(sessionFile);
|
|
expect(savedBinding?.threadId).toBe("thread-existing");
|
|
});
|
|
|
|
it("honors shorthand byte units for native rollout limits", async () => {
|
|
const sessionFile = path.join(tempDir, "session.jsonl");
|
|
const workspaceDir = path.join(tempDir, "workspace");
|
|
const agentDir = path.join(tempDir, "agent");
|
|
await writeExistingBinding(sessionFile, workspaceDir, { dynamicToolsFingerprint: "[]" });
|
|
await writeSessionRecord(sessionFile, { totalTokens: 12_000 });
|
|
const rolloutDir = path.join(agentDir, "codex-home", "sessions");
|
|
await fs.mkdir(rolloutDir, { recursive: true });
|
|
await fs.writeFile(path.join(rolloutDir, "rollout-thread-existing.jsonl"), "x".repeat(2_000));
|
|
|
|
const binding = await rotateOversizedCodexAppServerStartupBinding({
|
|
binding: await readCodexAppServerBinding(sessionFile),
|
|
sessionFile,
|
|
agentDir,
|
|
config: {
|
|
agents: {
|
|
defaults: {
|
|
compaction: {
|
|
truncateAfterCompaction: true,
|
|
maxActiveTranscriptBytes: "1k",
|
|
},
|
|
},
|
|
},
|
|
} as never,
|
|
});
|
|
|
|
expect(binding).toBeUndefined();
|
|
const savedBinding = await readCodexAppServerBinding(sessionFile);
|
|
expect(savedBinding).toBeUndefined();
|
|
});
|
|
|
|
it("honors custom Codex home rollout files for native rollout limits", async () => {
|
|
const sessionFile = path.join(tempDir, "session.jsonl");
|
|
const workspaceDir = path.join(tempDir, "workspace");
|
|
const agentDir = path.join(tempDir, "agent");
|
|
const codexHome = path.join(tempDir, "custom-codex-home");
|
|
await writeExistingBinding(sessionFile, workspaceDir, { dynamicToolsFingerprint: "[]" });
|
|
await writeSessionRecord(sessionFile, { totalTokens: 12_000 });
|
|
const rolloutDir = path.join(codexHome, "sessions");
|
|
await fs.mkdir(rolloutDir, { recursive: true });
|
|
await fs.writeFile(path.join(rolloutDir, "rollout-thread-existing.jsonl"), "x".repeat(2_000));
|
|
|
|
const binding = await rotateOversizedCodexAppServerStartupBinding({
|
|
binding: await readCodexAppServerBinding(sessionFile),
|
|
sessionFile,
|
|
agentDir,
|
|
codexHome,
|
|
config: {
|
|
agents: {
|
|
defaults: {
|
|
compaction: {
|
|
truncateAfterCompaction: true,
|
|
maxActiveTranscriptBytes: 1_000,
|
|
},
|
|
},
|
|
},
|
|
} as never,
|
|
});
|
|
|
|
expect(binding).toBeUndefined();
|
|
const savedBinding = await readCodexAppServerBinding(sessionFile);
|
|
expect(savedBinding).toBeUndefined();
|
|
});
|
|
|
|
it("uses current rollout token usage before cumulative usage", async () => {
|
|
const sessionFile = path.join(tempDir, "session.jsonl");
|
|
const workspaceDir = path.join(tempDir, "workspace");
|
|
const agentDir = path.join(tempDir, "agent");
|
|
await writeExistingBinding(sessionFile, workspaceDir, { dynamicToolsFingerprint: "[]" });
|
|
await writeSessionRecord(sessionFile, { totalTokens: 12_000 });
|
|
const rolloutDir = path.join(agentDir, "codex-home", "sessions");
|
|
await fs.mkdir(rolloutDir, { recursive: true });
|
|
await fs.writeFile(
|
|
path.join(rolloutDir, "rollout-thread-existing.jsonl"),
|
|
`${JSON.stringify({
|
|
payload: {
|
|
type: "token_count",
|
|
info: {
|
|
total_token_usage: {
|
|
total_tokens: 300_000,
|
|
},
|
|
last_token_usage: {
|
|
total_tokens: 12_000,
|
|
},
|
|
},
|
|
},
|
|
})}\n`,
|
|
);
|
|
|
|
const binding = await rotateOversizedCodexAppServerStartupBinding({
|
|
binding: await readCodexAppServerBinding(sessionFile),
|
|
sessionFile,
|
|
agentDir,
|
|
config: {
|
|
agents: {
|
|
defaults: {
|
|
compaction: {
|
|
truncateAfterCompaction: true,
|
|
maxActiveTranscriptBytes: "1mb",
|
|
},
|
|
},
|
|
},
|
|
} as never,
|
|
});
|
|
|
|
expect(binding?.threadId).toBe("thread-existing");
|
|
const savedBinding = await readCodexAppServerBinding(sessionFile);
|
|
expect(savedBinding?.threadId).toBe("thread-existing");
|
|
});
|
|
|
|
it("ignores stale session token totals for native rollout rotation", async () => {
|
|
const sessionFile = path.join(tempDir, "session.jsonl");
|
|
const workspaceDir = path.join(tempDir, "workspace");
|
|
const agentDir = path.join(tempDir, "agent");
|
|
await writeExistingBinding(sessionFile, workspaceDir, { dynamicToolsFingerprint: "[]" });
|
|
await writeSessionRecord(sessionFile, {
|
|
totalTokens: 300_000,
|
|
totalTokensFresh: false,
|
|
});
|
|
const rolloutDir = path.join(agentDir, "codex-home", "sessions");
|
|
await fs.mkdir(rolloutDir, { recursive: true });
|
|
await fs.writeFile(
|
|
path.join(rolloutDir, "rollout-thread-existing.jsonl"),
|
|
`${JSON.stringify({
|
|
payload: {
|
|
type: "token_count",
|
|
info: {
|
|
last_token_usage: {
|
|
total_tokens: 12_000,
|
|
},
|
|
},
|
|
},
|
|
})}\n`,
|
|
);
|
|
|
|
const binding = await rotateOversizedCodexAppServerStartupBinding({
|
|
binding: await readCodexAppServerBinding(sessionFile),
|
|
sessionFile,
|
|
agentDir,
|
|
config: {
|
|
agents: {
|
|
defaults: {
|
|
compaction: {
|
|
truncateAfterCompaction: true,
|
|
maxActiveTranscriptBytes: "1mb",
|
|
},
|
|
},
|
|
},
|
|
} as never,
|
|
});
|
|
|
|
expect(binding?.threadId).toBe("thread-existing");
|
|
const savedBinding = await readCodexAppServerBinding(sessionFile);
|
|
expect(savedBinding?.threadId).toBe("thread-existing");
|
|
});
|
|
|
|
it("clears native rollouts at Codex's reported model context window", async () => {
|
|
const sessionFile = path.join(tempDir, "session.jsonl");
|
|
const workspaceDir = path.join(tempDir, "workspace");
|
|
const agentDir = path.join(tempDir, "agent");
|
|
await writeExistingBinding(sessionFile, workspaceDir, { dynamicToolsFingerprint: "[]" });
|
|
await writeSessionRecord(sessionFile, { totalTokens: 12_000 });
|
|
const rolloutDir = path.join(agentDir, "codex-home", "sessions");
|
|
await fs.mkdir(rolloutDir, { recursive: true });
|
|
const rolloutFile = path.join(rolloutDir, "rollout-thread-existing.jsonl");
|
|
await fs.writeFile(
|
|
rolloutFile,
|
|
[
|
|
JSON.stringify({
|
|
payload: {
|
|
type: "token_count",
|
|
info: {
|
|
last_token_usage: {
|
|
total_tokens: 128_000,
|
|
},
|
|
},
|
|
},
|
|
}),
|
|
JSON.stringify({
|
|
payload: {
|
|
type: "token_count",
|
|
info: {
|
|
model_context_window: 128_000,
|
|
},
|
|
},
|
|
}),
|
|
].join("\n") + "\n",
|
|
);
|
|
const binding = await rotateOversizedCodexAppServerStartupBinding({
|
|
binding: await readCodexAppServerBinding(sessionFile),
|
|
sessionFile,
|
|
agentDir,
|
|
config: {
|
|
agents: {
|
|
defaults: {
|
|
compaction: {
|
|
truncateAfterCompaction: true,
|
|
maxActiveTranscriptBytes: "1mb",
|
|
},
|
|
},
|
|
},
|
|
} as never,
|
|
});
|
|
|
|
expect(binding).toBeUndefined();
|
|
const savedBinding = await readCodexAppServerBinding(sessionFile);
|
|
expect(savedBinding).toBeUndefined();
|
|
});
|
|
|
|
it("keeps native rollouts above the old guard when Codex still has context window headroom", async () => {
|
|
const sessionFile = path.join(tempDir, "session.jsonl");
|
|
const workspaceDir = path.join(tempDir, "workspace");
|
|
const agentDir = path.join(tempDir, "agent");
|
|
await writeExistingBinding(sessionFile, workspaceDir, { dynamicToolsFingerprint: "[]" });
|
|
await writeSessionRecord(sessionFile, { totalTokens: 12_000 });
|
|
const rolloutDir = path.join(agentDir, "codex-home", "sessions");
|
|
await fs.mkdir(rolloutDir, { recursive: true });
|
|
await fs.writeFile(
|
|
path.join(rolloutDir, "rollout-thread-existing.jsonl"),
|
|
`${JSON.stringify({
|
|
payload: {
|
|
type: "token_count",
|
|
info: {
|
|
last_token_usage: {
|
|
total_tokens: 86_000,
|
|
},
|
|
model_context_window: 272_000,
|
|
},
|
|
},
|
|
})}\n`,
|
|
);
|
|
|
|
const binding = await rotateOversizedCodexAppServerStartupBinding({
|
|
binding: await readCodexAppServerBinding(sessionFile),
|
|
sessionFile,
|
|
agentDir,
|
|
config: {
|
|
agents: {
|
|
defaults: {
|
|
compaction: {
|
|
truncateAfterCompaction: true,
|
|
maxActiveTranscriptBytes: "1mb",
|
|
},
|
|
},
|
|
},
|
|
} as never,
|
|
});
|
|
|
|
expect(binding?.threadId).toBe("thread-existing");
|
|
const savedBinding = await readCodexAppServerBinding(sessionFile);
|
|
expect(savedBinding?.threadId).toBe("thread-existing");
|
|
});
|
|
|
|
it("includes projected turn tokens in the native rollout pressure check", async () => {
|
|
const sessionFile = path.join(tempDir, "session.jsonl");
|
|
const workspaceDir = path.join(tempDir, "workspace");
|
|
const agentDir = path.join(tempDir, "agent");
|
|
await writeExistingBinding(sessionFile, workspaceDir, { dynamicToolsFingerprint: "[]" });
|
|
await writeSessionRecord(sessionFile, { totalTokens: 12_000 });
|
|
const rolloutDir = path.join(agentDir, "codex-home", "sessions");
|
|
await fs.mkdir(rolloutDir, { recursive: true });
|
|
await fs.writeFile(
|
|
path.join(rolloutDir, "rollout-thread-existing.jsonl"),
|
|
`${JSON.stringify({
|
|
payload: {
|
|
type: "token_count",
|
|
info: {
|
|
last_token_usage: {
|
|
total_tokens: 220_000,
|
|
},
|
|
model_context_window: 258_400,
|
|
},
|
|
},
|
|
})}\n`,
|
|
);
|
|
|
|
const binding = await rotateOversizedCodexAppServerStartupBinding({
|
|
binding: await readCodexAppServerBinding(sessionFile),
|
|
sessionFile,
|
|
agentDir,
|
|
config: undefined,
|
|
projectedTurnTokens: 30_000,
|
|
});
|
|
|
|
expect(binding).toBeUndefined();
|
|
const savedBinding = await readCodexAppServerBinding(sessionFile);
|
|
expect(savedBinding).toBeUndefined();
|
|
});
|
|
|
|
it("uses the session context window when the native rollout omits its model window", async () => {
|
|
const sessionFile = path.join(tempDir, "session.jsonl");
|
|
const workspaceDir = path.join(tempDir, "workspace");
|
|
const agentDir = path.join(tempDir, "agent");
|
|
await writeExistingBinding(sessionFile, workspaceDir, { dynamicToolsFingerprint: "[]" });
|
|
await writeSessionRecord(sessionFile, { totalTokens: 12_000, contextTokens: 258_400 });
|
|
const rolloutDir = path.join(agentDir, "codex-home", "sessions");
|
|
await fs.mkdir(rolloutDir, { recursive: true });
|
|
await fs.writeFile(
|
|
path.join(rolloutDir, "rollout-thread-existing.jsonl"),
|
|
`${JSON.stringify({
|
|
payload: {
|
|
type: "token_count",
|
|
info: {
|
|
last_token_usage: {
|
|
total_tokens: 241_198,
|
|
},
|
|
},
|
|
},
|
|
})}\n`,
|
|
);
|
|
|
|
const binding = await rotateOversizedCodexAppServerStartupBinding({
|
|
binding: await readCodexAppServerBinding(sessionFile),
|
|
sessionFile,
|
|
agentDir,
|
|
config: undefined,
|
|
});
|
|
|
|
expect(binding).toBeUndefined();
|
|
const savedBinding = await readCodexAppServerBinding(sessionFile);
|
|
expect(savedBinding).toBeUndefined();
|
|
});
|
|
|
|
it("clears byte-oversized rollouts before reading their contents", async () => {
|
|
const sessionFile = path.join(tempDir, "session.jsonl");
|
|
const workspaceDir = path.join(tempDir, "workspace");
|
|
const agentDir = path.join(tempDir, "agent");
|
|
await writeExistingBinding(sessionFile, workspaceDir, { dynamicToolsFingerprint: "[]" });
|
|
await writeSessionRecord(sessionFile, { totalTokens: 12_000 });
|
|
const rolloutDir = path.join(agentDir, "codex-home", "sessions");
|
|
await fs.mkdir(rolloutDir, { recursive: true });
|
|
const rolloutFile = path.join(rolloutDir, "rollout-thread-existing.jsonl");
|
|
await fs.writeFile(rolloutFile, "x".repeat(2_000));
|
|
const openSpy = vi.spyOn(fs, "open");
|
|
|
|
const binding = await rotateOversizedCodexAppServerStartupBinding({
|
|
binding: await readCodexAppServerBinding(sessionFile),
|
|
sessionFile,
|
|
agentDir,
|
|
config: {
|
|
agents: {
|
|
defaults: {
|
|
compaction: {
|
|
truncateAfterCompaction: true,
|
|
maxActiveTranscriptBytes: 1_000,
|
|
},
|
|
},
|
|
},
|
|
} as never,
|
|
});
|
|
|
|
expect(binding).toBeUndefined();
|
|
expect(openSpy.mock.calls.some(([file]) => String(file) === rolloutFile)).toBe(false);
|
|
const savedBinding = await readCodexAppServerBinding(sessionFile);
|
|
expect(savedBinding).toBeUndefined();
|
|
});
|
|
|
|
it("clears native rollouts at the configured byte limit", async () => {
|
|
const sessionFile = path.join(tempDir, "session.jsonl");
|
|
const workspaceDir = path.join(tempDir, "workspace");
|
|
const agentDir = path.join(tempDir, "agent");
|
|
await writeExistingBinding(sessionFile, workspaceDir, { dynamicToolsFingerprint: "[]" });
|
|
await writeSessionRecord(sessionFile, { totalTokens: 12_000 });
|
|
const rolloutDir = path.join(agentDir, "codex-home", "sessions");
|
|
await fs.mkdir(rolloutDir, { recursive: true });
|
|
await fs.writeFile(path.join(rolloutDir, "rollout-thread-existing.jsonl"), "x".repeat(1_000));
|
|
|
|
const binding = await rotateOversizedCodexAppServerStartupBinding({
|
|
binding: await readCodexAppServerBinding(sessionFile),
|
|
sessionFile,
|
|
agentDir,
|
|
config: {
|
|
agents: {
|
|
defaults: {
|
|
compaction: {
|
|
truncateAfterCompaction: true,
|
|
maxActiveTranscriptBytes: 1_000,
|
|
},
|
|
},
|
|
},
|
|
} as never,
|
|
});
|
|
|
|
expect(binding).toBeUndefined();
|
|
const savedBinding = await readCodexAppServerBinding(sessionFile);
|
|
expect(savedBinding).toBeUndefined();
|
|
});
|
|
});
|