mirror of
https://github.com/openclaw/openclaw.git
synced 2026-05-12 23:10:43 +00:00
Fix iOS LAN/setup-code pairing policy for #47887. - Allow explicit private LAN and .local plaintext ws:// setup/manual connects where policy allows it. - Keep public hosts, .ts.net, and Tailscale CGNAT plaintext fail-closed. - Prefer explicit passwords over stale bootstrap tokens in Swift and TypeScript gateway clients. - Update setup-code/device-pair coverage, docs, and changelog with source credit for #65185. Verification: - pnpm install - git diff --check origin/main..HEAD - pnpm exec oxfmt --check --threads=1 src/gateway/client.ts src/gateway/client.test.ts src/pairing/setup-code.ts src/pairing/setup-code.test.ts extensions/device-pair/index.ts extensions/device-pair/index.test.ts - pnpm format:docs:check - pnpm test src/gateway/client.test.ts src/pairing/setup-code.test.ts extensions/device-pair/index.test.ts - cd apps/shared/OpenClawKit && swift test --filter 'DeepLinksSecurityTests|GatewayNodeSessionTests' - pnpm lint:swift passes with the existing TalkModeRuntime.swift type-body-length warning Blocked locally: - iOS app-target xcodebuild tests require unavailable watchOS 26.4 runtime here. - Testbox check:changed previously failed because the image lacks swiftlint; local swiftlint passes.
166 lines
6.0 KiB
Swift
166 lines
6.0 KiB
Swift
import Foundation
|
|
import OpenClawKit
|
|
import Testing
|
|
|
|
private func setupCode(from payload: String) -> String {
|
|
Data(payload.utf8)
|
|
.base64EncodedString()
|
|
.replacingOccurrences(of: "+", with: "-")
|
|
.replacingOccurrences(of: "/", with: "_")
|
|
.replacingOccurrences(of: "=", with: "")
|
|
}
|
|
|
|
@Suite struct DeepLinksSecurityTests {
|
|
@Test func gatewayDeepLinkRejectsInsecureNonLoopbackWs() {
|
|
let url = URL(
|
|
string: "openclaw://gateway?host=attacker.example&port=18789&tls=0&token=abc")!
|
|
#expect(DeepLinkParser.parse(url) == nil)
|
|
}
|
|
|
|
@Test func gatewayDeepLinkRejectsInsecurePrefixBypassHost() {
|
|
let url = URL(
|
|
string: "openclaw://gateway?host=127.attacker.example&port=18789&tls=0&token=abc")!
|
|
#expect(DeepLinkParser.parse(url) == nil)
|
|
}
|
|
|
|
@Test func gatewayDeepLinkAllowsLoopbackWs() {
|
|
let url = URL(
|
|
string: "openclaw://gateway?host=127.0.0.1&port=18789&tls=0&token=abc")!
|
|
#expect(
|
|
DeepLinkParser.parse(url) == .gateway(
|
|
.init(
|
|
host: "127.0.0.1",
|
|
port: 18789,
|
|
tls: false,
|
|
bootstrapToken: nil,
|
|
token: "abc",
|
|
password: nil)))
|
|
}
|
|
|
|
@Test func setupCodeRejectsInsecureNonLoopbackWs() {
|
|
let payload = #"{"url":"ws://attacker.example:18789","bootstrapToken":"tok"}"#
|
|
#expect(GatewayConnectDeepLink.fromSetupCode(setupCode(from: payload)) == nil)
|
|
}
|
|
|
|
@Test func setupCodeRejectsInsecurePrefixBypassHost() {
|
|
let payload = #"{"url":"ws://127.attacker.example:18789","bootstrapToken":"tok"}"#
|
|
#expect(GatewayConnectDeepLink.fromSetupCode(setupCode(from: payload)) == nil)
|
|
}
|
|
|
|
@Test func setupCodeAllowsLoopbackWs() {
|
|
let payload = #"{"url":"ws://127.0.0.1:18789","bootstrapToken":"tok"}"#
|
|
#expect(
|
|
GatewayConnectDeepLink.fromSetupCode(setupCode(from: payload)) == .init(
|
|
host: "127.0.0.1",
|
|
port: 18789,
|
|
tls: false,
|
|
bootstrapToken: "tok",
|
|
token: nil,
|
|
password: nil))
|
|
}
|
|
|
|
@Test func setupCodeAllowsPrivateLanWs() {
|
|
let payload = #"{"url":"ws://192.168.1.20:18789","bootstrapToken":"tok"}"#
|
|
#expect(
|
|
GatewayConnectDeepLink.fromSetupCode(setupCode(from: payload)) == .init(
|
|
host: "192.168.1.20",
|
|
port: 18789,
|
|
tls: false,
|
|
bootstrapToken: "tok",
|
|
token: nil,
|
|
password: nil))
|
|
}
|
|
|
|
@Test func setupCodeAllowsMDNSWs() {
|
|
let payload = #"{"url":"ws://openclaw.local:18789","bootstrapToken":"tok"}"#
|
|
#expect(
|
|
GatewayConnectDeepLink.fromSetupCode(setupCode(from: payload)) == .init(
|
|
host: "openclaw.local",
|
|
port: 18789,
|
|
tls: false,
|
|
bootstrapToken: "tok",
|
|
token: nil,
|
|
password: nil))
|
|
}
|
|
|
|
@Test func setupCodeRejectsTailnetPlaintextWs() {
|
|
let payload = #"{"url":"ws://gateway.tailnet.ts.net:18789","bootstrapToken":"tok"}"#
|
|
#expect(GatewayConnectDeepLink.fromSetupCode(setupCode(from: payload)) == nil)
|
|
}
|
|
|
|
@Test func setupCodeRejectsCgnatPlaintextWs() {
|
|
let payload = #"{"url":"ws://100.64.0.9:18789","bootstrapToken":"tok"}"#
|
|
#expect(GatewayConnectDeepLink.fromSetupCode(setupCode(from: payload)) == nil)
|
|
}
|
|
|
|
@Test func setupCodeParsesHostPayload() {
|
|
let payload = #"{"host":"gateway.tailnet.ts.net","port":443,"tls":true,"bootstrapToken":"tok"}"#
|
|
#expect(
|
|
GatewayConnectDeepLink.fromSetupCode(setupCode(from: payload)) == .init(
|
|
host: "gateway.tailnet.ts.net",
|
|
port: 443,
|
|
tls: true,
|
|
bootstrapToken: "tok",
|
|
token: nil,
|
|
password: nil))
|
|
}
|
|
|
|
@Test func setupCodeParsesHostPayloadWithTLSDefaultPort() {
|
|
let payload = #"{"host":"gateway.tailnet.ts.net","tls":true,"bootstrapToken":"tok"}"#
|
|
#expect(
|
|
GatewayConnectDeepLink.fromSetupCode(setupCode(from: payload)) == .init(
|
|
host: "gateway.tailnet.ts.net",
|
|
port: 443,
|
|
tls: true,
|
|
bootstrapToken: "tok",
|
|
token: nil,
|
|
password: nil))
|
|
}
|
|
|
|
@Test func setupCodeRejectsInsecureHostPayload() {
|
|
let payload = #"{"host":"gateway.tailnet.ts.net","port":18789,"tls":false,"bootstrapToken":"tok"}"#
|
|
#expect(GatewayConnectDeepLink.fromSetupCode(setupCode(from: payload)) == nil)
|
|
}
|
|
|
|
@Test func setupCodeAllowsPrivateLanHostPayload() {
|
|
let payload = #"{"host":"openclaw.local","port":18789,"tls":false,"bootstrapToken":"tok"}"#
|
|
#expect(
|
|
GatewayConnectDeepLink.fromSetupCode(setupCode(from: payload)) == .init(
|
|
host: "openclaw.local",
|
|
port: 18789,
|
|
tls: false,
|
|
bootstrapToken: "tok",
|
|
token: nil,
|
|
password: nil))
|
|
}
|
|
|
|
@Test func setupInputParsesFullCopiedSetupMessage() {
|
|
let payload = #"{"url":"wss://gateway.tailnet.ts.net","bootstrapToken":"tok"}"#
|
|
let message = """
|
|
Pairing setup code generated.
|
|
|
|
Setup code:
|
|
\(setupCode(from: payload))
|
|
"""
|
|
#expect(
|
|
GatewayConnectDeepLink.fromSetupInput(message) == .init(
|
|
host: "gateway.tailnet.ts.net",
|
|
port: 443,
|
|
tls: true,
|
|
bootstrapToken: "tok",
|
|
token: nil,
|
|
password: nil))
|
|
}
|
|
|
|
@Test func setupInputParsesRawGatewayURL() {
|
|
#expect(
|
|
GatewayConnectDeepLink.fromSetupInput("wss://gateway.example.com:444") == .init(
|
|
host: "gateway.example.com",
|
|
port: 444,
|
|
tls: true,
|
|
bootstrapToken: nil,
|
|
token: nil,
|
|
password: nil))
|
|
}
|
|
}
|