Files
openclaw/src/plugin-sdk/facade-loader.ts
Alex Knight 342d13a914 fix(plugins): resolve public artifacts from installed plugin roots (#98819)
* fix(plugins): resolve public artifacts from installed plugin roots

Externalized official plugins ship gateway-auth/doctor/secret/message-tool
public artifacts in their installed npm package, but the public-surface
loader only searched bundled locations. On packaged installs this emptied
the gateway auth bypass set for /api/channels/mattermost/command, so every
Mattermost slash callback was rejected 401 before the plugin ran.

Fall back to the plugin's installed package root (install-record index)
when bundled resolution misses; bundled/source locations keep precedence.

Fixes #98740

* fix(gateway): resolve channel auth-bypass artifacts via activation-gated facade

Route gateway-auth bypass artifact loading through the activation-gated
facade seam so externalized (installed) channel plugins keep their
unauthenticated callback paths, while denied/disabled plugins contribute
nothing and never execute artifact code. Reject hardlinked artifacts for
installed plugin roots in the facade loader per hardlink-policy.

Replaces the earlier install-record fallback in the shared bundled
artifact loader, which broadened every artifact surface past its trust
boundary (see PR review); other externalized-plugin surfaces are #98842.

Fixes #98740

* fix(gateway): load facade activation runtime via async lazy import

The sync createRequire/jiti candidate loader for
facade-activation-check.runtime.js only resolves from built dist; under
vitest source runs it cannot follow .js->.ts specifiers or workspace
package subpaths, so the gateway auth-bypass path threw 'Unable to load
facade activation check runtime' (CI shard failure). Add an async
activated-load API backed by dynamic import (vitest- and dist-native),
warm the shared runtime memo, and make the bypass consumer async - its
single caller already awaits behind the config-snapshot promise cache.

* revert(plugins): drop install-record fallback from public-surface loader

Superseded by the activation-gated facade seam in gateway-auth-bypass;
review found the loader-level fallback broadened every artifact surface
past its trust boundary (see PR #98819 discussion).

* fix(plugin-sdk): drop unused oxlint disable on async facade loader

* test(plugin-sdk): cover facade hardlink policy for installed vs core roots

* test(plugin-sdk): cover facade hardlink policy for installed vs core roots

---------

Co-authored-by: Alex Knight <15041791+amknight@users.noreply.github.com>
2026-07-04 10:57:42 +10:00

292 lines
9.8 KiB
TypeScript

// Facade loader helpers resolve plugin public API modules from source, dist, or installed roots.
import fs from "node:fs";
import path from "node:path";
import { fileURLToPath, pathToFileURL } from "node:url";
import { openRootFileSync } from "../infra/boundary-file-read.js";
import { resolveBundledPluginsDir } from "../plugins/bundled-dir.js";
import { shouldRejectHardlinkedPluginFiles } from "../plugins/hardlink-policy.js";
import {
getCachedPluginModuleLoader,
type PluginModuleLoaderCache,
type PluginModuleLoaderFactory,
} from "../plugins/plugin-module-loader-cache.js";
import { resolveLoaderPackageRoot } from "../plugins/sdk-alias.js";
import { resolveBundledFacadeModuleLocation } from "./facade-resolution-shared.js";
const CURRENT_MODULE_PATH = fileURLToPath(import.meta.url);
const moduleLoaders: PluginModuleLoaderCache = new Map();
const loadedFacadeModules = new Map<string, unknown>();
const loadedFacadePluginIds = new Set<string>();
let facadeLoaderSourceTransformFactory: PluginModuleLoaderFactory | undefined;
let cachedOpenClawPackageRoot: string | undefined;
function getOpenClawPackageRoot() {
if (cachedOpenClawPackageRoot) {
return cachedOpenClawPackageRoot;
}
cachedOpenClawPackageRoot =
resolveLoaderPackageRoot({
modulePath: fileURLToPath(import.meta.url),
moduleUrl: import.meta.url,
}) ?? fileURLToPath(new URL("../..", import.meta.url));
return cachedOpenClawPackageRoot;
}
function resolveFacadeModuleLocation(params: {
dirName: string;
artifactBasename: string;
env?: NodeJS.ProcessEnv;
}): { modulePath: string; boundaryRoot: string } | null {
const bundledPluginsDir = resolveBundledPluginsDir(params.env ?? process.env);
return resolveBundledFacadeModuleLocation({
...params,
currentModulePath: CURRENT_MODULE_PATH,
packageRoot: getOpenClawPackageRoot(),
bundledPluginsDir,
});
}
function getModuleLoader(modulePath: string) {
return getCachedPluginModuleLoader({
cache: moduleLoaders,
modulePath,
importerUrl: import.meta.url,
preferBuiltDist: true,
loaderFilename: import.meta.url,
...(facadeLoaderSourceTransformFactory
? { createLoader: facadeLoaderSourceTransformFactory }
: {}),
});
}
function createLazyFacadeValueLoader<T>(load: () => T): () => T {
let loaded = false;
let value: T;
return () => {
if (!loaded) {
value = load();
loaded = true;
}
return value;
};
}
function createLazyFacadeProxyValue<T extends object>(params: {
load: () => T;
target: object;
}): T {
const resolve = createLazyFacadeValueLoader(params.load);
return new Proxy(params.target, {
defineProperty(_target, property, descriptor) {
return Reflect.defineProperty(resolve(), property, descriptor);
},
deleteProperty(_target, property) {
return Reflect.deleteProperty(resolve(), property);
},
get(_target, property, receiver) {
return Reflect.get(resolve(), property, receiver);
},
getOwnPropertyDescriptor(_target, property) {
return Reflect.getOwnPropertyDescriptor(resolve(), property);
},
getPrototypeOf() {
return Reflect.getPrototypeOf(resolve());
},
has(_target, property) {
return Reflect.has(resolve(), property);
},
isExtensible() {
return Reflect.isExtensible(resolve());
},
ownKeys() {
return Reflect.ownKeys(resolve());
},
preventExtensions() {
return Reflect.preventExtensions(resolve());
},
set(_target, property, value, receiver) {
return Reflect.set(resolve(), property, value, receiver);
},
setPrototypeOf(_target, prototype) {
return Reflect.setPrototypeOf(resolve(), prototype);
},
}) as T;
}
/** Create an object proxy that loads the underlying facade only on first property access. */
export function createLazyFacadeObjectValue<T extends object>(load: () => T): T {
return createLazyFacadeProxyValue({ load, target: {} });
}
/** Create an array proxy that loads the underlying facade only on first array access. */
export function createLazyFacadeArrayValue<T extends readonly unknown[]>(load: () => T): T {
return createLazyFacadeProxyValue({ load, target: [] });
}
/** Resolved public-surface module path plus the filesystem root it must stay within. */
export type FacadeModuleLocation = {
modulePath: string;
boundaryRoot: string;
};
function isPathAtOrInside(target: string, root: string): boolean {
const resolvedRoot = path.resolve(root);
const resolvedTarget = path.resolve(target);
return resolvedTarget === resolvedRoot || resolvedTarget.startsWith(resolvedRoot + path.sep);
}
// Registry-resolved locations can point at installed plugin roots, which must
// reject hardlinked artifacts (see hardlink-policy.ts); core-shipped roots keep
// hardlinks allowed for bundled dist/Nix layouts.
function resolveFacadeBoundaryOpenParams(boundaryRoot: string): {
boundaryLabel: string;
rejectHardlinks: boolean;
} {
if (isPathAtOrInside(boundaryRoot, getOpenClawPackageRoot())) {
return { boundaryLabel: "OpenClaw package root", rejectHardlinks: false };
}
const bundledDir = resolveBundledPluginsDir();
if (bundledDir && isPathAtOrInside(boundaryRoot, bundledDir)) {
return { boundaryLabel: "bundled plugin directory", rejectHardlinks: false };
}
return {
boundaryLabel: "plugin root",
rejectHardlinks: shouldRejectHardlinkedPluginFiles({ origin: "global", rootDir: boundaryRoot }),
};
}
/** Load and cache a facade module after verifying it is inside its declared boundary root. */
export function loadFacadeModuleAtLocationSync<T extends object>(params: {
location: FacadeModuleLocation;
trackedPluginId: string | (() => string);
loadModule?: (modulePath: string) => T;
}): T {
const location = params.location;
const cached = loadedFacadeModules.get(location.modulePath);
if (cached) {
return cached as T;
}
const opened = openRootFileSync({
absolutePath: location.modulePath,
rootPath: location.boundaryRoot,
...resolveFacadeBoundaryOpenParams(location.boundaryRoot),
});
if (!opened.ok) {
throw new Error(`Unable to open bundled plugin public surface ${location.modulePath}`, {
cause: opened.error,
});
}
fs.closeSync(opened.fd);
const sentinel = {} as T;
loadedFacadeModules.set(location.modulePath, sentinel);
let loaded: T;
try {
loaded =
params.loadModule?.(location.modulePath) ??
(getModuleLoader(location.modulePath)(location.modulePath) as T);
Object.assign(sentinel, loaded);
loadedFacadePluginIds.add(
typeof params.trackedPluginId === "function"
? params.trackedPluginId()
: params.trackedPluginId,
);
} catch (err) {
loadedFacadeModules.delete(location.modulePath);
throw err;
}
return sentinel;
}
/** Resolve and synchronously load a bundled plugin public surface by plugin dir and artifact name. */
// oxlint-disable-next-line typescript/no-unnecessary-type-parameters -- Dynamic facade loaders use caller-supplied module surface types.
export function loadBundledPluginPublicSurfaceModuleSync<T extends object>(params: {
dirName: string;
artifactBasename: string;
trackedPluginId?: string | (() => string);
env?: NodeJS.ProcessEnv;
}): T {
const location = resolveFacadeModuleLocation(params);
if (!location) {
throw new Error(
`Unable to resolve bundled plugin public surface ${params.dirName}/${params.artifactBasename}`,
);
}
return loadFacadeModuleAtLocationSync({
location,
trackedPluginId: params.trackedPluginId ?? params.dirName,
});
}
/** Resolve and asynchronously import a bundled plugin public surface with sync-loader fallback. */
export async function loadBundledPluginPublicSurfaceModule<T extends object>(params: {
dirName: string;
artifactBasename: string;
trackedPluginId?: string | (() => string);
}): Promise<T> {
const location = resolveFacadeModuleLocation(params);
if (!location) {
throw new Error(
`Unable to resolve bundled plugin public surface ${params.dirName}/${params.artifactBasename}`,
);
}
const preparedLocation = location;
const cached = loadedFacadeModules.get(preparedLocation.modulePath);
if (cached) {
return cached as T;
}
const opened = openRootFileSync({
absolutePath: preparedLocation.modulePath,
rootPath: preparedLocation.boundaryRoot,
...resolveFacadeBoundaryOpenParams(preparedLocation.boundaryRoot),
});
if (!opened.ok) {
throw new Error(`Unable to open bundled plugin public surface ${preparedLocation.modulePath}`, {
cause: opened.error,
});
}
fs.closeSync(opened.fd);
try {
const loaded = (await import(pathToFileURL(preparedLocation.modulePath).href)) as T;
loadedFacadeModules.set(preparedLocation.modulePath, loaded);
loadedFacadePluginIds.add(
typeof params.trackedPluginId === "function"
? params.trackedPluginId()
: (params.trackedPluginId ?? params.dirName),
);
return loaded;
} catch {
return loadFacadeModuleAtLocationSync({
location: preparedLocation,
trackedPluginId: params.trackedPluginId ?? params.dirName,
});
}
}
/** List plugin ids whose public facades have been loaded in this process. */
export function listImportedBundledPluginFacadeIds(): string[] {
return [...loadedFacadePluginIds].toSorted((left, right) => left.localeCompare(right));
}
/** Reset facade module caches and test loader overrides. */
export function resetFacadeLoaderStateForTest(): void {
loadedFacadeModules.clear();
loadedFacadePluginIds.clear();
moduleLoaders.clear();
facadeLoaderSourceTransformFactory = undefined;
cachedOpenClawPackageRoot = undefined;
}
/** Override source transform loader creation for facade-loader tests. */
export function setFacadeLoaderSourceTransformFactoryForTest(
factory: PluginModuleLoaderFactory | undefined,
): void {
facadeLoaderSourceTransformFactory = factory;
}