mirror of
https://github.com/openclaw/openclaw.git
synced 2026-07-19 13:21:42 +00:00
Adds client-capability-gated tool availability: gateway clients declare capabilities at connect (new inline-widgets cap), chat.send stamps them into the run context, and every tool assembly path (embedded runner, queued followups, Codex app-server harness, plugin-only construction plans) drops tools whose requiredClientCaps the originating client did not declare. The Canvas plugin ships the first such tool, show_widget: agents pass SVG or an HTML fragment plus a title; the plugin hosts it as a bounded, retention-scoped Canvas document and returns the existing canvas preview handle, which web chat renders as a sandboxed iframe fitted to the widget's reported content height. Widget frames never get allow-same-origin (per-preview sandbox ceiling, including the sidebar path) and the Canvas host serves widget documents with a CSP sandbox header so direct navigation runs in an opaque origin. Verified live end-to-end on a Testbox with gpt-5.5 (screenshots on the PR). CLI-backed model backends do not carry client caps yet and stay fail-closed (#102577). Closes #101790
214 lines
5.9 KiB
TypeScript
214 lines
5.9 KiB
TypeScript
// Covers plugin tool descriptor cache lifecycle and invalidation.
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
|
|
const hoisted = vi.hoisted(() => ({
|
|
resolveRuntimeConfigCacheKey: vi.fn((value: unknown) => {
|
|
const id =
|
|
value && typeof value === "object" && "id" in value
|
|
? String((value as { id?: unknown }).id)
|
|
: "config";
|
|
return `config:${id}:${JSON.stringify(value)}`;
|
|
}),
|
|
}));
|
|
|
|
vi.mock("../config/runtime-snapshot.js", () => ({
|
|
resolveRuntimeConfigCacheKey: hoisted.resolveRuntimeConfigCacheKey,
|
|
}));
|
|
|
|
import {
|
|
buildPluginToolDescriptorCacheKey,
|
|
capturePluginToolDescriptor,
|
|
createPluginToolDescriptorConfigCacheKeyMemo,
|
|
resetPluginToolDescriptorCache,
|
|
} from "./tool-descriptor-cache.js";
|
|
|
|
describe("plugin tool descriptor cache keys", () => {
|
|
afterEach(() => {
|
|
hoisted.resolveRuntimeConfigCacheKey.mockClear();
|
|
resetPluginToolDescriptorCache();
|
|
});
|
|
|
|
it("memoizes config cache keys across plugin descriptor keys in one resolution pass", () => {
|
|
const config = {
|
|
id: "runtime",
|
|
plugins: {
|
|
entries: {
|
|
demo: { enabled: true },
|
|
},
|
|
},
|
|
} as never;
|
|
const configCacheKeyMemo = createPluginToolDescriptorConfigCacheKeyMemo();
|
|
|
|
for (let index = 0; index < 25; index += 1) {
|
|
buildPluginToolDescriptorCacheKey({
|
|
pluginId: `plugin-${index}`,
|
|
source: `/tmp/plugin-${index}.js`,
|
|
contractToolNames: [`tool_${index}`],
|
|
ctx: {
|
|
config,
|
|
runtimeConfig: config,
|
|
workspaceDir: "/tmp/workspace",
|
|
agentDir: "/tmp/agent",
|
|
agentId: "main",
|
|
sessionKey: "agent:main",
|
|
sessionId: "session",
|
|
},
|
|
currentRuntimeConfig: config,
|
|
configCacheKeyMemo,
|
|
});
|
|
}
|
|
|
|
expect(hoisted.resolveRuntimeConfigCacheKey).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("preserves required gateway client capabilities in cached descriptors", () => {
|
|
const cached = capturePluginToolDescriptor({
|
|
pluginId: "demo",
|
|
optional: false,
|
|
tool: {
|
|
name: "inline_demo",
|
|
label: "Inline demo",
|
|
description: "Render a demo",
|
|
parameters: { type: "object", properties: {} },
|
|
requiredClientCaps: ["inline-widgets"],
|
|
execute: async () => ({ content: [], details: {} }),
|
|
},
|
|
});
|
|
|
|
expect(cached.requiredClientCaps).toEqual(["inline-widgets"]);
|
|
});
|
|
|
|
it("keeps distinct config objects distinct within the memo", () => {
|
|
const firstConfig = { id: "first" } as never;
|
|
const secondConfig = { id: "second" } as never;
|
|
const configCacheKeyMemo = createPluginToolDescriptorConfigCacheKeyMemo();
|
|
|
|
const firstKey = buildPluginToolDescriptorCacheKey({
|
|
pluginId: "demo",
|
|
source: "/tmp/demo.js",
|
|
contractToolNames: ["demo"],
|
|
ctx: {
|
|
config: firstConfig,
|
|
runtimeConfig: firstConfig,
|
|
},
|
|
currentRuntimeConfig: firstConfig,
|
|
configCacheKeyMemo,
|
|
});
|
|
const secondKey = buildPluginToolDescriptorCacheKey({
|
|
pluginId: "demo",
|
|
source: "/tmp/demo.js",
|
|
contractToolNames: ["demo"],
|
|
ctx: {
|
|
config: secondConfig,
|
|
runtimeConfig: secondConfig,
|
|
},
|
|
currentRuntimeConfig: secondConfig,
|
|
configCacheKeyMemo,
|
|
});
|
|
|
|
expect(hoisted.resolveRuntimeConfigCacheKey).toHaveBeenCalledTimes(2);
|
|
expect(firstKey).not.toBe(secondKey);
|
|
});
|
|
|
|
it("varies descriptor keys by active model metadata", () => {
|
|
const base = {
|
|
pluginId: "demo",
|
|
source: "/tmp/demo.js",
|
|
contractToolNames: ["demo"],
|
|
ctx: {
|
|
workspaceDir: "/tmp/workspace",
|
|
agentId: "main",
|
|
activeModel: {
|
|
provider: "openai",
|
|
modelId: "gpt-5.4",
|
|
modelRef: "openai/gpt-5.4",
|
|
},
|
|
},
|
|
};
|
|
|
|
const firstKey = buildPluginToolDescriptorCacheKey(base);
|
|
const secondKey = buildPluginToolDescriptorCacheKey({
|
|
...base,
|
|
ctx: {
|
|
...base.ctx,
|
|
activeModel: {
|
|
provider: "openrouter",
|
|
modelId: "openrouter/auto",
|
|
modelRef: "openrouter/auto",
|
|
},
|
|
},
|
|
});
|
|
|
|
expect(firstKey).not.toBe(secondKey);
|
|
});
|
|
|
|
it("varies descriptor keys by trusted owner state", () => {
|
|
const base = {
|
|
pluginId: "demo",
|
|
source: "/tmp/demo.js",
|
|
contractToolNames: ["owner_tool"],
|
|
ctx: {
|
|
workspaceDir: "/tmp/workspace",
|
|
agentId: "main",
|
|
},
|
|
};
|
|
|
|
const ownerKey = buildPluginToolDescriptorCacheKey({
|
|
...base,
|
|
ctx: { ...base.ctx, senderIsOwner: true },
|
|
});
|
|
const nonOwnerKey = buildPluginToolDescriptorCacheKey({
|
|
...base,
|
|
ctx: { ...base.ctx, senderIsOwner: false },
|
|
});
|
|
|
|
expect(ownerKey).not.toBe(nonOwnerKey);
|
|
});
|
|
|
|
it("keeps descriptor keys stable across config bookkeeping writes", () => {
|
|
const firstConfig = {
|
|
id: "runtime",
|
|
meta: { lastTouchedAt: "2026-05-02T10:00:00.000Z" },
|
|
plugins: {
|
|
entries: {
|
|
demo: { enabled: true },
|
|
},
|
|
},
|
|
wizard: { lastRunAt: "2026-05-02T10:00:00.000Z" },
|
|
} as never;
|
|
const secondConfig = {
|
|
id: "runtime",
|
|
meta: { lastTouchedAt: "2026-05-02T10:00:05.000Z" },
|
|
plugins: {
|
|
entries: {
|
|
demo: { enabled: true },
|
|
},
|
|
},
|
|
wizard: { lastRunAt: "2026-05-02T10:00:05.000Z" },
|
|
} as never;
|
|
|
|
const firstKey = buildPluginToolDescriptorCacheKey({
|
|
pluginId: "demo",
|
|
source: "/tmp/demo.js",
|
|
contractToolNames: ["demo"],
|
|
ctx: {
|
|
config: firstConfig,
|
|
runtimeConfig: firstConfig,
|
|
},
|
|
currentRuntimeConfig: firstConfig,
|
|
});
|
|
const secondKey = buildPluginToolDescriptorCacheKey({
|
|
pluginId: "demo",
|
|
source: "/tmp/demo.js",
|
|
contractToolNames: ["demo"],
|
|
ctx: {
|
|
config: secondConfig,
|
|
runtimeConfig: secondConfig,
|
|
},
|
|
currentRuntimeConfig: secondConfig,
|
|
});
|
|
|
|
expect(firstKey).toBe(secondKey);
|
|
});
|
|
});
|