Files
openclaw/src/tasks/task-executor-policy.ts
Masato Hoshino 153ee2abba fix(subagents): killed subagent runs stay running in the task list (#99806)
* fix(subagents): reconcile killed task outcomes

Co-authored-by: masatohoshino <g515hoshino@gmail.com>

* fix(subagents): retain reconciliation marker narrowing

* fix(subagents): honor generations in latest-run views

* test(subagents): align reconciliation fixtures

* fix(subagents): keep steer recovery best effort

* style(tasks): use type-only runtime contract import

* refactor(subagents): keep generation ordering leaf-only

* fix(subagents): sanitize persisted task owner ids

* fix(subagents): preserve failed replay lifecycle reason

* fix(agents): clear killed lifecycle timeout grace

* fix(tasks): preserve canonical subagent outcomes

* fix(agents): continue requester-wide cancellation

* fix(agents): fence yield revival races

* test(agents): mock detached task lookup

* fix: fence subagent cleanup deletion

---------

Co-authored-by: Peter Steinberger <steipete@gmail.com>
2026-07-05 02:17:10 -07:00

167 lines
5.9 KiB
TypeScript

// Decides task executor delivery, terminal update, and follow-up message policy.
import { SUBAGENT_KILL_TASK_ERROR } from "./detached-task-runtime-contract.js";
import type { TaskEventRecord, TaskRecord, TaskStatus } from "./task-registry.types.js";
import { formatTaskStatusTitleText, sanitizeTaskStatusText } from "./task-status.js";
/** Returns whether a task status is terminal for delivery and retention policy. */
export function isTerminalTaskStatus(status: TaskStatus): boolean {
return (
status === "succeeded" ||
status === "failed" ||
status === "timed_out" ||
status === "cancelled" ||
status === "lost"
);
}
function resolveTaskDisplayTitle(task: TaskRecord): string {
return formatTaskStatusTitleText(
task.label?.trim() ||
(task.runtime === "acp"
? "ACP background task"
: task.runtime === "subagent"
? "Subagent task"
: task.task.trim() || "Background task"),
);
}
function resolveTaskRunLabel(task: TaskRecord): string {
return task.runId ? ` (run ${task.runId.slice(0, 8)})` : "";
}
export function formatTaskTerminalMessage(
task: TaskRecord,
options: { surface?: "direct" | "parent_session" } = {},
): string {
const title = resolveTaskDisplayTitle(task);
const runLabel = resolveTaskRunLabel(task);
const summary = sanitizeTaskStatusText(task.terminalSummary, {
errorContext: task.status !== "succeeded" || task.terminalOutcome === "blocked",
});
if (task.status === "succeeded") {
if (task.terminalOutcome === "blocked") {
return summary
? `Background task blocked: ${title}${runLabel}. ${summary}`
: `Background task blocked: ${title}${runLabel}.`;
}
if (options.surface === "parent_session") {
const reviewNext = "Next: parent will review/verify before calling it done.";
return summary
? `Background task ready for review: ${title}${runLabel}. ${summary} ${reviewNext}`
: `Background task ready for review: ${title}${runLabel}. ${reviewNext}`;
}
return summary
? `Background task done: ${title}${runLabel}. ${summary}`
: `Background task done: ${title}${runLabel}.`;
}
if (task.status === "timed_out") {
return `Background task timed out: ${title}${runLabel}.`;
}
if (task.status === "lost") {
const error = sanitizeTaskStatusText(task.error, { errorContext: true });
const fallbackSummary = sanitizeTaskStatusText(task.terminalSummary, { errorContext: true });
return `Background task lost: ${title}${runLabel}. ${error || fallbackSummary || "Backing session disappeared."}`;
}
if (task.status === "cancelled") {
if (task.runtime === "subagent") {
// A final reply can win the kill race and reconcile this row to success.
// Report the operator action without claiming an irreversible outcome.
return `Background task cancellation requested: ${title}${runLabel}.`;
}
return `Background task cancelled: ${title}${runLabel}.`;
}
const error = sanitizeTaskStatusText(task.error, { errorContext: true });
const fallbackSummary = sanitizeTaskStatusText(task.terminalSummary, { errorContext: true });
return error
? `Background task failed: ${title}${runLabel}. ${error}`
: fallbackSummary
? `Background task failed: ${title}${runLabel}. ${fallbackSummary}`
: `Background task failed: ${title}${runLabel}.`;
}
export function shouldUseParentReviewTaskTerminalMessage(task: TaskRecord): boolean {
return (
task.runtime === "acp" &&
task.status === "succeeded" &&
task.terminalOutcome !== "blocked" &&
Boolean(task.childSessionKey?.trim())
);
}
export function formatTaskBlockedFollowupMessage(task: TaskRecord): string | null {
if (task.status !== "succeeded" || task.terminalOutcome !== "blocked") {
return null;
}
const title = resolveTaskDisplayTitle(task);
const runLabel = resolveTaskRunLabel(task);
const summary =
sanitizeTaskStatusText(task.terminalSummary, { errorContext: true }) ||
"Task is blocked and needs follow-up.";
return `Task needs follow-up: ${title}${runLabel}. ${summary}`;
}
export function formatTaskStateChangeMessage(
task: TaskRecord,
event: TaskEventRecord,
): string | null {
const title = resolveTaskDisplayTitle(task);
if (event.kind === "running") {
return `Background task started: ${title}.`;
}
if (event.kind === "progress") {
const summary = sanitizeTaskStatusText(event.summary);
return summary ? `Background task update: ${title}. ${summary}` : null;
}
return null;
}
export function shouldAutoDeliverTaskTerminalUpdate(task: TaskRecord): boolean {
if (task.notifyPolicy === "silent") {
return false;
}
if (task.runtime === "subagent" && task.status !== "cancelled") {
// Subagent lifecycle owns provider-result publication.
return false;
}
if (
task.runtime === "subagent" &&
task.status === "cancelled" &&
task.error === SUBAGENT_KILL_TASK_ERROR
) {
// A direct kill is provisional until lifecycle reconciliation settles.
return false;
}
if (!isTerminalTaskStatus(task.status)) {
return false;
}
return task.deliveryStatus === "pending";
}
export function shouldAutoDeliverTaskStateChange(task: TaskRecord): boolean {
return (
task.notifyPolicy === "state_changes" &&
task.deliveryStatus === "pending" &&
!isTerminalTaskStatus(task.status)
);
}
export function shouldSuppressDuplicateTerminalDelivery(params: {
task: TaskRecord;
preferredTaskId?: string;
peerDeliveryCovered?: boolean;
}): boolean {
if (!params.task.runId?.trim()) {
return false;
}
const sharesRunDelivery =
params.task.runtime === "acp" ||
(params.task.runtime === "subagent" && params.task.status === "cancelled");
if (!sharesRunDelivery) {
return false;
}
if (params.task.runtime === "subagent" && params.peerDeliveryCovered) {
return true;
}
return Boolean(params.preferredTaskId && params.preferredTaskId !== params.task.taskId);
}