mirror of
https://github.com/openclaw/openclaw.git
synced 2026-03-14 11:30:41 +00:00
* security(exec): add obfuscated command detector * test(exec): cover obfuscation detector patterns * security(exec): enforce obfuscation approval on gateway host * security(exec): enforce obfuscation approval on node host * test(exec): prevent obfuscation timeout bypass * chore(changelog): credit obfuscation security fix
152 lines
4.5 KiB
TypeScript
152 lines
4.5 KiB
TypeScript
/**
|
|
* Detects obfuscated or encoded commands that could bypass allowlist-based
|
|
* security filters.
|
|
*
|
|
* Addresses: https://github.com/openclaw/openclaw/issues/8592
|
|
*/
|
|
|
|
export type ObfuscationDetection = {
|
|
detected: boolean;
|
|
reasons: string[];
|
|
matchedPatterns: string[];
|
|
};
|
|
|
|
type ObfuscationPattern = {
|
|
id: string;
|
|
description: string;
|
|
regex: RegExp;
|
|
};
|
|
|
|
const OBFUSCATION_PATTERNS: ObfuscationPattern[] = [
|
|
{
|
|
id: "base64-pipe-exec",
|
|
description: "Base64 decode piped to shell execution",
|
|
regex: /base64\s+(?:-d|--decode)\b.*\|\s*(?:sh|bash|zsh|dash|ksh|fish)\b/i,
|
|
},
|
|
{
|
|
id: "hex-pipe-exec",
|
|
description: "Hex decode (xxd) piped to shell execution",
|
|
regex: /xxd\s+-r\b.*\|\s*(?:sh|bash|zsh|dash|ksh|fish)\b/i,
|
|
},
|
|
{
|
|
id: "printf-pipe-exec",
|
|
description: "printf with escape sequences piped to shell execution",
|
|
regex: /printf\s+.*\\x[0-9a-f]{2}.*\|\s*(?:sh|bash|zsh|dash|ksh|fish)\b/i,
|
|
},
|
|
{
|
|
id: "eval-decode",
|
|
description: "eval with encoded/decoded input",
|
|
regex: /eval\s+.*(?:base64|xxd|printf|decode)/i,
|
|
},
|
|
{
|
|
id: "base64-decode-to-shell",
|
|
description: "Base64 decode piped to shell",
|
|
regex: /\|\s*base64\s+(?:-d|--decode)\b.*\|\s*(?:sh|bash|zsh|dash|ksh|fish)\b/i,
|
|
},
|
|
{
|
|
id: "pipe-to-shell",
|
|
description: "Content piped directly to shell interpreter",
|
|
regex: /\|\s*(?:sh|bash|zsh|dash|ksh|fish)\b(?:\s+[^|;\n\r]+)?\s*$/im,
|
|
},
|
|
{
|
|
id: "command-substitution-decode-exec",
|
|
description: "Shell -c with command substitution decode/obfuscation",
|
|
regex:
|
|
/(?:sh|bash|zsh|dash|ksh|fish)\s+-c\s+["'][^"']*\$\([^)]*(?:base64\s+(?:-d|--decode)|xxd\s+-r|printf\s+.*\\x[0-9a-f]{2})[^)]*\)[^"']*["']/i,
|
|
},
|
|
{
|
|
id: "process-substitution-remote-exec",
|
|
description: "Shell process substitution from remote content",
|
|
regex: /(?:sh|bash|zsh|dash|ksh|fish)\s+<\(\s*(?:curl|wget)\b/i,
|
|
},
|
|
{
|
|
id: "source-process-substitution-remote",
|
|
description: "source/. with process substitution from remote content",
|
|
regex: /(?:^|[;&\s])(?:source|\.)\s+<\(\s*(?:curl|wget)\b/i,
|
|
},
|
|
{
|
|
id: "shell-heredoc-exec",
|
|
description: "Shell heredoc execution",
|
|
regex: /(?:sh|bash|zsh|dash|ksh|fish)\s+<<-?\s*['"]?[a-zA-Z_][\w-]*['"]?/i,
|
|
},
|
|
{
|
|
id: "octal-escape",
|
|
description: "Bash octal escape sequences (potential command obfuscation)",
|
|
regex: /\$'(?:[^']*\\[0-7]{3}){2,}/,
|
|
},
|
|
{
|
|
id: "hex-escape",
|
|
description: "Bash hex escape sequences (potential command obfuscation)",
|
|
regex: /\$'(?:[^']*\\x[0-9a-fA-F]{2}){2,}/,
|
|
},
|
|
{
|
|
id: "python-exec-encoded",
|
|
description: "Python/Perl/Ruby with base64 or encoded execution",
|
|
regex: /(?:python[23]?|perl|ruby)\s+-[ec]\s+.*(?:base64|b64decode|decode|exec|system|eval)/i,
|
|
},
|
|
{
|
|
id: "curl-pipe-shell",
|
|
description: "Remote content (curl/wget) piped to shell execution",
|
|
regex: /(?:curl|wget)\s+.*\|\s*(?:sh|bash|zsh|dash|ksh|fish)\b/i,
|
|
},
|
|
{
|
|
id: "var-expansion-obfuscation",
|
|
description: "Variable assignment chain with expansion (potential obfuscation)",
|
|
regex: /(?:[a-zA-Z_]\w{0,2}=\S+\s*;\s*){2,}.*\$(?:[a-zA-Z_]|\{[a-zA-Z_])/,
|
|
},
|
|
];
|
|
|
|
const FALSE_POSITIVE_SUPPRESSIONS: Array<{
|
|
suppresses: string[];
|
|
regex: RegExp;
|
|
}> = [
|
|
{
|
|
suppresses: ["curl-pipe-shell"],
|
|
regex: /curl\s+.*https?:\/\/(?:raw\.githubusercontent\.com\/Homebrew|brew\.sh)\b/i,
|
|
},
|
|
{
|
|
suppresses: ["curl-pipe-shell"],
|
|
regex:
|
|
/curl\s+.*https?:\/\/(?:raw\.githubusercontent\.com\/nvm-sh\/nvm|sh\.rustup\.rs|get\.docker\.com|install\.python-poetry\.org)\b/i,
|
|
},
|
|
{
|
|
suppresses: ["curl-pipe-shell"],
|
|
regex: /curl\s+.*https?:\/\/(?:get\.pnpm\.io|bun\.sh\/install)\b/i,
|
|
},
|
|
];
|
|
|
|
export function detectCommandObfuscation(command: string): ObfuscationDetection {
|
|
if (!command || !command.trim()) {
|
|
return { detected: false, reasons: [], matchedPatterns: [] };
|
|
}
|
|
|
|
const reasons: string[] = [];
|
|
const matchedPatterns: string[] = [];
|
|
|
|
for (const pattern of OBFUSCATION_PATTERNS) {
|
|
if (!pattern.regex.test(command)) {
|
|
continue;
|
|
}
|
|
|
|
const urlCount = (command.match(/https?:\/\/\S+/g) ?? []).length;
|
|
const suppressed =
|
|
urlCount <= 1 &&
|
|
FALSE_POSITIVE_SUPPRESSIONS.some(
|
|
(exemption) => exemption.suppresses.includes(pattern.id) && exemption.regex.test(command),
|
|
);
|
|
|
|
if (suppressed) {
|
|
continue;
|
|
}
|
|
|
|
matchedPatterns.push(pattern.id);
|
|
reasons.push(pattern.description);
|
|
}
|
|
|
|
return {
|
|
detected: matchedPatterns.length > 0,
|
|
reasons,
|
|
matchedPatterns,
|
|
};
|
|
}
|