mirror of
https://github.com/openclaw/openclaw.git
synced 2026-05-04 12:20:28 +00:00
* fix(doctor): resolve false positive for local memory search when no explicit modelPath When memorySearch.provider is 'local' (or 'auto') and no explicit local.modelPath is configured, the runtime auto-resolves to DEFAULT_LOCAL_MODEL (embeddinggemma-300m via HuggingFace). However, the doctor's hasLocalEmbeddings() check only inspected the config value and returned false when modelPath was empty, triggering a misleading warning. Fix: fall back to DEFAULT_LOCAL_MODEL in hasLocalEmbeddings(), matching the runtime behavior in createLocalEmbeddingProvider(). Closes #31998 * fix: scope DEFAULT_LOCAL_MODEL fallback to explicit provider:local only Address review feedback: canAutoSelectLocal() in the runtime skips local for empty/hf: model paths in auto mode. The DEFAULT_LOCAL_MODEL fallback should only apply when provider is explicitly 'local', not when provider is 'auto' — otherwise users with no local file and no API keys would get a clean doctor report but no working embeddings. Add useDefaultFallback parameter to hasLocalEmbeddings() to distinguish the two code paths. * fix: preserve gateway probe warning for local provider with default model When hasLocalEmbeddings returns true via DEFAULT_LOCAL_MODEL fallback, also check the gateway memory probe if available. If the probe reports not-ready (e.g. node-llama-cpp missing or model download failed), emit a warning instead of silently reporting healthy. Addresses review feedback about bypassing probe-based validation. * fix: add changelog attribution for doctor local fallback fix (#32014) (thanks @adhishthite) --------- Co-authored-by: Adhish <adhishthite@Adhishs-MacBook-Pro.local> Co-authored-by: Peter Steinberger <steipete@gmail.com>
233 lines
8.4 KiB
TypeScript
233 lines
8.4 KiB
TypeScript
import fsSync from "node:fs";
|
|
import { resolveAgentDir, resolveDefaultAgentId } from "../agents/agent-scope.js";
|
|
import { resolveMemorySearchConfig } from "../agents/memory-search.js";
|
|
import { resolveApiKeyForProvider } from "../agents/model-auth.js";
|
|
import { formatCliCommand } from "../cli/command-format.js";
|
|
import type { OpenClawConfig } from "../config/config.js";
|
|
import { resolveMemoryBackendConfig } from "../memory/backend-config.js";
|
|
import { DEFAULT_LOCAL_MODEL } from "../memory/embeddings.js";
|
|
import { note } from "../terminal/note.js";
|
|
import { resolveUserPath } from "../utils.js";
|
|
|
|
/**
|
|
* Check whether memory search has a usable embedding provider.
|
|
* Runs as part of `openclaw doctor` — config-only, no network calls.
|
|
*/
|
|
export async function noteMemorySearchHealth(
|
|
cfg: OpenClawConfig,
|
|
opts?: {
|
|
gatewayMemoryProbe?: {
|
|
checked: boolean;
|
|
ready: boolean;
|
|
error?: string;
|
|
};
|
|
},
|
|
): Promise<void> {
|
|
const agentId = resolveDefaultAgentId(cfg);
|
|
const agentDir = resolveAgentDir(cfg, agentId);
|
|
const resolved = resolveMemorySearchConfig(cfg, agentId);
|
|
const hasRemoteApiKey = Boolean(resolved?.remote?.apiKey?.trim());
|
|
|
|
if (!resolved) {
|
|
note("Memory search is explicitly disabled (enabled: false).", "Memory search");
|
|
return;
|
|
}
|
|
|
|
// QMD backend handles embeddings internally (e.g. embeddinggemma) — no
|
|
// separate embedding provider is needed. Skip the provider check entirely.
|
|
const backendConfig = resolveMemoryBackendConfig({ cfg, agentId });
|
|
if (backendConfig.backend === "qmd") {
|
|
return;
|
|
}
|
|
|
|
// If a specific provider is configured (not "auto"), check only that one.
|
|
if (resolved.provider !== "auto") {
|
|
if (resolved.provider === "local") {
|
|
if (hasLocalEmbeddings(resolved.local, true)) {
|
|
// Model path looks valid (explicit file, hf: URL, or default model).
|
|
// If a gateway probe is available and reports not-ready, warn anyway —
|
|
// the model download or node-llama-cpp setup may have failed at runtime.
|
|
if (opts?.gatewayMemoryProbe?.checked && !opts.gatewayMemoryProbe.ready) {
|
|
const detail = opts.gatewayMemoryProbe.error?.trim();
|
|
note(
|
|
[
|
|
'Memory search provider is set to "local" and a model path is configured,',
|
|
"but the gateway reports local embeddings are not ready.",
|
|
detail ? `Gateway probe: ${detail}` : null,
|
|
"",
|
|
`Verify: ${formatCliCommand("openclaw memory status --deep")}`,
|
|
]
|
|
.filter(Boolean)
|
|
.join("\n"),
|
|
"Memory search",
|
|
);
|
|
}
|
|
return;
|
|
}
|
|
note(
|
|
[
|
|
'Memory search provider is set to "local" but no local model file was found.',
|
|
"",
|
|
"Fix (pick one):",
|
|
`- Install node-llama-cpp and set a local model path in config`,
|
|
`- Switch to a remote provider: ${formatCliCommand("openclaw config set agents.defaults.memorySearch.provider openai")}`,
|
|
"",
|
|
`Verify: ${formatCliCommand("openclaw memory status --deep")}`,
|
|
].join("\n"),
|
|
"Memory search",
|
|
);
|
|
return;
|
|
}
|
|
// Remote provider — check for API key
|
|
if (hasRemoteApiKey || (await hasApiKeyForProvider(resolved.provider, cfg, agentDir))) {
|
|
return;
|
|
}
|
|
if (opts?.gatewayMemoryProbe?.checked && opts.gatewayMemoryProbe.ready) {
|
|
note(
|
|
[
|
|
`Memory search provider is set to "${resolved.provider}" but the API key was not found in the CLI environment.`,
|
|
"The running gateway reports memory embeddings are ready for the default agent.",
|
|
`Verify: ${formatCliCommand("openclaw memory status --deep")}`,
|
|
].join("\n"),
|
|
"Memory search",
|
|
);
|
|
return;
|
|
}
|
|
const gatewayProbeWarning = buildGatewayProbeWarning(opts?.gatewayMemoryProbe);
|
|
const envVar = providerEnvVar(resolved.provider);
|
|
note(
|
|
[
|
|
`Memory search provider is set to "${resolved.provider}" but no API key was found.`,
|
|
`Semantic recall will not work without a valid API key.`,
|
|
gatewayProbeWarning ? gatewayProbeWarning : null,
|
|
"",
|
|
"Fix (pick one):",
|
|
`- Set ${envVar} in your environment`,
|
|
`- Configure credentials: ${formatCliCommand("openclaw configure --section model")}`,
|
|
`- To disable: ${formatCliCommand("openclaw config set agents.defaults.memorySearch.enabled false")}`,
|
|
"",
|
|
`Verify: ${formatCliCommand("openclaw memory status --deep")}`,
|
|
].join("\n"),
|
|
"Memory search",
|
|
);
|
|
return;
|
|
}
|
|
|
|
// provider === "auto": check all providers in resolution order
|
|
if (hasLocalEmbeddings(resolved.local)) {
|
|
return;
|
|
}
|
|
for (const provider of ["openai", "gemini", "voyage", "mistral"] as const) {
|
|
if (hasRemoteApiKey || (await hasApiKeyForProvider(provider, cfg, agentDir))) {
|
|
return;
|
|
}
|
|
}
|
|
|
|
if (opts?.gatewayMemoryProbe?.checked && opts.gatewayMemoryProbe.ready) {
|
|
note(
|
|
[
|
|
'Memory search provider is set to "auto" but the API key was not found in the CLI environment.',
|
|
"The running gateway reports memory embeddings are ready for the default agent.",
|
|
`Verify: ${formatCliCommand("openclaw memory status --deep")}`,
|
|
].join("\n"),
|
|
"Memory search",
|
|
);
|
|
return;
|
|
}
|
|
const gatewayProbeWarning = buildGatewayProbeWarning(opts?.gatewayMemoryProbe);
|
|
|
|
note(
|
|
[
|
|
"Memory search is enabled but no embedding provider is configured.",
|
|
"Semantic recall will not work without an embedding provider.",
|
|
gatewayProbeWarning ? gatewayProbeWarning : null,
|
|
"",
|
|
"Fix (pick one):",
|
|
"- Set OPENAI_API_KEY, GEMINI_API_KEY, VOYAGE_API_KEY, or MISTRAL_API_KEY in your environment",
|
|
`- Configure credentials: ${formatCliCommand("openclaw configure --section model")}`,
|
|
`- For local embeddings: configure agents.defaults.memorySearch.provider and local model path`,
|
|
`- To disable: ${formatCliCommand("openclaw config set agents.defaults.memorySearch.enabled false")}`,
|
|
"",
|
|
`Verify: ${formatCliCommand("openclaw memory status --deep")}`,
|
|
].join("\n"),
|
|
"Memory search",
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Check whether local embeddings are available.
|
|
*
|
|
* When `useDefaultFallback` is true (explicit `provider: "local"`), an empty
|
|
* modelPath is treated as available because the runtime falls back to
|
|
* DEFAULT_LOCAL_MODEL (an auto-downloaded HuggingFace model).
|
|
*
|
|
* When false (provider: "auto"), we only consider local available if the user
|
|
* explicitly configured a local file path — matching `canAutoSelectLocal()`
|
|
* in the runtime, which skips local for empty/hf: model paths.
|
|
*/
|
|
function hasLocalEmbeddings(local: { modelPath?: string }, useDefaultFallback = false): boolean {
|
|
const modelPath =
|
|
local.modelPath?.trim() || (useDefaultFallback ? DEFAULT_LOCAL_MODEL : undefined);
|
|
if (!modelPath) {
|
|
return false;
|
|
}
|
|
// Remote/downloadable models (hf: or http:) aren't pre-resolved on disk,
|
|
// so we can't confirm availability without a network call. Treat as
|
|
// potentially available — the user configured it intentionally.
|
|
if (/^(hf:|https?:)/i.test(modelPath)) {
|
|
return true;
|
|
}
|
|
const resolved = resolveUserPath(modelPath);
|
|
try {
|
|
return fsSync.statSync(resolved).isFile();
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
async function hasApiKeyForProvider(
|
|
provider: "openai" | "gemini" | "voyage" | "mistral",
|
|
cfg: OpenClawConfig,
|
|
agentDir: string,
|
|
): Promise<boolean> {
|
|
// Map embedding provider names to model-auth provider names
|
|
const authProvider = provider === "gemini" ? "google" : provider;
|
|
try {
|
|
await resolveApiKeyForProvider({ provider: authProvider, cfg, agentDir });
|
|
return true;
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
function providerEnvVar(provider: string): string {
|
|
switch (provider) {
|
|
case "openai":
|
|
return "OPENAI_API_KEY";
|
|
case "gemini":
|
|
return "GEMINI_API_KEY";
|
|
case "voyage":
|
|
return "VOYAGE_API_KEY";
|
|
default:
|
|
return `${provider.toUpperCase()}_API_KEY`;
|
|
}
|
|
}
|
|
|
|
function buildGatewayProbeWarning(
|
|
probe:
|
|
| {
|
|
checked: boolean;
|
|
ready: boolean;
|
|
error?: string;
|
|
}
|
|
| undefined,
|
|
): string | null {
|
|
if (!probe?.checked || probe.ready) {
|
|
return null;
|
|
}
|
|
const detail = probe.error?.trim();
|
|
return detail
|
|
? `Gateway memory probe for default agent is not ready: ${detail}`
|
|
: "Gateway memory probe for default agent is not ready.";
|
|
}
|