Files
openclaw/test/scripts/plugin-contract-test-plan.test.ts
Peter Steinberger fe261b0f59 chore(tooling): typecheck root test/** with a dedicated tsgo lane (#104475)
* chore(types): add declaration files for scripts/lib and scripts/e2e modules

* chore(types): add declaration files for top-level script modules (a-m)

* chore(types): add declaration files for top-level script modules (n-z)

* test: use a non-secret-shaped gateway token fixture

* test: type ci workflow guard helpers for the root test lane

* chore(tooling): typecheck root test/** with a dedicated tsgo lane

- test/tsconfig/tsconfig.test.root.json: root-test program (strict unused checks,
  fixtures excluded; two Docker E2E clients that import built dist/** stay out,
  same rationale as the scripts/e2e exclusion in tsconfig.scripts.json)
- tsgo:test:root wired into tsgo:test, check:test-types, scripts/check.mjs, and
  the ci.yml test-types shard, mirroring the tsgo:scripts lane (#104348)
- changed-lane routing: test/**/*.ts (excluding fixtures) and the lane tsconfig
  now trigger 'typecheck test root' in check:changed; previously test/ paths ran
  lint only, so harness type errors surfaced first in CI (#104287 envDir case)
- burn down all 1071 latent type errors in the program: precise param/local
  types across test/scripts, test/vitest, test/e2e, and transitive scripts/e2e
  program members; 205 sibling .d.mts declaration files for imported .mjs
  modules (committed separately); zero any, zero ts-expect-error
- resolve the pre-existing testing star-export ambiguity in
  scripts/e2e/parallels/common.ts with an explicit re-export

Closes #104388

* chore(types): correct declaration fidelity per structured review

- re-derive 51 .d.mts files from implementation data flow instead of
  initializers: fix a wrong never return (runTestProjectsDelegation returns
  the child), add encoding-sensitive exec/spawn overloads (plain-gh), restore
  the full release profile union, make parsed paths string | null, add missing
  parseArgs fields via help/non-help unions, add a missing sibling declaration
  (budget-number-args), drop 15 unused lint directives
- precise install-record/tuple typing removes the type-aware oxlint
  regressions the first declarations caused in scripts/e2e implementations
- route .mts declaration edits under test/ to the testRoot lane and reference
  the test-root project from tsconfig.projects.json so tsgo:all covers it
  (closes both review findings against the lane wiring)

* chore(scripts): keep telegram runner dist typing structural for the boundary guard

* chore(types): declare runtime pack and gateway readiness exports added on main

* test: pin the importTargetPlan form of the plugin-contract plan import

The guard expectation still referenced the raw await import( form that
7ae5996bb3 (#103975) replaced with the importTargetPlan fallback helper;
the assertion fails on current main.
2026-07-11 06:15:41 -07:00

81 lines
3.0 KiB
TypeScript

// Plugin Contract Test Plan tests cover plugin contract test plan script behavior.
import { readFileSync } from "node:fs";
import { describe, expect, it } from "vitest";
import { createPluginContractTestShards } from "../../scripts/lib/plugin-contract-test-plan.mjs";
import { expectNoNodeFsScans } from "../../src/test-utils/fs-scan-assertions.js";
import { listGitTrackedFiles } from "../../src/test-utils/repo-files.js";
function listContractTests(rootDir = "src/plugins/contracts"): string[] {
const files = listGitTrackedFiles({ pathspecs: rootDir });
expect(files).not.toBeNull();
return (files ?? []).filter((line) => line.endsWith(".test.ts"));
}
describe("scripts/lib/plugin-contract-test-plan.mjs", () => {
it("keeps manual CI compatible with legacy target refs", () => {
const workflow = readFileSync(".github/workflows/ci.yml", "utf8");
// ci.yml imports the plan through the importTargetPlan fallback helper since
// 7ae5996bb3c so historical target refs without the module keep working.
expect(workflow).toContain(
'await importTargetPlan(\n "./scripts/lib/plugin-contract-test-plan.mjs"',
);
expect(workflow).toContain("checks-fast-contracts-plugins-legacy");
expect(workflow).not.toContain(
"createPluginContractTestShards: () => [\n createPluginContractTestShards",
);
});
it("splits plugin contracts into focused shards", () => {
const suffixes = ["a", "b"];
expect(
createPluginContractTestShards().map((shard) => ({
checkName: shard.checkName,
runtime: shard.runtime,
task: shard.task,
})),
).toEqual(
suffixes.map((suffix) => ({
checkName: `checks-fast-contracts-plugins-${suffix}`,
runtime: "node",
task: "contracts-plugins",
})),
);
});
it("covers every plugin contract test exactly once", () => {
const actual = createPluginContractTestShards()
.flatMap((shard) => shard.includePatterns)
.toSorted((a, b) => a.localeCompare(b));
expect(actual).toEqual(listContractTests());
expect(new Set(actual).size).toBe(actual.length);
});
it("uses git-tracked files without walking contract directories", () => {
const payload = expectNoNodeFsScans<{
files: number;
shards: number;
}>(`
const { createPluginContractTestShards } = await import("./scripts/lib/plugin-contract-test-plan.mjs");
const shards = createPluginContractTestShards();
return {
files: shards.reduce((total, shard) => total + shard.includePatterns.length, 0),
shards: shards.length,
};
`);
expect(payload.shards).toBe(2);
expect(payload.files).toBeGreaterThan(0);
});
it("keeps plugin registration contract files spread across checks", () => {
for (const shard of createPluginContractTestShards()) {
const registrationFiles = shard.includePatterns.filter((pattern) =>
pattern.includes("/plugin-registration."),
);
expect(registrationFiles.length).toBeLessThanOrEqual(14);
}
});
});