mirror of
https://github.com/openclaw/openclaw.git
synced 2026-07-06 03:53:32 +00:00
* fix: stop iOS screen recording after cancellation * test(ios): exercise real screen-record cancellation --------- Co-authored-by: NianJiuZst <180004567+users.noreply.github.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>
100 lines
3.2 KiB
Swift
100 lines
3.2 KiB
Swift
import Foundation
|
|
import Testing
|
|
@testable import OpenClaw
|
|
|
|
private final class ScreenRecordServiceProbe: @unchecked Sendable {
|
|
private let lock = NSLock()
|
|
private(set) var startCount = 0
|
|
private(set) var stopCount = 0
|
|
|
|
func recordStart() {
|
|
self.lock.lock()
|
|
self.startCount += 1
|
|
self.lock.unlock()
|
|
}
|
|
|
|
func recordStop() {
|
|
self.lock.lock()
|
|
self.stopCount += 1
|
|
self.lock.unlock()
|
|
}
|
|
|
|
func counts() -> (start: Int, stop: Int) {
|
|
self.lock.lock()
|
|
defer { self.lock.unlock() }
|
|
return (self.startCount, self.stopCount)
|
|
}
|
|
}
|
|
|
|
@Suite(.serialized) struct ScreenRecordServiceTests {
|
|
@Test func `clamp defaults and bounds`() {
|
|
#expect(ScreenRecordService._test_clampDurationMs(nil) == 10000)
|
|
#expect(ScreenRecordService._test_clampDurationMs(0) == 250)
|
|
#expect(ScreenRecordService._test_clampDurationMs(60001) == 60000)
|
|
|
|
#expect(ScreenRecordService._test_clampFps(nil) == 10)
|
|
#expect(ScreenRecordService._test_clampFps(0) == 1)
|
|
#expect(ScreenRecordService._test_clampFps(120) == 30)
|
|
#expect(ScreenRecordService._test_clampFps(.infinity) == 10)
|
|
}
|
|
|
|
@Test @MainActor func `record rejects invalid screen index`() async {
|
|
let recorder = ScreenRecordService()
|
|
do {
|
|
_ = try await recorder.record(
|
|
screenIndex: 1,
|
|
durationMs: 250,
|
|
fps: 5,
|
|
includeAudio: false,
|
|
outPath: nil)
|
|
Issue.record("Expected invalid screen index to throw")
|
|
} catch let error as ScreenRecordService.ScreenRecordError {
|
|
#expect(error.localizedDescription.contains("Invalid screen index") == true)
|
|
} catch {
|
|
Issue.record("Unexpected error type: \(error)")
|
|
}
|
|
}
|
|
|
|
@Test func `record stops capture when sleep is cancelled`() async {
|
|
let probe = ScreenRecordServiceProbe()
|
|
let started = AsyncStream<Void>.makeStream()
|
|
let recorder = ScreenRecordService(
|
|
startReplayKitCaptureAction: { _, _, completion in
|
|
probe.recordStart()
|
|
started.continuation.yield()
|
|
started.continuation.finish()
|
|
completion(nil)
|
|
},
|
|
stopReplayKitCaptureAction: { completion in
|
|
probe.recordStop()
|
|
completion(nil)
|
|
})
|
|
|
|
let recordingTask = Task {
|
|
try await recorder.record(
|
|
screenIndex: nil,
|
|
durationMs: 60000,
|
|
fps: 5,
|
|
includeAudio: false,
|
|
outPath: nil)
|
|
}
|
|
for await _ in started.stream {
|
|
break
|
|
}
|
|
recordingTask.cancel()
|
|
|
|
do {
|
|
_ = try await recordingTask.value
|
|
Issue.record("Expected cancellation to throw")
|
|
} catch is CancellationError {
|
|
// Expected; cleanup should stop ReplayKit before preserving cancellation.
|
|
} catch {
|
|
Issue.record("Unexpected error type: \(error)")
|
|
}
|
|
|
|
let counts = probe.counts()
|
|
#expect(counts.start == 1)
|
|
#expect(counts.stop == 1)
|
|
}
|
|
}
|