Outbound: remove channel-specific message action fallbacks

src/infra/outbound/message-action-runner.poll.test.ts

@@ -20,7 +20,6 @@ type MessageActionRunnerTestHelpersModule =
 let runMessageAction: MessageActionRunnerModule["runMessageAction"];
 let installMessageActionRunnerTestRegistry: MessageActionRunnerTestHelpersModule["installMessageActionRunnerTestRegistry"];
 let resetMessageActionRunnerTestRegistry: MessageActionRunnerTestHelpersModule["resetMessageActionRunnerTestRegistry"];
-let slackConfig: MessageActionRunnerTestHelpersModule["slackConfig"];
 let telegramConfig: MessageActionRunnerTestHelpersModule["telegramConfig"];
 
 async function runPollAction(params: {
@@ -37,10 +36,9 @@ async function runPollAction(params: {
   const call = mocks.executePollAction.mock.calls[0]?.[0] as
     | {
         resolveCorePoll?: () => {
-          durationSeconds?: number;
+          durationHours?: number;
           maxSelections?: number;
           threadId?: string;
-          isAnonymous?: boolean;
         };
         ctx?: { params?: Record<string, unknown> };
       }
@@ -60,7 +58,6 @@ describe("runMessageAction poll handling", () => {
     ({
       installMessageActionRunnerTestRegistry,
       resetMessageActionRunnerTestRegistry,
-      slackConfig,
       telegramConfig,
     } = await import("./message-action-runner.test-helpers.js"));
     installMessageActionRunnerTestRegistry();
@@ -88,36 +85,12 @@ describe("runMessageAction poll handling", () => {
       },
       message: /pollOption requires at least two values/i,
     },
-    {
-      name: "rejects durationSeconds outside telegram",
-      getCfg: () => slackConfig,
-      actionParams: {
-        channel: "slack",
-        target: "#C12345678",
-        pollQuestion: "Lunch?",
-        pollOption: ["Pizza", "Sushi"],
-        pollDurationSeconds: 60,
-      },
-      message: /pollDurationSeconds is only supported for Telegram polls/i,
-    },
-    {
-      name: "rejects poll visibility outside telegram",
-      getCfg: () => slackConfig,
-      actionParams: {
-        channel: "slack",
-        target: "#C12345678",
-        pollQuestion: "Lunch?",
-        pollOption: ["Pizza", "Sushi"],
-        pollPublic: true,
-      },
-      message: /pollAnonymous\/pollPublic are only supported for Telegram polls/i,
-    },
   ])("$name", async ({ getCfg, actionParams, message }) => {
     await expect(runPollAction({ cfg: getCfg(), actionParams })).rejects.toThrow(message);
     expect(mocks.executePollAction).toHaveBeenCalledTimes(1);
   });
 
-  it("passes Telegram durationSeconds, visibility, and auto threadId to executePollAction", async () => {
+  it("passes shared poll fields and auto threadId to executePollAction", async () => {
     const call = await runPollAction({
       cfg: telegramConfig,
       actionParams: {
@@ -125,8 +98,7 @@ describe("runMessageAction poll handling", () => {
         target: "telegram:123",
         pollQuestion: "Lunch?",
         pollOption: ["Pizza", "Sushi"],
-        pollDurationSeconds: 90,
-        pollPublic: true,
+        pollDurationHours: 2,
       },
       toolContext: {
         currentChannelId: "telegram:123",
@@ -134,8 +106,7 @@ describe("runMessageAction poll handling", () => {
       },
     });
 
-    expect(call?.durationSeconds).toBe(90);
-    expect(call?.isAnonymous).toBe(false);
+    expect(call?.durationHours).toBe(2);
     expect(call?.threadId).toBe("42");
     expect(call?.ctx?.params?.threadId).toBe("42");
   });

src/infra/outbound/message-action-runner.ts

@@ -16,7 +16,7 @@ import type {
 import type { OpenClawConfig } from "../../config/config.js";
 import { hasInteractiveReplyBlocks, hasReplyPayloadContent } from "../../interactive/payload.js";
 import { getAgentScopedMediaLocalRoots } from "../../media/local-roots.js";
-import { hasPollCreationParams, resolveTelegramPollVisibility } from "../../poll-params.js";
+import { hasPollCreationParams } from "../../poll-params.js";
 import { resolvePollMaxSelections } from "../../polls.js";
 import { buildChannelAccountBindings } from "../../routing/bindings.js";
 import { normalizeAgentId } from "../../routing/session-key.js";
@@ -477,12 +477,6 @@ async function handleSendAction(ctx: ResolvedActionContext): Promise<MessageActi
   });
 
   const mediaUrl = readStringParam(params, "media", { trim: false });
-  if (channel === "whatsapp") {
-    message = message.replace(/^(?:[ \t]*\r?\n)+/, "");
-    if (!message.trim()) {
-      message = "";
-    }
-  }
   if (
     !hasReplyPayloadContent(
       {
@@ -638,34 +632,18 @@ async function handlePollAction(ctx: ResolvedActionContext): Promise<MessageActi
         throw new Error("pollOption requires at least two values");
       }
       const allowMultiselect = readBooleanParam(params, "pollMulti") ?? false;
-      const pollAnonymous = readBooleanParam(params, "pollAnonymous");
-      const pollPublic = readBooleanParam(params, "pollPublic");
-      const isAnonymous = resolveTelegramPollVisibility({ pollAnonymous, pollPublic });
       const durationHours = readNumberParam(params, "pollDurationHours", {
         integer: true,
         strict: true,
       });
-      const durationSeconds = readNumberParam(params, "pollDurationSeconds", {
-        integer: true,
-        strict: true,
-      });
-
-      if (durationSeconds !== undefined && channel !== "telegram") {
-        throw new Error("pollDurationSeconds is only supported for Telegram polls");
-      }
-      if (isAnonymous !== undefined && channel !== "telegram") {
-        throw new Error("pollAnonymous/pollPublic are only supported for Telegram polls");
-      }
 
       return {
         to,
         question,
         options,
         maxSelections: resolvePollMaxSelections(options.length, allowMultiselect),
-        durationSeconds: durationSeconds ?? undefined,
         durationHours: durationHours ?? undefined,
         threadId: resolvedThreadId ?? undefined,
-        isAnonymous,
       };
     },
   });