vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-04-21 22:21:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(test): split extra params resolver coverage

Browse Source
This commit is contained in:
Peter Steinberger
2026-04-06 06:44:47 +01:00
parent b432dc5af9
commit 0c63fccc1e
2 changed files with 217 additions and 216 deletions
Download Patch File Download Diff File Expand all files Collapse all files

217
src/agents/pi-embedded-runner-extraparams-resolve.test.ts Normal file
View File

@@ -0,0 +1,217 @@
import { describe, expect, it } from "vitest";
import { resolveExtraParams } from "./pi-embedded-runner/extra-params.js";
describe("resolveExtraParams", () => {
it("returns undefined with no model config", () => {
const result = resolveExtraParams({
cfg: undefined,
provider: "zai",
modelId: "glm-4.7",
});
expect(result).toBeUndefined();
});
it("applies default runtime params for OpenAI GPT-5 models", () => {
const result = resolveExtraParams({
cfg: undefined,
provider: "openai",
modelId: "gpt-5.4",
});
expect(result).toEqual({
parallel_tool_calls: true,
text_verbosity: "low",
openaiWsWarmup: true,
});
});
it("returns params for exact provider/model key", () => {
const result = resolveExtraParams({
cfg: {
agents: {
defaults: {
models: {
"openai/gpt-4": {
params: {
temperature: 0.7,
maxTokens: 2048,
},
},
},
},
},
},
provider: "openai",
modelId: "gpt-4",
});
expect(result).toEqual({
temperature: 0.7,
maxTokens: 2048,
});
});
it("ignores unrelated model entries", () => {
const result = resolveExtraParams({
cfg: {
agents: {
defaults: {
models: {
"openai/gpt-4": {
params: {
temperature: 0.7,
},
},
},
},
},
},
provider: "openai",
modelId: "gpt-4.1-mini",
});
expect(result).toBeUndefined();
});
it("returns per-agent params when agentId matches", () => {
const result = resolveExtraParams({
cfg: {
agents: {
list: [
{
id: "risk-reviewer",
params: { cacheRetention: "none" },
},
],
},
},
provider: "anthropic",
modelId: "claude-opus-4-6",
agentId: "risk-reviewer",
});
expect(result).toEqual({ cacheRetention: "none" });
});
it("merges per-agent params over global model defaults", () => {
const result = resolveExtraParams({
cfg: {
agents: {
defaults: {
models: {
"anthropic/claude-opus-4-6": {
params: {
temperature: 0.5,
cacheRetention: "long",
},
},
},
},
list: [
{
id: "risk-reviewer",
params: { cacheRetention: "none" },
},
],
},
},
provider: "anthropic",
modelId: "claude-opus-4-6",
agentId: "risk-reviewer",
});
expect(result).toEqual({
temperature: 0.5,
cacheRetention: "none",
});
});
it("preserves higher-precedence agent parallelToolCalls override across alias styles", () => {
const result = resolveExtraParams({
cfg: {
agents: {
defaults: {
models: {
"openai/gpt-4.1": {
params: {
parallel_tool_calls: true,
},
},
},
},
list: [
{
id: "main",
params: {
parallelToolCalls: false,
},
},
],
},
},
provider: "openai",
modelId: "gpt-4.1",
agentId: "main",
});
expect(result).toEqual({
parallel_tool_calls: false,
});
});
it("canonicalizes text verbosity alias styles with agent override precedence", () => {
const result = resolveExtraParams({
cfg: {
agents: {
defaults: {
models: {
"openai/gpt-5.4": {
params: {
text_verbosity: "high",
},
},
},
},
list: [
{
id: "main",
params: {
textVerbosity: "low",
},
},
],
},
},
provider: "openai",
modelId: "gpt-5.4",
agentId: "main",
});
expect(result).toEqual({
openaiWsWarmup: true,
parallel_tool_calls: true,
text_verbosity: "low",
});
});
it("ignores per-agent params when agentId does not match", () => {
const result = resolveExtraParams({
cfg: {
agents: {
list: [
{
id: "risk-reviewer",
params: { cacheRetention: "none" },
},
],
},
},
provider: "anthropic",
modelId: "claude-opus-4-6",
agentId: "main",
});
expect(result).toBeUndefined();
});
});

216
src/agents/pi-embedded-runner-extraparams.test.ts
View File

@@ -125,7 +125,6 @@ import {
import {
applyExtraParamsToAgent,
resolveAgentTransportOverride,
resolveExtraParams,
resolvePreparedExtraParams,
} from "./pi-embedded-runner/extra-params.js";
import { createGoogleThinkingPayloadWrapper } from "./pi-embedded-runner/google-stream-wrappers.js";
@@ -313,221 +312,6 @@ afterEach(() => {
extraParamsTesting.resetProviderRuntimeDepsForTest();
});
describe("resolveExtraParams", () => {
it("returns undefined with no model config", () => {
const result = resolveExtraParams({
cfg: undefined,
provider: "zai",
modelId: "glm-4.7",
});
expect(result).toBeUndefined();
});
it("applies default runtime params for OpenAI GPT-5 models", () => {
const result = resolveExtraParams({
cfg: undefined,
provider: "openai",
modelId: "gpt-5.4",
});
expect(result).toEqual({
parallel_tool_calls: true,
text_verbosity: "low",
openaiWsWarmup: true,
});
});
it("returns params for exact provider/model key", () => {
const result = resolveExtraParams({
cfg: {
agents: {
defaults: {
models: {
"openai/gpt-4": {
params: {
temperature: 0.7,
maxTokens: 2048,
},
},
},
},
},
},
provider: "openai",
modelId: "gpt-4",
});
expect(result).toEqual({
temperature: 0.7,
maxTokens: 2048,
});
});
it("ignores unrelated model entries", () => {
const result = resolveExtraParams({
cfg: {
agents: {
defaults: {
models: {
"openai/gpt-4": {
params: {
temperature: 0.7,
},
},
},
},
},
},
provider: "openai",
modelId: "gpt-4.1-mini",
});
expect(result).toBeUndefined();
});
it("returns per-agent params when agentId matches", () => {
const result = resolveExtraParams({
cfg: {
agents: {
list: [
{
id: "risk-reviewer",
params: { cacheRetention: "none" },
},
],
},
},
provider: "anthropic",
modelId: "claude-opus-4-6",
agentId: "risk-reviewer",
});
expect(result).toEqual({ cacheRetention: "none" });
});
it("merges per-agent params over global model defaults", () => {
const result = resolveExtraParams({
cfg: {
agents: {
defaults: {
models: {
"anthropic/claude-opus-4-6": {
params: {
temperature: 0.5,
cacheRetention: "long",
},
},
},
},
list: [
{
id: "risk-reviewer",
params: { cacheRetention: "none" },
},
],
},
},
provider: "anthropic",
modelId: "claude-opus-4-6",
agentId: "risk-reviewer",
});
expect(result).toEqual({
temperature: 0.5,
cacheRetention: "none",
});
});
it("preserves higher-precedence agent parallelToolCalls override across alias styles", () => {
const result = resolveExtraParams({
cfg: {
agents: {
defaults: {
models: {
"openai/gpt-4.1": {
params: {
parallel_tool_calls: true,
},
},
},
},
list: [
{
id: "main",
params: {
parallelToolCalls: false,
},
},
],
},
},
provider: "openai",
modelId: "gpt-4.1",
agentId: "main",
});
expect(result).toEqual({
parallel_tool_calls: false,
});
});
it("canonicalizes text verbosity alias styles with agent override precedence", () => {
const result = resolveExtraParams({
cfg: {
agents: {
defaults: {
models: {
"openai/gpt-5.4": {
params: {
text_verbosity: "high",
},
},
},
},
list: [
{
id: "main",
params: {
textVerbosity: "low",
},
},
],
},
},
provider: "openai",
modelId: "gpt-5.4",
agentId: "main",
});
expect(result).toEqual({
openaiWsWarmup: true,
parallel_tool_calls: true,
text_verbosity: "low",
});
});
it("ignores per-agent params when agentId does not match", () => {
const result = resolveExtraParams({
cfg: {
agents: {
list: [
{
id: "risk-reviewer",
params: { cacheRetention: "none" },
},
],
},
},
provider: "anthropic",
modelId: "claude-opus-4-6",
agentId: "main",
});
expect(result).toBeUndefined();
});
});
describe("applyExtraParamsToAgent", () => {
function createOptionsCaptureAgent() {
const calls: Array<(SimpleStreamOptions & { openaiWsWarmup?: boolean }) | undefined> = [];