vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-09 18:30:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: clarify hook workspace assertions

Browse Source
This commit is contained in:
Peter Steinberger
2026-05-08 08:50:28 +01:00
parent e63e4f9551
commit 1ae3e5b527
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/hooks/workspace.test.ts
View File

@@ -49,6 +49,10 @@ function tryCreateHardlinkOrSkip(createLink: () => void): boolean {
}
}
function hookNames(entries: ReturnType<typeof loadHookEntriesFromDir>): string[] {
return entries.map((entry) => entry.hook.name);
}
describe("hooks workspace", () => {
it("ignores package.json hook paths that traverse outside package directory", () => {
const root = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-hooks-workspace-"));
@@ -66,7 +70,7 @@ describe("hooks workspace", () => {
writeHookPackageManifest(pkgDir, ["../outside"]);
const entries = loadHookEntriesFromDir({ dir: hooksRoot, source: "openclaw-workspace" });
expect(entries.some((e) => e.hook.name === "outside")).toBe(false);
expect(hookNames(entries)).not.toContain("outside");
});
it("accepts package.json hook paths within package directory", () => {
@@ -84,7 +88,7 @@ describe("hooks workspace", () => {
writeHookPackageManifest(pkgDir, ["./nested"]);
const entries = loadHookEntriesFromDir({ dir: hooksRoot, source: "openclaw-workspace" });
expect(entries.some((e) => e.hook.name === "nested")).toBe(true);
expect(hookNames(entries)).toContain("nested");
});
it("ignores package.json hook paths that escape via symlink", () => {
@@ -108,7 +112,7 @@ describe("hooks workspace", () => {
writeHookPackageManifest(pkgDir, ["./linked"]);
const entries = loadHookEntriesFromDir({ dir: hooksRoot, source: "openclaw-workspace" });
expect(entries.some((e) => e.hook.name === "outside")).toBe(false);
expect(hookNames(entries)).not.toContain("outside");
});
it("ignores hooks with hardlinked HOOK.md aliases", () => {
@@ -128,8 +132,7 @@ describe("hooks workspace", () => {
}
const entries = loadHookEntriesFromDir({ dir: hooksRoot, source: "openclaw-workspace" });
expect(entries.some((e) => e.hook.name === "hardlink-hook")).toBe(false);
expect(entries.some((e) => e.hook.name === "outside")).toBe(false);
expect(hookNames(entries)).not.toEqual(expect.arrayContaining(["hardlink-hook", "outside"]));
});
it("ignores hooks with hardlinked handler aliases", () => {
@@ -147,7 +150,7 @@ describe("hooks workspace", () => {
}
const entries = loadHookEntriesFromDir({ dir: hooksRoot, source: "openclaw-workspace" });
expect(entries.some((e) => e.hook.name === "hardlink-handler-hook")).toBe(false);
expect(hookNames(entries)).not.toContain("hardlink-handler-hook");
});
it("does not let workspace hooks override managed hooks with the same name", () => {