vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-17 02:40:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: tighten security audit finding assertions

Browse Source
This commit is contained in:
Peter Steinberger
2026-05-09 22:59:57 +01:00
parent 8334e755a1
commit 34d275cf87
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/security/audit-gateway-http-auth.test.ts
View File

@@ -5,7 +5,10 @@ import {
collectGatewayHttpSessionKeyOverrideFindings,
} from "./audit-extra.sync.js";
function requireFinding(findings: Array<{ checkId: string; detail: string }>, checkId: string) {
function requireFinding(
findings: Array<{ checkId: string; detail: string; severity?: string }>,
checkId: string,
) {
const finding = findings.find((entry) => entry.checkId === checkId);
if (!finding) {
throw new Error(`Expected ${checkId} finding`);
@@ -81,9 +84,9 @@ describe("security audit gateway HTTP auth findings", () => {
];
if (expectedFinding) {
expect(findings).toEqual(expect.arrayContaining([expect.objectContaining(expectedFinding)]));
const finding = requireFinding(findings, expectedFinding.checkId);
expect(finding.severity).toBe(expectedFinding.severity);
if (detailIncludes) {
const finding = requireFinding(findings, expectedFinding.checkId);
for (const text of detailIncludes) {
expect(finding.detail, `${expectedFinding.checkId}:${text}`).toContain(text);
}

5
src/security/audit-summary.test.ts
View File

@@ -6,12 +6,11 @@ function requireAttackSurfaceSummary(
findings: ReturnType<typeof collectAttackSurfaceSummaryFindings>,
) {
const summary = findings.find((f) => f.checkId === "summary.attack_surface");
expect(summary).toEqual(
expect.objectContaining({ checkId: "summary.attack_surface", severity: "info" }),
);
if (!summary) {
throw new Error("Expected attack surface summary finding");
}
expect(summary.checkId).toBe("summary.attack_surface");
expect(summary.severity).toBe("info");
return summary;
}