vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-02 04:21:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(qa): stop waiting on yielded fanout runs (#116440)

Browse Source 
* fix(qa): observe resumed fanout completions

* test(qa): keep runtime watchdog assertions in runtime suite
This commit is contained in:
Dallin Romney
2026-07-31 14:36:59 +08:00
committed by GitHub
parent b13b3d9a0f
commit 397fe272a0
4 changed files with 31 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
extensions/qa-lab/src/scenario-catalog-channels.test.ts
View File

@@ -77,7 +77,10 @@ describe("qa scenario catalog channel contracts", () => {
const completionWait = flow.indexOf('"saveAs":"completedFanout"');
const storeReads = [...flow.matchAll(/readRawQaSessionStore/gu)].map((match) => match.index);
expect(flow).toContain("readSessionTranscriptSummary(env, sessionKey)");
expect(flow).toContain('"call":"startAgentRun"');
expect(flow).not.toContain('"call":"runAgentPrompt"');
expect(flow).toContain('"saveAs":"parentOutbound"');
expect(flow).toContain("messages.slice(parentOutboundStartIndex)");
expect(flow).not.toContain("waitForAgentHistoryReply");
expect(flow).not.toContain('"call":"waitForOutboundMessage"');
expect(flow).not.toContain("childCompletionMarker");
@@ -87,7 +90,7 @@ describe("qa scenario catalog channel contracts", () => {
);
expect(flow).toContain("Boolean(env.mock) ? config.expectedChildCompletionMarkers[0] : 'ok'");
expect(flow).toContain('saveAs":"timeoutEvidence');
expect(flow).toContain('saveAs":"recoveredParentTranscript');
expect(flow).toContain('saveAs":"recoveredParentOutbound');
expect(flow).not.toContain('"value":"subagent-1: ok\\nsubagent-2: ok"');
expect(flow).toContain("Promise.all([readSessionTranscriptSummary");
expect(completionWait).toBeGreaterThan(-1);

7
extensions/qa-lab/src/scenario-catalog.runtime-pair.test.ts
View File

@@ -76,5 +76,12 @@ describe("QA runtime-pair scenario catalog", () => {
requiredProviderMode: "live-frontier",
harnessRuntime: "codex",
});
const longContextFlow = JSON.stringify(
readQaScenarioById("long-context-progress-watchdog").execution.flow,
);
expect(longContextFlow).toContain("agentRuntime: { id: config.harnessRuntime }, params: null");
expect(longContextFlow).toContain(
"snapshot.config.agents?.defaults?.models?.[env.primaryModel]?.params === undefined",
);
});
});

25
qa/scenarios/agents/subagent-fanout-synthesis.yaml
View File

@@ -93,7 +93,12 @@ flow:
- set: sessionKey
value:
expr: "`agent:qa:fanout:${attempt}:${randomUUID().slice(0, 8)}`"
- call: runAgentPrompt
- set: parentOutboundStartIndex
value:
expr: "state.getSnapshot().messages.length"
# sessions_yield ends the original run. Observe the resumed
# announce turn through channel delivery instead of agent.wait.
- call: startAgentRun
args:
- ref: env
- sessionKey:
@@ -101,14 +106,13 @@ flow:
message:
ref: prompt
timeoutMs:
expr: liveTurnTimeoutMs(env, 90000)
expr: liveTurnTimeoutMs(env, 30000)
- call: waitForCondition
saveAs: parentTranscript
saveAs: parentOutbound
args:
- lambda:
async: true
expr: "readSessionTranscriptSummary(env, sessionKey).then((summary) => config.expectedReplyGroups.every((group) => group.some((needle) => normalizeLowercaseStringOrEmpty(summary.finalText).includes(needle))) ? summary : undefined).catch(() => undefined)"
- expr: "30000"
expr: "state.getSnapshot().messages.slice(parentOutboundStartIndex).find((message) => message.direction === 'outbound' && message.conversation.id === 'qa-operator' && config.expectedReplyGroups.every((group) => group.some((needle) => normalizeLowercaseStringOrEmpty(message.text).includes(needle))))"
- expr: liveTurnTimeoutMs(env, 90000)
- expr: "env.providerMode === 'mock-openai' ? 100 : 250"
# Native child completions are private. Wait for this parent's
# actual SQLite rows and both settled final transcripts.
@@ -151,7 +155,7 @@ flow:
expr: "`expected at least two sessions_spawn tool calls during subagent fanout scenario, saw ${fanoutSpawnRequests.length}`"
- set: details
value:
expr: "parentTranscript.finalText"
expr: "parentOutbound.text"
- set: lastError
value: __done__
catchAs: attemptError
@@ -218,16 +222,15 @@ flow:
expr: "timeoutSawAlpha && timeoutSawBeta && timeoutAlphaOk && timeoutBetaOk && (!env.mock || timeoutSpawnRequests.length >= 2)"
then:
- call: waitForCondition
saveAs: recoveredParentTranscript
saveAs: recoveredParentOutbound
args:
- lambda:
async: true
expr: "readSessionTranscriptSummary(env, sessionKey).then((summary) => config.expectedReplyGroups.every((group) => group.some((needle) => normalizeLowercaseStringOrEmpty(summary.finalText).includes(needle))) ? summary : undefined).catch(() => undefined)"
expr: "state.getSnapshot().messages.slice(parentOutboundStartIndex).find((message) => message.direction === 'outbound' && message.conversation.id === 'qa-operator' && config.expectedReplyGroups.every((group) => group.some((needle) => normalizeLowercaseStringOrEmpty(message.text).includes(needle))))"
- expr: liveTurnTimeoutMs(env, 30000)
- expr: "env.providerMode === 'mock-openai' ? 100 : 250"
- set: details
value:
expr: recoveredParentTranscript.finalText
expr: recoveredParentOutbound.text
- set: lastError
value: __done__
catchAs: recoveryError

6
qa/scenarios/runtime/long-context-progress-watchdog.yaml
View File

@@ -74,7 +74,7 @@ flow:
agents:
defaults:
models:
expr: "({ [env.primaryModel]: { agentRuntime: { id: config.harnessRuntime } } })"
expr: "({ [env.primaryModel]: { agentRuntime: { id: config.harnessRuntime }, params: null } })"
- call: waitForGatewayHealthy
args:
- ref: env
@@ -91,6 +91,10 @@ flow:
expr: "snapshot.config.agents?.defaults?.models?.[env.primaryModel]?.agentRuntime?.id === config.harnessRuntime"
message:
expr: "`expected ${env.primaryModel} agentRuntime.id=${config.harnessRuntime}, got ${JSON.stringify(snapshot.config.agents?.defaults?.models?.[env.primaryModel]?.agentRuntime)}`"
- assert:
expr: "snapshot.config.agents?.defaults?.models?.[env.primaryModel]?.params === undefined"
message:
expr: "`expected ${env.primaryModel} provider request params to be absent for the Codex harness, got ${JSON.stringify(snapshot.config.agents?.defaults?.models?.[env.primaryModel]?.params)}`"
- call: reset
- set: logCursor
value: