vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-06 16:30:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(security): redact secrets in exec approval prompts (#61077)

Browse Source
This commit is contained in:
Pengfei Ni
2026-04-11 12:04:35 +00:00
committed by Vincent Koc
parent dcaccdc5c4
commit 4935bc9e82
2 changed files with 26 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/infra/exec-approval-command-display.test.ts
View File

@@ -11,6 +11,29 @@ describe("sanitizeExecApprovalDisplayText", () => {
])("sanitizes exec approval display text for %j", (input, expected) => {
expect(sanitizeExecApprovalDisplayText(input)).toBe(expected);
});
it("redacts bearer tokens embedded in commands", () => {
const cmd =
'curl -H "Authorization: Bearer eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.longtoken.sig" https://api.example.com';
const result = sanitizeExecApprovalDisplayText(cmd);
expect(result).not.toContain("eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.longtoken.sig");
expect(result).toContain("curl");
expect(result).toContain("https://api.example.com");
});
it("redacts API keys in environment variable assignments", () => {
const cmd = 'API_SECRET="sk-abc123456789012345678" python script.py';
const result = sanitizeExecApprovalDisplayText(cmd);
expect(result).not.toContain("sk-abc123456789012345678");
expect(result).toContain("python script.py");
});
it("redacts GitHub personal access tokens", () => {
const cmd = "git clone https://ghp_1234567890abcdefghij1234567890abcdef@github.com/user/repo";
const result = sanitizeExecApprovalDisplayText(cmd);
expect(result).not.toContain("ghp_1234567890abcdefghij1234567890abcdef");
expect(result).toContain("git clone");
});
});
describe("resolveExecApprovalCommandDisplay", () => {

4
src/infra/exec-approval-command-display.ts
View File

@@ -1,3 +1,4 @@
import { redactSensitiveText } from "../logging/redact.js";
import type { ExecApprovalRequestPayload } from "./exec-approvals.js";
// Escape invisible characters that can spoof approval prompts in common UIs.
@@ -8,7 +9,8 @@ function formatCodePointEscape(char: string): string {
}
export function sanitizeExecApprovalDisplayText(commandText: string): string {
return commandText.replace(EXEC_APPROVAL_INVISIBLE_CHAR_REGEX, formatCodePointEscape);
const escaped = commandText.replace(EXEC_APPROVAL_INVISIBLE_CHAR_REGEX, formatCodePointEscape);
return redactSensitiveText(escaped);
}
function normalizePreview(commandText: string, commandPreview?: string | null): string | null {