test: tighten qa cli runtime assertions

extensions/discord/src/internal/interactions.test.ts

@@ -239,7 +239,9 @@ describe("BaseInteraction", () => {
     );
 
     const result = await wait;
-    expect(result.success).toBe(true);
+    if (!result.success) {
+      throw new Error("expected component wait to succeed");
+    }
     expect(result.customId).toBe("button1");
     expect(result.message).toBeInstanceOf(Message);
     expect(result.message?.id).toBe("message1");

extensions/qa-lab/src/cli.runtime.test.ts

@@ -84,6 +84,31 @@ import { runQaTelegramCommand } from "./live-transports/telegram/cli.runtime.js"
 import { defaultQaModelForMode as defaultQaProviderModelForMode } from "./model-selection.js";
 import type { QaProviderModeInput } from "./run-config.js";
 
+function mockFirstObjectArg(mock: unknown): Record<string, unknown> {
+  const calls = (mock as { mock?: { calls?: Array<Array<unknown>> } }).mock?.calls ?? [];
+  const [arg] = calls[0] ?? [];
+  expect(arg).toBeTypeOf("object");
+  expect(arg).not.toBeNull();
+  return arg as Record<string, unknown>;
+}
+
+function expectFields(value: unknown, expected: Record<string, unknown>): void {
+  expect(value).toBeTypeOf("object");
+  expect(value).not.toBeNull();
+  const record = value as Record<string, unknown>;
+  for (const [key, expectedValue] of Object.entries(expected)) {
+    expect(record[key], key).toEqual(expectedValue);
+  }
+}
+
+function expectWriteContains(mock: unknown, fragment: string): void {
+  const calls = (mock as { mock?: { calls?: Array<Array<unknown>> } }).mock?.calls ?? [];
+  expect(
+    calls.some(([value]) => String(value).includes(fragment)),
+    `write contains ${fragment}`,
+  ).toBe(true);
+}
+
 describe("qa cli runtime", () => {
   let stdoutWrite: ReturnType<typeof vi.spyOn>;
   let stderrWrite: ReturnType<typeof vi.spyOn>;
@@ -301,13 +326,11 @@ describe("qa cli runtime", () => {
       scenarioIds: ["telegram-help-command"],
     });
 
-    expect(runTelegramQaLive).toHaveBeenCalledWith(
-      expect.objectContaining({
-        repoRoot: path.resolve("/tmp/openclaw-repo"),
-        providerMode: "live-frontier",
-        allowFailures: undefined,
-      }),
-    );
+    expectFields(mockFirstObjectArg(runTelegramQaLive), {
+      repoRoot: path.resolve("/tmp/openclaw-repo"),
+      providerMode: "live-frontier",
+      allowFailures: undefined,
+    });
   });
 
   it("prints telegram scenario catalog without starting the live lane", async () => {
@@ -319,10 +342,9 @@ describe("qa cli runtime", () => {
 
     expect(listTelegramQaScenarioCatalog).toHaveBeenCalledWith("mock-openai");
     expect(runTelegramQaLive).not.toHaveBeenCalled();
-    expect(stdoutWrite).toHaveBeenCalledWith(
-      expect.stringContaining(
-        "telegram-status-command\tdefault\tTelegram status command reply\tstatus rationale refs=openclaw/openclaw#74698",
-      ),
+    expectWriteContains(
+      stdoutWrite,
+      "telegram-status-command\tdefault\tTelegram status command reply\tstatus rationale refs=openclaw/openclaw#74698",
     );
   });
 
@@ -390,14 +412,12 @@ describe("qa cli runtime", () => {
       concurrency: 3,
     });
 
-    expect(runQaSuiteFromRuntime).toHaveBeenCalledWith(
-      expect.objectContaining({
-        repoRoot: path.resolve("/tmp/openclaw-repo"),
-        transportId: "qa-channel",
-        scenarioIds: ["channel-chat-baseline", "thread-follow-up"],
-        concurrency: 3,
-      }),
-    );
+    expectFields(mockFirstObjectArg(runQaSuiteFromRuntime), {
+      repoRoot: path.resolve("/tmp/openclaw-repo"),
+      transportId: "qa-channel",
+      scenarioIds: ["channel-chat-baseline", "thread-follow-up"],
+      concurrency: 3,
+    });
   });
 
   it("sets a failing exit code when host suite scenarios fail", async () => {
@@ -492,9 +512,7 @@ describe("qa cli runtime", () => {
     });
 
     expect(runQaSuiteFromRuntime).toHaveBeenCalledTimes(2);
-    expect(stderrWrite).toHaveBeenCalledWith(
-      expect.stringContaining("[qa-suite] infra retry 1/1: agent.wait timeout"),
-    );
+    expectWriteContains(stderrWrite, "[qa-suite] infra retry 1/1: agent.wait timeout");
   });
 
   it("retries host suite runs once for qa-channel readiness timeouts", async () => {
@@ -516,10 +534,9 @@ describe("qa cli runtime", () => {
     });
 
     expect(runQaSuiteFromRuntime).toHaveBeenCalledTimes(2);
-    expect(stderrWrite).toHaveBeenCalledWith(
-      expect.stringContaining(
-        "[qa-suite] infra retry 1/1: timed out after 180000ms waiting for qa-channel ready",
-      ),
+    expectWriteContains(
+      stderrWrite,
+      "[qa-suite] infra retry 1/1: timed out after 180000ms waiting for qa-channel ready",
     );
   });
 
@@ -586,11 +603,9 @@ describe("qa cli runtime", () => {
       preflight: true,
     });
 
-    expect(runQaSuiteFromRuntime).toHaveBeenCalledWith({
+    const preflightArgs = mockFirstObjectArg(runQaSuiteFromRuntime);
+    expectFields(preflightArgs, {
       repoRoot,
-      outputDir: expect.stringContaining(
-        path.join(repoRoot, ".artifacts", "qa-e2e", "preflight", "suite-"),
-      ),
       transportId: "qa-channel",
       providerMode: "mock-openai",
       primaryModel: "openai/gpt-5.5",
@@ -598,9 +613,10 @@ describe("qa cli runtime", () => {
       scenarioIds: ["approval-turn-tool-followthrough"],
       concurrency: 1,
     });
-    expect(stdoutWrite).toHaveBeenCalledWith(
-      expect.stringContaining("QA parity preflight summary:"),
+    expect(String(preflightArgs.outputDir)).toContain(
+      path.join(repoRoot, ".artifacts", "qa-e2e", "preflight", "suite-"),
     );
+    expectWriteContains(stdoutWrite, "QA parity preflight summary:");
   });
 
   it("throws when parity preflight finds a failing sentinel scenario", async () => {
@@ -685,16 +701,14 @@ describe("qa cli runtime", () => {
       scenarioIds: ["claude-cli-provider-capabilities-subscription"],
     });
 
-    expect(runQaSuiteFromRuntime).toHaveBeenCalledWith(
-      expect.objectContaining({
-        repoRoot: path.resolve("/tmp/openclaw-repo"),
-        providerMode: "live-frontier",
-        primaryModel: "claude-cli/claude-sonnet-4-6",
-        alternateModel: "claude-cli/claude-sonnet-4-6",
-        claudeCliAuthMode: "subscription",
-        scenarioIds: ["claude-cli-provider-capabilities-subscription"],
-      }),
-    );
+    expectFields(mockFirstObjectArg(runQaSuiteFromRuntime), {
+      repoRoot: path.resolve("/tmp/openclaw-repo"),
+      providerMode: "live-frontier",
+      primaryModel: "claude-cli/claude-sonnet-4-6",
+      alternateModel: "claude-cli/claude-sonnet-4-6",
+      claudeCliAuthMode: "subscription",
+      scenarioIds: ["claude-cli-provider-capabilities-subscription"],
+    });
   });
 
   it("expands the agentic parity pack onto the suite scenario list", async () => {
@@ -704,26 +718,24 @@ describe("qa cli runtime", () => {
       scenarioIds: ["channel-chat-baseline"],
     });
 
-    expect(runQaSuiteFromRuntime).toHaveBeenCalledWith(
-      expect.objectContaining({
-        repoRoot: path.resolve("/tmp/openclaw-repo"),
-        scenarioIds: [
-          "channel-chat-baseline",
-          "approval-turn-tool-followthrough",
-          "model-switch-tool-continuity",
-          "source-docs-discovery-report",
-          "image-understanding-attachment",
-          "compaction-retry-mutating-tool",
-          "subagent-handoff",
-          "subagent-fanout-synthesis",
-          "subagent-stale-child-links",
-          "memory-recall",
-          "thread-memory-isolation",
-          "config-restart-capability-flip",
-          "instruction-followthrough-repo-contract",
-        ],
-      }),
-    );
+    expectFields(mockFirstObjectArg(runQaSuiteFromRuntime), {
+      repoRoot: path.resolve("/tmp/openclaw-repo"),
+      scenarioIds: [
+        "channel-chat-baseline",
+        "approval-turn-tool-followthrough",
+        "model-switch-tool-continuity",
+        "source-docs-discovery-report",
+        "image-understanding-attachment",
+        "compaction-retry-mutating-tool",
+        "subagent-handoff",
+        "subagent-fanout-synthesis",
+        "subagent-stale-child-links",
+        "memory-recall",
+        "thread-memory-isolation",
+        "config-restart-capability-flip",
+        "instruction-followthrough-repo-contract",
+      ],
+    });
   });
 
   it("rejects unknown suite CLI auth modes", async () => {
@@ -772,8 +784,8 @@ describe("qa cli runtime", () => {
   it("prints a markdown coverage report from scenario metadata", async () => {
     await runQaCoverageReportCommand({ repoRoot: process.cwd() });
 
-    expect(stdoutWrite).toHaveBeenCalledWith(expect.stringContaining("# QA Coverage Inventory"));
-    expect(stdoutWrite).toHaveBeenCalledWith(expect.stringContaining("memory.recall"));
+    expectWriteContains(stdoutWrite, "# QA Coverage Inventory");
+    expectWriteContains(stdoutWrite, "memory.recall");
   });
 
   it("resolves character eval paths and passes model refs through", async () => {
@@ -795,7 +807,9 @@ describe("qa cli runtime", () => {
       judgeConcurrency: 3,
     });
 
-    expect(runQaCharacterEval).toHaveBeenCalledWith({
+    const characterEvalArgs = mockFirstObjectArg(runQaCharacterEval);
+    expect(typeof characterEvalArgs.progress).toBe("function");
+    expectFields(characterEvalArgs, {
       repoRoot: path.resolve("/tmp/openclaw-repo"),
       outputDir: path.resolve("/tmp/openclaw-repo", ".artifacts/qa/character"),
       models: ["openai/gpt-5.5", "codex-cli/test-model"],
@@ -816,7 +830,6 @@ describe("qa cli runtime", () => {
       judgeBlindModels: true,
       candidateConcurrency: 4,
       judgeConcurrency: 3,
-      progress: expect.any(Function),
     });
   });
 
@@ -826,7 +839,9 @@ describe("qa cli runtime", () => {
       model: ["openai/gpt-5.5"],
     });
 
-    expect(runQaCharacterEval).toHaveBeenCalledWith({
+    const characterEvalArgs = mockFirstObjectArg(runQaCharacterEval);
+    expect(typeof characterEvalArgs.progress).toBe("function");
+    expectFields(characterEvalArgs, {
       repoRoot: path.resolve("/tmp/openclaw-repo"),
       outputDir: undefined,
       models: ["openai/gpt-5.5"],
@@ -841,7 +856,6 @@ describe("qa cli runtime", () => {
       judgeBlindModels: undefined,
       candidateConcurrency: undefined,
       judgeConcurrency: undefined,
-      progress: expect.any(Function),
     });
   });
 
@@ -946,18 +960,16 @@ describe("qa cli runtime", () => {
       scenarioIds: ["channel-chat-baseline"],
     });
 
-    expect(runQaMultipass).toHaveBeenCalledWith(
-      expect.objectContaining({
-        repoRoot: path.resolve("/tmp/openclaw-repo"),
-        transportId: "qa-channel",
-        providerMode: "live-frontier",
-        primaryModel: "openai/gpt-5.5",
-        alternateModel: "openai/gpt-5.5",
-        fastMode: true,
-        allowFailures: true,
-        scenarioIds: ["channel-chat-baseline"],
-      }),
-    );
+    expectFields(mockFirstObjectArg(runQaMultipass), {
+      repoRoot: path.resolve("/tmp/openclaw-repo"),
+      transportId: "qa-channel",
+      providerMode: "live-frontier",
+      primaryModel: "openai/gpt-5.5",
+      alternateModel: "openai/gpt-5.5",
+      fastMode: true,
+      allowFailures: true,
+      scenarioIds: ["channel-chat-baseline"],
+    });
   });
 
   it("sets a failing exit code when multipass summary reports failed scenarios", async () => {