vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-06 09:50:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: dedupe tool result hook fixtures

Browse Source
This commit is contained in:
Peter Steinberger
2026-04-18 21:54:58 +01:00
parent 2bca977ced
commit 607c855621
1 changed files with 43 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

110
src/agents/session-tool-result-guard.tool-result-persist-hook.test.ts
View File

@@ -59,6 +59,35 @@ function getPersistedToolResult(sm: ReturnType<typeof SessionManager.inMemory>)
return messages.find((m) => (m as any).role === "toolResult") as any;
}
function initializeTempPlugin(params: { tmpPrefix: string; id: string; body: string }) {
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), params.tmpPrefix));
process.env.OPENCLAW_BUNDLED_PLUGINS_DIR = "/nonexistent/bundled/plugins";
const plugin = writeTempPlugin({
dir: tmp,
id: params.id,
body: params.body,
});
const registry = loadOpenClawPlugins({
cache: false,
workspaceDir: tmp,
config: {
plugins: {
load: { paths: [plugin] },
allow: [params.id],
},
},
});
initializeGlobalHookRunner(registry);
}
function expectPersistedToolResultTextCapped(sm: ReturnType<typeof SessionManager.inMemory>) {
const toolResult = getPersistedToolResult(sm);
const text = toolResult.content.find((block: { type: string }) => block.type === "text")?.text;
expect(typeof text).toBe("string");
expect(text.length).toBeLessThanOrEqual(120);
expect(text).toContain("truncated");
}
afterEach(() => {
resetGlobalHookRunner();
if (originalBundledPluginsDir === undefined) {
@@ -136,11 +165,8 @@ describe("tool_result_persist hook", () => {
});
it("reapplies the cap after tool_result_persist expands a tool result", () => {
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-toolpersist-expand-"));
process.env.OPENCLAW_BUNDLED_PLUGINS_DIR = "/nonexistent/bundled/plugins";
const plugin = writeTempPlugin({
dir: tmp,
initializeTempPlugin({
tmpPrefix: "openclaw-toolpersist-expand-",
id: "persist-expand",
body: `export default { id: "persist-expand", register(api) {
api.on("tool_result_persist", (event) => {
@@ -150,22 +176,10 @@ describe("tool_result_persist hook", () => {
content: [{ type: "text", text: "y".repeat(5000) }],
},
};
}, { priority: 10 });
} };`,
}, { priority: 10 });
} };`,
});
const registry = loadOpenClawPlugins({
cache: false,
workspaceDir: tmp,
config: {
plugins: {
load: { paths: [plugin] },
allow: ["persist-expand"],
},
},
});
initializeGlobalHookRunner(registry);
const sm = guardSessionManager(SessionManager.inMemory(), {
agentId: "main",
sessionKey: "main",
@@ -173,41 +187,22 @@ describe("tool_result_persist hook", () => {
});
appendToolCallAndResult(sm);
const toolResult = getPersistedToolResult(sm);
const text = toolResult.content.find((block: { type: string }) => block.type === "text")?.text;
expect(typeof text).toBe("string");
expect(text.length).toBeLessThanOrEqual(120);
expect(text).toContain("truncated");
expectPersistedToolResultTextCapped(sm);
});
});
describe("before_message_write hook", () => {
it("continues persistence when a before_message_write hook throws", () => {
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-before-write-"));
process.env.OPENCLAW_BUNDLED_PLUGINS_DIR = "/nonexistent/bundled/plugins";
const plugin = writeTempPlugin({
dir: tmp,
initializeTempPlugin({
tmpPrefix: "openclaw-before-write-",
id: "before-write-throws",
body: `export default { id: "before-write-throws", register(api) {
api.on("before_message_write", () => {
throw new Error("boom");
}, { priority: 10 });
} };`,
}, { priority: 10 });
} };`,
});
const registry = loadOpenClawPlugins({
cache: false,
workspaceDir: tmp,
config: {
plugins: {
load: { paths: [plugin] },
allow: ["before-write-throws"],
},
},
});
initializeGlobalHookRunner(registry);
const sm = guardSessionManager(SessionManager.inMemory(), {
agentId: "main",
sessionKey: "main",
@@ -229,11 +224,8 @@ describe("before_message_write hook", () => {
});
it("reapplies the cap after before_message_write expands a tool result", () => {
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-before-write-expand-"));
process.env.OPENCLAW_BUNDLED_PLUGINS_DIR = "/nonexistent/bundled/plugins";
const plugin = writeTempPlugin({
dir: tmp,
initializeTempPlugin({
tmpPrefix: "openclaw-before-write-expand-",
id: "before-write-expand",
body: `export default { id: "before-write-expand", register(api) {
api.on("before_message_write", (event) => {
@@ -244,22 +236,10 @@ describe("before_message_write hook", () => {
content: [{ type: "text", text: "z".repeat(5000) }],
},
};
}, { priority: 10 });
} };`,
}, { priority: 10 });
} };`,
});
const registry = loadOpenClawPlugins({
cache: false,
workspaceDir: tmp,
config: {
plugins: {
load: { paths: [plugin] },
allow: ["before-write-expand"],
},
},
});
initializeGlobalHookRunner(registry);
const sm = guardSessionManager(SessionManager.inMemory(), {
agentId: "main",
sessionKey: "main",
@@ -267,10 +247,6 @@ describe("before_message_write hook", () => {
});
appendToolCallAndResult(sm);
const toolResult = getPersistedToolResult(sm);
const text = toolResult.content.find((block: { type: string }) => block.type === "text")?.text;
expect(typeof text).toBe("string");
expect(text.length).toBeLessThanOrEqual(120);
expect(text).toContain("truncated");
expectPersistedToolResultTextCapped(sm);
});
});