test: trim nextcloud send config import cost

This commit is contained in:
Peter Steinberger
2026-04-03 14:02:41 +01:00
parent a884ad3cf2
commit 6d05607cd9
3 changed files with 31 additions and 77 deletions

View File

@@ -18,69 +18,26 @@ const hoisted = vi.hoisted(() => ({
mockFetchGuard: vi.fn(),
}));
vi.mock("./runtime.js", async (importOriginal) => {
const actual = await importOriginal<typeof import("./runtime.js")>();
vi.mock("./send.runtime.js", () => {
return {
...actual,
getNextcloudTalkRuntime: () => createSendCfgThreadingRuntime(hoisted),
};
});
vi.mock("./accounts.js", async (importOriginal) => {
const actual = await importOriginal<typeof import("./accounts.js")>();
return {
...actual,
resolveNextcloudTalkAccount: hoisted.resolveNextcloudTalkAccount,
};
});
vi.mock("./signature.js", async (importOriginal) => {
const actual = await importOriginal<typeof import("./signature.js")>();
return {
...actual,
convertMarkdownTables: hoisted.convertMarkdownTables,
fetchWithSsrFGuard: hoisted.mockFetchGuard,
generateNextcloudTalkSignature: hoisted.generateNextcloudTalkSignature,
};
});
vi.mock("openclaw/plugin-sdk/ssrf-runtime", async (importOriginal) => {
const original = (await importOriginal()) as Record<string, unknown>;
return {
...original,
fetchWithSsrFGuard: hoisted.mockFetchGuard,
};
});
vi.mock("../../../src/infra/net/fetch-guard.js", async (importOriginal) => {
const original = (await importOriginal()) as Record<string, unknown>;
return {
...original,
fetchWithSsrFGuard: hoisted.mockFetchGuard,
};
});
vi.mock("openclaw/plugin-sdk/config-runtime", async (importOriginal) => {
const original = (await importOriginal()) as Record<string, unknown>;
return {
...original,
getNextcloudTalkRuntime: () => createSendCfgThreadingRuntime(hoisted),
resolveNextcloudTalkAccount: hoisted.resolveNextcloudTalkAccount,
resolveMarkdownTableMode: hoisted.resolveMarkdownTableMode,
};
});
vi.mock("openclaw/plugin-sdk/text-runtime", async (importOriginal) => {
const original = (await importOriginal()) as Record<string, unknown>;
return {
...original,
convertMarkdownTables: hoisted.convertMarkdownTables,
};
});
const accountsActual = await vi.importActual<typeof import("./accounts.js")>("./accounts.js");
hoisted.resolveNextcloudTalkAccount.mockImplementation(accountsActual.resolveNextcloudTalkAccount);
const { sendMessageNextcloudTalk, sendReactionNextcloudTalk } = await import("./send.js");
describe("nextcloud-talk send cfg threading", () => {
const fetchMock = vi.fn<typeof fetch>();
const defaultAccount = {
accountId: "default",
baseUrl: "https://nextcloud.example.com",
secret: "secret-value",
};
beforeEach(() => {
vi.stubGlobal("fetch", fetchMock);
@@ -89,9 +46,13 @@ describe("nextcloud-talk send cfg threading", () => {
const response = await globalThis.fetch(p.url, p.init);
return { response, release: async () => {}, finalUrl: p.url };
});
hoisted.resolveNextcloudTalkAccount.mockImplementation(
accountsActual.resolveNextcloudTalkAccount,
);
hoisted.loadConfig.mockReset();
hoisted.resolveMarkdownTableMode.mockClear();
hoisted.convertMarkdownTables.mockClear();
hoisted.record.mockReset();
hoisted.generateNextcloudTalkSignature.mockClear();
hoisted.resolveNextcloudTalkAccount.mockReset();
hoisted.resolveNextcloudTalkAccount.mockReturnValue(defaultAccount);
});
afterEach(() => {
@@ -102,11 +63,6 @@ describe("nextcloud-talk send cfg threading", () => {
it("uses provided cfg for sendMessage and skips runtime loadConfig", async () => {
const cfg = { source: "provided" } as const;
hoisted.resolveNextcloudTalkAccount.mockReturnValue({
accountId: "default",
baseUrl: "https://nextcloud.example.com",
secret: "secret-value", // pragma: allowlist secret
});
fetchMock.mockResolvedValueOnce(
new Response(
JSON.stringify({
@@ -148,11 +104,6 @@ describe("nextcloud-talk send cfg threading", () => {
it("sends with provided cfg even when the runtime store is not initialized", async () => {
const cfg = { source: "provided" } as const;
hoisted.resolveNextcloudTalkAccount.mockReturnValue({
accountId: "default",
baseUrl: "https://nextcloud.example.com",
secret: "secret-value",
});
hoisted.record.mockImplementation(() => {
throw new Error("Nextcloud Talk runtime not initialized");
});
@@ -192,11 +143,6 @@ describe("nextcloud-talk send cfg threading", () => {
it("falls back to runtime cfg for sendReaction when cfg is omitted", async () => {
const runtimeCfg = { source: "runtime" } as const;
hoisted.loadConfig.mockReturnValueOnce(runtimeCfg);
hoisted.resolveNextcloudTalkAccount.mockReturnValue({
accountId: "default",
baseUrl: "https://nextcloud.example.com",
secret: "secret-value", // pragma: allowlist secret
});
fetchMock.mockResolvedValueOnce(new Response("{}", { status: 200 }));
const result = await sendReactionNextcloudTalk("room:ops", "m-1", "👍", {

View File

@@ -0,0 +1,6 @@
export { resolveMarkdownTableMode } from "openclaw/plugin-sdk/config-runtime";
export { convertMarkdownTables } from "openclaw/plugin-sdk/text-runtime";
export { fetchWithSsrFGuard } from "../runtime-api.js";
export { resolveNextcloudTalkAccount } from "./accounts.js";
export { getNextcloudTalkRuntime } from "./runtime.js";
export { generateNextcloudTalkSignature } from "./signature.js";

View File

@@ -1,10 +1,12 @@
import { resolveMarkdownTableMode } from "openclaw/plugin-sdk/config-runtime";
import { convertMarkdownTables } from "openclaw/plugin-sdk/text-runtime";
import { fetchWithSsrFGuard } from "../runtime-api.js";
import { resolveNextcloudTalkAccount } from "./accounts.js";
import { stripNextcloudTalkTargetPrefix } from "./normalize.js";
import { getNextcloudTalkRuntime } from "./runtime.js";
import { generateNextcloudTalkSignature } from "./signature.js";
import {
convertMarkdownTables,
fetchWithSsrFGuard,
generateNextcloudTalkSignature,
getNextcloudTalkRuntime,
resolveMarkdownTableMode,
resolveNextcloudTalkAccount,
} from "./send.runtime.js";
import type { CoreConfig, NextcloudTalkSendResult } from "./types.js";
type NextcloudTalkSendOpts = {