fix(approvals): use canonical decision values in interactive button payloads

This commit is contained in:
James Cowan
2026-04-01 16:14:58 -03:00
committed by Peter Steinberger
parent 316d10637b
commit 7fea8250fb
6 changed files with 12 additions and 12 deletions

View File

@@ -100,7 +100,7 @@ describe("TelegramExecApprovalHandler", () => {
},
{
text: "Allow Always",
callback_data: "/approve 9f1c7d5d-b1fb-46ef-ac45-662723b65bb7 always",
callback_data: "/approve 9f1c7d5d-b1fb-46ef-ac45-662723b65bb7 allow-always",
style: "primary",
},
{

View File

@@ -95,7 +95,7 @@ function buildTelegramExecApprovalPendingPayloadForTest(params: {
},
{
label: "Allow Always",
value: `/approve ${params.request.id} always`,
value: `/approve ${params.request.id} allow-always`,
style: "primary",
},
{
@@ -115,7 +115,7 @@ function buildTelegramExecApprovalPendingPayloadForTest(params: {
buttons: [
[
{ text: "Allow Once", callback_data: `/approve ${params.request.id} allow-once` },
{ text: "Allow Always", callback_data: `/approve ${params.request.id} always` },
{ text: "Allow Always", callback_data: `/approve ${params.request.id} allow-always` },
],
[{ text: "Deny", callback_data: `/approve ${params.request.id} deny` }],
],
@@ -465,7 +465,7 @@ describe("exec approval forwarder", () => {
},
{
label: "Allow Always",
value: "/approve req-1 always",
value: "/approve req-1 allow-always",
style: "primary",
},
{

View File

@@ -119,7 +119,7 @@ describe("exec approval reply helpers", () => {
},
{
label: "Allow Always",
value: "/approve req-1 always",
value: "/approve req-1 allow-always",
style: "primary",
},
{
@@ -236,7 +236,7 @@ describe("exec approval reply helpers", () => {
decision: "allow-always",
label: "Allow Always",
style: "primary",
command: "/approve req-1 always",
command: "/approve req-1 allow-always",
},
{
decision: "deny",
@@ -256,7 +256,7 @@ describe("exec approval reply helpers", () => {
type: "buttons",
buttons: [
{ label: "Allow Once", value: "/approve req-1 allow-once", style: "success" },
{ label: "Allow Always", value: "/approve req-1 always", style: "primary" },
{ label: "Allow Always", value: "/approve req-1 allow-always", style: "primary" },
{ label: "Deny", value: "/approve req-1 deny", style: "danger" },
],
},
@@ -270,7 +270,7 @@ describe("exec approval reply helpers", () => {
approvalCommandId: "req-1",
decision: "allow-always",
}),
).toBe("/approve req-1 always");
).toBe("/approve req-1 allow-always");
expect(parseExecApprovalCommandText("/approve req-1 deny")).toEqual({
approvalId: "req-1",

View File

@@ -67,7 +67,7 @@ export function buildExecApprovalCommandText(params: {
approvalCommandId: string;
decision: ExecApprovalReplyDecision;
}): string {
return `/approve ${params.approvalCommandId} ${params.decision === "allow-always" ? "always" : params.decision}`;
return `/approve ${params.approvalCommandId} ${params.decision}`;
}
export function buildExecApprovalActionDescriptors(params: {

View File

@@ -106,7 +106,7 @@ describe("plugin approval forwarding", () => {
},
{
label: "Allow Always",
value: "/approve plugin-req-1 always",
value: "/approve plugin-req-1 allow-always",
style: "primary",
},
{

View File

@@ -28,7 +28,7 @@ describe("plugin-sdk/approval-renderers", () => {
},
{
label: "Allow Always",
value: "/approve plugin:approval-123 always",
value: "/approve plugin:approval-123 allow-always",
style: "primary",
},
{
@@ -75,7 +75,7 @@ describe("plugin-sdk/approval-renderers", () => {
},
{
label: "Allow Always",
value: "/approve plugin-approval-123 always",
value: "/approve plugin-approval-123 allow-always",
style: "primary",
},
{