test: avoid zero length filter assertions

This commit is contained in:
Peter Steinberger
2026-05-08 21:49:20 +01:00
parent ed4d7bb94e
commit 84c4e66288
3 changed files with 12 additions and 12 deletions

View File

@@ -673,7 +673,7 @@ describe("qa-lab server", () => {
const snapshot = (await (await fetchWithRetry(`${lab.baseUrl}/api/state`)).json()) as {
messages: Array<{ direction: string }>;
};
expect(snapshot.messages.filter((message) => message.direction === "outbound")).toHaveLength(0);
expect(snapshot.messages.some((message) => message.direction === "outbound")).toBe(false);
});
it("exposes structured outcomes and can attach control-ui after startup", async () => {

View File

@@ -1538,7 +1538,7 @@ describe("agent event handler", () => {
emitLifecycleEnd(handler, "run-hidden", 2);
expect(chatBroadcastCalls(broadcast)).toHaveLength(0);
expect(broadcast.mock.calls.filter(([event]) => event === "agent")).toHaveLength(0);
expect(broadcast.mock.calls.some(([event]) => event === "agent")).toBe(false);
expect(nodeSendToSession).not.toHaveBeenCalled();
expect(persistGatewaySessionLifecycleEventMock).toHaveBeenCalledWith({
sessionKey: "session-hidden",

View File

@@ -261,7 +261,7 @@ describe("stuck session diagnostics threshold", () => {
unsubscribe();
}
expect(events.filter((event) => event.type === "session.long_running")).toHaveLength(0);
expect(events.some((event) => event.type === "session.long_running")).toBe(false);
const stuckEvents = events.filter((event) => event.type === "session.stuck");
expect(stuckEvents).toHaveLength(1);
expect(stuckEvents[0]).toMatchObject({
@@ -298,9 +298,9 @@ describe("stuck session diagnostics threshold", () => {
unsubscribe();
}
expect(events.filter((event) => event.type === "session.stuck")).toHaveLength(0);
expect(events.filter((event) => event.type === "session.stalled")).toHaveLength(0);
expect(events.filter((event) => event.type === "session.long_running")).toHaveLength(0);
expect(events.some((event) => event.type === "session.stuck")).toBe(false);
expect(events.some((event) => event.type === "session.stalled")).toBe(false);
expect(events.some((event) => event.type === "session.long_running")).toBe(false);
});
it("backs off repeated stuck warnings while a session remains unchanged", () => {
@@ -359,7 +359,7 @@ describe("stuck session diagnostics threshold", () => {
unsubscribe();
}
expect(events.filter((event) => event.type === "session.stuck")).toHaveLength(0);
expect(events.some((event) => event.type === "session.stuck")).toBe(false);
const stalledEvents = events.filter((event) => event.type === "session.stalled");
expect(stalledEvents).toHaveLength(1);
expect(stalledEvents[0]).toMatchObject({
@@ -657,8 +657,8 @@ describe("stuck session diagnostics threshold", () => {
unsubscribe();
}
expect(events.filter((event) => event.type === "session.stuck")).toHaveLength(0);
expect(events.filter((event) => event.type === "session.stalled")).toHaveLength(0);
expect(events.some((event) => event.type === "session.stuck")).toBe(false);
expect(events.some((event) => event.type === "session.stalled")).toBe(false);
const longRunningEvents = events.filter((event) => event.type === "session.long_running");
expect(longRunningEvents).toHaveLength(1);
expect(longRunningEvents[0]).toMatchObject({
@@ -737,8 +737,8 @@ describe("stuck session diagnostics threshold", () => {
unsubscribe();
}
expect(events.filter((event) => event.type === "session.stuck")).toHaveLength(0);
expect(events.filter((event) => event.type === "session.stalled")).toHaveLength(0);
expect(events.some((event) => event.type === "session.stuck")).toBe(false);
expect(events.some((event) => event.type === "session.stalled")).toBe(false);
const longRunningEvents = events.filter((event) => event.type === "session.long_running");
expect(longRunningEvents).toHaveLength(1);
expect(longRunningEvents[0]).toMatchObject({
@@ -1077,7 +1077,7 @@ describe("stuck session diagnostics threshold", () => {
unsubscribe();
}
expect(events.filter((event) => event.type === "session.stuck")).toHaveLength(0);
expect(events.some((event) => event.type === "session.stuck")).toBe(false);
});
it("uses default threshold for invalid values", () => {