vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-06 16:20:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: tighten session entry slot cleanup checks

Browse Source
This commit is contained in:
Eva
2026-05-01 23:08:31 +07:00
committed by Josh Lehman
parent 9d4633c460
commit 870babd252
3 changed files with 23 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/contracts/session-entry-projection.contract.test.ts
View File

@@ -162,8 +162,11 @@ describe("plugin session extension SessionEntry projection", () => {
}),
).resolves.toMatchObject({ ok: true });
expect(
(loadSessionStore(storePath, { skipCache: true })["agent:main:main"] as never)
.approvalSnapshot,
(
loadSessionStore(storePath, { skipCache: true })[
"agent:main:main"
] as unknown as Record<string, unknown>
).approvalSnapshot,
).toEqual({ state: "ready" });
await expect(
@@ -195,8 +198,11 @@ describe("plugin session extension SessionEntry projection", () => {
}),
).resolves.toMatchObject({ ok: true });
expect(
(loadSessionStore(storePath, { skipCache: true })["agent:main:main"] as never)
.approvalSnapshot,
(
loadSessionStore(storePath, { skipCache: true })[
"agent:main:main"
] as unknown as Record<string, unknown>
).approvalSnapshot,
).toEqual({ state: "ready-again" });
await expect(

6
src/plugins/host-hook-cleanup.ts
View File

@@ -159,7 +159,11 @@ function collectSessionEntrySlotKeys(
if (!shouldCleanPlugin(registration.pluginId, pluginId)) {
continue;
}
const normalized = normalizeSessionEntrySlotKey(registration.extension.sessionEntrySlotKey);
const slotKey = registration.extension.sessionEntrySlotKey;
if (slotKey === undefined) {
continue;
}
const normalized = normalizeSessionEntrySlotKey(slotKey);
if (normalized.ok) {
slotKeys.add(normalized.key);
}

8
src/plugins/session-entry-slot-keys.ts
View File

@@ -103,6 +103,14 @@ const SESSION_ENTRY_RESERVED_SLOT_KEY_LIST = [
"acp",
] as const satisfies ReadonlyArray<keyof SessionEntry | "__proto__" | "constructor" | "prototype">;
type ReservedSessionEntrySlotKey = Extract<
(typeof SESSION_ENTRY_RESERVED_SLOT_KEY_LIST)[number],
keyof SessionEntry
>;
type MissingSessionEntryReservedSlotKeys = Exclude<keyof SessionEntry, ReservedSessionEntrySlotKey>;
type AssertNever<T extends never> = T;
type _AssertAllSessionEntryKeysAreReserved = AssertNever<MissingSessionEntryReservedSlotKeys>;
const SESSION_ENTRY_RESERVED_SLOT_KEYS = new Set<string>(SESSION_ENTRY_RESERVED_SLOT_KEY_LIST);
const SESSION_ENTRY_SLOT_KEY_RE = /^[A-Za-z][A-Za-z0-9_]*$/u;