mirror of
https://github.com/openclaw/openclaw.git
synced 2026-05-06 07:50:43 +00:00
fix(codex): exclude codex-app-server synthetic apiKey from secrets audit (#69581)
* fix(codex): exclude codex-app-server synthetic apiKey from secrets audit
The Codex extension uses the literal string "codex-app-server" as a
hardcoded placeholder apiKey in provider.ts, since the real
authentication is managed by the app-server transport itself.
The secrets audit currently reports this as a real plaintext leak
(PLAINTEXT_FOUND), producing a false positive for any user who has
configured the Codex harness.
Declare it as a plugin-owned non-secret marker in the Codex plugin
manifest, so it flows through the standard
`listKnownNonSecretApiKeyMarkers()` path alongside `ollama-local`,
`lmstudio-local`, `gcp-vertex-credentials`, and `minimax-oauth`.
Also extends the existing `model auth markers` unit tests to lock
in the behavior.
Fixes #69511
* ci: retrigger checks (no-op)
(cherry picked from commit 081da17090)
This commit is contained in:
committed by
Peter Steinberger
parent
815c2e3052
commit
9040cda408
@@ -3,6 +3,7 @@
|
||||
"name": "Codex",
|
||||
"description": "Codex app-server harness and Codex-managed GPT model catalog.",
|
||||
"providers": ["codex"],
|
||||
"nonSecretAuthMarkers": ["codex-app-server"],
|
||||
"activation": {
|
||||
"onAgentHarnesses": ["codex"]
|
||||
},
|
||||
|
||||
@@ -69,12 +69,14 @@ describe("model auth markers", () => {
|
||||
expect(isNonSecretApiKeyMarker(resolveOAuthApiKeyMarker("chutes"))).toBe(true);
|
||||
expect(isNonSecretApiKeyMarker("ollama-local")).toBe(true);
|
||||
expect(isNonSecretApiKeyMarker("lmstudio-local")).toBe(true);
|
||||
expect(isNonSecretApiKeyMarker("codex-app-server")).toBe(true);
|
||||
expect(isNonSecretApiKeyMarker(GCP_VERTEX_CREDENTIALS_MARKER)).toBe(true);
|
||||
});
|
||||
|
||||
it("reads bundled plugin-owned non-secret markers from manifests", () => {
|
||||
expect(listKnownNonSecretApiKeyMarkers()).toEqual(
|
||||
expect.arrayContaining([
|
||||
"codex-app-server",
|
||||
"gcp-vertex-credentials",
|
||||
"lmstudio-local",
|
||||
"minimax-oauth",
|
||||
|
||||
Reference in New Issue
Block a user