fix: fail plugin update on update errors

src/cli/plugins-cli.update.test.ts

@@ -227,4 +227,103 @@ describe("plugins cli update", () => {
       runtimeLogs.some((line) => line.includes("Restart the gateway to load plugins and hooks.")),
     ).toBe(true);
   });
+
+  it("exits non-zero when a plugin update reports an error after persisting successes", async () => {
+    const cfg = {
+      plugins: {
+        installs: {
+          alpha: {
+            source: "npm",
+            spec: "@openclaw/alpha@1.0.0",
+          },
+          beta: {
+            source: "npm",
+            spec: "@openclaw/beta@1.0.0",
+          },
+        },
+      },
+    } as OpenClawConfig;
+    const nextConfig = {
+      plugins: {
+        installs: {
+          alpha: {
+            source: "npm",
+            spec: "@openclaw/alpha@1.1.0",
+          },
+          beta: {
+            source: "npm",
+            spec: "@openclaw/beta@1.0.0",
+          },
+        },
+      },
+    } as OpenClawConfig;
+    loadConfig.mockReturnValue(cfg);
+    setInstalledPluginIndexInstallRecords(cfg.plugins?.installs ?? {});
+    updateNpmInstalledPlugins.mockResolvedValue({
+      outcomes: [
+        { pluginId: "alpha", status: "updated", message: "Updated alpha -> 1.1.0" },
+        { pluginId: "beta", status: "error", message: "Failed to update beta: registry timeout" },
+      ],
+      changed: true,
+      config: nextConfig,
+    });
+    updateNpmInstalledHookPacks.mockResolvedValue({
+      outcomes: [],
+      changed: false,
+      config: nextConfig,
+    });
+
+    await expect(runPluginsCommand(["plugins", "update", "--all"])).rejects.toThrow("__exit__:1");
+
+    expect(writePersistedInstalledPluginIndexInstallRecords).toHaveBeenCalledWith(
+      nextConfig.plugins?.installs,
+    );
+    expect(refreshPluginRegistry).toHaveBeenCalledWith({
+      config: {},
+      installRecords: nextConfig.plugins?.installs,
+      reason: "source-changed",
+    });
+    expect(runtimeLogs).toContain("Failed to update beta: registry timeout");
+  });
+
+  it("exits non-zero when a hook pack update reports an error", async () => {
+    const cfg = {
+      hooks: {
+        internal: {
+          installs: {
+            "demo-hooks": {
+              source: "npm",
+              spec: "@acme/demo-hooks@1.0.0",
+              installPath: "/tmp/hooks/demo-hooks",
+              resolvedName: "@acme/demo-hooks",
+            },
+          },
+        },
+      },
+    } as OpenClawConfig;
+    loadConfig.mockReturnValue(cfg);
+    updateNpmInstalledPlugins.mockResolvedValue({
+      config: cfg,
+      changed: false,
+      outcomes: [],
+    });
+    updateNpmInstalledHookPacks.mockResolvedValue({
+      config: cfg,
+      changed: false,
+      outcomes: [
+        {
+          hookId: "demo-hooks",
+          status: "error",
+          message: 'Failed to update hook pack "demo-hooks": registry timeout',
+        },
+      ],
+    });
+
+    await expect(runPluginsCommand(["plugins", "update", "demo-hooks"])).rejects.toThrow(
+      "__exit__:1",
+    );
+
+    expect(writeConfigFile).not.toHaveBeenCalled();
+    expect(runtimeLogs).toContain('Failed to update hook pack "demo-hooks": registry timeout');
+  });
 });

src/cli/plugins-update-command.ts

@@ -146,4 +146,11 @@ export async function runPluginUpdateCommand(params: {
     }
     defaultRuntime.log("Restart the gateway to load plugins and hooks.");
   }
+
+  if (
+    pluginResult.outcomes.some((outcome) => outcome.status === "error") ||
+    hookResult.outcomes.some((outcome) => outcome.status === "error")
+  ) {
+    defaultRuntime.exit(1);
+  }
 }