vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-03-31 03:41:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Agents: cover subagent memory tool policy

Browse Source
This commit is contained in:
Vignesh Natarajan
2026-03-28 18:44:51 -07:00
committed by Vignesh
parent 6c85c82ba3
commit 9c185faba9
2 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/agents/pi-tools.policy.test.ts
View File

@@ -99,6 +99,22 @@ describe("resolveSubagentToolPolicy depth awareness", () => {
expect(isToolAllowedByPolicyName("sessions_send", policy)).toBe(false);
});
it("applies configured deny to memory tools even though they are allowed by default", () => {
const cfg = {
agents: { defaults: { subagents: { maxSpawnDepth: 2 } } },
tools: {
subagents: {
tools: {
deny: ["memory_search", "memory_get"],
},
},
},
} as unknown as OpenClawConfig;
const policy = resolveSubagentToolPolicy(cfg, 1);
expect(isToolAllowedByPolicyName("memory_search", policy)).toBe(false);
expect(isToolAllowedByPolicyName("memory_get", policy)).toBe(false);
});
it("does not create a restrictive allowlist when only alsoAllow is configured", () => {
const cfg = {
agents: { defaults: { subagents: { maxSpawnDepth: 2 } } },
@@ -129,12 +145,12 @@ describe("resolveSubagentToolPolicy depth awareness", () => {
expect(isToolAllowedByPolicyName("sessions_history", policy)).toBe(true);
});
it("depth-1 orchestrator still denies gateway, cron, memory", () => {
it("depth-1 orchestrator still denies gateway and cron but allows memory tools", () => {
const policy = resolveSubagentToolPolicy(baseCfg, 1);
expect(isToolAllowedByPolicyName("gateway", policy)).toBe(false);
expect(isToolAllowedByPolicyName("cron", policy)).toBe(false);
expect(isToolAllowedByPolicyName("memory_search", policy)).toBe(false);
expect(isToolAllowedByPolicyName("memory_get", policy)).toBe(false);
expect(isToolAllowedByPolicyName("memory_search", policy)).toBe(true);
expect(isToolAllowedByPolicyName("memory_get", policy)).toBe(true);
});
it("depth-2 leaf denies sessions_spawn", () => {
@@ -206,6 +222,8 @@ describe("resolveSubagentToolPolicy depth awareness", () => {
const policy = resolveSubagentToolPolicyForSession(cfg, "agent:main:subagent:flat-leaf");
expect(isToolAllowedByPolicyName("sessions_spawn", policy)).toBe(false);
expect(isToolAllowedByPolicyName("subagents", policy)).toBe(false);
expect(isToolAllowedByPolicyName("memory_search", policy)).toBe(true);
expect(isToolAllowedByPolicyName("memory_get", policy)).toBe(true);
});
it("defaults to leaf behavior when no depth is provided", () => {

2
src/agents/pi-tools.policy.ts
View File

@@ -30,8 +30,6 @@ const SUBAGENT_TOOL_DENY_ALWAYS = [
// Status/scheduling - main agent coordinates
"session_status",
"cron",
// Memory - pass relevant info in spawn prompt instead
// (removed: memory_search, memory_get — read-only, essential for multi-agent setups)
// Direct session sends - subagents communicate through announce chain
"sessions_send",
];